From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.4932.1622111550281185624 for ; Thu, 27 May 2021 03:32:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rNx/zloP; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) IronPort-SDR: Nn1l2WWZQclmOclPNOYmK6sCWzSib4OSGrp5BsSWyVGIv5Jzu0j4nzClhJov69GrevyRpzlqNq KJNr+4fTh1Dw== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="202464881" X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="202464881" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 03:32:28 -0700 IronPort-SDR: agKZN2uH8bbcWuQu0YYJ4kLv/3D2Wqb98R+AdXhwmqxHamR8UpHtvb43/GbCCIIFAdAQU4A2ql TNXBcwP6VBmQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="633946351" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 27 May 2021 03:32:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 27 May 2021 03:32:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 27 May 2021 03:32:28 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 27 May 2021 03:31:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZYdR6yKKldt6d/9AMAuIaR70KCBsTeEfN6cH9ZnvkWsyYv2aMara4+Rb1ZCmh8EcheB9WJJpUOjQyj/hzKj6a1bhOucVtvivFMa77K7gi8H78AdBpcHhY00cbZWdHeFIRgzD9gL+x/DbyTdAfojrtn+8lv+WM253UaJzaCA41gxD20LUWLgLU3nS6S0ijqa9oD8FtsMtow4YsUaj1Z56d9e3s8BdA0mGYxgY4eLlsx8fjHqzPD5WLp8pgY4FRpQY2IslC6QYEwe4VkNJ62SGkDhxdocNJEiAqziO8lQfLigPmUh8voeKtJDH3yoVXl8gHnSWTC3dDz7ZqGy3HI5vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=colMreibDe2mQ/Sgz05IlDldx46Yjxhe6p3HBTYRJVM=; b=br8Y66Svy3l0d40FI+7+UDwVJSH2rTJrJfqEGHOfBAU+N7wrS8SA/+Sxg6B8lSW9du7uuTSuTBfDFQ7srFpEL5+/TZubi2Fu3QxdhBJBUMk80LCEiG0Y6dGu6jrGWDiYuvJPmLCG4CG5xbaGRrTDSryu6F2TJkNtM0voeaUZLoTZNYS6WM5ILu1e/HIEZcYTjiNBhy3oSSLQQpfZ/fZTOVNl4kdnk3K6a6XJ0SwotihBsgtBftKosltZDAHjaeVLWhWptSx8v/ZIbek2b9/OO+atqSdTklorsViWGrqbNzlNiTzDVt/G3XbXeUgpSinrjZA2EonRoEyTi6RD21tqHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=colMreibDe2mQ/Sgz05IlDldx46Yjxhe6p3HBTYRJVM=; b=rNx/zloPKPmPXVRZDKC21sv016DwiI/OdItXfeoj3zBzJh6LU06zF4CyGpqGuxIUUB/rs5Nunyffl5Y3Wf3g4hyQYF6RNI7Rk6wuDIPhQOIK2BAX0KNPSH6xrD/OJl0PXy4j2MNtsid11TCmz1pJgTWfWmwt3sK91YWsbk0UrU4= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Thu, 27 May 2021 10:31:35 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::547d:4eb3:f37e:dac4]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::547d:4eb3:f37e:dac4%7]) with mapi id 15.20.4173.020; Thu, 27 May 2021 10:31:35 +0000 From: "Yao, Jiewen" To: "Kuo, Scottie" , "devel@edk2.groups.io" CC: "Zhang, Qi1" , "Kumar, Rahul1" , "Chu, Maggie" , "Wang, Jian J" Subject: Re: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter. Thread-Topic: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter. Thread-Index: AQHXUGfW8M4yI8Mi7UaEhmyI1vf0MKr3JeXg Date: Thu, 27 May 2021 10:31:35 +0000 Message-ID: References: <20210524064107.537-1-scottie.kuo@intel.com> In-Reply-To: <20210524064107.537-1-scottie.kuo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1313ad08-69c1-4a04-528d-08d920fa9a7a x-ms-traffictypediagnostic: PH0PR11MB5048: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yHx4Hh3kKi2X9DA8zQvpUfCRnDMJTbvrGixgAd2ajFbt2zevhtSNvGkFaPL6MLqI/xgbgyLtVHzRo1mBL/S4LqTWNn7/xoaNQQDarZUyYg44uS1mXfEMFw6K7oyDT0KGBmZDsLSS0ltLLIps+r60IiEynT1gp1F8Vnt5R/5z6QSmb4xx4Q0l0wFnjRiI4EExomuE+IJegOgnmZcTOz6ED9jTTQZgd1f20mqJg0drTS6KGStHWRJHxfLbwPH2SaOw0wdCEQ0WJFZ73goROI3bg4JI9olMsYVEFjMktDmm6BRsR42i5renxlhj2n7qA+HIA+86fiDQTwv6ocXtszcWlaRpuuqQK/p/WC3xaZIkGUDwjTiJXd4i4bE8/BS1mUXoZjRTkdZp/3XCDWv8x3ji1by/yUS5Iypzkw5HkLbglVMB45Dq6g1NVoLIEZgWtg8YUk+a6dmn5erLQG/dg9uDLdoDtoFszmpX2RDAxZvJOQ1VEL8ScTWRpAIhFXuBqozLQK+t+ThidqoP4XCno6bXDUvtA1qfh68vmXnW5Kxh5Sa1PPKNM0ZwOrytw1496jk5PDWvMhhKdOUdIchCCfvQGqYCvuiLz+KFCJ6LwJhaqcyFto5HVANK+ovgXsxBshrpjjW1TsP+CWolnaGlPByU74OUOxLtKQPvg1fuBj5/6kiLKMujT6y+p+Ow3funTYmChpN3EmStuG3zQHBJrb+di6dLEwTjyuqEvKW9SQspxAo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(39860400002)(376002)(396003)(346002)(52536014)(110136005)(54906003)(122000001)(76116006)(15650500001)(26005)(53546011)(66556008)(4326008)(107886003)(316002)(71200400001)(83380400001)(5660300002)(186003)(2906002)(6506007)(66946007)(7696005)(33656002)(66446008)(8936002)(55016002)(966005)(478600001)(38100700002)(8676002)(9686003)(64756008)(86362001)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kaAnUgqz05/NqQM4u767o531949Nbh9qXa2S7tmLbBeVLECI/uRD2fz9rOfq?= =?us-ascii?Q?u6SO9kw6zDz+Er69Xa7gBwEj8y3wALjwWV+pgf35Onb0PxL36AERvqwNRm+l?= =?us-ascii?Q?+60Pj+medKxRDusrebv9q+es4DbZxFI5QF3R93A5iW5Bq7sE8+qNPcsqJbW7?= =?us-ascii?Q?nwl7hgFWrcirnhToWcGoiENVYA3FZ1zNxIdJoWVy9AQ+RrVy9b55gehuOWzs?= =?us-ascii?Q?/wvCUnMZmNg3QcI2Y6yH4taA7/BPOOxKyHvVS9W/DklWbTHO1tWTT3MRVwJK?= =?us-ascii?Q?28++am1MSH1mojCbK2Ereh5UwBnpyTYdo2ic6wjZTkTR2d6r3CyGWTe6obUm?= =?us-ascii?Q?LQ1PjtNL+973mbwtX5A6+2quewpPaY4sTuLwithsDCD011i2QpWXe3iCA3A0?= =?us-ascii?Q?Qoemc6HTtcvkX3xzWqFJvGGudiHl+lFCDYoI0vWBCuSriK7glTN7yYV35g5V?= =?us-ascii?Q?aKOAA18GWXVrBKRXnzd5Fut8oNmJBY/1yUDGkCSCfOxUzUCGDSLvhCf/32RC?= =?us-ascii?Q?68d3IQ6ptqzAZJ7uIuE3C6nCu/yn1VdJQvphtK1LmZdpbaoiAYIvPI93UXrz?= =?us-ascii?Q?33VD1CNFS0YCN1jjUQdmGWvgBssUdlmWYSXunuH/v2NUOpAc59IDydslasWw?= =?us-ascii?Q?LWgz3rBMjHMYriTqWBH5ciLJBWwC1Us8V6PiiCf1oh4Ly/w6LVrXWA1sL1G/?= =?us-ascii?Q?/fZMtHpcV/HH+hzXKXMcDE0xGwLWO3rpdqODTUdm8C6J7YlklGPgjrKaMfYT?= =?us-ascii?Q?BLvaZbrhEpb1Vi0wZlw+NlbexFbVamEnBLv/nbqQMwba05jupHK9jhe2Hr/q?= =?us-ascii?Q?UQkpRn/hK4W90ruWu+pJ07Mgvl35TGEYqj0witPhR8Z6RtH6d8vi6fR4kkiv?= =?us-ascii?Q?OzAZqBTstovMeJSkMCnflpl+eIQOqendoz+DcfuCZr/4ba/3cY1/LMtBzxem?= =?us-ascii?Q?qucdQkYBpKw0Poa/ONvkNBIy6jCYPsk377ih9iC3EnjtWWlb4meMM2aGAO5D?= =?us-ascii?Q?41A8ZsENbzDomYrMt8YO9SpAZR8szKkwuRqSCibiekH3g7vs5jEmQRmM2ya8?= =?us-ascii?Q?RVyhpDIGnKdg42gHIshc1DBLkidnEFtsiCXeScCHKeRQw/KptpL13ngEexFm?= =?us-ascii?Q?ZJxmEUarE+9dOWoxBq4KIel5LcsQK1hOaFyUDXyvevNPrKnpDIL12hoR1MJq?= =?us-ascii?Q?4JfxWq5to2e40htk9p4sfMFTaC3Z9Qu0aDUvr2Jug4al3HQ/5D9WO8AngKr9?= =?us-ascii?Q?FFIc4ebxV/fnGQO8+/PHBwsv1kbgq/4qOj5SiMSjV9zTpz7IpSS+CvrCt5jA?= =?us-ascii?Q?gxMEoOxxNI8T7WKqS3X2snmd?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1313ad08-69c1-4a04-528d-08d920fa9a7a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2021 10:31:35.3733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A30+Rkdh+G0HJw/xJxHztVJOZ6Jd/fRmnkjW2hE2UvhNWGfoO9uW73tKo4lRxJC0uLuxBcruv7W93iEqvpiVxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5048 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao Hi Scottie Please remember to add Wang, Jian J as reviewer too. Thank you Yao Jiewen > -----Original Message----- > From: Kuo, Scottie > Sent: Monday, May 24, 2021 2:41 PM > To: devel@edk2.groups.io > Cc: Kuo, Scottie ; Zhang, Qi1 ; > Kumar, Rahul1 ; Yao, Jiewen > ; Chu, Maggie > Subject: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttr= ibutes > parameter. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3408 >=20 > The value of SupportedAttributes in OpalGetSupportedAttributesInfo () > is left undetermined, if the caller doesn't initialize it. > Initialize it in the function entry. >=20 > Signed-off-by: Scottie Kuo > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Jiewen Yao > Cc: Maggie Chu > --- > SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > index b58597e61f..c840590e8e 100644 > --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c > @@ -1,7 +1,7 @@ > /** @file > Public API for Opal Core library. >=20 > -Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2016 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -1647,6 +1647,7 @@ OpalGetSupportedAttributesInfo( > NULL_CHECK(OpalBaseComId); >=20 > ZeroMem(Buffer, BUFFER_SIZE); > + ZeroMem(SupportedAttributes, sizeof(OPAL_DISK_SUPPORT_ATTRIBUTE)); > ASSERT(sizeof(Buffer) >=3D sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS)); >=20 > // > -- > 2.26.2.windows.1