From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.43906.1636373597286076569 for ; Mon, 08 Nov 2021 04:13:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=J2pEHt3n; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10161"; a="232056752" X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="232056752" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 04:13:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="469587185" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 08 Nov 2021 04:13:16 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 04:13:15 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 8 Nov 2021 04:13:15 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 8 Nov 2021 04:13:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QHUpdpirbZzLGTzx3rJUr5MDenHtmNJSxVf7tLOG8IUlu3nPoD+C0bMu0Kj8fE7yflNWJ0I3ovpFXU5m86NsxSwZbEdX/P5LJG1gRXvl9kanV6L69xDfQSXEqohwUbDn5w4dTDZJL8UPo2BilMeMkyufjDnAK/HZSSEJQavV0NgUH62lmGCcHZjnHRP90oEXzJrBZUJKAxbiq3KM3k731rWLd9UY7qsD/7WVVK76yNEq/jTHmYR6H7sVQ1CCgHtZIyY1yJwFBx5gY9MaCRZC6L8xr0v3/SNRqVJRrBZBzMWaWVI2xh1kMlx7VHgBmrDAGGg/R5H/hZWiLNvLpooAJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0XX/5hth4W710sf7Agi9xWPsNgLzTEZISn1tKhPAmxU=; b=mDmKywQpnW53I+naIkvevqEC9Ncwx3ek1GOHHIhbmgoNTux+gDBczb/urMCnW0NA4bkwDrNY0/btANHOZaR3MpjR2Qk6QX6Jy4TUS1vT0/nPdkTR0OfmeHcQYvFI4l8xfKJURN0sEmQTwFMrOuzDKccip2FINASpDf2jTxO3QoWlEy7OIL4VRUdlbhSK1nrUe5YwCOZm4U8IWls4o0EkrSkbwG5LpMp5uDqkyigF28f6pnVn298aZrTpUR4mxLcFPXZdKFZ1rFwfvIpSlGqnBvQ7lt78F1xDn3FCHWKU5tYwD3Iva9mwmC4VumzGSAlxugrmPcCSKVosA3GO5pJliw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XX/5hth4W710sf7Agi9xWPsNgLzTEZISn1tKhPAmxU=; b=J2pEHt3n5VFxXjmtmXslygAaOxFGpWNtx8Dd6AryLk6Xv1zWcBeIjX8Wf5EYsGLg6o94Hexlj27yKh/5+yNkyp8NFz1KYatT71K4clBoAe297dfdip5MomDZ+2YAJd0gDQJlijjJlKzB8+bp1e0k6g5vV51A/Mhpz340PcFB5ZY= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4856.namprd11.prod.outlook.com (2603:10b6:510:32::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Mon, 8 Nov 2021 12:13:11 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80%6]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 12:13:11 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , Stefan Berger CC: "devel@edk2.groups.io" , "marcandre.lureau@redhat.com" , "Wang, Jian J" , Ard Biesheuvel , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2 Thread-Topic: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2 Thread-Index: AQHX0APAuOdXfU2II0K24jM1t7GPvqv03imAgAJs2YCAAkSwAIAAA/ow Date: Mon, 8 Nov 2021 12:13:11 +0000 Message-ID: References: <20211102154910.2715495-1-stefanb@linux.ibm.com> <20211102154910.2715495-4-stefanb@linux.ibm.com> <20211105121727.uy6hmpkj3xg5bpc2@sirius.home.kraxel.org> <05c7dab9-ff60-db8b-d91c-9d769c25c45f@linux.ibm.com> <20211108115754.tm5cfewgrzyvptet@sirius.home.kraxel.org> In-Reply-To: <20211108115754.tm5cfewgrzyvptet@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 77eeb13f-f824-44a2-c22c-08d9a2b1224c x-ms-traffictypediagnostic: PH0PR11MB4856: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qjBblzz47TNNv0ffZwjyzs7tYPkWTINs6953ieNRYskzVlUyskgLhjCF5JWmvnUWuJmRht3Wv/hmSqJqDCTzjNk1KyJLZw5tM3FaNsFnymK+hvVBf/LvDxBZfaQ/3pheJKj0r356GYM3abCnmyq09ZO11g4m7pCWDMuP3xJj24NLFrMgba3t9i6S+MQTtHDyD7ql+/f2wBNjaG3bq0sq6rTU+RSvghZIFdi+rzEY7wttCviTORREFlmwSTiBq57/f9Eh7+wMVXJ1W6WSBuibZetqnlddsRsW+ra/rHQHVfzvlgHDbUol2xAJCTlQcXmC+ql4ITpT1dX9K6xUONL8OdQE7yjTAtd+N09oeL9vb12+12z7JnqJLnQCPykv98rY+MgrqhjifRO0ikc0gmJAW2u2wsbzZAjfmw3Z9NEltu6OAIEOGC8+zIRL7jzx0bnFvHAFRKWHAFyAtEU7nywgrMH7g8/OMjDjs1DeZMedemRzsaKh/tq9MwEZFC66Aoo3JNZLOq3J5wQfSSpfGMU0vdQ7hWlIVzQ6E3QdVT0G5WvS+rhGWAm4EKFXQG536B85CZiYKXdSoHiH5rr5VdzTncgSAFSZOSacXYaVyqnhW43t3uddhvdaawBMn3SFIuZtDqp8ge17KwJJaumoAZ14fyjR5DZ6Lty5a/p/7hvELYibgu8RmvO73P5wfzE8EoJwkADeHg7DPc8e+nx5l++D/Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(186003)(4326008)(71200400001)(8936002)(9686003)(19627235002)(55016002)(508600001)(76116006)(5660300002)(26005)(8676002)(110136005)(54906003)(82960400001)(66946007)(6506007)(33656002)(52536014)(316002)(122000001)(7696005)(38100700002)(86362001)(66556008)(64756008)(66446008)(66476007)(53546011)(107886003)(83380400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ryR9PEYoixHpjyv9FgDi6kV9ZWpkqVwS4hdNL+V2zkmZpWAfRGUQnyHKk73b?= =?us-ascii?Q?5BDSqJlHt8eVLUlup/fGRJWlSvwnxWozv8Ho1Hm2nyJJo7MmR0222O9xQjBH?= =?us-ascii?Q?z4AMI1kORdbR7ziVTJsThkaXbQgQAOnSAfO3o6WaX2RALIREJsvf76tImRge?= =?us-ascii?Q?VSh/mOyPAApQA8F8BKJqBzmeqctc9sNezDcEdNd3IBckFStIzvWxrJRb8dP8?= =?us-ascii?Q?rm8uVI/jHMADSwfTmaimC6zeF7fGpPexvFhW/g7sDdhZH1TAnZeuZYCkNasu?= =?us-ascii?Q?x/b9Hiy62Cm3YOCT5Si/s6CzYMupWmgSvEX7WkpDWj8hS/qeugzD9N4LHcko?= =?us-ascii?Q?xA3POOfu39KMlKHa6V+PCfhibcbcK6z4hVXKmHnPd5JOkXThNN+fJOGvomel?= =?us-ascii?Q?cCZXdcuZ/fToEjghzUAe9J/5q5KyaxbQ5B3PG8PBOOJLB4aWK75FchxTK0zK?= =?us-ascii?Q?1G8OvQQswHD85GokGsLHHDqHWgC/r8G5RVeqMLv5orkJbapMUrrsuIeWkiZv?= =?us-ascii?Q?OcVrX7k159d5vFr2MqswuIY5k9QejSW0pn1CKAAsdmEijxal0bRnuh/zdEsf?= =?us-ascii?Q?L2l9cF2QUFkITXw/hdAIp7FnwCUjNLnOyVIKEl6o5MUT9QitNPorViWeCuD0?= =?us-ascii?Q?WuWu2bjLTIcR+LelQkRZGU+AiWTKzUBDLCvIZcgxVeeejwXXNrZegfPNLMIO?= =?us-ascii?Q?vwt+ZHYsUphlVsptVJl9uMJe9uNiANVz5QbfuGSXs0nxkrFR1WoEsN/Hi7b9?= =?us-ascii?Q?ohRLz/YwKUo8OFrL+z5/G0k8dO+FUim+nhn3pRhHJzbeiHKIRWfPOZgrOIOQ?= =?us-ascii?Q?vTt7Q26EdxNgz9rfIgIZ9UgvZTzxoyRpEGHvlgICTkx9qTf8ANgJyK+MNLIW?= =?us-ascii?Q?q/vdoCqFTDTI1UEG+h9+HcFG6m2ZG4SkffMFC7chp9DfuNImwxLP/pTDVeXJ?= =?us-ascii?Q?baLwgWf922hKFqvQSW+zd5an3FqNly+50iOLHdmnO4H3O02q2rhbh1uwiBMo?= =?us-ascii?Q?Pz+tJer0368oQQjOHU1RBntbY3TUEIAXmoX2b49SWjwPO+ulSeQUfJoNEvw8?= =?us-ascii?Q?tdWuf8KXuuG2HWEiG1Qu9+05LCv3YXxeYEwnDMrh0tjZ0z9GCVe6ZSPF8p4U?= =?us-ascii?Q?zUsc8DJ7bprfqAJhCQ9JZ1S0DPQ0qqR2vVT+fDJqHnp+uq59xhLnG5YXLMDq?= =?us-ascii?Q?Yqs4L5GdLgiOBeBJk0U+8x/K3LPxuEUiux0BYgw6O0O9ssP9AXQhxnCtrkCG?= =?us-ascii?Q?odXKlIzrSy+GyB3r3d+nVKwCcm/T3wooNCIEn8DYU0e/D1EqPZN/9mkRkJuE?= =?us-ascii?Q?ccSOXjJyvK8yjwwWThHUg/PL7e1vGu8WnsyQfVAagjJdGKDhO/bVM4NmnJTg?= =?us-ascii?Q?+zk80GkVUWLeHOe3higHtVCwyTyXXuQIzNaYhWbv5BrSBqOnKRHvwa6yIcNQ?= =?us-ascii?Q?CaXVv6U/IztmKmAGqSpsxRj2QUV9tvf0OM72wuKi47id+VKIsbOCyPMmdRug?= =?us-ascii?Q?3SVb+dXf7QXKBN2hPWlvUl+Cs6cOsQTrw8XIksEHoW2kkwcENFYm+TUlt1dp?= =?us-ascii?Q?bzbr2w3KF0AvNGHp2zRwneApS6Fmy5RxMRRQrGze9rgrRTN92ZkDJFZqvMlM?= =?us-ascii?Q?ieQS7dQ8T8ctEgDlRe7Rd9g=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77eeb13f-f824-44a2-c22c-08d9a2b1224c X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2021 12:13:11.7226 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JFMhhkp14WKvxY9/qkJtSJTtSv8vQvDlrVhWLgduHzGr0FpLh7ZVy3mwhxtb8Q5DdQJac2fzKRmeR/f5rjvfdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4856 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The PPFlag variable MUST to be locked to prevent malicious modification. Otherwise, anyone can change the PP configuration without confirmation from= end user. Thank you Yao Jiewen > -----Original Message----- > From: Gerd Hoffmann > Sent: Monday, November 8, 2021 7:58 PM > To: Stefan Berger > Cc: devel@edk2.groups.io; marcandre.lureau@redhat.com; Yao, Jiewen > ; Wang, Jian J ; Ard Biesheu= vel > ; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presenc= e > interface for TPM 1.2 >=20 > On Sat, Nov 06, 2021 at 09:19:33PM -0400, Stefan Berger wrote: > > > > On 11/5/21 08:17, Gerd Hoffmann wrote: > > > On Tue, Nov 02, 2021 at 11:49:09AM -0400, Stefan Berger wrote: > > > > Enable the physical presence interface for TPM 1.2. It is required = for the > > > > TPM 1.2 menu to work. > > > > > > > > The changes to DxeTcgPhysicalPresenceLib.c are due to the device we= are > using > > > > in QEMU for presenting the supported PPI commands and results to th= e OS > via > > > > ACPI as well as to store the PPI opcode to execute. > > > Fails to build for microvm. > > > > > > > + > TcgPhysicalPresenceLib|OvmfPkg/Library/TcgPhysicalPresenceLibNull/DxeTcgP= h > ysicalPresenceLib.inf > > > I guess this line is needed just next to Tcg2PhysicalPresenceLibNull > > > line? > > > (same problem on OvmfXen.dsc) > > > > Fixed in v3 for microvm and Xen and Bhyve also. > > > > You happen to know about the variable lock issue? Why does the variable= need > > to be locked? >=20 > No clue, sorry. That's a topic I have to learn about myself. Noticed > the variable locking deprecation warning in the ovmf boot log too, but > havn't found the time yet to look into that. >=20 > take care, > Gerd