From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.12701.1629883485834921571 for ; Wed, 25 Aug 2021 02:24:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=GE2ON19r; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="217520312" X-IronPort-AV: E=Sophos;i="5.84,350,1620716400"; d="scan'208";a="217520312" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2021 02:24:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,350,1620716400"; d="scan'208";a="597991088" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 25 Aug 2021 02:24:45 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 25 Aug 2021 02:24:44 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 25 Aug 2021 02:24:44 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 25 Aug 2021 02:24:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i+TxogQcD4pU98k94B61XFBC21GEa/oRh2n6UhW21Q4bo0RRavgpvQB5JS/rByCx45xEUA2mFz5frI3CN9GrP8vUMeZRVj+BiMsZbGrYlVccS9sGdk0FuCPi3yg2vDGVTTwZVnVZQMG9/SG1iy2SlvrUm1SaRk4xcbRi7TOSctMKOswu5WiqPM6/ub8Ygmc5huEVhw2B8WWD3Zj20ikgsyJVGNTGP600XVB50+8jA+3wCuaH1qtaSpW59LdsIXRfeJwlpK/ZM57cWai2m3sCHzs3+z8qD4RPxVCh+b0PNJKL0wTeJShV1dGnVd1QmI7yiVXre9vN3cCYNyDAzoIBGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qiUurWYir7nv/x4xKdBNxemP1FbNiWtbvt+e3uR+KqM=; b=ST0wfjvjnL11yvmDe5Yy+yJvOPiQ6OifkO2+xVn0BlVTbjpxAKseTxW5qJG6gcoqLrAsJWn2jYwsBqlMRgD4khCgHnZk5EKRLUQMlgsNkaWFn5U78eSt6WJp4Juk4nlL5tRzM4r57aVWRCVAhLzJPvNEbp+IdwvQMmilx5r9VuaRNG4otJP+F/TZmhvgdVoXoHinszskP076ZtLD0aORuSPfOQOYnP0ShU2R0YKB1gCYUzKz2f73ptFR/qGeucsh9SaTBSVfaaFSy99SgA+f3vrAOM/hc8uno8vSuOiGRyKt/FgGYJTFLBpE0kjptsd46lBIuhqoQaWPPHW6vhuAiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qiUurWYir7nv/x4xKdBNxemP1FbNiWtbvt+e3uR+KqM=; b=GE2ON19rvaN0oBOrckARZa+3qqFpwW+GR/1zNfzIVPAKUV36HmMk2gzpvDEgni9DVnocoRQjNlid6naRuQ173kHCsQXO9rFQFN54pgfqO3IUXuJlZmYpbHjDm4HomuR9J1ZmQeU5ZLf6HwQZvmz8o8tUDHqd6rhNw2JrbUhhcF0= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Wed, 25 Aug 2021 09:24:43 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79%6]) with mapi id 15.20.4436.024; Wed, 25 Aug 2021 09:24:43 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "kraxel@redhat.com" Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection Thread-Topic: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection Thread-Index: AQHXlNHd+ct4uWoBFEmrpZV2UtccPauD+vOQ Date: Wed, 25 Aug 2021 09:24:43 +0000 Message-ID: References: <20210819081110.1612205-1-kraxel@redhat.com> <20210819081110.1612205-3-kraxel@redhat.com> In-Reply-To: <20210819081110.1612205-3-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56c2ad33-83e1-44fe-77d8-08d967aa2c38 x-ms-traffictypediagnostic: PH0PR11MB4968: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3VtlB/zkuMZ/KIwYIjCXmMbsxE5iP4Svlv87xBbK6L0lNv4PT8EYkyf98vWuBUK6oIRaXMdkRGsOipq6PCROTlDBZxHsIHTUHUNxjH03HNW6WfxxZkJHT7RSxoPkPBL45i1Ir9YNTck/DuUPA/Eu2PNfKLgLHMeu8ylFXkj0aA6Bg8een36uLWvOBYVQuMNw4IiX1q9HWDmaYDR2Xl/BzjEzOo5e9TWkjwPGlZ7UmMnZxAYS6S0rRFYrZD+X+e223J454keUQsr69+pNyLHHreyrLaV11LibfOr/1bYdG0melHwl0pcE/egcGZeTnRbFRQbYwrKd7cOcQJFP7nTiBtSDEd2wxqcJJ8FBFpd9tuZzNCKSMsys6Ag6lNmWCLNzyqN71Wh4z5gyF6bSZD0YLfDdP8ZN/JsKn5tRVb5c9KWTvxGmVFwHlyYI2LGxkthrcNsV4rGw5yGPP7GXTx2ECc2svxobhtW1XTSrSbJIAcL1Cd9SGyA/NOtHZig/zUkCixeFnFtZK/Jn9bjX3HigpYApkgqdAq+VSd+t24ZShjtrN310s7LE1ctRErsd19DGuZ6g6F1JAVZcoQvvFtSO4tKpC+m2ziL6UG5lo04OuEYGx5PFN2BpqvI49Gg9WZZIxxJN6Bh7C359S55c8gIMtPi9q0Ldepy1fMUclekbjZaAEfzyq1DVRNxUqiA7i1slO0KxXitCk5DZ3Vhd/btqrjSP0lSLmObJD6F4HP37cB7zJZUEdV4h5g5KUqc+2FAE2IPSgwKIoqOcz7glMcT+qG62THBwV1JfVmGCv4ycRfN/j6thCjhiMRghLRPc9e1wDGKP2fDvg0q+p8O5Nn2Y+g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(396003)(39860400002)(136003)(71200400001)(33656002)(83380400001)(9686003)(316002)(55016002)(110136005)(5660300002)(6506007)(7696005)(52536014)(38070700005)(186003)(66556008)(8676002)(64756008)(76116006)(966005)(66446008)(478600001)(38100700002)(8936002)(66476007)(86362001)(66946007)(2906002)(53546011)(19627235002)(122000001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9W+hErajKNiDcEeZ5y2Xi5aC0hObBVfSRk0H9EzlXQ4fNK+R5/EEBA1G0JOK?= =?us-ascii?Q?i10BNYyQok786Fh4aKzKzjaFUYgJ3U4ftHgjaku1V69J3awmukhZWfMQ7YQF?= =?us-ascii?Q?wUJojYr7MLdqkmXhAiaErXEgVa77j5LhxdYALNkTeUlMYCKWZR0yFqQU8U49?= =?us-ascii?Q?8dBfv5ukzto4Z4dd3xW6JdkXojt3lfVYILIomsgOgwEzF3dLvK6foyDrr1RA?= =?us-ascii?Q?DWLH/Y8m5aaW3nC/R0I7CW+pjxCA0YBj6UV9N8bugJmq5sPVb82zqJEcUXaP?= =?us-ascii?Q?3o/wi9F3z9UI6aJIXyE+wOwLsOQNKda0xG+L04QuBg1LmHxujTvuEtmIuHIZ?= =?us-ascii?Q?tSQGY1oJqc23f+eYyEQEMNiE6ooaD0/kXgkrkOPRKufoJ90tAtfzf7eglzcx?= =?us-ascii?Q?EnA36c5nQ6jT/B3jyl3f4XZiiG3RSLETTk+TtxiS62PQTCgy58pWr1Ck6Nuj?= =?us-ascii?Q?vGP/rdbGNefTXS16z8LrbM3J603ZlMcZoItQFCChAjIdSvqqAiEHDwm4b6vz?= =?us-ascii?Q?Q21Ac2kTOmZi1eEUYtKZWZ20zbhqn4uMXs3hy8/jkk0triO4DTIakPkCHf9p?= =?us-ascii?Q?ZhuiMU5EbayfOUPmKdQkCHokwD9BfXvRXZekER6MJ7mq4EQ+kMPT7PIw+e/5?= =?us-ascii?Q?B3NaiAGF8anb1yKAKEkxCrqR5Htk6/+hQ6q6fUhs1CB9Bj4w7ff54585vjlo?= =?us-ascii?Q?3Pg30niFIkPkEMkW7nr58q3ADO95rnGPc5804P8TMC6jQn3j2ar6W0GLqD87?= =?us-ascii?Q?SYddbuC0MuqHsrFZK5in1VWbpvIOGRuc1CrScSkiUU1IxXkw/SZG7BM+XqQ/?= =?us-ascii?Q?miGof0QLvZxAZkQP6yRm4Py4dqKyqmjMLE/YefBkEBy1MLNvoaD274/frdRi?= =?us-ascii?Q?V0PX5vq3VAfv70umcynAF0biwHCilpUCAh7QbfeUA6yMBkptGSJbnVANQEw4?= =?us-ascii?Q?jdnyei8X0UIbZqxmDJk2pa4slwtIrb+EkQe6yiIHzBOOSTNRkCF7u3ngcsDX?= =?us-ascii?Q?xqdsHQ0Aag3rH/mYz+Un7lt+hy8ONbuJFUVL4MswoPu9gAbzYsy+BCjzy0T/?= =?us-ascii?Q?3iGzI7wGUI947kNtEuoSj16eDxPFTD/OyDtRUrHPT2vPNtA52c+s6v62QVtL?= =?us-ascii?Q?zh7YIzJRPYcpCL24vsgGMotfanm3qh9Hn/ksN+kD329mzaE+GRo5tQ5cGS6w?= =?us-ascii?Q?+HAbvVdsVIEdRPRTttWn/P/17qzoUUN9ybzACsfjPr8I1BGbtEgsSDDGTVyp?= =?us-ascii?Q?krvVW5PWjV3UPAxDJt2k0/jfiZh9DPvA6MJLSjQGRCfaC2B99tHXM9kYpAWZ?= =?us-ascii?Q?uPdMsIMvZqVIM9pSWDwvXf2d?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56c2ad33-83e1-44fe-77d8-08d967aa2c38 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2021 09:24:43.2838 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2mTELPG3auFRwazU2l+VhR4NN72EWYMxnUM5hU9VX/rMviPKkmmrlQRidKayPPDRBMj5Bpz3c7PZvxykjcJBVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4968 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Would you please follow EDKII process? 1) File an EDKII Bugzilla. 2) CC all reviewers in OVMF package. Please also describe what the reason of change, what is the benefit we can = get from the change? I just feel it is confusing. Previously, the data is consistent from CMOS. = Now, we have two ways to get one data from different sources. Please help me understand: A) What if the data are different from different source? B) Why we choose to trust E820 at first, the CMOS? Not verse versa. C) If we trust E820 (in B), then why we need go back to CMOS, if LowMemoryS= ize is 0? Thank you Yao Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, August 19, 2021 4:11 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann > Subject: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformPei: prefer etc/e820 fo= r > memory detection >=20 > Prefer the e820 map provided via qemu firmware config interface > for memory detection. Use rtc cmos only as fallback, which should > be rarely needed these days as qemu supports etc/e820 since 2013. >=20 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/PlatformPei/MemDetect.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) >=20 > diff --git a/OvmfPkg/PlatformPei/MemDetect.c > b/OvmfPkg/PlatformPei/MemDetect.c > index d7fb3e742be3..71bd28bd1d2b 100644 > --- a/OvmfPkg/PlatformPei/MemDetect.c > +++ b/OvmfPkg/PlatformPei/MemDetect.c > @@ -293,9 +293,16 @@ GetSystemMemorySizeBelow4gb ( > VOID > ) > { > + EFI_STATUS Status; > + UINT64 LowerMemorySize; > UINT8 Cmos0x34; > UINT8 Cmos0x35; >=20 > + Status =3D ScanOrAdd64BitE820Ram (FALSE, &LowerMemorySize, NULL); > + if (Status =3D=3D EFI_SUCCESS || LowerMemorySize > 0) { > + return LowerMemorySize; > + } > + > // > // CMOS 0x34/0x35 specifies the system memory above 16 MB. > // * CMOS(0x35) is the high byte > @@ -722,7 +729,6 @@ QemuInitializeRam ( > // Determine total memory size available > // > LowerMemorySize =3D GetSystemMemorySizeBelow4gb (); > - UpperMemorySize =3D GetSystemMemorySizeAbove4gb (); >=20 > if (mBootMode =3D=3D BOOT_ON_S3_RESUME) { > // > @@ -769,8 +775,11 @@ QemuInitializeRam ( > // memory size read from the CMOS. > // > Status =3D ScanOrAdd64BitE820Ram (TRUE, NULL, NULL); > - if (EFI_ERROR (Status) && UpperMemorySize !=3D 0) { > - AddMemoryBaseSizeHob (BASE_4GB, UpperMemorySize); > + if (EFI_ERROR (Status)) { > + UpperMemorySize =3D GetSystemMemorySizeAbove4gb (); > + if (UpperMemorySize !=3D 0) { > + AddMemoryBaseSizeHob (BASE_4GB, UpperMemorySize); > + } > } > } >=20 > -- > 2.31.1 >=20 >=20 >=20 >=20 >=20