From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.3027.1623208085239989811 for ; Tue, 08 Jun 2021 20:08:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qC98qDGu; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) IronPort-SDR: w2feNsUkuKrfwFWm/CDm+L91f1JxpyPX0fFqh8eVClqrVWwXtRcEeEuR3/SEae1nbkrr4A9uUb 0vYSi9FFYvmw== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="203138361" X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="203138361" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2021 20:08:04 -0700 IronPort-SDR: xypeaJw6iR7snW9QBb6I1OTQdD2XoYnHZQAqKpaXE25wUpUcJ3/vcX2ytdYoX05w1K9t3XTqne aNlDOj3XfmRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="482220859" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 08 Jun 2021 20:08:03 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 8 Jun 2021 20:08:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 8 Jun 2021 20:08:03 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 8 Jun 2021 20:08:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CvAO6JYuAnM5p3tkjlBXeaNAEYL9yCPjUboXRYsKuq27lwQ0/GUjUINusg3JS7GksF8orkRXA8q29TqxLOOVNrucPedX81u7t0T45n5euehDTFlVaf7UAQ7jNelR5rqT5CvavxhR89aXhG/ovcGmsrF+kWEo4kvE7HAJywKhzWBL0W6wVP2W6Yf8bh9+0HLhioGTECz4SUp7Jjc24+boBSV1ivqTBipdw2Kq/2U9WrkDaJJtgqYjcnLWIkGDCg0kDEVe7i0MgGDgavh0F/d204+xPHx+MEL4ZZf/oHIXlXfWbNoNO2KpfK117NGev+cJdor1Oi4K0pn2T5XjN2aoYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j+Ke9RtzydKdYB9erfvp0p2MjrzI9BUQal736WVmTIo=; b=BdRQ8VCbQPtaVfvmBfNQeyq7lQRaEY/6vV2OIgGPqT16LUQ3C+fLMLc2ghoxXn5PDlSNax/v2NWxG1BD/yJ+rMMn93anBW/6BThmILk9ZIIVVxRCH/9UPh8T8GhLriSYt5ih9IagoKnoBjHhqAR6LSGQxHvFUhE+eOaKh3Ro/0rLzPMmlpFWnfurVlJfSBKGeg0X+TqMnZy7vdctXfOXq2qMIWY4cvdSKYorEem1BegRil/GWxGCgeg3b4YyP77ksJLVPbAmAv7SQKCjm3kW0pGH7ce/cczX+1ezoWHwtuO46R1sxsgU5E2Rwae3LkUz+3TwTT+7YffAxMI5qp/gyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j+Ke9RtzydKdYB9erfvp0p2MjrzI9BUQal736WVmTIo=; b=qC98qDGuMYIKfPPhW+VetMcC7HlTBWNWJv8pwSSHSYXGdjA/Rix+KKpH5SQ55Jkcrl50D9mSnsssHcEJeo9aGER5o2I/ZfP7XDLhwEwcNC5G3n+/Nk06blQDHrhxTnsUoiSYoR3/tYVE0PMMprrsiQDpOpPtAJhzmhTenEpTP0k= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB5096.namprd11.prod.outlook.com (2603:10b6:510:3c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Wed, 9 Jun 2021 03:08:02 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::547d:4eb3:f37e:dac4]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::547d:4eb3:f37e:dac4%9]) with mapi id 15.20.4195.030; Wed, 9 Jun 2021 03:08:02 +0000 From: "Yao, Jiewen" To: "Xue, Shengfeng" , "devel@edk2.groups.io" , "Wang, Jian J" CC: "Xue, ShengfengX" Subject: Re: [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm/Runtime drivers Thread-Topic: [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm/Runtime drivers Thread-Index: AQHXXB8f++RIe5vsdEiCFu42A2tiAqsLAMaw Date: Wed, 9 Jun 2021 03:08:02 +0000 Message-ID: References: <4a939b6b9a46a1b498931dd1ceb1bc62c4832ef9.1622805260.git.xueshengfeng@byosoft.com.cn> In-Reply-To: <4a939b6b9a46a1b498931dd1ceb1bc62c4832ef9.1622805260.git.xueshengfeng@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cf416983-d022-410a-5ab9-08d92af3cb1f x-ms-traffictypediagnostic: PH0PR11MB5096: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I3YTod/F9au2Uxzae5/ujZ6PFHrI+crXD+bNgINEVPS5WGApEhYB9zQnihlaJ8VoD6zKOWDZce35kvaoKCE4/Gpzntj3/2Nk0FYhk6UYcbx8Lv1G0E4mYnOqLK1HLE+ECcR2AhFPzOaWcUpgAo2O23fdIsKxPUXtHoh36c6InBSkSFTqWnhKlMhzEPNo8xfYQ1FbB2O/3snsUJY9jClT1Y5lMn8FjG5pNcQTpdJR2G+NQ5Sy53mpzOvyUOd5kOfIuTRshe7WM2mBFDjffrksgEV4al1TSl4ne0BtXcSHXwzxhhkoPM71TjF7KI2b2xEm6wb3CdtopJ5CneKBKOlsMrr+9IoCMuaRxAA4+PVGgBIy8WITZOePP5KA63YTCicNPuBWZb3WVvD7zea2bgyFlRO/CYZHOGHEb8/n9a2TPcoyojPaMOF4V2uHpW61QVaZHzovGAKlPNkWWtW+GsrQMyPkp5r/Du4R9OcfQ2NNQJlw781rXxRt+EQXcc44/K7iFzh43nUr5pyysNucPBIGFeuCctZ95rybmvauD4iGrMoFuUZmwGgfePp104vdhRTI4eieVFYGH5381Ena0c4t8LX4g8skFkHE7D94NHGGtsIZ4UVWgSD0hETKxUw/fzqwGRWLQYRt5m23VLQF2BoRV7eTpO77CMnMobJLfXvU8B4f1Ybw7IltGXNg+MdNHwhf/Fn4QnZBDgSsSRMFuzAinjD4wKb6Pmvei/h6IyN5lT4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(376002)(136003)(396003)(366004)(110136005)(478600001)(83380400001)(4326008)(107886003)(316002)(8676002)(71200400001)(86362001)(19627235002)(966005)(6636002)(55016002)(53546011)(2906002)(7696005)(6506007)(33656002)(9686003)(8936002)(26005)(38100700002)(66946007)(66556008)(66446008)(122000001)(64756008)(186003)(5660300002)(76116006)(52536014)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g241v71dReAY1UhQE/8ghSNiWWdnEvelgHw7SQ3H2UAI0P9TYCDaZ57ippzg?= =?us-ascii?Q?SWC7srINyf69CmegTiXhfdhhToi7G9T1XvDwd40zNtR3utUCrqJ05sryO/Rn?= =?us-ascii?Q?Pa/beCRv4tlyNYDyIu4IiwG28vEFzpw68in6wETueW1kyatt9moB0IgjieUK?= =?us-ascii?Q?Bm3H2hEmKdcd8hKt223itMswzRv/rBOock1H26CHsqNIGwPq3LhKRH2RKrQZ?= =?us-ascii?Q?6UK2/0PrgKcGCfr8d1O/ZEU6pSncdZtO6vLjN3G/H4BY/KpcqIzYN5uiyleE?= =?us-ascii?Q?YyllotWYGC7ulr4hTJ+rG7PIcQi1awXUQtsVXYgW3H6Jbs7JZa8hW4YPipdx?= =?us-ascii?Q?rIHBy0/oVva/lhPRa19Hdx01uvahnLxfMqnYNf5+fgW4+TXMRuDPSJCKSZGM?= =?us-ascii?Q?kxY5mpY8nhgBn1R4pjQ143Yx0V1ipX2cHpckN25r57gMJNl85+g5cng2/Jb6?= =?us-ascii?Q?4Wu+wC6iCS0jEbqriMJBQnfxW1J0YoC6W5c6K6CN2BhU6scftXvEoD1FlAMO?= =?us-ascii?Q?n0R9AdBNuvQ89aGMt7TBbn3uc3M/RGu9mtkOzlG5ptSmWQNKEmjRmA7t+LsQ?= =?us-ascii?Q?Yw6O8WhyFxJ26zI9hFuMkfnKe3orBT9QtQ28mmLFUGcFcSHqj7iLni9vwEvH?= =?us-ascii?Q?I/XA626zOpJfFedfEqlEkYb1Lkes8i9BpfMTZgc5m2+bwMIMhRCjzrsmW+EE?= =?us-ascii?Q?YBXqT2u1tEJyw9ndDTD8zFq+42n/CnYE0Y/kN+A/2pmCfrMsZ2+DTUgVru6W?= =?us-ascii?Q?QQozH1mHsNulBeUB/KC3k8bP4OGeECt22wm0AWHmKC7L1IUBSvf3GXr5FAEb?= =?us-ascii?Q?UKsuvr5pnDIhp/ngWtRBPIBtejk/6uVLc3zgFepZsOU0BykZ52DrfSGqvNQ9?= =?us-ascii?Q?AlT9BBrxvsR9KFMSQuUzROxgKwS7TIKYhgOdJ8bBDLZNcJSqkJ4Jux8LD6kW?= =?us-ascii?Q?FXmj8+ZJ1MFY3K5kmtfTwcughWU2rVSn4e5NqG+5jOTeWoQggFJlvyFVTG7w?= =?us-ascii?Q?uDZxoj1s0wnrzHM41Ls6y8RvuNOFbju3YtsZJaTVGZdmQJjIPhp2Oo2ZCaSh?= =?us-ascii?Q?MIMUYFxd+kU46wz1EUy5La8qlz3jsZXvYvYg6fsJFEUcEfahPNAMFPr4lKAO?= =?us-ascii?Q?vDKdwOEkT2TgEFZK8r4KMg1PXfppTE3YJ4xpf7HbijZabQdY8pryDzO4xX+q?= =?us-ascii?Q?3aBeXNq1zkW4pML5B4RXaG1HGsValWwk54Gn+WrgiM/vRRNK0v1lBVgI50hV?= =?us-ascii?Q?XMDGUPq+TKLhAwADTVJoef7s8hIVEQoA7aj0+RpDI7NKEuiFJbxwjlSRPKo/?= =?us-ascii?Q?UuqnNNjd9MoqAcVPjCPzyrjy?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf416983-d022-410a-5ab9-08d92af3cb1f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2021 03:08:02.2227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5iaGTAF77w9TQgN3tGuHpIeykO3NeBssvsq+3uo8dRYt37MttCGbBDj0rSp8cCJKrSSTD06IcEtLtLmhpg94Dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5096 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you! Shengfeng Reviewed-by: Jiewen Yao I recommend to wait for *1 week*, to see if anyone has concern on size chan= ge. Thank you Yao Jiewen > -----Original Message----- > From: xueshengfeng > Sent: Tuesday, June 8, 2021 12:31 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian = J > > Cc: Xue, ShengfengX > Subject: [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for > Smm/Runtime drivers >=20 > Intel Platform utility Syscfg/sysfwupdt will trigger SMI > to enter BIOS interface. then BIOS invoke EncodePassword > in SMM mode to check password. > it's need sha384(in CryptSha512.c) in SMM mode. >=20 > the origin SmmCryptLib.lib size is 1389KB, > after changed, the size is 1391KB. >=20 > the origin RuntimeCryptLib.lib size is 911KB, > after changed,the size is 913KB. >=20 > in SmmCryptLib.inf and RuntimeCryptLib.inf, > change CryptSha512NULL.c to CryptSha512.c. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3423 >=20 > Signed-off-by: xueshengfeng > --- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 6 +++--- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > index 3d3a6fb94a..fdbb6edfd2 100644 > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > @@ -11,8 +11,8 @@ > # functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions= , and > # authenticode signature verification functions are not supported in th= is > instance. > # > -# Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved. > -# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All ri= ghts > reserved.
> +# Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved. > +# Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All ri= ghts > reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -39,7 +39,7 @@ > Hash/CryptSha1.c > Hash/CryptSha256.c > Hash/CryptSm3.c > - Hash/CryptSha512Null.c > + Hash/CryptSha512.c > Hmac/CryptHmacSha256.c > Kdf/CryptHkdf.c > Cipher/CryptAes.c > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index 07c376ce04..e6470d7a21 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -10,7 +10,7 @@ > # RSA external functions, PKCS#7 SignedData sign functions, Diffie-Hell= man > functions, and > # authenticode signature verification functions are not supported in th= is > instance. > # > -# Copyright (c) 2010 - 2020, Intel Corporation. All rights reserved. > +# Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -37,7 +37,7 @@ > Hash/CryptSha1.c > Hash/CryptSha256.c > Hash/CryptSm3.c > - Hash/CryptSha512Null.c > + Hash/CryptSha512.c > Hmac/CryptHmacSha256.c > Kdf/CryptHkdfNull.c > Cipher/CryptAes.c > -- > 2.31.1.windows.1 >=20