Re: [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hi Min
I think it is good idea to rename to LocalApicTimeDxe.

I double checked dependency in INF file. But I did not know why it depends upon OvmfPkg.

=======================
[LibraryClasses]
  UefiBootServicesTableLib
  BaseLib
  DebugLib
  UefiDriverEntryPoint
  LocalApicLib

...

[Protocols]
  gEfiCpuArchProtocolGuid       ## CONSUMES
  gEfiTimerArchProtocolGuid     ## PRODUCES
[Pcd]
  gEfiMdePkgTokenSpaceGuid.PcdFSBClock  ## CONSUMES
[Depex]
  gEfiCpuArchProtocolGuid
=======================


Do you think it should so generic that it can remove OvmfPkg dependency and be moved to UefiCpuPkg?

Thank you
Yao Jiewen


> -----Original Message-----
> From: Xu, Min M <min.m.xu@intel.com>
> Sent: Monday, November 1, 2021 4:46 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Brijesh Singh <brijesh.singh@amd.com>; Erdem Aktas
> <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Tom Lendacky <thomas.lendacky@amd.com>;
> Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
> 
> XenTimerDxe is a local Apic timer driver and it has nothing to do
> with Xen. So rename it to LocalApicTimerDxe.
> 
> After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.
> Otherwise 8254 timer is used.
> 
> Patch #1:
> Rename XenTimerDxe to LocalApicTimerDxe
> 
> Patch #2:
> Switch timer in build time for OvmfPkg. If CSM_ENABLE=TRUE, 8254 timer
> is used, otherwise the timer is LocalApicTimerDxe.
> 
> Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v2
> 
> v2 changes:
>  - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> 
> Min Xu (2):
>   OvmfPkg: Rename XenTimerDxe to LocalApicTimerDxe
>   OvmfPkg: Switch timer in build time for OvmfPkg
> 
>  OvmfPkg/AmdSev/AmdSevX64.dsc                           |  5 +++--
>  OvmfPkg/AmdSev/AmdSevX64.fdf                           |  3 +--
>  .../LocalApicTimerDxe.c}                               |  7 +++----
>  .../LocalApicTimerDxe.h}                               |  4 ++--
>  .../LocalApicTimerDxe.inf}                             |  6 +++---
>  OvmfPkg/Microvm/MicrovmX64.dsc                         |  2 +-
>  OvmfPkg/Microvm/MicrovmX64.fdf                         |  2 +-
>  OvmfPkg/OvmfPkgIa32.dsc                                | 10 +++++++++-
>  OvmfPkg/OvmfPkgIa32.fdf                                |  8 ++++++--
>  OvmfPkg/OvmfPkgIa32X64.dsc                             | 10 +++++++++-
>  OvmfPkg/OvmfPkgIa32X64.fdf                             |  8 ++++++--
>  OvmfPkg/OvmfPkgX64.dsc                                 | 10 +++++++++-
>  OvmfPkg/OvmfPkgX64.fdf                                 |  8 ++++++--
>  OvmfPkg/OvmfXen.dsc                                    |  2 +-
>  OvmfPkg/OvmfXen.fdf                                    |  2 +-
>  15 files changed, 61 insertions(+), 26 deletions(-)
>  rename OvmfPkg/{XenTimerDxe/XenTimerDxe.c =>
> LocalApicTimerDxe/LocalApicTimerDxe.c} (95%)
>  rename OvmfPkg/{XenTimerDxe/XenTimerDxe.h =>
> LocalApicTimerDxe/LocalApicTimerDxe.h} (96%)
>  rename OvmfPkg/{XenTimerDxe/XenTimerDxe.inf =>
> LocalApicTimerDxe/LocalApicTimerDxe.inf} (86%)
> 
> --
> 2.29.2.windows.2