From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.7718.1631081005952247091 for ; Tue, 07 Sep 2021 23:03:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VejQLpPr; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="220079208" X-IronPort-AV: E=Sophos;i="5.85,276,1624345200"; d="scan'208";a="220079208" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 23:03:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,276,1624345200"; d="scan'208";a="538399901" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 07 Sep 2021 23:03:24 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 23:03:24 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 23:03:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 7 Sep 2021 23:03:23 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 7 Sep 2021 23:03:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dp4iPYxFfioVQ2tbSs5+JntYGA6V+sQvDdWwNqYk39Tq/qXkZ8E6XSNaIL/1CEI02qGsTvSZA/1+bebrCc6gB2XbSS0XJ/GXW993husVKgyNDP6sJ+ywdoWQANGBNW7Q/We5Aj9Zq11owwyxNNouW+C1EnnryJR0YW23j2pLmvEd0VAtlyUDQBiaeZQZqLYolFuStSKwZoXylbLZ2YR+cnEebpvJVC+TA70NB+8961XzMpIkZTlj7YHijWFKGFuaEh5Iepk3Xj9Ydd+/IZZPYTG4YOo2DkehgrcwqDPW2cpp1CmoiNG8fNcMW/7VobuBvQakR8+qCghmQq0adae7XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2zdNDeOChBL/yENfClw3w4+/hnkdZ1o4lIlx5TWpi/M=; b=oAYYA0JvwgdDVDAqdmofYvIpgwKmHZ0uQREd5hTTOXLHQG6qtHaSgdCFyYgTBrx7mjAxa/0AkgC/+aMgU5vS/eD2Q8lLqhQ71Crv3/XXo6+GUdFgC89Dbl58FFC1xOzYUSGPbI9F/3RyIkQimJu9r+fLTggyNsI8MD63CcxVDerBTu9LtKjitvwkE9WAKMOP6rtkKDu+W0w0nziZrL/UYH+vVqqMnf79EEo5LgzFxIvGjc8wGLvV6MCfX7AhLsrw6cATsazQJBYubVuFYE1GUL2RCMY1TmQ9HYDK/utEtXRj0PltC7EZid7QfSg/SMG0idDtXD061xPJfHqi+gN7og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2zdNDeOChBL/yENfClw3w4+/hnkdZ1o4lIlx5TWpi/M=; b=VejQLpPrAi5tGslhNmmxKg44biOVs9unOy5ebwZeeoPgAa5jTmQyrlOPhdazdytISo3eUQu84pPjqaKqidcUKwdYL9qXtZZ9NsadYlYJzZ29/u82E/5tE0Bz/UsBS/uWTsjZcRhbowzexZxALE0o1vAGQd0DK1hgHBgkmLjn7zw= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB5157.namprd11.prod.outlook.com (2603:10b6:510:3d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 8 Sep 2021 06:03:21 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::754e:42e9:16cd:1306]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::754e:42e9:16cd:1306%5]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 06:03:21 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , Brijesh Singh , "devel@edk2.groups.io" CC: James Bottomley , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann Subject: Re: [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support Thread-Topic: [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support Thread-Index: AQHXn00B059wRY98pU27Y2OZJ6b/8KuXyo8AgAGppICAADtwMA== Date: Wed, 8 Sep 2021 06:03:21 +0000 Message-ID: References: <20210901161646.24763-1-brijesh.singh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8bb41749-3f50-4567-c318-08d9728e5cc3 x-ms-traffictypediagnostic: PH0PR11MB5157: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QB4y9XoJk8buMsd589cPaksxHra39R4nXvnjvbUeLLIOOX9FanHjXFmK5ttDilSnwpH61uJKiT/xzTiYoP8dKqSEnScxnApceYGJTy7TmUbeuTfJJ7EZYU4na7wVZGFIFOgTipahMaKMx6EfjPORjampN7gKiF2I3HyAq+vdrEZPmmJP7zS8qS+uAW6Z9Jkdb3CeqS6+nd2g9H+5D6FjFUX6I3jl7M99zWkFFu7RAb8jupQrE+W1uH68D2SCRfDRjPb8Z712gGryWeUm2PIR3BZpcXsToCdZMzA+27jOB8rUl+CwC80QfM+tVopJA0Uu4fAUVL7O7UgAwOH+r8C4HHZA6JFrPcf6T1Qb2rCHKSXo6GXsKc+SkDzxeRYaGaKty72ClX1SalGtSNKyGMh+sbzLFabroktdJTMUOhe59JTwFxdNbGnVoLIUTnHWmSHy6WsNMvblJ00kkweQjpmMt+dE1um6/d+Y83bRLcZJ6KWE0KVkIY6w7VDmjihles2XYlhm3bJZtCCtEc9J61CBiwgP2D93+/4wj+GrskPfHrf01kjg25gvsoV/HoQ3+2gRacuVmxikgT8oM2TyYfiyZbflQma+3/aa0cP1LX0Dkwy4XDTyACNLR+hYSZoi6/sIj+MwU2OZO2EBJSCZ4fbN5BBxxCY5p+QhkMbeI2Ck1wlHe0+6Gr/gjxL5/ffwat5N68OxXHIwNzi8nDN8SVu7rA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(39860400002)(346002)(366004)(38070700005)(6506007)(86362001)(76116006)(53546011)(66946007)(66476007)(54906003)(8676002)(5660300002)(186003)(110136005)(66446008)(71200400001)(64756008)(66556008)(55016002)(8936002)(316002)(122000001)(7696005)(33656002)(4326008)(478600001)(38100700002)(9686003)(2906002)(83380400001)(52536014)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aTWceYlsAelcokxuQhukFTFEVMyJC8e6pkWkaHJga0YU4ddq9UOyaTlervC7?= =?us-ascii?Q?liY/OfdoZCxPq/w2XHA1oRumU5MHWQqoL7ceHQmRXh0OIsKY0riidGkJvRr7?= =?us-ascii?Q?xjmxp/F6UnPWrl7tjL5UhGHqJPHSuVNq7Xqdn5bhVtw+XBQOd5wD6AejizdZ?= =?us-ascii?Q?6TntBCjzOkajOhM6Bq4jZZgRONVgbre3X2JK/QlLpq+pp0GuhJtqpCOdUtVx?= =?us-ascii?Q?E/C1K47EoMZpJUgCY8k2q2F0LEmq3R+zXH9Fl4m9LSeTOwl+67sA8kBdqAVE?= =?us-ascii?Q?tLJqhrvxSMKibJ+Ymaqh34bgawSQruqJ6Vs54gPoy9oupl0y8onqsTDHwz9f?= =?us-ascii?Q?fS2ju0z6xiEwiKlZxhNr3FfmikAI/HnA1WzzPKUwg0y7f9UTNachmQg7RI6l?= =?us-ascii?Q?mO1OiILdDDrehf7uckr3n8MX28QCTgeqD+yNfO0bXf7BkagJX/sTqKvZxTPm?= =?us-ascii?Q?nJaaxc05xFEFeVv7qRfj6l/uGSf6w45mWLWVX9PC6jWTWqHnOCeF58d21QGi?= =?us-ascii?Q?MTNP2vxaLdQvS8uDUlfEydgvGOGoYebvgds09oD91gAmYat/anc+ijHmoUPJ?= =?us-ascii?Q?XHHGnOZLoxI3wtjij0fJXv+J8+K4t5diHLi/qQ8Z2hKUQP7Yv/5MQ/NpQ45Y?= =?us-ascii?Q?XT9TOBykcokf2H9+H9Fq0biq1Q4H/2wCcOlSa4Jk12TsfOs7k4qqCAKOEYl1?= =?us-ascii?Q?4l5bIKTZ61+ucLDAEdqAXlvzLOOAxLhkA3ZtcpMVyOvyu2ne7FNJ8Vxvb2mK?= =?us-ascii?Q?erOwv3IkCYgB85eALcl1WZg5tWBhKwLa/f9YDyGKMMmTYaIDXl7PHcz1zXia?= =?us-ascii?Q?Snh6fmpUjrLVd6z5VW5ryB4kcbWpBO5AcRo/HJvtharvp6tpM2JH/owe/MN4?= =?us-ascii?Q?YFKwmWhyL/PcLAadDMmADQ218wEJjJ1HwnYlhx9iJkCCRgn8sHBEFnwHzwFj?= =?us-ascii?Q?3QA1ZZSeiaL3Rdd55/CTSuY93w7eosACbCLiE3PG4D3oliNKXKYWrt7o0pQr?= =?us-ascii?Q?/hh6/AN1LajxOoEQfc9gcsBxMRtW73+cLrp7rXsVzuntkjDwUFUFJWewGkg3?= =?us-ascii?Q?YVotxW8xuBxJo3c2rplXTSEyuUUNIjgif+kuDUHqyjoO7hbNL79D3MmVvF04?= =?us-ascii?Q?uMRRornivRIEdOc9Sf2KW4tPT/l+t7gaK5XYJb3tier7OB+AsT4oLmCiQ1Kf?= =?us-ascii?Q?wMH3ubDyQWPIEkwgqzXChA8qxoDImirNg8vo9qRY5wI1rfLJU0cJcktG9ivc?= =?us-ascii?Q?/+C0lCNK978mqivniwLlxjCeSI46f26PruLc52naVXw6LVWS3OHf6Y/hr1Mm?= =?us-ascii?Q?xJIRMXxHvQvuQGNpDW4pKMms?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bb41749-3f50-4567-c318-08d9728e5cc3 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 06:03:21.5238 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rGqQDlKPE9i+Rh+nGYtv2YXSqHulqtzQ+k/viTN/V9lGRwZNgvGSb/PefGWDHG4s5wifUtnLi2YLFOm1755AsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5157 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, that is good idea. > -----Original Message----- > From: Xu, Min M > Sent: Wednesday, September 8, 2021 10:30 AM > To: Yao, Jiewen ; Brijesh Singh > ; devel@edk2.groups.io > Cc: James Bottomley ; Tom Lendacky > ; Justen, Jordan L ; > Ard Biesheuvel ; Erdem Aktas > ; Michael Roth ; Gerd > Hoffmann > Subject: RE: [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) > support >=20 > On September 7, 2021 10:37 AM, Jiewen Yao wrote: > > > > 0008-UefiCpuPkg-Define-the-SEV-SNP-specific-dynamic-PCDs > > I really don't like the idea to use BOOL PcdSevEsIsEnabled and > > PcdSevSnpIsEnabled. > > Can we define *one* PCD - such as PcdConfidentialComputingCategory? > > We can assign range 0x0000~0xFFFF to AMD SEV, 0x10000~0x1FFFF to Intel > TDX. > > Then SEV=3D0x0000, SEV-ES=3D0x0001, SEV-SNP=3D0x0002, and TDX=3D0x10000= later. > > I really don't want to keep adding PCD endlessly in the future, like > > PcdSevXXXIsEnabled, PcdSevYYYIsEnabled, PcdTdxIsEnabled, PcdTdx20Enable= d, > > PcdTdx30Enabled, ...... > > > We have CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER definition in > OvmfPkg\Include\WorkArea.h like below: > typedef struct _CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER { > UINT8 GuestType; // 0 - legacy guest, 1 - SEV guest= , 2 - tdx guest > UINT8 Reserved1[3]; > } CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER; >=20 > Can we define the PcdConfidentialComputingCategory like below: > ## This dynamic PCD indicates the Confidential Computing Category > # [7:0] Confidential Computing Category (0 - Non-Cc, 1 - AmdSev, = 2 - > IntelTdx) > # [15:8] Sub-Category (defined by each vendor, SEV-ES, SEV-SNP, or T= DX-1.0, > TDX-2.0, etc) > # [31:16] Reserved > # @Prompt Confidential Computing Category >=20 > gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingCategory|0|UINT32|0x > 60000018 >=20 > Thanks! > Min