From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.3426.1627520940576417325 for ; Wed, 28 Jul 2021 18:09:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CE4pqnH1; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="193058755" X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="193058755" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2021 18:08:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="581057974" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga001.fm.intel.com with ESMTP; 28 Jul 2021 18:08:56 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 28 Jul 2021 18:08:56 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 28 Jul 2021 18:08:56 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 28 Jul 2021 18:08:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJlLozfQZBh8+H6COKdacyKBCbs/0D7MB18rfjkhxYf60nSpsoK7Bvwvrlos0o/8qGng0XoZ4yHXpOtCpKOBkKVaNqBBeh3EMxr5cG7cM0vV816QiLaXTdEoYmW84ZPv3P56HltQOLysySBJPYwsSdhHhfP9/aZ+YMXFUuVhJxgqFnUZjjsyCJokHbvKlXMD5okIytQkYvvArj4y7CB08hHn4Kfncoo9u9tLGuhDQO5wmbo+mmAe2oQPbWbpFpvDB2WXqqAPgCR7MUDdPL3DzFkd0NmKsvEXFR/sT5WqrHJbhES/pilL+gBNEg7NnawVv5VhiVBXr6UuK39ZK5uptQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IRkhifnYADhdKBdz3BKRLW7cc0HUeGRhHceCzlR0UCw=; b=CdC6aObbvXskytmqTfHvdkk94KAIm0l6Ope2RfI3B0lxJrWTOEiH/iKsnyfDkssvw5KkBepARzna+GMqb7f2DuQ30otlckL4dTWL1DLK/mHuUfCc9sHJs+gLODZxRzMzktI4qwLujkc2Tr3XGRux1Z4lNEFDOYAZh1wFlvgRR2DDvkFVkBKEJRxLN854tg+/rSkcpcIquZnjosDM8bvh/MS2hlvJrrbd0djdoqcT6rmi4sGj4z5+Kkwqr1RORUI5l3LRsv3UtctLXilgZjNcl1KZuE7sGHYqe2siYHH9C5rtCGfiK0qYy746ai7EvWikyG4kMJZ4/MY571+zAJf9UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IRkhifnYADhdKBdz3BKRLW7cc0HUeGRhHceCzlR0UCw=; b=CE4pqnH12WUWjywZXW8+Wpm0zJmQ8o8H3xRRB9Ukjy8X29OQwNWRa5JAi+MNxn8Om5p51ik75gQNlNheCQiO0ePCWdKla8dKJDoVCxpIgdj6qXcHEBSCK0O+7Vrc9zq8x7aPLM2m0VUUuF8VT0DybuJOFuVeKkF74GCHvOod330= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB5175.namprd11.prod.outlook.com (2603:10b6:510:3d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.28; Thu, 29 Jul 2021 01:08:52 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::6c99:8170:1c3c:9121]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::6c99:8170:1c3c:9121%3]) with mapi id 15.20.4352.031; Thu, 29 Jul 2021 01:08:52 +0000 From: "Yao, Jiewen" To: Brijesh Singh , "devel@edk2.groups.io" CC: James Bottomley , "Xu, Min M" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas Subject: Re: [PATCH v2 0/3] Move the SEV specific changes in ResetVector in separate file Thread-Topic: [PATCH v2 0/3] Move the SEV specific changes in ResetVector in separate file Thread-Index: AQHXgxLEiSzD4foiGUe/twkD79EMJ6tZJljQ Date: Thu, 29 Jul 2021 01:08:52 +0000 Message-ID: References: <20210727181024.28770-1-brijesh.singh@amd.com> In-Reply-To: <20210727181024.28770-1-brijesh.singh@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97d83db2-318e-4a8a-973c-08d9522d6e5a x-ms-traffictypediagnostic: PH0PR11MB5175: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GeyDOCRgQEvizAO9z/sxAcipwOJUJyh3ZkkfEhtTyngzSyy0CJFQ75YAbnh5Xo9FGAL9efKZeoIL6/uX+WRQH2FbYvkKxwMu968cezQyNXZU1syh4Equ2pJYs9UjZvIM44G4CH8V44pB0eZX+PFOLEC9Hd5KmDM+WDvopMJDzMoOtrieHB4bm+ceMBblBF8gMW3KsSRu+6Ght1kWUQo1KcFH4QfDE9a8LebywYpVAlX4loOhJeNB3lKQ5C2qR++tgloNOS3nkUE89E4pppsb/JcYV47engZRJF3+Q3kc+Ku3mRhdtUUgQqTbpse5eMC+e67NDr0WgXwxaJwT/kX608pZBbMiyxmOzCixSSNON5GwVFe9bzWjcHeWePKidMDVWumTxwMIX2yZODtAYa8QTtjqJUwtCJI4ipSTPzDwNlMae850iw2FDUXOmNUd0Zk3OkUgusq6XPclSTizJ7o6A1bT44th8StMPaPJmjBSWSUwXHliRLJbryNsmN6HulILV+86/eCiQq9gTzNwlVu/LzI/K8vkr37Fu9uCslX/p6UirdozFUieZP0JxhtHE/v0Aymft8Jg3TfqBLa8yqtpExpOQ7nrQd8j2zJHgZlwRnCYZTmdNtAWLjTIZ8tnWmfRr2Xmj6RzeHiT9/hhNrR/lkQ49nMCdjF7RYhtB8nPDFA/9PO9uZytzpGm0LRH9yYGMrSferHj6VBSje9zSPaEilrt5vGzvVZtYwEIXLulk/Uja1r4v1brbB/gGUICG+C0ffozIfPwHPWzMp/sa+xBGzjaplejXC8++JkWzgNZM3Ne4LEVuweekZFRcb3hND2O8Yh0q52XReqe2wfElhaQDg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(966005)(9686003)(7696005)(66446008)(122000001)(66946007)(55016002)(186003)(38100700002)(52536014)(26005)(76116006)(110136005)(86362001)(38070700005)(54906003)(83380400001)(66476007)(66556008)(71200400001)(19627235002)(508600001)(64756008)(53546011)(6506007)(316002)(8676002)(5660300002)(4326008)(8936002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xmwgGOV5j6c9NJhhvOl31E4f6TbpiEQ0wRXK9UaxvNCzM7VKzo5KfJiJW8BN?= =?us-ascii?Q?aOJci1rSczarm1QZWtZjeiY24I6HiKtTJ1TvwATkSiom/kaTUsi9eOK8ZOZr?= =?us-ascii?Q?LvvU1nOQBNr/5zV23u636CQZ9xYLJ2wcKxETAYod7qgkHGRTG2nS0v6JVrBz?= =?us-ascii?Q?CZTVdAhiBbDaNB2o7v/PUhxUeG+Trb+mpjEK9qnhDoATaPNTKTD4baiPeGUB?= =?us-ascii?Q?HDxIT6bQiL5cKijEMI9ehUBHYCfGKAg8ERrGNpngNebu6141ZEczg0yDCB6+?= =?us-ascii?Q?IunIGH8PWvQL1fs27WULXUyBzethR00JWuej8yxx4oAgrjBMrT97IiBHDcJI?= =?us-ascii?Q?09RSgw/oyT5bZKKoXUYrSlLxy+J6LFhD83wH+pz+zD3jG4K4PWRPXPbISjpW?= =?us-ascii?Q?f9+jH5xEdw5QamoCmxkp3GMvTArJmYFVEeXMs0FZl+2O8slHWFtskoy280Qv?= =?us-ascii?Q?qbFiAyw/kjgoikzwOdB6nQ4ti1dSLJ+ox/wSQouaj3suJc9qsTDQ1Jix9LqS?= =?us-ascii?Q?AuNulkYUYdsBZ6U47vFCSDvVVhffQm+2cklfJT0n1hftoNBkindaFT5zkjE9?= =?us-ascii?Q?zTtOuCRyNn8Jm6Vs4FdoVUYDSv6rdDXVG1+0Wf8gmvgVAM93vafd+iZ4HbqP?= =?us-ascii?Q?mAq298laq/i2fqXJttiouZUGM909h7INAEV71tg4BF0WnZCuE1JTq9ymGRr2?= =?us-ascii?Q?Nn7bj52SeYXBO7giMMKoLjcHVT7nkAe/+K3uBy8e/UUXK1SOHAx1fH5btmr9?= =?us-ascii?Q?Wu5WCBzzNMsjSrKgqPnQVHT57Az9CwwLtDndPqhnv12lrlOjXMNNY5RhBSdP?= =?us-ascii?Q?A5lXFW/OFq8jZn9fHa9zIeZPW2b+HGsRmQDcjgbFjo4LBIweZaY4rhrui3dj?= =?us-ascii?Q?drNmCzAgNRhsAYf9eAkc6Yi1zJx+YxkbiWPYudIO8nzDZAltehsfDBAHVz2S?= =?us-ascii?Q?xX0rZx6eAGk36sMruMPBUr4FOSd8KHyQtrD/A+I7Cfb7F/cRk1fZMKlh5Tqw?= =?us-ascii?Q?1vuNfzN0+DSmwBDNAtyP1cQX9j12vSEUCFpZrpLDjD08QurPeZ0p+/OljDot?= =?us-ascii?Q?xzgo7/t2DZfUm7/9ej0GItAj77cUQ/9ZxUmVEKacCedQZJ0zlCM6rTcJqIdn?= =?us-ascii?Q?D3YYTiM2oSldKqR0DWvRGoSez0vZmvtJWIiTae1VToEh0G2mRe3oC7yHZGG/?= =?us-ascii?Q?cG4fcWZHl+D2WA1TsWO9vZC96nGiJ3rn4IRljysRUdT6wHCgWm9+TQF+txOR?= =?us-ascii?Q?eIiSVuz+zyhincu7RnbrtGaTrsV8S/a7ThotbBZyh7giELHhHwWqIn6UFMql?= =?us-ascii?Q?GTeBhA0UlXBD50mXrNmteW9n?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97d83db2-318e-4a8a-973c-08d9522d6e5a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2021 01:08:52.7435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LceuuY7SOteCqu+ljjfw+5rfFkhkdpeBkrvRgLmzBjd6V66KX5YZruyEFlRkQwHEO7EXeVuF8lLuq6W30Ph54Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5175 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed. https://github.com/tianocore/edk2/pull/1842 githash: dc485c556d5f5db21debe8de3a45a7564aacbe24..b461d67639f2deced77e9bb9= 67d014b7cfcd75f8 > -----Original Message----- > From: Brijesh Singh > Sent: Wednesday, July 28, 2021 2:10 AM > To: devel@edk2.groups.io > Cc: Brijesh Singh ; James Bottomley > ; Xu, Min M ; Yao, Jiewen > ; Tom Lendacky ; Justen, > Jordan L ; Ard Biesheuvel > ; Laszlo Ersek ; Erdem Akta= s > > Subject: [PATCH v2 0/3] Move the SEV specific changes in ResetVector in > separate file >=20 > The PageTable64.asm was created to build the initial page table, > but over the time it grew to include bunch of the SEV specific code > which does not directly manipulates the pagetable. Before adding more > to it, let's move all the SEV-specific routines into a separate file. >=20 > The series is taken from SNP RFCv4. And there is no functionality change > intended. Its just moving the code from one place to another. >=20 > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas >=20 > The full branch is available at: > https://github.com/AMDESE/ovmf/pull/new/refactor-reset-vector >=20 > Changelog: > - fix the copyright header in AmdSev.asm >=20 > Brijesh Singh (3): > OvmfPkg/ResetVector: move SEV specific code in a separate file > OvmfPkg/ResetVector: add the macro to invoke MSR protocol based > VMGEXIT > OvmfPkg/ResetVector: add the macro to request guest termination >=20 > .../Ia32/{PageTables64.asm =3D> AmdSev.asm} | 297 ++++--------- > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 391 ------------------ > OvmfPkg/ResetVector/ResetVector.nasmb | 1 + > 3 files changed, 92 insertions(+), 597 deletions(-) > copy OvmfPkg/ResetVector/Ia32/{PageTables64.asm =3D> AmdSev.asm} (66%) >=20 > -- > 2.17.1