From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.17212.1628472441923265623 for ; Sun, 08 Aug 2021 18:27:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kJYP0wXO; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="212749070" X-IronPort-AV: E=Sophos;i="5.84,305,1620716400"; d="scan'208";a="212749070" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2021 18:27:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,305,1620716400"; d="scan'208";a="514738749" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 08 Aug 2021 18:27:20 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 8 Aug 2021 18:27:20 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 8 Aug 2021 18:27:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 8 Aug 2021 18:27:19 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 8 Aug 2021 18:27:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kttIrE+69olkZ+XTRcWKxqw3dArzReB3ISIhX6mjtucJ30izPuLgk7+INdP9tLiYY3rIft11Hl4pagWCcCM4fPigvO7x/gfgVmQ7ESYQsi8xT1zSSPduEawAM7+97GBLX97z3mNzVS5nQzDQZ5UJEKCUp0h4EptczX5eYqyqrG7W2imkbYvjH0eGdYPONDWS2omDTy3NdOjOdn4J8RYBuEKldPV+/niHLJFVuH5r7dj40V0Y3FXefZ78Uem1eaqjcCLuRqOux6GNOkZq7njUu2DmtfjPaGmxhZ4PU0p/cFmgTuhMnKfW5/3JBJ+ajjbBUO1bOmqixIWqkGmx+UTVwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8QmjT1GXMOKrtmrMhfGuPdFlNy9KA/u0mqhhirQML/0=; b=Iq4wWyDsNe5Tfemvir+BcqvtRkDXf/gbl3WX1UqalUdA8cloGw+osLp/n9Du/eztqb67oR5v7G5sykEeCRGbobC/N4qNm9uQ8LJV/PwfCCOCJCL1NPUm6EVXBY9HyMOmnDwExEDZFlOYgz6dPPZ31ciyTwj1ObS1JWssoWkCd13BHFIdNnfmMJYDF3nO6XHspV7DFP9eBkRdKGSpd3ADFsIbwyeym6LR9/ptoEtpMCYebgx67OkN5zITKDf3gYRCRF4FpqCYhASoQS3K7jtO/t+Hk8yLHlNyI0htpjFRHpMH+XJX2xX3L7JA/WOCfIijosiY4vYJcdG3INbZmeL0pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8QmjT1GXMOKrtmrMhfGuPdFlNy9KA/u0mqhhirQML/0=; b=kJYP0wXOwsjs710RY6P7tL0xsojWczLfk2++AHkxeM8M9gHcH2+3iZ+xjNiGarYadOXF/s1+AK8IqiQErToDbYVJtzPy8FcEmN+XI78zGXYpBwJTakQ0B/ug+07zH3fgQWLambfB4uotN4GeyrhjL9Sxnel+vsgABCbkre35JwU= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4983.namprd11.prod.outlook.com (2603:10b6:510:40::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Mon, 9 Aug 2021 01:27:18 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79%5]) with mapi id 15.20.4394.022; Mon, 9 Aug 2021 01:27:18 +0000 From: "Yao, Jiewen" To: "Gonzalez Del Cueto, Rodrigo" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion. Thread-Topic: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion. Thread-Index: AQHXeogrYsCxTB3/+kyyE/JN9B8psatqhgKQ Date: Mon, 9 Aug 2021 01:27:18 +0000 Message-ID: References: <20210716211817.263-1-rodrigo.gonzalez.del.cueto@intel.com> In-Reply-To: <20210716211817.263-1-rodrigo.gonzalez.del.cueto@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 812d6156-2bfe-4cc3-4527-08d95ad4d3d2 x-ms-traffictypediagnostic: PH0PR11MB4983: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ztrM1rAr2bIEK4cNEm69ytRMXk+hYy3WbYU/IKkzOx8WFL0GAncEdct7FqINs/PjQMwOC+vWL3kAmMnVnHrCkaNaW3C8QiV8WE39yjNzkdpMIcLLBNU0M0+/zGCmXAjuHYXstWj4rtWGh73BcmNbqMDMxNvoOLRUvtLjKStALebYJLClZBudEJhPRI2ykRQfafDFjjDM+OlzxOVvqTYdDYW7bhLnW4x5+bQBxCIEvPsSIydSkLxMOn+g1PhE1GoWQclYnK2g9bpYEVnmqeLc20N9Tb1t6Z+6mp9Qsge2qG9W/amyFk9/jN7st6UJbqurCA71Xew+2V9aRAt1UMgzTRr/PwvcuyeOsrZo71XbaSe//neJKk+rN6v3hEPWlNRSrMqw/SAP25wgHpY8B9hmNRRiLSQUYv3/kadSPFNSavmowqwSjZ2U+5avo1f2pxBNriV6dNqKMsKycXqF+rOiRd9CSA6/vyDjJbevc4kZ1Lgra/I/FEx1Tcw+63WYi1YkVUCvnMTw6KKh1C3XgfQdnDU0jkg5rc8kQpStOs83cewU3wzpn+YCvW5R2H7Qvqwbal0mOuxLsiR4Sm6sni10cpCgmOFaMQgEGHp1dPOyTb1MJ6dynViU/yVODBEGwFo7UXMD9uSFfzYEwwNVXRyfv+/ZDsrsZ4tmepXXPkqX8buVPf29FCX6CtKvwITfebKDtpBOaO4QK1h+F2IT14KT7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(52536014)(66476007)(7696005)(38070700005)(33656002)(9686003)(53546011)(38100700002)(8936002)(66556008)(110136005)(66946007)(26005)(316002)(2906002)(6506007)(76116006)(478600001)(122000001)(83380400001)(4326008)(71200400001)(186003)(19627235002)(86362001)(107886003)(64756008)(8676002)(66446008)(15650500001)(55016002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kUmakjKa1EmREbG0s/hD8MgAqe+9wlzD0AuL+GGhrQaa8i47OgWvWGm+VcEV?= =?us-ascii?Q?o/D59pLPjp1+ei0jIF9jVgJFsNHkdz2r2f46B2bSZB69rw3veFIUTQ0QNfI6?= =?us-ascii?Q?Z+yVWGc5vqGl9Bk2bW9FM+pL2XYabAT1VRez/uzJji4lk515lWPtAZ5Aj5Za?= =?us-ascii?Q?/fDFjeKv2sKCgjYnBRAlbib/uUoIX4HfC4pONUpQLvhAEir6dnye+y6EqqY+?= =?us-ascii?Q?b4fh3pcSoZu0yJwwq7Dpqc2UG5KhyVff4+RTRlECIiyi0RNPeZJKz4kQ9Rp4?= =?us-ascii?Q?vU+jXESag9yX2ANbCAc+MINpTRw/JH6/M832Gxj2qJmDMw+ICMEsPAJ0tIgx?= =?us-ascii?Q?mA8TSxBcxom/Z5Tk7ZZSi2CxzsuWsLL+eedW4hCaSLXs6m/806T2RbjtcNOu?= =?us-ascii?Q?PPvRcLvyPzlqDm0am7Xq2YPto5bqc/ASIt6ZON3cKHzhp5FQBSb3w8gTGozw?= =?us-ascii?Q?s5JFMLQ7bJm0vvg45ju4rzDXMqPAhvID3Kg/g3Lb/DuwkHH3Pobcm0k6updc?= =?us-ascii?Q?pe8Oo4vAVhWZtTHx6YlJgBAzYM1qtkXCikp8pzIbgTIAWf1iKL5kDraG5XuO?= =?us-ascii?Q?SnEg27jMto9QIXZFyyl0tb16N1NHuHx/hU9THcWApy+9tHB382jGkC16ndg1?= =?us-ascii?Q?6Kg6ghdfOySOmKFsjBndVjRz/kD/aEofty55x0ivl1gLYffDVKseHGlRHNHW?= =?us-ascii?Q?SyT2BvibPe/hC7Y4flenZgVKVOunvgMVfkDLAl2SBEKc3Wrr7JuBqO5b3S5v?= =?us-ascii?Q?uvxmSeDNWRZi3sRTXF8DLcdwtKW1G8lFLacc8L7XduzxnjvduaZ5O6PSHjRZ?= =?us-ascii?Q?EdN2xqWrHi/Y1KO+DM7Wv7XZnNY5un392qyC4fAyvSxsf/g4b43grgAUNUmV?= =?us-ascii?Q?PlYpH2FX8kX3w3nueVBV8YlG/tSbq89XcBzgTyKCi17zi81BAhd9s4a+vfXY?= =?us-ascii?Q?ULSJU/iYD329mdzG3+OMocT8ferMh3CL7QLMY0sxCvRAv9VmWlEaFo470SdV?= =?us-ascii?Q?EgU99vgipzgoKXh8wQpPY63ycdPmkU6/ulkUtnwCkY5odRm9PZzpj/AoldmJ?= =?us-ascii?Q?RYxH+bcCZAAcUPW6FMOFhimDF6+jB2oMznI13VH6wgGBvm07cDF+Wd0Zljsy?= =?us-ascii?Q?ChyR0z+tFHbcdDsUBdFPsDCFMTKQbXa/PipTgZK04W/aU7HEtUPONGKESIS+?= =?us-ascii?Q?xEROSwWB7NIRjUKG+wAJ1flbc2po7+yZ9asfGMbjhWlp51cV+xTnNnfuRrbG?= =?us-ascii?Q?Rw8lt39A3ueCSNsL12gHNxqj0MFsFfDKbr37EKE1mQ/j7uL3I1n+e2+JuLAU?= =?us-ascii?Q?3ESNRdcpi+oCNK/SAz+tC9iI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 812d6156-2bfe-4cc3-4527-08d95ad4d3d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 01:27:18.1501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bNWH1CwLskQyHGe5EEfAq1Mdh+Hvm/9BSVqCGC+ZQV9pGyig3HsEIz4fd7BdfEil7CYfprERXyQ4sBoLkEXQZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Would you please tell us how many TPM2 chip you have tested? I think we need consider the compatibility of exiting TPM2 chips, to make s= ure the code still work. Thank you Yao Jiewen > -----Original Message----- > From: Gonzalez Del Cueto, Rodrigo > Sent: Saturday, July 17, 2021 5:18 AM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo ; > Wang, Jian J ; Yao, Jiewen > Subject: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command > completion. >=20 > To follow the TCG CRB protocol specification, on every CRB TPM command > completion the TPM should return to Idle state, regardless of the > CRB Idle Bypass capability reported by the TPM device. >=20 > See: TCG PC Client Device Driver Design Principles for TPM 2.0, > Version 1.0, Rev 0.27 >=20 > Signed-off-by: Rodrigo Gonzalez del Cueto > > Cc: Jian J Wang > Cc: Jiewen Yao > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) >=20 > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > index f1f8091683..34e3874a5b 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > @@ -310,7 +310,7 @@ PtpCrbTpmCommand ( > // Command completed, but buffer is not enough > // > Status =3D EFI_BUFFER_TOO_SMALL; > - goto GoReady_Exit; > + goto GoIdle_Exit; > } > *SizeOut =3D TpmOutSize; > // > @@ -328,16 +328,6 @@ PtpCrbTpmCommand ( > DEBUG ((EFI_D_VERBOSE, "\n")); > ); >=20 > -GoReady_Exit: > - // > - // Goto Ready State if command is completed successfully and TPM suppo= rt > IdleBypass > - // If not supported. flow down to GoIdle > - // > - if (GetCachedIdleByPass () =3D=3D 1) { > - MmioWrite32((UINTN)&CrbReg->CrbControlRequest, > PTP_CRB_CONTROL_AREA_REQUEST_COMMAND_READY); > - return Status; > - } > - > // > // Do not wait for state transition for TIMEOUT_C > // This function will try to wait 2 TIMEOUT_C at the beginning in next= call. > -- > 2.31.1.windows.1