Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

["Yao, Jiewen" <jiewen.yao@intel.com>]

Besides VmgExitLib - 
https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Include/Library/VmgExitLib.h

We have another potential issue - MemEncryptSevLib -
https://github.com/tianocore/edk2/blob/master/OvmfPkg/Include/Library/MemEncryptSevLib.h
We might need rename it to MemEncryptionTeeLib.

I think we need setup direction on how to hand those cases in a consistent way.

Option 1: Keep using current name: SEV and TDX as two class name. Add two instances.

Option 2: Define a new architecture neutral class name such as TEE. Add one instance to cover both SEV and TDX.

Thought?

Thank you
Yao Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Thursday, October 28, 2021 10:00 AM
> To: kraxel@redhat.com; Xu, Min M <min.m.xu@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>; devel@edk2.groups.io; Erdem
> Aktas <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>;
> Tom Lendacky <thomas.lendacky@amd.com>; Dong, Eric
> <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul1
> <rahul1.kumar@intel.com>
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
> 
> Hi Gerd
> I tend to agree with you on the direction to use one TEE specific Exception lib.
> 
> However, I have naming concern.
> The VMG is very SEV specific term. I don't believe it is a right name to cover the
> TEE exception lib.
> 
> If Brijesh agree to merge, I think we should rename it to a neutral name, such as
> TeeExitLib.
> 
> What do you think, Brijesh?
> 
> Thank you
> Yao Jiewen
> 
> 
> > -----Original Message-----
> > From: kraxel@redhat.com <kraxel@redhat.com>
> > Sent: Wednesday, October 27, 2021 3:20 PM
> > To: Xu, Min M <min.m.xu@intel.com>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>; Yao, Jiewen
> > <jiewen.yao@intel.com>; devel@edk2.groups.io; Erdem Aktas
> > <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Tom
> > Lendacky <thomas.lendacky@amd.com>; Dong, Eric <eric.dong@intel.com>;
> Ni,
> > Ray <ray.ni@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
> > Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> > Add base support for the #VE exception
> >
> >   Hi,
> >
> > > > How about adding the tdx exception handler to the existing library, so we
> > don't
> > > > have the churn of adding a new library everywhere *again*?
> >
> > > Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in
> > CpuExceptionHandlerLib, then include the corresponding source file in each
> > *CpuExceptionHandlerLib.inf?
> >
> > No, I mean extend the existing VmgExitLib instead of adding a new
> > VmTdExitLib, i.e. place the tdx handler in
> > OvmfPkg/Library/VmgExitLib/TdxExitHandler.c
> >
> > take care,
> >   Gerd
> 
> 
> 
> 
>