From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.5962.1635386886765181333 for ; Wed, 27 Oct 2021 19:08:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=V835J4xf; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="229058053" X-IronPort-AV: E=Sophos;i="5.87,188,1631602800"; d="scan'208";a="229058053" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 19:08:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,188,1631602800"; d="scan'208";a="597605836" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 27 Oct 2021 19:08:05 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 19:08:05 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 19:08:05 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 19:08:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cBic2h3qMJ2XOL8UZmPyPO/Nh/I2BU8y13ES6HHsf7tIaJ3gK15O1eiObN3tgXmAUqmxx2q/KTv2EBNKSPCMDlKW29H+NN6OFtGc59oWFq+KGcc0TguVip/RTZ2nn3c/GhqpIcXm268L5r7Jr9H6uFguvyrqC2GE0LYEB1dOpw6nHS6lXDspoc2YKR93Vb6yt4yIsQOYSgKt0YWY/+gIJ4EoORjE52jx46JwEy21Gjckz7NgI9rDASVNT8sCRUPlC16yvTVWPCbSp+DsHjAotUQqoryMXMrhF3H6ETis+f96/nTptFVEQeP3gNllvfvWdtZVEmaJWqov2tsE14HzzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=idWs7noZ8XJjDot3PMpo381cQDq6MYkSAEdPPWZhLpY=; b=WPr3Ow6wgxcOP2HuPZ/geoKq5Vsp2XqWPR2BjXP/zgXD123jiySXpIFbu0U/hzh6LLfSCf43ccY2mRomwKh8gepulmuR+FOQ586xwhdMukWvg75rPULtR8zeHGR0W4Xl/EMb/SybyE8zyNToU2vFnTc/fXGwC7wBFWrg0zNAGJ9KS/uZ1T6xnhZytwvmYR0yi9u3nr7uvHl0++Pr2E+Pbd0BUdPzbYXEGp4I5NWWB8Gvnw5H60fsIOjYSezRcP2TkmiPUltQkaN6YkdarlLoRfz6CHUBmnXEWocKoCwYzDanQE/m7N0kxPLjKlr/nZZ8qciouN4pKPdBVyV3VP3uFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=idWs7noZ8XJjDot3PMpo381cQDq6MYkSAEdPPWZhLpY=; b=V835J4xfFxSJW1RwI1aTNM25iacJWvYFeF/pXOQE2/MZWkWEoN5iYrqSxP3OJVYz0ZOIptA6k9dpnNHxBhQt34h6JDIeLM0s6nlRuFWBMIDPSITd4iShP3D/FroyeY78jdiHcAJOYZqcd1aQulQ2BhiXSQyLC0RA9X03Xg6ZO8U= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct 2021 02:07:58 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80%5]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021 02:07:58 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "kraxel@redhat.com" , "Xu, Min M" CC: Brijesh Singh , Erdem Aktas , James Bottomley , Tom Lendacky , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception Thread-Topic: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception Thread-Index: AQHXuZrE7gBtLlCCUUGhb3hSRuaAb6vPND8AgBWluZCAABOKAIAAAekggABE0wCAAB0zgIABQVaAgAE37jCAAAHi0A== Date: Thu, 28 Oct 2021 02:07:58 +0000 Message-ID: References: <24d3a351f21bff1a4b20490313d039e403b1453c.1633401643.git.min.m.xu@intel.com> <20211012102716.wr6bao42f5hviz5z@sirius.home.kraxel.org> <20211026061148.omqerrswnpgs3jin@sirius.home.kraxel.org> <20211026102458.pvzp5nxyegq7ftuu@sirius.home.kraxel.org> <20211027071935.a4l3aiiu6uaaqdvl@sirius.home.kraxel.org> <16B20F4407499229.28171@groups.io> In-Reply-To: <16B20F4407499229.28171@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 512dbe61-5d51-420b-b717-08d999b7c379 x-ms-traffictypediagnostic: PH0PR11MB4885: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KMj8A/iHq/HBqejoaKVv94zd1ARXOOgc0NM3s5Gz6pKiueIzZuimrwsOE9fcmWqvg2Pc6E2ErZOb2bHhUkX9qkHFV662CG1gI8lI3LHMQugpPXhfsu/Gphk4wqRWWs3QkbNKatHpqokRr9JAl86t3ckiNCtHEbFIXFkLOLPGtEYrzKrCwM+HB6druPNtotSKPoCVyeYghTtLsbjsBYd85snCXkOyaUmAAZIJr3TTJD4AKIdSw3v1bxKtBXu5CgmpxvHZhIm1chHb2J6mKakcG8ZmDcazD3zmqR4x2W2UmGM7w1FAjqEnBZdosD4+Sv26x7cnfspPxV9xbpwmXrEWTT/aHrjviSEmPLS4GvKvUeAf58VPZn4kxpb0W7prlhLarKXFZ929L3ruuKDWWYE9gJJT2R/+dB6sq8ZkHKzOthKHwtqXDo8b0enplNaD3QLzlx+XyA+bTuYv+Ht93IfqeY5f0iwL4tezCnmd8W1SfF17kyQ6wZ0gifgtQ3Uy0oEmi3YnVHICKqpQj/vEzu+zwGFuJzs5bbW9cP3XnL2tnseB5pMWqhHFEso0R9GrIcTHt0iwsxKQ7e9DDgCgoQBGzM5ZLwiGev87VfVR904iPsmu5bdYuD6IDWHhk/n6Z9y5yJMUWIwZIRiM14sMNUf5tYS04ObHoR1tRPXK/RjxreXM/lMgIOMLWaV69GCfyvy+ZP55FY07NY6Z7ZZ3vR94Secec8PgV8Erf7YB26dK0DuP0YIyLDx41rShJMG7mWMXLztCPFSg/L3SSLkPaJaFcdfIUbpEz94cp7xjf7TSAJz+6Z2BmDzEVBaSzxzD+sn05hm102rZipBI5ha/qemeEw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(33656002)(8676002)(55016002)(66446008)(2906002)(83380400001)(52536014)(66476007)(4326008)(186003)(38100700002)(508600001)(7696005)(122000001)(66556008)(316002)(107886003)(5660300002)(54906003)(966005)(110136005)(64756008)(9686003)(66946007)(86362001)(82960400001)(6506007)(53546011)(8936002)(38070700005)(6636002)(76116006)(71200400001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wq1qwRCthc/L0b7AQ5Twr2vc3imgqZ95x9Z7Xw+Z+HKVGXthyv1bpfbtGTlx?= =?us-ascii?Q?qq0LgqczduZogdEab8c7JWs7f1aJRYiKaa02tajZudZhpraG1T4BB31z/LuY?= =?us-ascii?Q?Hez294f5pzVxAFsIKfd35WfohCNkTxpMYBtNDOoWM4TyNLGcyQHqm1B6dktz?= =?us-ascii?Q?qZU+pzpJiGFZswm+VrNfSdUz1JsrR0tiJZ4IUgv1ZFw8/1mLG/KQUUIy8Yes?= =?us-ascii?Q?rbS8FDzM6srTaJtGZ0JEyq7erIIiGDjU5G0elX8qv8oNh00wH9+InEcI/6OP?= =?us-ascii?Q?1Rc1ZNx8nK4uManiNKyPFF754xZjvFux6hj6TWMCKZvmhHQ9+WvjZTxQGco2?= =?us-ascii?Q?ur6FrbnQSLZltVs4M+bTRWhFGdF5+E0Tz8HUfe9XD+y/nGNn5jn/2rCAMtoE?= =?us-ascii?Q?PZnOch0k63s7cZ6JVRv63GcMRtlqUDzDAyJScyj61MFwV7CI3OLQyquQ/eMD?= =?us-ascii?Q?OcdAHm5LcM93zWXxuQJIia3CqTMai8mo9cXbldCju3kiukLj6fWC4REL9LcW?= =?us-ascii?Q?BrC3dOOPMRaaNsO7IHBnfsv84Japg6BwGqfecIt+sWEGT6na8zcetrWYmRFe?= =?us-ascii?Q?xrYOYcxpowXyT3a619QEyna3Ygmfmo3U+o7t2AlAZDFCB8uIoTFOLLtTACvC?= =?us-ascii?Q?2vPiHAxbXk4/9gs6kQ/mDDryyFFIie1eWAjfQaMd4RvtVG4VnyHVj7++aKtt?= =?us-ascii?Q?ueAd3253qvvaKBFkOYmCyzYfGYMnQH7Uu+An2mGAE6C2HN1W+jg1XNhAWGm4?= =?us-ascii?Q?Zu3J9rnOe78ifKO9tLUA0uBk1kpDkRFrPuIyud9XsfGaFfvXFeE+7heL9fhD?= =?us-ascii?Q?lTMIymw/AwMNbSISzIoYsQlJuoZYIwt251AHzkClFts02gl093cJk5OW+wWX?= =?us-ascii?Q?8ZHeFNtQQuDgO+qHy2SNclMcIByDtvUI1/V6THo2KJNsuS8YPxPbzeja+zOz?= =?us-ascii?Q?jiXgt9KtKpWjQvaSrJgJ68TMhVXeT/Y2d5HfaAaf4pntT4FcD7pU4Detr/Rn?= =?us-ascii?Q?o+5lkV2Py6EgZLqrvn2oIp2baOb4sptvv36bIZBKMdWgRNdjEmRybOXxcnW8?= =?us-ascii?Q?Ux1ca1GaMJfa0QSq0xE9DqmOWVxaGi1csa15120t95mJ5djoftDoOpFPJkHt?= =?us-ascii?Q?5Qj8Z5PaSh1CIuNgg9bBrtytL5PLRTNdYG1kwM29I/28tMNJVR2ieZT/8tx9?= =?us-ascii?Q?ycMQOVYax76JCbv/k8R5flJRP2L8wqI8G6DeZzSe7K23SG8DfYTuWjdN2AU3?= =?us-ascii?Q?qB2VUmGQYrw0BRaNQpDn8lrI/eaAroVaaaOU5HV3mmBlEDDuhOT9+B87nOz7?= =?us-ascii?Q?DOXLa/hmW0T9X32WZc2TdAwcB2rGvdfo/EC9uAcDFiGBryUk2JkM/eGjc7x+?= =?us-ascii?Q?H/mANTc8HxVow3iKs8PH3BnWM7m6tosj64sjad52L89P6sG58O3wEPq/uUHW?= =?us-ascii?Q?vnIebI1DW/vOX4t0RlcJL+ehcqzlHYUijA03ayG4Jza2pQQTaSDgAWcoAv0X?= =?us-ascii?Q?/adIiahK+Mfer4QQDtrsj7PxzegYFcOvnuaI5kg1dm2BoRz7A/0PYryKm6Rg?= =?us-ascii?Q?yxoyOM7WVCJjIX8/BQfdxnIKsFgmNCE6F/YzeMIgEMmzA5eHhjSAJESXAgXJ?= =?us-ascii?Q?NvTFg0958KfaHJvhxPGevFI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 512dbe61-5d51-420b-b717-08d999b7c379 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 02:07:58.6428 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E55gKBvxn4IQjCqUL0UkO96l569j58KFxlDzeNe9axJYLpv4aCFkKqkxwOD3EtBRopelXoADjodZlkAn1ZU7XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4885 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Besides VmgExitLib -=20 https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Include/Library/Vm= gExitLib.h We have another potential issue - MemEncryptSevLib - https://github.com/tianocore/edk2/blob/master/OvmfPkg/Include/Library/MemEn= cryptSevLib.h We might need rename it to MemEncryptionTeeLib. I think we need setup direction on how to hand those cases in a consistent = way. Option 1: Keep using current name: SEV and TDX as two class name. Add two i= nstances. Option 2: Define a new architecture neutral class name such as TEE. Add one= instance to cover both SEV and TDX. Thought? Thank you Yao Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Thursday, October 28, 2021 10:00 AM > To: kraxel@redhat.com; Xu, Min M > Cc: Brijesh Singh ; devel@edk2.groups.io; Erdem > Aktas ; James Bottomley ; > Tom Lendacky ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul1 > > Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler= : > Add base support for the #VE exception >=20 > Hi Gerd > I tend to agree with you on the direction to use one TEE specific Excepti= on lib. >=20 > However, I have naming concern. > The VMG is very SEV specific term. I don't believe it is a right name to = cover the > TEE exception lib. >=20 > If Brijesh agree to merge, I think we should rename it to a neutral name,= such as > TeeExitLib. >=20 > What do you think, Brijesh? >=20 > Thank you > Yao Jiewen >=20 >=20 > > -----Original Message----- > > From: kraxel@redhat.com > > Sent: Wednesday, October 27, 2021 3:20 PM > > To: Xu, Min M > > Cc: Brijesh Singh ; Yao, Jiewen > > ; devel@edk2.groups.io; Erdem Aktas > > ; James Bottomley ; Tom > > Lendacky ; Dong, Eric ; > Ni, > > Ray ; Kumar, Rahul1 > > Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandl= er: > > Add base support for the #VE exception > > > > Hi, > > > > > > How about adding the tdx exception handler to the existing library,= so we > > don't > > > > have the churn of adding a new library everywhere *again*? > > > > > Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in > > CpuExceptionHandlerLib, then include the corresponding source file in e= ach > > *CpuExceptionHandlerLib.inf? > > > > No, I mean extend the existing VmgExitLib instead of adding a new > > VmTdExitLib, i.e. place the tdx handler in > > OvmfPkg/Library/VmgExitLib/TdxExitHandler.c > > > > take care, > > Gerd >=20 >=20 >=20 >=20 >=20