Re: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

["Yao, Jiewen" <jiewen.yao@intel.com>]

Acked-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Christopher
> Zurcher
> Sent: Wednesday, July 21, 2021 6:07 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb@kernel.org>; Feng, Bob C <bob.c.feng@intel.com>;
> Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section
> from the GCC discard list
> 
> From: Christopher Zurcher <christopher.zurcher@microsoft.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507
> 
> The COMMON section is used by OpenSSL assembly-optimized crypto
> functions. OpenSSL assembly code is auto-generated from the submodule
> and cannot be modified to remove dependence on the COMMON section.
> The default -fno-common compiler flag should still prevent variable from
> being emitted into the COMMON section.
> 
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Christopher Zurcher <christopher.zurcher@microsoft.com>
> ---
>  BaseTools/Scripts/GccBase.lds | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/BaseTools/Scripts/GccBase.lds b/BaseTools/Scripts/GccBase.lds
> index a9dd2138d4..83cebd29d5 100644
> --- a/BaseTools/Scripts/GccBase.lds
> +++ b/BaseTools/Scripts/GccBase.lds
> @@ -74,6 +74,5 @@ SECTIONS {
>      *(.dynamic)
>      *(.hash .gnu.hash)
>      *(.comment)
> -    *(COMMON)
>    }
>  }
> --
> 2.32.0.windows.1
> 
> 
> 
> 
>