Re: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for Smm/Runtime drivers

["Yao, Jiewen" <jiewen.yao@intel.com>]

Ah. Yes. I think so.

Hi Jian
Can you help on that?

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Thursday, June 24, 2021 9:30 AM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Xue,
> Shengfeng <xueshengfeng@byosoft.com.cn>; Wang, Jian J
> <jian.j.wang@intel.com>
> Cc: Xue, ShengfengX <shengfengx.xue@intel.com>
> Subject: 回复: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled
> CryptSha512 for Smm/Runtime drivers
> 
> So far, there is no objection for this patch. How about merge it?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen
> > 发送时间: 2021年6月9日 11:08
> > 收件人: Xue, Shengfeng <xueshengfeng@byosoft.com.cn>;
> > devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>
> > 抄送: Xue, ShengfengX <shengfengx.xue@intel.com>
> > 主题: Re: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled
> > CryptSha512 for Smm/Runtime drivers
> >
> > Thank you! Shengfeng
> >
> > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> >
> > I recommend to wait for *1 week*, to see if anyone has concern on size
> > change.
> >
> > Thank you
> > Yao Jiewen
> >
> >
> > > -----Original Message-----
> > > From: xueshengfeng <xueshengfeng@byosoft.com.cn>
> > > Sent: Tuesday, June 8, 2021 12:31 PM
> > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> > Jian J
> > > <jian.j.wang@intel.com>
> > > Cc: Xue, ShengfengX <shengfengx.xue@intel.com>
> > > Subject: [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for
> > > Smm/Runtime drivers
> > >
> > > Intel Platform utility Syscfg/sysfwupdt will trigger SMI
> > > to enter BIOS interface. then BIOS invoke EncodePassword
> > > in SMM mode to check password.
> > > it's need sha384(in CryptSha512.c) in SMM mode.
> > >
> > > the origin SmmCryptLib.lib size is 1389KB,
> > > after changed, the size is 1391KB.
> > >
> > > the origin RuntimeCryptLib.lib size is 911KB,
> > > after changed,the size is 913KB.
> > >
> > > in SmmCryptLib.inf and RuntimeCryptLib.inf,
> > > change CryptSha512NULL.c to CryptSha512.c.
> > >
> > > https://bugzilla.tianocore.org/show_bug.cgi?id=3423
> > >
> > > Signed-off-by: xueshengfeng <xueshengfeng@byosoft.com.cn>
> > > ---
> > >  CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 6 +++---
> > >  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf     | 4 ++--
> > >  2 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> > > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> > > index 3d3a6fb94a..fdbb6edfd2 100644
> > > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> > > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> > > @@ -11,8 +11,8 @@
> > >  #  functions, PKCS#7 SignedData sign functions, Diffie-Hellman
> functions,
> > and
> > >  #  authenticode signature verification functions are not supported in
> this
> > > instance.
> > >  #
> > > -#  Copyright (c) 2009 - 2020, Intel Corporation. All rights
> reserved.<BR>
> > > -#  Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All
> > rights
> > > reserved.<BR>
> > > +#  Copyright (c) 2009 - 2021, Intel Corporation. All rights
> reserved.<BR>
> > > +#  Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All
> > rights
> > > reserved.<BR>
> > >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > >  #
> > >  ##
> > > @@ -39,7 +39,7 @@
> > >    Hash/CryptSha1.c
> > >    Hash/CryptSha256.c
> > >    Hash/CryptSm3.c
> > > -  Hash/CryptSha512Null.c
> > > +  Hash/CryptSha512.c
> > >    Hmac/CryptHmacSha256.c
> > >    Kdf/CryptHkdf.c
> > >    Cipher/CryptAes.c
> > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > index 07c376ce04..e6470d7a21 100644
> > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > @@ -10,7 +10,7 @@
> > >  #  RSA external functions, PKCS#7 SignedData sign functions,
> > Diffie-Hellman
> > > functions, and
> > >  #  authenticode signature verification functions are not supported in
> this
> > > instance.
> > >  #
> > > -#  Copyright (c) 2010 - 2020, Intel Corporation. All rights
> reserved.<BR>
> > > +#  Copyright (c) 2010 - 2021, Intel Corporation. All rights
> reserved.<BR>
> > >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > >  #
> > >  ##
> > > @@ -37,7 +37,7 @@
> > >    Hash/CryptSha1.c
> > >    Hash/CryptSha256.c
> > >    Hash/CryptSm3.c
> > > -  Hash/CryptSha512Null.c
> > > +  Hash/CryptSha512.c
> > >    Hmac/CryptHmacSha256.c
> > >    Kdf/CryptHkdfNull.c
> > >    Cipher/CryptAes.c
> > > --
> > > 2.31.1.windows.1
> > >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
>