From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.7098.1635847562044181062 for ; Tue, 02 Nov 2021 03:06:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=czWk58MF; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="254834259" X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="254834259" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 03:06:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="531487485" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 02 Nov 2021 03:06:00 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 03:06:00 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 03:05:59 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 03:05:59 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 03:05:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HegfT3wwiIWcl4fK5DKFU5lViTwtaWy6a5dxC9Kq4yRhW9MGfGtjCxl6htZhVQNwK6NtUokUqFUoJlHZDnr4ZYR4mepN3NVpaULbpvReuza32u5i35WvII3/H+R73GmlZq4ErFQIfKqPyfxmtYet8GMw40E1NRj/hGs3eSLkT7Z0bqw7ZCnlvE0dkjfZAtOraZ09wSWHqwgI9krohxts/baLqKsapz/8KcLjQiC1fDmVPZsEApJLikUCj/iRp1RW0VucjGdTPxc3bnCyJVm4azSIetw/IatpvbHKqbuQEC4OXeKziKr40UxwWB2izoJ0D9r8MaJsPGOfhpGTzBwmMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j4yEzTGGBsaLb/nLnjlL7jbENq8tGRP9e/VLyhM0LKA=; b=l1A5+hS7u+s7GQQse7H1WiTNy0YAd8AHpwc/bI5Ga9HfgzQQVPXniLb12QCtV+p+fzcBpWRlhcJ9YCC4+3/6YhtY1D2ZVqBZryWUERraOY7WdwJ0KMArKP+RRbqM5vhuEKsmA5Jjp2bOS0YgGgfghGnU8pmki/L/LVl9CamwoP5JE7OetUhMidwIA06mBCi3PPgLiP1DvaalYEEoIxirirYU5ypWfX2k/NXvNLctd4TDKDMbMKNXvuezHtu5KSbhImQLQe5n4jot1Nx2SdjA37W5yVCugIHJ/WJRrnNmwLL2sHBAUIsqtf/AU9BSPp6oAP3OCQqRG2l2x1RsoU7FJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4yEzTGGBsaLb/nLnjlL7jbENq8tGRP9e/VLyhM0LKA=; b=czWk58MFjRhfah7V9sB+xHNRXPiuNI1VvuJH05E0ZqW8XQVaVVJVcNi3wqH6zWgkUWOI+R5gBmbSuLt3rk+hlxYNuVC/73Dwuaz9mY9wuuJgSjYhNqV0a6NATNj5dbWhfcX390pYQdYe0NsFyvIAN3mutPILfutdTHG93bfBxWk= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4918.namprd11.prod.outlook.com (2603:10b6:510:31::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Tue, 2 Nov 2021 10:05:56 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80%5]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 10:05:56 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: "Xu, Min M" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , Erdem Aktas , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe Thread-Topic: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe Thread-Index: AQHXzv0GsAENSBHujU2SN72SZkXR2Kvv/AAQgAAGfYCAAACaoA== Date: Tue, 2 Nov 2021 10:05:56 +0000 Message-ID: References: <20211102095849.xwhyj3xoz6uftypn@sirius.home.kraxel.org> In-Reply-To: <20211102095849.xwhyj3xoz6uftypn@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 00eafd80-6dd4-4c57-2c6e-08d99de85cce x-ms-traffictypediagnostic: PH0PR11MB4918: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UPYQsZNqZ1CQOt8XrC3joAFyrNwx+xlLDvCdF3QfDdVXm9MEhpekKgJvJu3b4BFRk55+LMihh9nILs/44cyObORe2QOZRE+XpdCbOQjVHnaJlQOy+HaiVyszxzEfDK05cjHxvq/JqcNmXDXdfQvCGEc4rSQGkQJnmXtCy2jEgwecWyHsq8z1rziz2AXeCaJiGPy1873g0+9Fu7jbPtRVpjklg7x9Q0mJJM9SnE0M1KsN9lsXBk2/TzWey2nKoBMV/sZ9Gq9GtKV9r9xMizXCNwQrxENDGFyN06Lvvd+57xHSw2GJ3hP6PQybJQfgwW1DMdyOG5evC6u0/UXl37TqjBKe8/aejDBbiisj3UDwymq0XYEyX9MLHl4xWjGXShtNP3MhsK5Nda09vMl4F/WCE4mVuIvr7kSVfbhfj61eOftcKEZn12K1VATdmG52lb2/SKlcd5kct92F1fxzcL5NMNDxwPoLVdGW+oNIKQjA87PX9haIleDtAWfBzif+H8+Pj9mnSUtAReGaDfU+gcJn1nLBcSxg3zPaqVYiUiHRf6bKqwWNUV4J3FACKDO8DxybgOZRoCJ5ukmnswfAIjfig6dipE+FX3nglgZhmOmuVcPuuuSFXgJeiXPFYa3cigpdmcTNMZljdlejw9ss0EN1kswDhSgqykqKDT4Xoz6juPTAB6DtPeoujQl9Xk9NzUBwJ7qaU1KCG8FkDl9vGmZC0A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(8676002)(316002)(186003)(7696005)(5660300002)(8936002)(508600001)(55016002)(9686003)(83380400001)(4326008)(2906002)(82960400001)(71200400001)(66446008)(53546011)(122000001)(66556008)(52536014)(76116006)(64756008)(54906003)(110136005)(66476007)(6506007)(38100700002)(86362001)(66946007)(33656002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lVKB3AnEuxZQ8FNezZFEaAjLEbtPfuq2FMOmR6xgQJTgbloYelmHiRa6fpH5?= =?us-ascii?Q?vfnudq1V7iEiWJNJAqgIMj+5cX93Jg9W/2asnZaU42atPQied6i78aT97LKD?= =?us-ascii?Q?f/Y1VlyOWjd3Nnb1vgsMzR6gXsiAfQ7rhId7ZnVheQGITcCuzUHgYazkQ+jJ?= =?us-ascii?Q?8aW+sA83nk95O67xKOwdoSHESnqZDtyZWgg0VJSTJS0jQUPZ2hgaW/4ZUkwT?= =?us-ascii?Q?R6Bsi1A9BYXxyyZo7ejXsWjI0ZRAOh3ieuBlOF787ieEsYjiJgj5Xj1rYtSA?= =?us-ascii?Q?1UJv97fpM+L2IY3QSDSLUlm9y6vv5Ct7eQ51qktlpmlfYkcm8ZrONg0ED+0f?= =?us-ascii?Q?rWWb1NaP3xGcV5ke7Jiw0iDWDtFtht7bqt16FR3aR40ASUpJp5MCG0qOn1Sk?= =?us-ascii?Q?odMjYaq+0ZHpCHVwxRpT1FFAI2q3u/8xT9aAXECDpFhEQjFg0E2nV95xBfJw?= =?us-ascii?Q?pRWZGwgV+W+OhmEn9VeBh0AssIxaEdUWY0n1t/Sp+C24q7uIVGOzkbPAob3T?= =?us-ascii?Q?m4qBXS2iKThuTABN+X8mgnXhVMJMfN0XhwgpfN4UU+FT+xrXuNCHz6eEELbN?= =?us-ascii?Q?9ZJCCv6CeHlRYggv8u1a7MMSoNN4ELrR7uo33s3T+xa9wOMkGotWtITUDpm3?= =?us-ascii?Q?4qhygYM0SGieydAULYmiRuZqvzJTrn8uTeUM3UvG3KXmKbQclAVRUbB6Hxbj?= =?us-ascii?Q?yrv7hKuyo53aTgLflF3tTgA4MgJ6cajfUjjFGf8RglbkUlDFJyH1IpUBOOU7?= =?us-ascii?Q?cpGUYp/9JWm5R8PoAwXYsjb94KSeBFGa71s69u46cf54zUWSF8luW/CBGjQX?= =?us-ascii?Q?L/aIJrcJngXYPXiu0PWzY/TuxluGs94IORbBXUpBgoDwJRLGfvLTd1D9vBLG?= =?us-ascii?Q?Gh+b5vOS3sgNfcZlizuYTDoSBDb2E37dp6yRzk8umRkjmiZmeX1LngUNLWgJ?= =?us-ascii?Q?L75P3rUaCFGDyC5fx401fy/xJdEyxQLRipAG6tomb3B8R3zjMeOrLskotHDX?= =?us-ascii?Q?7vFqImLINu6gtuC2vB8vxzGgB4fVWySaNiYHw38b3jrdOmg8FmdUZOzlR9VY?= =?us-ascii?Q?obDV3BgZRTEySrZQPNFq5dPLd+s+phfYHiBZyRed5ll4G/mhbilg71lkZIDC?= =?us-ascii?Q?6Q1RQovENCJDc8Ct1Ljx5Ddk/mtIJL4gniPCib1jxCyYyp3843EDEd8F4Yrj?= =?us-ascii?Q?bg0bUlYnL60SoB3x8RZ/XO4HhzZn1JSI1Wl/11HQ8NM1neRhhRY4GEs3kzW1?= =?us-ascii?Q?EYCbPN7ZMVYT3Bl7xscFCKlqRMMbunzv2QIP+nyn99nsuv6JcN3Ungr1opPP?= =?us-ascii?Q?WQn/JWH5LYXLw1M0G+2cROh7/2pd8/ApvKkxjgfi+oUzrBM9/gfcTOAvPcEo?= =?us-ascii?Q?dEt5UoVdhx+oZ9QWee1qwr5r54WkBx2jvZgp78JqnkZgbL+KCKLVN3xkd8cJ?= =?us-ascii?Q?kr5DNQTXVpWxiKA5yvxPa39jAcKIwLwlV3iN9AOxT45Dc0leJKAMd5L+O6bJ?= =?us-ascii?Q?N/zrFOlcBmQYcJ4Zd9YLXla0ToC4moEmwPp0bMrZz5BATrK+3plTqR9wRNv8?= =?us-ascii?Q?VHtzMRdbogpZbyEaPXdK9W0uePSixrPgUBahZdccTU1nOv55xWV73Gh+sNHE?= =?us-ascii?Q?OlNPJKinVjYf1Vcqxtjb1vE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00eafd80-6dd4-4c57-2c6e-08d99de85cce X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 10:05:56.3131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ED9EJPBfjWS9MfGlD2H26uwOdtSGxsUSOtwqGT6UGywffsQj9HCEUsRtxkdVk6SSGKCj9BtuXwPjzMhL4sCN2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4918 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable We can state, this driver is to support fixed frequency. If a real platform happens to have fixed frequency, then it can be used. gEfiMdePkgTokenSpaceGuid.PcdFSBClock is defined in MdePkg. The consumer need set PcdFSBClock.=20 I don't see a need to bind to OVMF. Thank you Yao Jiewen > -----Original Message----- > From: Gerd Hoffmann > Sent: Tuesday, November 2, 2021 5:59 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Xu, Min M ; Ard Biesheuvel > ; Justen, Jordan L = ; > Brijesh Singh ; Erdem Aktas > ; James Bottomley ; Tom > Lendacky > Subject: Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to > LocalApicTimerDxe >=20 > Hi, >=20 > > Do you think it should so generic that it can remove OvmfPkg dependency= and > be moved to UefiCpuPkg? >=20 > It's not fully standalone, the driver needs to know the lapic frequency > (that is the reason why PcdFSBClock exists). >=20 > For KVM this is easy, the lapic uses a fixed frequency so it can simply > be set in the .dsc file. >=20 > For Xen the lapic frequency is the same as the tsc frequency, so the xen > code (platform init I think) goes figure the tsc freq and sets > PcdFSBClock accordingly. >=20 > So, when you want use the driver elsewhere you need to fill that gap, > and there is little reason to go that extra mile because on physical > hardware you have other options like using the hpet timer. >=20 > [ qemu supports hpet emulation but it is disabled by default for > performance reasons, other timers have less virtualization > overhead. ] >=20 > I'd suggest to keep it in OvmfPkg. >=20 > take care, > Gerd