From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.3265.1633655626990709225 for ; Thu, 07 Oct 2021 18:13:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=pPtipD4r; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="226360855" X-IronPort-AV: E=Sophos;i="5.85,356,1624345200"; d="scan'208,217";a="226360855" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 18:13:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,356,1624345200"; d="scan'208,217";a="484845725" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 07 Oct 2021 18:13:45 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 18:13:45 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 18:13:44 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 7 Oct 2021 18:13:44 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 7 Oct 2021 18:13:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oDm4a4kbyiinvksMbnrZtsK4jt3esm0hXF7Zzzm3KpJ6iqWhoj24yUY6R+ijPEydn9Wp/d9ze7ZJrs4ZAWAUiPjt3+hZYx9ZmkFQQ8uNqmvUd4AQXKthhhWIodjpN+QRTMe8BJvrM/kEgG5qWJq/ZWqQB5yCEv1/2mepGYE1ciZj/ig+sVMr9GQ1TEo45Fk43VbvL3AnEl/b0mQolX8k1u2P3TsYCXAIlytZnDua/OxXh3PK4I7yfBZOxAyKn5HUrfL9QmPeRp9dwk5qgMvEriQYNAWkjEuUAapcJ2O1fS3leMlArikLMDstDtHtRczRwwxAeYZNJ1Ltcf0MiqnmgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nsqoCoQQct7p7i1fQDTef93+0H8rH4MZbMLmbi747IY=; b=W5f+0mu948HC9jHBQUWfBcmX3F9ljBSWWQNpcIwWTRgJNzTLOalnNICyMWuD4TIfa6Jgk3cSMzJ6bEvVqHYy8fNeKcobv1Ik2aEtEMZDhT/lquiBIY8hSnmKNAmZCfPBEuv/gUv6g8rR18pk18LVeXh7tcQN45q7sO3EuHgogfv+NGJU8jTDGAolwXhHtHuer4EqPJsXSb/mwPPw7FpeSy34dBp+UAr26S7GwXtH/KLZTXjE0PNhuGU14MkZg2yWS1JQaYmwKUWnJSOLf2pK+V3f0VRP/7UqGvoBM+TZWLQ3ui2vEzkNTZUVjY2l3lNtHExUPgfu1vEhaq9Ps2FrXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nsqoCoQQct7p7i1fQDTef93+0H8rH4MZbMLmbi747IY=; b=pPtipD4r2xAZr3oSg2TMtdGjszKFPSrd5v0qH15v58AGW+um3/9vHLh1yVmi3NCeuFoVFamgx3k8QklGOLh0Il07EllkjD8hicDedty61zg+Fz/jIrcbBWgi2mbwzilNGaMgr/xRn2yjalNZAaqYKQLVjNsCiej4eSQTWIZ2j9Y= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4853.namprd11.prod.outlook.com (2603:10b6:510:40::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct 2021 01:13:39 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80%5]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 01:13:39 +0000 From: "Yao, Jiewen" To: "Singh, Brijesh" , "Xu, Min M" , "devel@edk2.groups.io" , "kraxel@redhat.com" CC: Ard Biesheuvel , "Justen, Jordan L" , Erdem Aktas , "James Bottomley" , "Lendacky, Thomas" Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Topic: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Index: AQHXtBDHYb2olh8+zkiqemHpeOfBcKu3kLSAgAEMVRCAAEMIAIAALc3QgACFLgCAAJwHgIACrR6AgAt98xA= Date: Fri, 8 Oct 2021 01:13:39 +0000 Message-ID: References: <729034c8d47013be1e87a68ba1b6c3a7b79a4b2a.1632707635.git.min.m.xu@intel.com> <20210927084235.pj7x2agzzzjqz7be@sirius.home.kraxel.org> <20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=True; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-09-28T15:23:29.4460000Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0c154bb-e1ba-4ea8-2fe6-08d989f8dcd2 x-ms-traffictypediagnostic: PH0PR11MB4853: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MOFvyshHKE/DjmkIH2M6gqnxiZYql8hqibtNBPMP866o7C4fNmbZWOrZXv47Y6xaDQAFK5/6T8dK9dkRcNGnBGVAfsAIYoHrDdV+kOQ/T1HQDJJ2wLmmuSom5w74nGNuwvSwW5F5x7uCQ7MhOcUM4mtWV0/YDdmgSOphLiyK1kgWF71loPyH/pruUqo6RaKSHlJuLUzRApRAMwlPZ8l6+tuJGGNN2Chm58DSbOD4wQifEzGSa9pfZn0Hu/se6xOurMpBwhu6Da5xZKzqEY63llnGkzXIIbIASvV8vHM8nlFlkj35lS0HTEtpS534IlISPk7WwUl6cvwDd+eUGY26w8iD+pSFm+5oIjKNRfgo/ZCCNOOzTDu7P6oy6J/a7cbGgLEplWwlUvl4aZevVOxy09sJdeLHBcSRPJbWZHue6yYBiHleHH5risSkylHLL9cHMWkqlq1hUpskbMsFs0cnVr9advSKjZFwGOjSmJ5a3LLEaHc34JtvcR3j9IHGFLjqpqKupX+UvghS5GdkflmCG75kXboSEun4vgK65HpRbJKsjU+8KR18OuisY3VIdxuflDuojWP/c8oFFg6s5buoKvBmvvjQDkJdXAd9bb5rh7t+QRoV4aDIkvhso7XONRq6zcBFodzer6yt+f1Cp18cg2QdKW50tsfABK4pcz1L2k3TDnvkbKfacRo3biSiPqRpr0Riv7hVjBFmXaAbOTYPt1w+Mrr9+pSngGLJ9Mc2mVlvN/cTVfsNBBTUrEKPMS03igP3AhkZ96Q4am0eJ7oer24rZKJ+61GGF7HaAzow5LnVaQjtapv9O+1BN4goCC6JejSgQuT7IaVFHy7h0wJxEQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(8676002)(26005)(110136005)(54906003)(53546011)(33656002)(6506007)(38070700005)(186003)(7696005)(38100700002)(2906002)(122000001)(166002)(66556008)(66476007)(9686003)(64756008)(55016002)(508600001)(66446008)(45080400002)(71200400001)(76236003)(83380400001)(76116006)(66946007)(52536014)(5660300002)(86362001)(8936002)(4326008)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ylnIF5haFYNFrtnh2OSHW3VmP8ULtjv9501B5BuxZP3MECbaiQLF4B1RVGni?= =?us-ascii?Q?fV+CXpqVv3xzic95kIZif5pLn+XEWpSQsAWIfcnubBWFrUyoOdmRY34TPWrE?= =?us-ascii?Q?3PnvGTMXxFBycsHeNWAiEuwOaurm8GtvtJoxBH6PKHamDR+Es0q77TTLchvd?= =?us-ascii?Q?PrV5VsWxt1oONkSf/E14YKITKFan0v/A4mVPidKKxHMI8QfFNk9OBVw6YI4V?= =?us-ascii?Q?dp6rsopBc61hWw68cPfwUZijacdi9xPA9il7P93WBf/0ZgBv7uin0sRIZczi?= =?us-ascii?Q?ibZ0VnOD1floJLLW8/rLaUc1R4AEYA0uci5vkavw1/8nO8R9o4tsYFy6Zbte?= =?us-ascii?Q?dxdXnDxVvajkzA/kwYASpkMwiMbdMLpHP1M8BENeFYzFtbsUw4sFHIjcjGLA?= =?us-ascii?Q?wqwhjHPYC8Svem0qvpHelTUTTmV6UxB9ONbI6jgtET4UehIKOJnInDybKizT?= =?us-ascii?Q?B78pSmmnpH+0pAIH+S2CwynyNaJnUGONKC1RTy3MV9CYizMBUIgDZSLlf4Xq?= =?us-ascii?Q?tJT2IfT+DvplYjyIqlxN1PB1iq9Y/ns7vUZa1Ch8GIlI6QMhhqCgHonhO1OE?= =?us-ascii?Q?RZL3u87w/Ob2WGe+EjryzAOf1ORSFqvmwwedydYj7OgqVYRNtdEEMD6wDttQ?= =?us-ascii?Q?GRiLIp/1PEK2+jf1RpVwct+dAZvCLb6PRAJkjuBCQjcxbe3+OYKZX0O+tTMg?= =?us-ascii?Q?TdFyw1ofTkbxQWkGSYgtYO8AeKdkr0SkOPtSWe/FOxZi/70ne+j3EPNjQQ0W?= =?us-ascii?Q?OuZ4YoYvZx0TyedPlhPNX+0/t3FysTiUdrfC7k/FYrTFPJgBJRBB6bmDifw9?= =?us-ascii?Q?6MFrWw6HnOInJZFaIKzoyP7lvmy5CpXizp09m1EbTwnBTlwGATnxG2JKNWHY?= =?us-ascii?Q?W6dR8rp7ANJl4egcEWIfhUQBjkIJ2xHO4unQ3tSMlouOhcq9+W0GJk/b5Tl9?= =?us-ascii?Q?D7jGT5BUCqZfoZz9lteYXrG5W5o/pF/OCu/R9CkNCCQW0jJGAIkZ+E67UEj+?= =?us-ascii?Q?Uv1p+PZyKwIz6cA/8KxPZUEVBWJtbZjPAtuh2peAI59J9YYgo/Ia+dXoSbrI?= =?us-ascii?Q?oovvfEHlaICFyTIS8YqywhY/EjQvFmK6TYP3AwDwoxf9PFqlPt1CELjEtgle?= =?us-ascii?Q?pXn7kuWgEms+GeUSDfXzqQF9pnEdszX1ox0tJ9EyXXfNuur6Jqp3NALzkhPP?= =?us-ascii?Q?BiC+bxMql+eqs7TDlzgRTdDy/qU1kdqpL6slqC4zXBwrskUMyTLro1J0i2QY?= =?us-ascii?Q?aS/O35kD13gFChqD9kFOdx/nF1fXNwn+QXZeRR2GkkpEJBrYpQUYDtYE0kde?= =?us-ascii?Q?MsI3Rar6mwTo7kPhN6G26YJJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0c154bb-e1ba-4ea8-2fe6-08d989f8dcd2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2021 01:13:39.7928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MFh+UQpBpT3NO6tkwNroD34b5tdAswecUbxBO8GgyPvA3NuXQkzgBj3tk8H2xHURNwOexGiLlOJpZQwm59CPfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4853 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR11MB4885A815A1FE9D46A21268F68CB29PH0PR11MB4885namp_" --_000_PH0PR11MB4885A815A1FE9D46A21268F68CB29PH0PR11MB4885namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I propose to submit independent patch with independent metadata (2 tables) = - don't complicate thing. We can revisit to see if there is need to merge to 1 table or how to merge,= as a separate/standalone patch. Thank you Yao Jiewen From: Singh, Brijesh Sent: Friday, October 1, 2021 1:40 AM To: Xu, Min M ; devel@edk2.groups.io; kraxel@redhat.com= ; Yao, Jiewen Cc: Ard Biesheuvel ; Justen, Jordan L ; Erdem Aktas ; James Bottomley ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] Yes, I will try to make it work for the unified Metadata. Let's do it indep= ent of SNP and TDX series. You can pick the generic patch from my series an= d add the additional fields we need for the TDX and submit it. Get Outlook for Android ________________________________ From: Xu, Min M > Sent: Thursday, September 30, 2021 12:31:56 AM To: devel@edk2.groups.io >; Singh, Brijesh >; kraxel@redhat.com >; Yao, Jiewen > Cc: Ard Biesheuvel >; Justen, Jordan L >; Erdem Aktas >; James Bottomley >; Lendac= ky, Thomas > Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] Hi, Brijesh In the current discussion there are 2 options for the metadata, a unified M= etadata and 2 separate Metadata (SEV and TDX metadata). My understanding to your last mail is that you're going to use the unified = Metadata option, right? As to the offset of metadata, absolute offset is a good idea. I will update= it in my next version. Thanks! Min From: devel@edk2.groups.io > On Behalf Of Brijesh Singh via groups.io Sent: Tuesday, September 28, 2021 11:24 PM To: Xu, Min M >; devel@edk2.g= roups.io; kraxel@redhat.com Cc: Yao, Jiewen >; Ard Bi= esheuvel >; Jus= ten, Jordan L >= ; Erdem Aktas >; James = Bottomley >; Lendacky, Thomas= > Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] May I ask to use the OvmfMetadata instead of the of TdxMetadata for the Gui= ded structure name label (same as what I did in SNP series patch #4). If yo= u can send the metadata introduction as a patch separately then add the TDX= descriptor in TDX series. I can try to make it work for the SNP series and= add SNP specific descriptors. Additionally, I think you want to provide an= absolute offset for the start of the metadata instead relative value so th= at VMM can very easily reach to the start of metadata. e.g +OvmfMetadataOffsetStart: + DD (fourGigabytes - OvmfMetadataGuid - 16) + DW OvmfMetadataOffsetEnd - OvmfMetadataOffsetStart + DB 0x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47 + DB 0x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2 +OvmfMetadataOffsetEnd: For SNP series, I will 3 section types #1 CPUID, # Secrets, and #3 SEC_MEM = and will probably add a total of 3 more descriptors. ________________________________ From: Xu, Min M > Sent: Tuesday, September 28, 2021 2:35 AM To: devel@edk2.groups.io >; kraxel@redhat.com= > Cc: Yao, Jiewen >; Ard Bi= esheuvel >; Jus= ten, Jordan L >= ; Singh, Brijesh >; Erd= em Aktas >; James Botto= mley >; Lendacky, Thomas > Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patch in the next versi= on. > > Can you also add a comment block documenting the format? Not only those > parts which are used for TDVF, but everything? The description in tdx-vi= rtual- > firmware-design-guide-rev-1.pdf seems to be incomplete, specifically the > option to use the table for TD memory allocation (as mentioned by Jiewen)= is > not covered. And possibly there is more which is missing ... Sure. I will add the comment in IntelTdxMetadata.asm to describe the format= of Tdx Metadata. Here is the PR I would send as the next version. https://nam11.safelinks.pr= otection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fp= ull%2F2018&data=3D04%7C01%7Cbrijesh.singh%40amd.com%7Cf49ea5bc7d79474e5= 72108d982529cbd%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63768411359027= 3535%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik= 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DbGOxYMIKtHYKhcfk0Wt4qoIgiz3b9DM%2FA= D%2Fui3ByVrU%3D&reserved=3D0 You can have a preliminary review if you want. > > thanks, > Gerd > > > > > --_000_PH0PR11MB4885A815A1FE9D46A21268F68CB29PH0PR11MB4885namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I propose to submit independent patch with independe= nt metadata (2 tables) – don’t complicate thing.

 

We can revisit to see if there is need to merge to 1= table or how to merge, as a separate/standalone patch.

 

Thank you

Yao Jiewen

 

 

From: Singh, Brijesh <brijesh.singh@amd.co= m>
Sent: Friday, October 1, 2021 1:40 AM
To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io; krax= el@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan= L <jordan.l.justen@intel.com>; Erdem Aktas <erdemaktas@google.com= >; James Bottomley <jejb@linux.ibm.com>; Lendacky, Thomas <Thom= as.Lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

[AMD Official Use Only]

 

Yes, I will try to make it work for the unified Meta= data. Let's do it indepent of SNP and TDX series. You can pick the generic = patch from my series and add the additional fields we need for the TDX and = submit it.

 

From: Xu, Min M <min.m.xu@intel.com>
Sent: Thursday, September 30, 2021 12:31:56 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; = Singh, Brijesh <brijesh.singh@a= md.com>; kraxel@redhat.com <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>
Cc: Ard Biesheuvel <= ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Erdem Aktas &l= t;erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.c= om>; Lendacky, Thomas <Thomas.Lendacky@amd.com>
Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

[AMD Official Use Only]

 

Hi, Brijesh

In the current discussion there are 2 options for t= he metadata, a unified Metadata and 2 separate Metadata (SEV and TDX metada= ta).

My understanding to your last mail is that you̵= 7;re going to use the unified Metadata option, right?

 

As to the offset of metadata, absolute offset is a = good idea. I will update it in my next version.

 

Thanks!

Min

From: devel@edk2.groups.io <deve= l@edk2.groups.io> On Behalf Of Brijesh Singh via groups.io
Sent: Tuesday, September 28, 2021 11:24 PM
To: Xu, Min M <min.m.xu@int= el.com>; devel@edk2.groups.io; kraxel@redhat.com
Cc: Yao, Jiewen <jiewen.y= ao@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Erdem Aktas <erdemaktas@google= .com>; James Bottomley <jej= b@linux.ibm.com>; Lendacky, Thomas <Thomas.Lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

[AMD Official Use Only]

 

May I = ask to use the OvmfMetadata instead of the of TdxMetadata for the Guid= ed structure name label (same as what I did in SNP series patch #4). If you= can send the metadata introduction as a patch separately then add the TDX descriptor in TDX series. I can try to m= ake it work for the SNP series and add SNP specific descriptors. Additional= ly, I think you want to provide an absolute offset for the start of th= e metadata instead relative value so that VMM can very easily reach to the start of metadata. =

e.g

 =

+OvmfMetadataOffsetStart:
+  DD      (fourGigaby= tes - OvmfMetadataGuid - 16)
+  DW      O= vmfMetadataOffsetEnd - OvmfMetadataOffsetStart
+  DB      0= x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47
+  DB      0= x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2
+OvmfMetadataOffsetEnd:=

 =

For SN= P series, I will 3 section types #1 CPUID, # Secrets, and #3 SEC_MEM and wi= ll probably add a total of 3 more descriptors. 

 =

From: Xu, Min M <min.m.xu@intel.com>
Sent: Tuesday, September 28, 2021 2:35 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; kraxel@redhat.com <kraxel@redhat.com>
Cc: Yao, Jiewen <jiewen.y= ao@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Singh, Brijesh <brijesh.singh@= amd.com>; Erdem Aktas <e= rdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Lendacky, Thomas <Thomas.Lendacky@amd.com= >
Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

On September 28, 202= 1 12:43 PM, Gerd Hoffmann wrote:
>   Hi,
>
> > > Can you move the metadata changes to a separate patch please= ?
> > Yes, the metadata changes will be in a separate patch in the next= version.
>
> Can you also add a comment block documenting the format?  Not onl= y those
> parts which are used for TDVF, but everything?  The description i= n tdx-virtual-
> firmware-design-guide-rev-1.pdf seems to be incomplete, specifically t= he
> option to use the table for TD memory allocation (as mentioned by Jiew= en) is
> not covered.  And possibly there is more which is missing ...
Sure. I will add the comment in IntelTdxMetadata.asm to describe the format= of Tdx Metadata.
Here is the PR I would send as the next version. https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Ftianocore%2Fedk2%2Fpull%2F2018&amp;data=3D04%7C01%7Cbrijesh.singh= %40amd.com%7Cf49ea5bc7d79474e572108d982529cbd%7C3dd8961fe4884e608e11a82d994= e183d%7C0%7C0%7C637684113590273535%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3Db= GOxYMIKtHYKhcfk0Wt4qoIgiz3b9DM%2FAD%2Fui3ByVrU%3D&amp;reserved=3D0<= br> You can have a preliminary review if you want.
>
> thanks,
>   Gerd
>
>
>
>
>

--_000_PH0PR11MB4885A815A1FE9D46A21268F68CB29PH0PR11MB4885namp_--