* [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print
@ 2021-09-03 19:58 Michael Kubacki
2021-09-04 7:47 ` Yao, Jiewen
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kubacki @ 2021-09-03 19:58 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Jian J Wang, Qi Zhang, Rahul Kumar
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3605
The error message is missing the argument for the status code
print specifier.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
index 1bf49f2d0fb8..32b64a31d17c 100644
--- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
+++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
@@ -52,7 +52,7 @@ OnReadyToBoot (
&mMorControl
);
if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT failure, Status = %r\n"));
+ DEBUG ((DEBUG_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT failure, Status = %r\n", Status));
}
}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print
2021-09-03 19:58 [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print Michael Kubacki
@ 2021-09-04 7:47 ` Yao, Jiewen
2021-09-04 9:05 ` Yao, Jiewen
0 siblings, 1 reply; 3+ messages in thread
From: Yao, Jiewen @ 2021-09-04 7:47 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Wang, Jian J, Zhang, Qi1, Kumar, Rahul1
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Saturday, September 4, 2021 3:58 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>; Kumar,
> Rahul1 <rahul1.kumar@intel.com>
> Subject: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add
> missing argument to DEBUG print
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3605
>
> The error message is missing the argument for the status code
> print specifier.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> index 1bf49f2d0fb8..32b64a31d17c 100644
> --- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> +++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> @@ -52,7 +52,7 @@ OnReadyToBoot (
> &mMorControl
> );
> if (EFI_ERROR (Status)) {
> - DEBUG ((EFI_D_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT
> failure, Status = %r\n"));
> + DEBUG ((DEBUG_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT
> failure, Status = %r\n", Status));
> }
> }
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print
2021-09-04 7:47 ` Yao, Jiewen
@ 2021-09-04 9:05 ` Yao, Jiewen
0 siblings, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2021-09-04 9:05 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Wang, Jian J, Zhang, Qi1, Kumar, Rahul1
Merged - https://github.com/tianocore/edk2/pull/1950
edf8bc6d24c6f490c27de3144eee88f1ca40ce6a
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Saturday, September 4, 2021 3:47 PM
> To: mikuback@linux.microsoft.com; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Zhang, Qi1
> <qi1.zhang@intel.com>; Kumar, Rahul1 <Rahul1.Kumar@intel.com>
> Subject: RE: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add
> missing argument to DEBUG print
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> > Sent: Saturday, September 4, 2021 3:58 AM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>; Kumar,
> > Rahul1 <rahul1.kumar@intel.com>
> > Subject: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add
> > missing argument to DEBUG print
> >
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3605
> >
> > The error message is missing the argument for the status code
> > print specifier.
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Qi Zhang <qi1.zhang@intel.com>
> > Cc: Rahul Kumar <rahul1.kumar@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> > SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> > b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> > index 1bf49f2d0fb8..32b64a31d17c 100644
> > --- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> > +++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c
> > @@ -52,7 +52,7 @@ OnReadyToBoot (
> > &mMorControl
> > );
> > if (EFI_ERROR (Status)) {
> > - DEBUG ((EFI_D_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT
> > failure, Status = %r\n"));
> > + DEBUG ((DEBUG_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT
> > failure, Status = %r\n", Status));
> > }
> > }
> >
> > --
> > 2.28.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-04 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-03 19:58 [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print Michael Kubacki
2021-09-04 7:47 ` Yao, Jiewen
2021-09-04 9:05 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox