From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.9236.1630746322739902442 for ; Sat, 04 Sep 2021 02:05:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yXKAeJG6; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10096"; a="199828089" X-IronPort-AV: E=Sophos;i="5.85,267,1624345200"; d="scan'208";a="199828089" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2021 02:05:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,267,1624345200"; d="scan'208";a="500939342" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 04 Sep 2021 02:05:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sat, 4 Sep 2021 02:05:21 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sat, 4 Sep 2021 02:05:21 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sat, 4 Sep 2021 02:05:21 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sat, 4 Sep 2021 02:05:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lp4R6EWbGxy1DkD1JemV4ValjTYeDePcmd7gOc70uIUoGt28WF+xXw8ycX8TYt+AhewD8vYxLY4uFaxWPLPiQTsaf0obxH71tbcAyau9dTci/5Aq5cA+i+9VYJKbvDQkfn8ZY/uJV27U0LSWKEezM4MAkEC9NbIQETNtdiy9CEboxxSBo00VhVp8i/9MBn1woRc0h2TYlycGU+SCwWjMNnBkOxlyDFor0Qe7Ojf86lQkjOj1BHCoC6ILoR/5gMrp1qDy1krWJ++fuWapdIxnrwOsZuQ9a+jlfSW4LQTuLvhEv9HLFRVI9K3g/3iLttCG4xZ9nxUz8zNof5lk6HCIuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=O3WSjOQblW2Xz+hsfKl90Ftr7rU0FybeARBmyt1+Sz8=; b=Q8ueCL+P81a1ZmamTqD/JqI05oT9BOuDVwNdrlx9anIPi1+iWIiTjlHombV0guR3vkBF6Hhj19/H/hLw8EbzpOnCL+1W7+FkWZuNZu1UKVS8MXw6+Q2w7I2EiriWjiUTHIa2FVwlBQDvGt5LYfyAfsBDSWPSSR5Q4io5S+Al3AKlQHVTPsbk1Q92S+Hx/5MnaxFDwZnwqnTPeqOige9PraB01jDpY8+9RJSxKxqcYyQIKs7Rt4gRYUyZmWe6L5Kzz6mkglYZ1O2/XYUAFQ7Jc1CwtwBiuH/zG1fJlX7eEcHcCwxFFEmvoWEBeEI2Cxubc8IZixWFSrEeNsci1hHz7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3WSjOQblW2Xz+hsfKl90Ftr7rU0FybeARBmyt1+Sz8=; b=yXKAeJG6/Ve7KuBWsZOI/vlWeamFiXAbrB8lZ4NCCNQ9pUMY1vNnGBGgolBzd9bb1TO0vBlvEUJeZefaCvvgzYsooq7sW+IKt17+2vctzGPs6CPxvm5AwD0BL9c6A46i/kHHLeBF1vWmA9vhhIbKRQoJGUt6rHSTxoCF1tK0h18= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4871.namprd11.prod.outlook.com (2603:10b6:510:30::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Sat, 4 Sep 2021 09:05:14 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::754e:42e9:16cd:1306]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::754e:42e9:16cd:1306%5]) with mapi id 15.20.4478.024; Sat, 4 Sep 2021 09:05:14 +0000 From: "Yao, Jiewen" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul1" Subject: Re: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print Thread-Topic: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print Thread-Index: AQHXoP4geNOFoyNqskmz6CDKmVMly6uTgBrwgAAVr+A= Date: Sat, 4 Sep 2021 09:05:14 +0000 Message-ID: References: <20210903195821.1050-1-mikuback@linux.microsoft.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b45a745-41fe-4772-2b12-08d96f831b92 x-ms-traffictypediagnostic: PH0PR11MB4871: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qaQfSWIUl340/KYkgKzPBffuSUmc1ld3eFglT0QkqIE9YEbzOIWJabQifaSfAoLhT9fzmgssnd+orjD+NUutqkABHTMJ1Ry89v1n2ouUbX6/os96Gn/8WLkBTvktfEOVJ5CHSbes24IQsolzkC5VaQz7UEg00hdJinc3KukKGAkvLy5oEJ5ysWKUFsQtREE5pFMxmMqCS1HjRcsWmyhc2exW+APb/JbtVvsNZ/i+kCFcYJl2SvthveHRkK6uTl7tNw+RIgCGgl5YAPFeeLYWxXEB/eLA7FOcS25m4288xF2flCVh7Weqhoz+4AYF3ozX0oIEldH5sdg5F8pEXYXqBOLt6gzdhG+lFMXW3/4GWThRMhhMZUtUS9OgE0QHFTTJrCg9sDmPe9/7bZbtQo56bYEVNdU7uoVTY/zCCOeNAAS4vV/3dRoyH5Jm1BJzH2JS5OiXCY7RPpJTYuYbeEEu4qSJdyjHALSuS5A8YxAsKYQDVdS1N8eOVYYQ6l++mQjkPi4Mwr1AOH+rQ9rj79sbD7glBA6dddOZykF3Whf3fryLBLPaUCaLZGHemAQK8zTyXKZ5uYhZ7I2vVkrqqMKPx1FtdUQpxx4+BCZexDR9GXyC0mvnX3k4JBTUI9kDGfXfiwLw225QTynYMSEAq6I4uZoGQsJDeL7mhLusYIyR1ehLnVxUBkDPe8ci/mCE5X6SEOSKirjnasdBOtg2TGK3vo85Kfts+CU4RKofF+HBJjCqavYy0RTCUUj1EUnp75E613URWtbmTELW5WcaWzlzWBix+xrqur+8AugGQszAEgs9eJzmm2ThDkg5WxOJmXwoDrU2Mtdvf4zBw729muRlAg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39850400004)(376002)(396003)(366004)(136003)(966005)(64756008)(186003)(66946007)(110136005)(38070700005)(66446008)(66476007)(76116006)(66556008)(478600001)(2906002)(2940100002)(33656002)(83380400001)(54906003)(316002)(86362001)(5660300002)(55016002)(26005)(8676002)(38100700002)(8936002)(4326008)(71200400001)(9686003)(122000001)(107886003)(52536014)(7696005)(53546011)(15650500001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q9KU6Qw0utGCPWnc2YPvofHCUkF31xxrFXgmKFz1UVO2D9St/pGAkWaIMyIT?= =?us-ascii?Q?7VkhekG57AIb1kCwoWho/NwjDPCo0WvHj1In0cVvfJLr3mGJK6hLo7a6iZPW?= =?us-ascii?Q?Oq6Z56BefVfNVPx+/TEFJKNhFxaXN6Basg/zlzIn31RmqviZcRaiouH+GrFy?= =?us-ascii?Q?DVGHOZ7uChDYm5amh1mHqukgbBBhsyA/lTNzCaF7PCLTywwkTJiyJWVjnpwV?= =?us-ascii?Q?S1bxEdJrLPt0OcCaBL41JNMunUA+IuHAkXVmNucgPoXau9kIO+2qxdi7d4Dd?= =?us-ascii?Q?BhKWPc1D9oow1VB5zgBVhzr9xwRaev5rVg1fq5ZQ/HsAxCYSuH0Y5goLVA/m?= =?us-ascii?Q?ojHFizD/RcSQbZxlgJX6BRnYc/pQOcXg84U+K8Vv9ebJ7dLjHDfADJojemQ3?= =?us-ascii?Q?I3nlRB+SAZq7Q4hWpT8VJ0CDdVGWTKJFoKgPC73Nl+nzA79XHQwB0/DdtBUW?= =?us-ascii?Q?ZYcoOF2UTxdXIEesTwUUMk0nOgPtJ5a9Bib//df0dACrQhW3/20yW4lmSrPv?= =?us-ascii?Q?0168518p0IqHFopCTYpi8Ts/m0Mjl9xyEvUvOhwOeOFnawv/NvBIs9pa2f/g?= =?us-ascii?Q?Et1DD9U/UEuj1EWxHhg2jG4HMeC3pXxv4LMpLZ6kTzAU3DS2c4RkHb248fRM?= =?us-ascii?Q?lFvdTlKvC8fpO1EAV31d4e9sERynANd5pEYd69L1O2a3KA6hEu0WknrrTMFL?= =?us-ascii?Q?TIsfqjQ8yJZekaJGaKF2OyPOuYZOQMBx8hKixd8Vf2HGkQcty78BmafWwfw7?= =?us-ascii?Q?CfbqNEiNAKF8HHUtq+HP0IsGpLBTzH4jzzFcremXbJ4OJyqYzbnHpXpw2jbo?= =?us-ascii?Q?go2b0Lcd5F96bHW3ZAYlYeWLCmLvK/lQzaTbDvS8DyMenm5Cm3tVuCeNMEkD?= =?us-ascii?Q?BCA+CMxyxh75/1wZeU+Asv+XqJ00aJJqNwaUnkfA8xxoTKgYj3eL3NBeAUQt?= =?us-ascii?Q?v+zI1xXcg4HOCdhJWvYcvVqrJvDCTjfWdhnO1ibP7lKcb12zdIa0eeWnIfGY?= =?us-ascii?Q?iAf/mB+Hk9E+xKW4h07CKBhBhYhIoRRWbQb6u4dnMMOsHJL4YHBLyEberpoM?= =?us-ascii?Q?yEWJY7yngNZI+g5Em3VDKGTg5z6fvpcRmQplOGfYxECNgCPeNQMFRF30HwFG?= =?us-ascii?Q?NbT4gNbL0OWTetLpkI0AEFPGr+gr/nciEPK6miZ7bQ9mCbCwwMiET84DRVmU?= =?us-ascii?Q?tk017IhEBmxh8Vsc0EBcn5Ta4/y+EoIseebPUblmfdvHTZ6JjoXyJvEIEC8q?= =?us-ascii?Q?Z56MTfSlZNdU/l3aEPqwO6oFI39FLT2LebtA+4ZTb5Ctr9BHDw181D+Hz+hC?= =?us-ascii?Q?1Bt/8Rjpvjp6dv6svNun0sFS?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b45a745-41fe-4772-2b12-08d96f831b92 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2021 09:05:14.1926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9ayO7/5c59CE+88wZjQuTDeRlXFYfx/TisTuO7fg+nPH/VN0tRkXB4RMEmAaOlwrkhBeaiBrK9YjLBOr8Zx/ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4871 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged - https://github.com/tianocore/edk2/pull/1950 edf8bc6d24c6f490c27de3144eee88f1ca40ce6a > -----Original Message----- > From: Yao, Jiewen > Sent: Saturday, September 4, 2021 3:47 PM > To: mikuback@linux.microsoft.com; devel@edk2.groups.io > Cc: Wang, Jian J ; Zhang, Qi1 > ; Kumar, Rahul1 > Subject: RE: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add > missing argument to DEBUG print >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: mikuback@linux.microsoft.com > > Sent: Saturday, September 4, 2021 3:58 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Zhang, Qi1 ; Kumar, > > Rahul1 > > Subject: [PATCH v1 1/1] SecurityPkg/MemoryOverwriteControl: Add > > missing argument to DEBUG print > > > > From: Michael Kubacki > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3605 > > > > The error message is missing the argument for the status code > > print specifier. > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Qi Zhang > > Cc: Rahul Kumar > > Signed-off-by: Michael Kubacki > > --- > > SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c > > b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c > > index 1bf49f2d0fb8..32b64a31d17c 100644 > > --- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c > > +++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c > > @@ -52,7 +52,7 @@ OnReadyToBoot ( > > &mMorControl > > ); > > if (EFI_ERROR (Status)) { > > - DEBUG ((EFI_D_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT > > failure, Status =3D %r\n")); > > + DEBUG ((DEBUG_ERROR, "TcgMor: Clear MOR_CLEAR_MEMORY_BIT > > failure, Status =3D %r\n", Status)); > > } > > } > > > > -- > > 2.28.0.windows.1