From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Michael Kubacki" <michael.kubacki@microsoft.com>
Subject: Re: [Patch V2 7/7] OvmfPkg: Reproduce builds across source format changes
Date: Fri, 5 Nov 2021 03:18:37 +0000 [thread overview]
Message-ID: <PH0PR11MB4885C55B3F270EEFB9351F658C8E9@PH0PR11MB4885.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211101213737.586-8-michael.d.kinney@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Tuesday, November 2, 2021 5:38 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Michael Kubacki
> <michael.kubacki@microsoft.com>
> Subject: [Patch V2 7/7] OvmfPkg: Reproduce builds across source format
> changes
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> Use DEBUG_LINE_NUMBER instead of __LINE__.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 6 +++---
> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 4 ++--
> OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 2 +-
> OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> b/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> index 746b366448e6..350cf3dd0b3a 100644
> --- a/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> +++ b/OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
> @@ -2321,7 +2321,7 @@ LegacyBiosInstallRom (
> );
>
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "return LegacyBiosInstallRom(%d):
> EFI_OUT_OF_RESOURCES (no more space for OpROM)\n", __LINE__));
> + DEBUG ((DEBUG_ERROR, "return LegacyBiosInstallRom(%d):
> EFI_OUT_OF_RESOURCES (no more space for OpROM)\n",
> DEBUG_LINE_NUMBER));
> //
> // Report Status Code to indicate that there is no enough space for OpROM
> //
> @@ -2337,7 +2337,7 @@ LegacyBiosInstallRom (
> //
> RuntimeAddress = Private->OptionRom;
> if (RuntimeAddress + *RuntimeImageLength > MaxRomAddr) {
> - DEBUG ((DEBUG_ERROR, "return LegacyBiosInstallRom(%d):
> EFI_OUT_OF_RESOURCES (no more space for OpROM)\n", __LINE__));
> + DEBUG ((DEBUG_ERROR, "return LegacyBiosInstallRom(%d):
> EFI_OUT_OF_RESOURCES (no more space for OpROM)\n",
> DEBUG_LINE_NUMBER));
> gBS->FreePages (PhysicalAddress, EFI_SIZE_TO_PAGES (ImageSize));
> //
> // Report Status Code to indicate that there is no enough space for OpROM
> @@ -2355,7 +2355,7 @@ LegacyBiosInstallRom (
> //
> InitAddress = PCI_START_ADDRESS (Private->OptionRom);
> if (InitAddress + ImageSize > MaxRomAddr) {
> - DEBUG ((DEBUG_ERROR, "return LegacyBiosInstallRom(%d):
> EFI_OUT_OF_RESOURCES (no more space for OpROM)\n", __LINE__));
> + DEBUG ((DEBUG_ERROR, "return LegacyBiosInstallRom(%d):
> EFI_OUT_OF_RESOURCES (no more space for OpROM)\n",
> DEBUG_LINE_NUMBER));
> //
> // Report Status Code to indicate that there is no enough space for OpROM
> //
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> index 9b21ba2bd699..186401296ae2 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
> @@ -624,7 +624,7 @@ PrepareLpcBridgeDevicePath (
> DEBUG((
> DEBUG_INFO,
> "BdsPlatform.c+%d: COM%d DevPath: %s\n",
> - __LINE__,
> + DEBUG_LINE_NUMBER,
> gPnp16550ComPortDeviceNode.UID + 1,
> DevPathStr
> ));
> @@ -656,7 +656,7 @@ PrepareLpcBridgeDevicePath (
> DEBUG((
> DEBUG_INFO,
> "BdsPlatform.c+%d: COM%d DevPath: %s\n",
> - __LINE__,
> + DEBUG_LINE_NUMBER,
> gPnp16550ComPortDeviceNode.UID + 1,
> DevPathStr
> ));
> diff --git a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c
> b/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c
> index 513d2f00a747..e767c3b172ba 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c
> @@ -586,7 +586,7 @@ PrepareLpcBridgeDevicePath (
> DEBUG((
> DEBUG_INFO,
> "BdsPlatform.c+%d: COM%d DevPath: %s\n",
> - __LINE__,
> + DEBUG_LINE_NUMBER,
> gPnp16550ComPortDeviceNode.UID + 1,
> DevPathStr
> ));
> diff --git a/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
> b/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
> index 1c5405f620e7..fd8057735549 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
> @@ -556,7 +556,7 @@ PrepareLpcBridgeDevicePath (
> DEBUG((
> DEBUG_INFO,
> "BdsPlatform.c+%d: COM%d DevPath: %s\n",
> - __LINE__,
> + DEBUG_LINE_NUMBER,
> gPnp16550ComPortDeviceNode.UID + 1,
> DevPathStr
> ));
> @@ -588,7 +588,7 @@ PrepareLpcBridgeDevicePath (
> DEBUG((
> DEBUG_INFO,
> "BdsPlatform.c+%d: COM%d DevPath: %s\n",
> - __LINE__,
> + DEBUG_LINE_NUMBER,
> gPnp16550ComPortDeviceNode.UID + 1,
> DevPathStr
> ));
> --
> 2.32.0.windows.1
next prev parent reply other threads:[~2021-11-05 3:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 21:37 [Patch V2 0/7] Reproduce builds across source format changes Michael D Kinney
2021-11-01 21:37 ` [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to support reproduce builds Michael D Kinney
2021-11-02 2:12 ` 回复: " gaoliming
2021-11-02 7:05 ` [edk2-devel] " Michael D Kinney
2021-11-04 5:24 ` 回复: " gaoliming
2021-11-01 21:37 ` [Patch V2 2/7] MdePkg: Reproduce builds across source format changes Michael D Kinney
2021-11-01 21:37 ` [Patch V2 3/7] ArmPkg: " Michael D Kinney
2021-11-01 21:37 ` [Patch V2 4/7] MdeModulePkg: " Michael D Kinney
2021-11-01 21:37 ` [Patch V2 5/7] NetworkPkg: " Michael D Kinney
2021-11-08 17:09 ` [edk2-devel] " Maciej Rabeda
2021-11-01 21:37 ` [Patch V2 6/7] SecurityPkg: " Michael D Kinney
2021-11-02 0:14 ` Yao, Jiewen
2021-11-01 21:37 ` [Patch V2 7/7] OvmfPkg: " Michael D Kinney
2021-11-05 3:18 ` Yao, Jiewen [this message]
2021-11-02 2:31 ` 回复: [Patch V2 0/7] " gaoliming
2021-11-02 7:10 ` Michael D Kinney
2021-11-04 5:15 ` 回复: [edk2-devel] " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB4885C55B3F270EEFB9351F658C8E9@PH0PR11MB4885.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox