From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.23417.1629724613350470170 for ; Mon, 23 Aug 2021 06:16:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KFfFsoPd; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="217102838" X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="217102838" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 06:16:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="492695300" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga008.fm.intel.com with ESMTP; 23 Aug 2021 06:16:51 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 23 Aug 2021 06:16:51 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 23 Aug 2021 06:16:51 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 23 Aug 2021 06:16:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFxogMv1LIiRSjuwEmgKpS8PCVZr7INMPW8y+5/RaoGLqs5JW+wPZOxOi9CPVqTqj1NC/Co7AsCCA9sFWMkCNQ02/u6ODbMnUgD0XszfDwFfIvjy/+kyK+8wpZJ6Ya4/XJ3o1wWjqceIQBpNDrnKELupaws5opZN0Yd+ciGdkduil8UVdLT2iI1aaxyo47+XP8o3RJOybjs5siU3B8upHtZHImcdjrAZsHtqf/km+C4Pi8uAS5MmXxoEJAufr5WIPIBHHvQ7UeEbXkDrSBHQZgXpNzhoanmKQ85BcrYIRmLU76dxD3Lj6pOe8gx7VhwFo6bELl0qBbjdtfx6W1aOPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b53PGOx3Zkvj7BCypMMjD40/2drcJM7Fdla5oTtgDEI=; b=fzGXSsO6qm86LJx22IPTFtIP/MDsa2GCz3z+S7HfV0f1rC3UtA1C2t54B/goGilXSLSXcyYhzNM/tRVz15CvAyx09iDcKOdeNuerJ3/KWf7GnLNK4GLMJwsBhlPp/46fVnlnAKLY6yPfM2SbfStASWRfVVo0ycIK5dxkFlYjt9A7YXhykiZjBdg3F8m0DPkfVhbjuThTloHuWioRpyPx1VYVQ7GZMaBvEQwStx6xVzMhI1lOddlMX2q2htEthe1bgP/8Kp57+0V2a7pd05bxL04XKYldknmCXX0rrpWOdWxzSCL+M6mTOyQv/OgmBsuUTuxlMVUlLQGxr8J0nJxFZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b53PGOx3Zkvj7BCypMMjD40/2drcJM7Fdla5oTtgDEI=; b=KFfFsoPdyW1AhrhpIAvJ4xCLNrIiYZSJQ8vg1kZHxE/ZAlvD0izqhiiZtUPqF9PcrpRQl4w7wickai2K+KK8v9I1zSa7xp2LYwXKih6yHBNUQJa3UCdXVyv2I5iPNOfgb4u+5rrFcGFqNICyEYfyayjHkF6tLc8g0wkQaXwr6qY= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4791.namprd11.prod.outlook.com (2603:10b6:510:43::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 13:16:49 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79%6]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 13:16:49 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "gary.lin@hpe.com" CC: Ard Biesheuvel , "Justen, Jordan L" , Anthony Perard , Julien Grall , Jim Fehlig , Joey Li Subject: Re: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Thread-Topic: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Thread-Index: AQHXl+3pYRTBujgDNUidcH7cOfWK5auBElHA Date: Mon, 23 Aug 2021 13:16:49 +0000 Message-ID: References: <20210823070925.10095-1-gary.lin@hpe.com> In-Reply-To: <20210823070925.10095-1-gary.lin@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53db73ea-1820-4d80-5674-08d96638440d x-ms-traffictypediagnostic: PH0PR11MB4791: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E8AiKgADjcFjMSpUpDr7370V/XCa0isjONf/gI/ORIORtHjCX60fyfNr3GfHFYTwP/pjTldjc8XA3z9fvJ37kNGTj6uh/imb+eMa0wERKDhwkrD1QwvFD07aGM1LwMAGMpDuT8dWOv9iyDhFh+GfzRsRsA4RlVHUQ6RjyYlSLxLU9GiZKceBCP9j881XIG2gxV76D9J27Cm/PZSwB50BizCK3GxAX2o1s/2PPSPKONFcVGLM/nY2AAFd/71z44wd0VPuP6EP56ZZpCu5y0qaXvfy4WpnU0WTP25lJC+e4ngBlz/aNfAWmRb8NgevzYThVN/oHmlaWoiXWCXc1HexY79rqCsUlc1Uea7IX0qZNp7C+9SW0qokiJJxtwr44lB7T7vigbCHYy53D92Z32uLSEBBjcGfgc9xgFxQugrnt37SMx5kVTrvPZqRdTVJT+V/NnEnmkl189Pu5MQbdIJlZPk293FGo9Y2Wc/hn84IzlYc56NfaVBucRQZXxbrb5/AZWQHfQEXtVEu4GtlGLDt+7ff5kqkRo551URowW73QtOyFrz/Sf9LNEJueFbiCgLMhPHU19LqdalfWq2t78jIojes/sTLTMsFyfHVEzZYnZRoX+9NxRXdi/APJjo6MG+xx2A3cvdBwku/wRqBsnjWLRtwDijVpHCzZqg/6bR/AoOxfNlth9HWpldsccWRbkZyYHkqCGxQX3N4Cbwkf3Ai4Jeb2oCzb1b0cMC9fFKySArUjAvLIPEIzAkom3NYn2IYvPtyZxR4GgmJOc/tpQo5LEtB7tGwzzH+eMgNci33dKCKAgMX/uLysOvg2oF46fJJ/FTMOHJfO338RWpuLgfmzA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(136003)(366004)(346002)(376002)(316002)(54906003)(2906002)(122000001)(38100700002)(110136005)(19627235002)(71200400001)(8676002)(26005)(33656002)(55016002)(9686003)(5660300002)(83380400001)(966005)(6506007)(86362001)(76116006)(38070700005)(478600001)(8936002)(52536014)(4326008)(7696005)(186003)(66946007)(53546011)(64756008)(66446008)(66476007)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JK/eyfFAuAwavOLeLK6dXccLEACA7RoysAQ+vUhpDMaHT00hhnC8lKxbV9QB?= =?us-ascii?Q?CB5FCTOc2ZLhxtfSK8zvq3zfiPar2QIZKfxQ0KMnwSYJYOmleI3FG8/QmVSB?= =?us-ascii?Q?XI4pPHlo+JyyZ2lZGD189LR40/Tc5+EYDpRR8UFt2fncUQbYxrYxSitkcOTS?= =?us-ascii?Q?tVfazdE+xv0whhzRpgtkVt/tpEItVfOxlxO241zQbXXT0R8aWr8QYE8eyl9r?= =?us-ascii?Q?nFwSyR4eW425i8lQt88++WcCjS7U5KKrHKTuI8Xm/AuSZGILXupxQklOdz5a?= =?us-ascii?Q?36SP0/dET3cJ8zDccZNr5hzO5f0ISo6mS/9JG9IU/4dx8TzrO8bXLX282ITy?= =?us-ascii?Q?Dt2S0Asr4Ky5Quh5lzI/8DSuuWn6kL6KiWN+ZcZjfO919JZBlP3YDPv+RvNq?= =?us-ascii?Q?xlCrLQtlLnwYkGh+TzNcsqjQzWWxoK+fa1qMa4cYG703epQuuxSK+c6peHY5?= =?us-ascii?Q?qmm1ItRlGKiXOoDEkrYGEIYVnzUOxyigdssJPJa8M/VwIHyR9+DcETgGGDZ7?= =?us-ascii?Q?PWL0anFhN53hQMRKyRLa5HYfuYDAhNGziGtGeA8yk/diOlEN8SQvpqvdL4hA?= =?us-ascii?Q?TP9Itq/Y8TsvIQOW2haM82tOBTUryAOqZ5u4qYHjB7Ryt0+jcgmxEsb1mvXv?= =?us-ascii?Q?UahKkkMhqNatcSKrGWuPyHLOQbTNdHUH/7GIBqjC30gOnsnbGMKXBpHrefxQ?= =?us-ascii?Q?WzimPWGh3mIdFJv+AioIFPu3b8o2VHtOkKG5L1jv+CyekT79ctWH+x5XKlU6?= =?us-ascii?Q?opcDjx9/tEl1xA1gLFO2BEra2cI+AR/ITc3jNY74fh59qUdeTxhoToDnrO87?= =?us-ascii?Q?8zGQUVoOYcEQqQF608LXNl4SHUazyfZmkxylICe12EXFvNvxL6ooaCei3p3X?= =?us-ascii?Q?bTjQaJICMGxX2NHsZYBeMYvnF0Fd0IAlZpXIcAs50H79YhZGmPeojKd5bzZp?= =?us-ascii?Q?4KeooTK36z3CSRE1XGrYUUg+/mVS8h+JPZvIm90hMSzNjrLZGHv7Utl04GzW?= =?us-ascii?Q?njnRUPCi63R3jRebr+l1/AfiWveOVzpmIgueI1jOtLt0w1Mhw3g+m+SQgI3B?= =?us-ascii?Q?NYq/qpSjZaPByfpv4wve2k3k3ZtfVCj2/swJ4DsZWjGsX/7NdHsB12ozDhKB?= =?us-ascii?Q?abW+hltJjUzFPYYsbGYlFgcgTYTWfV8j8zG58G6Ll3kX1Ych0kwdIScV9Emc?= =?us-ascii?Q?lYrYHIccM+JaZDQHDh+OBIdLNiRVdy2RcSW7xXIFpT2NWNEZNkR6+56gUffz?= =?us-ascii?Q?CDq0QWbS68v94ArxufQi8mK5xRgYBypnfYJTcG4WbGbpcD0vP/0d3a+Mgckq?= =?us-ascii?Q?RlEVFoWjDsHFFKMhJeKEdNq+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53db73ea-1820-4d80-5674-08d96638440d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2021 13:16:49.3899 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RprePBR7IEo9bxYR150pf3VH+T5+csmz5uLFTm2hEN6JOTStfH9cm8kcO4HVQM8Nfm2/8hUozl4snmA0dBwQqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4791 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series reviewed-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Lin, Gary > (HPS OE-Linux) > Sent: Monday, August 23, 2021 3:09 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; > Anthony Perard ; Julien Grall = ; > Jim Fehlig ; Joey Li > Subject: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 s= upport > state >=20 > When using HVM Direct kernel boot with OvmfXen, it could fail at the > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > and PcdAcpiS3Enable. >=20 > This patch series initializes PcdAcpiS3Enable in > . Besides, QemuFwCfgS3Enabled() is > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > potential inconsistency. >=20 > Bugzilla links: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3573 >=20 > v3: > - Update the description per Anthony's suggestion > - Add the bugzilla links > - Move the QemuKernelLoaderFsDxe patch out of this patch series > and make it an independent patch > v2: > - Amend the description and address "HVM Direct Kernel Boot" > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > - Remove unused QemuFwCfgLib > - Update my email address >=20 > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > Cc: Jim Fehlig > Cc: Joey Li >=20 > Gary Lin (4): > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > support > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support >=20 > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > .../PlatformBootManagerLib.inf | 1 + > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > 8 files changed, 22 insertions(+), 9 deletions(-) >=20 > -- > 2.31.1 >=20 >=20 >=20 >=20 >=20