From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "mhaeuser@posteo.de" <mhaeuser@posteo.de>,
"spbrogan@outlook.com" <spbrogan@outlook.com>,
"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy
Date: Thu, 30 Sep 2021 00:01:56 +0000 [thread overview]
Message-ID: <PH0PR11MB4885DF0E330C76227A6DC9048CAA9@PH0PR11MB4885.namprd11.prod.outlook.com> (raw)
In-Reply-To: <da269347-e134-1697-ddaf-ed3f385d9c2c@linux.ibm.com>
Yes. Merged.
499c4608b13df0738213329722cdcb0ac838f3ad.. bd298d75934a7a0cf6b9e2863a5e4975e9714285
> -----Original Message-----
> From: Stefan Berger <stefanb@linux.ibm.com>
> Sent: Thursday, September 30, 2021 3:15 AM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>
> Cc: mhaeuser@posteo.de; spbrogan@outlook.com;
> marcandre.lureau@redhat.com; kraxel@redhat.com
> Subject: Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform
> hierarchy
>
>
> On 9/14/21 6:26 PM, Yao, Jiewen wrote:
> > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> >
> > I will wait for a week, to see if there is any feedback from AMD or Bhyve
> reviewer.
>
> I didn't see any more comments to v3
> (https://listman.redhat.com/archives/edk2-devel-archive/2021-
> September/msg00641.html)
> So maybe you can apply it to the repo.
>
>
> Stefan
>
>
> >
> > Thank you
> > Yao Jiewen
> >
> >
> >> -----Original Message-----
> >> From: Stefan Berger <stefanb@linux.ibm.com>
> >> Sent: Tuesday, September 14, 2021 10:18 PM
> >> To: devel@edk2.groups.io
> >> Cc: mhaeuser@posteo.de; spbrogan@outlook.com;
> >> marcandre.lureau@redhat.com; kraxel@redhat.com; Yao, Jiewen
> >> <jiewen.yao@intel.com>; Stefan Berger <stefanb@linux.ibm.com>
> >> Subject: [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy
> >>
> >> This series of patches adds support for disabling the TPM 2 platform
> >> hierarchy to Ovmf. To be able to do this we have to handle TPM 2
> >> physical presence interface (PPI) opcodes before the TPM 2 platform
> >> hierarchy is disabled otherwise TPM 2 commands that are sent due to the
> >> PPI opcodes may fail if the platform hierarchy is already disabled.
> >> Therefore, we need to invoke the handler function
> >> Tcg2PhysicalPresenceLibProcessRequest from within
> >> PlatformBootManagerBeforeConsole. Since handling of PPI opcodes may
> >> require
> >> interaction with the user, we also move PlatformInitializeConsole
> >> to before the handling of PPI codes so that the keyboard is available
> >> when needed. The PPI handling code will activate the default consoles
> >> only if it requires user interaction.
> >>
> >> Regards,
> >> Stefan
> >>
> >> v2:
> >> - 1/4: Added missing link library
> >> - 2/4: Modified other BdsPlatform.c files as well
> >> - Added Yao's comments to 1/2 and 2/2
> >>
> >> Stefan Berger (4):
> >> OvmfPkg/TPM PPI: Connect default consoles for user interaction
> >> OvmfPkg: Handle TPM 2 physical presence opcodes much earlier
> >> OvmfPkg: Reference new Tcg2PlatformDxe in the build system for
> >> compilation
> >> OvmfPkg: Reference new Tcg2PlatformPei in the build system
> >>
> >> OvmfPkg/AmdSev/AmdSevX64.dsc | 8 ++++++++
> >> OvmfPkg/AmdSev/AmdSevX64.fdf | 2 ++
> >> .../PlatformBootManagerLib/BdsPlatform.c | 19 +++++++++++--------
> >> .../PlatformBootManagerLibBhyve/BdsPlatform.c | 16 +++++++++-------
> >> .../PlatformBootManagerLibGrub/BdsPlatform.c | 16 +++++++++-------
> >> .../DxeTcg2PhysicalPresenceLib.c | 5 +++++
> >> .../DxeTcg2PhysicalPresenceLib.inf | 1 +
> >> OvmfPkg/OvmfPkgIa32.dsc | 8 ++++++++
> >> OvmfPkg/OvmfPkgIa32.fdf | 2 ++
> >> OvmfPkg/OvmfPkgIa32X64.dsc | 8 ++++++++
> >> OvmfPkg/OvmfPkgIa32X64.fdf | 2 ++
> >> OvmfPkg/OvmfPkgX64.dsc | 8 ++++++++
> >> OvmfPkg/OvmfPkgX64.fdf | 2 ++
> >> 13 files changed, 75 insertions(+), 22 deletions(-)
> >>
> >> --
> >> 2.31.1
> >
> >
> >
> >
> >
prev parent reply other threads:[~2021-09-30 0:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 14:18 [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy Stefan Berger
2021-09-14 14:18 ` [PATCH v2 1/4] OvmfPkg/TPM PPI: Connect default consoles for user interaction Stefan Berger
2021-09-14 14:18 ` [PATCH v2 2/4] OvmfPkg: Handle TPM 2 physical presence opcodes much earlier Stefan Berger
2021-09-14 14:18 ` [PATCH v2 3/4] OvmfPkg: Reference new Tcg2PlatformDxe in the build system for compilation Stefan Berger
2021-09-14 14:18 ` [PATCH v2 4/4] OvmfPkg: Reference new Tcg2PlatformPei in the build system Stefan Berger
2021-09-14 22:26 ` [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy Yao, Jiewen
2021-09-14 22:37 ` [edk2-devel] " Stefan Berger
2021-09-29 19:15 ` Stefan Berger
2021-09-30 0:01 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB4885DF0E330C76227A6DC9048CAA9@PH0PR11MB4885.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox