From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.19505.1629084137197477045 for ; Sun, 15 Aug 2021 20:22:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lLdmVNnq; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="195371977" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208,217";a="195371977" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2021 20:22:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208,217";a="461916266" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 15 Aug 2021 20:22:15 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 15 Aug 2021 20:22:15 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 15 Aug 2021 20:22:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 15 Aug 2021 20:22:13 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 15 Aug 2021 20:22:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DP6PFoh9V17AcrYwMl/cDxg98yxdfvtjsLb5AeMdc3XUppK/enKL2p9iFw21oOxNUWdLIbgROc/Ct8xhw30jaKNwFlKm++PYJEHzV2DFZNN2y4Bh7swEUt1/SmkfTIeqq7zf5GuFlVSVTIC+KBLz3eMxNhoVhbgBZvDfkCF8YORfGmuQxpCL7kLD9tS4hfL340/P2iq8Abs65RNuefeakzj2Oq0c8nRE9QRX66A6BQxEn1mrN0XgXhYoKE9Vlzlun/oEE8B1lrJmAtMzzi6/hxHhH5xEtOya7zmiLMppWMIzadpTl/l2Dsa8d9vmn6GnFGwi3kdIJoP1/a8VteUk4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJ8RtfjCD1oQDGIKqjsqtVfoyM6RCNDEjYBDXeCPDq0=; b=kj04rfXbBwjio9H/ipHkFmKlwVLbgW6PPnFxz+bKilJgV0Eswt9F+KdLILqVCSlfb3mKy6aKGwiYhu6btEE2dp6e2yL97GxCS212BEKUH83111OKrv6NzFNkhzYoPR2d+VrCHn7sgLd4yHDeew2C9PYgGHoaZWPUApQrhEqcnkNKG3oANU5+bqO2MV/hGUJP6uK6LxNXUuuK8lNopKMRq/gdMGVfM5XtUklRaA87iwPkYNOrauWJP5a9rbIfAz1NBMDWSgEQEqqmUhGiVU6pxLIQ1CdkE1k7XxbdR3M222vNbqD2hhAkuJ4hzbjOqS7kHeiM4e/UbJPSWRswVy1KPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJ8RtfjCD1oQDGIKqjsqtVfoyM6RCNDEjYBDXeCPDq0=; b=lLdmVNnqmP6vLdxu4yVK8yDOG16vws10UN+1b/BZmNXGllp293ryTaG4bjwedBMK+DkUPDTysRP8fgintnJYWq6Y0NM/trQY5eisTqtsO2X4JJmUeUiYb2ITAVwp15kZEmtekpdoDEQ/35OtYwego+5OtW5fCdOjb+FIeXgg7x4= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4806.namprd11.prod.outlook.com (2603:10b6:510:31::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13; Mon, 16 Aug 2021 03:22:13 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79%5]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 03:22:13 +0000 From: "Yao, Jiewen" To: "Ni, Ray" , "Zhang, Qi1" CC: "devel@edk2.groups.io" Subject: Re: Why SetVariableCheckHandlerMor() is implemented in VariableSmm and TcgMorLockSmm? Thread-Topic: Why SetVariableCheckHandlerMor() is implemented in VariableSmm and TcgMorLockSmm? Thread-Index: AdeSTMF6h1SuufF1QU+skt8s2GeRwwAAQB2g Date: Mon, 16 Aug 2021 03:22:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0379bb5-7528-4daa-1d76-08d960650a52 x-ms-traffictypediagnostic: PH0PR11MB4806: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DMKD2kUmObIxxyezlsa0herFFaqmW0vDlLtWgepgJkXnG82ZE2SSSCkQoJ9xqlpixgGIJXk9UKZvlBo02F+P+4GuVrqIE7e4BtSbrfAgoCWq41db+tAq37LfGU9ClA8V2B+YZ00Jdc4kj1oCs1YPfslbd/X7IDCimrTCpHRXIvDIKS8qoOEK1yOVWurrHRzu+5EedZ7GwbLW0OPemsht7eCkppNYa0wdG2HoRptSLrsLt2qVEcjv+oiczqnB/+pltmdSXB+m2AiFpyzdK9W7nsQwr1cL5TfDfenYRWhp5Hvfl4I1bn6SniL2SlbpD1iRkUtaKK76OBbUYUgTOttsRuYhEOhPxe3DH0/DV6aX3FQKcdQBNEwwWFabLaKqKPtxNCWIhFp+k9Rs7eBNOymqc4kfInPNRJ5a/pm3aiUlrLCcg8qjKsRImw4dN0EZbK8Bn6hNcxQpXzFM8/LaIzA/j6drKWMgh5rvE2pnpKeb+CO20bw7b3uXrWa4NUlUvkd8KUd4dR61HcguPlBlEqITTBkHgEwVRCYfzi4K2dx6T26BWh0X/d8c8HF9hrhU9r0B5N9F9HmbcLsEuWB3EotYEbADvjrP1C7ruljOIPJsALGsToXdF+ee1/MqqYQZHEcvZiWpCz0nI47BL7per+fNl81T6Rwp4ng+sJHwsCktXd9r1YpRXK6X7wluRyK7MOUvuU9WCWNMIPMbtpHtN4LpBbhSpq26If5poMYiUsE2qOc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4744005)(316002)(5660300002)(110136005)(76116006)(186003)(83380400001)(2906002)(8936002)(9686003)(7696005)(122000001)(4326008)(508600001)(33656002)(64756008)(8676002)(52536014)(66446008)(66556008)(71200400001)(66946007)(66476007)(55016002)(38100700002)(38070700005)(86362001)(26005)(6506007)(53546011)(6636002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ShFCw0VYXBiBdx9kQ7pPFZ5VnwoDpO9Y3s5SFQsl8cBXlrfUzjtMX7E1hJWY?= =?us-ascii?Q?GpiZF5kVQmvJGDKDYbrlOzhn3PI253sc+lr76BiDeHH+ypY4sr7wz85OIsyr?= =?us-ascii?Q?BDDZsTVisfUMn96Bu3N6Ed3DdpB1epeXjem9Kz0dHqhVKgpQg7rAJGKTINTb?= =?us-ascii?Q?dBiKCLDxVjMsUDj+U5PUrV5i+cguBkN/dC50H1PEzevwceRx3CA9Vf/KUNN1?= =?us-ascii?Q?gfga3+8Dd0z/9cOctWDV6kBSfg2UsU7yVsHytbzELKgTSDPlGRI5DplbqikU?= =?us-ascii?Q?D8nC1XZCN4cwFEZwBOizS7EGe4vav05twRNH+K7o3NNa/BORMbOudP/rj09w?= =?us-ascii?Q?9KpiSbODh+andyHELQAfWN6mIlHZHJSHJVpJKJh1ylZgJRLbsRgmA1RO8gbD?= =?us-ascii?Q?7/mX/8pOXwTDVUos5WGBS05Bj1xYesdT7AjRYf4laCBoNJS6ZkdaHA1ZoCyH?= =?us-ascii?Q?6kiVq7cBw1liHO6ppNCu+cp0LyaruTIlcOJvWQV1dvF8n986MdsRld8OsbbE?= =?us-ascii?Q?K+BLrDyEtCgaSpTDrdgbsAznuO1DQePfsv0BatSfGcr2aLyIgRldkP6A0mZb?= =?us-ascii?Q?MrFBP+vCxCdqAovzdEATIsKeaMelbLs1Um4zr+ybYoauQlPGD5Egzrug55PQ?= =?us-ascii?Q?aL93fqoiMGecCEjNSVyoTc7PnxjLS1MwxeeCJsal69CoesMGwga0qNL6vyRw?= =?us-ascii?Q?/TTUcPBQGBIAByjrPgFGDYKz8qsBhJZrfGAbv6CEGoFCD+Gt91DE+vzk2nhC?= =?us-ascii?Q?lubAvIJrrcdm/LbuOnqwGAF3KTIikXKYsLxCA/zlqWA1gq0ugb9l8iXrARNa?= =?us-ascii?Q?NO6RuNaiwvrNMG5NNz7iQb5xnuqnMYT0BViBkboflHjjeiU6GfK0zIZJfFIX?= =?us-ascii?Q?oeGK/f3r7zmvaoSivUIYcNF/yl8chCA5OzxTTHEdWlck+vKk4zUr/m7L7QB4?= =?us-ascii?Q?4+jQIc+HVCl1ZQSl9FWwg0qG6WLpiUmIGqugQ3a+IF1mVEsi0AGp4dm1Qo/l?= =?us-ascii?Q?U53BALXVpCb1Vorp2atpgyvcEhxepqG5Caffkt+O1swA4eHl8QcgCn9LvmFP?= =?us-ascii?Q?V/EY7Y+YIFbxbgebQ1Bmy/9hhDxXP96ZshhX2604b4nAwGbbQmw2054LMHhu?= =?us-ascii?Q?RVneKcvlfL5mlWYxxIo3TkOyoU1hAw+5SVCWCv5uff8wVY4AJvhX8lvbHl4S?= =?us-ascii?Q?pKMWpQtMeoBV8slc5d4e2MJWwXXWJv+3o2fgvhtEdg1aK407vWSW5a4JkwTb?= =?us-ascii?Q?9Pe8r4V7wgi5pymaxkISKP4rRs8yVu7cSQTioSd0q5/MMe1PMW+E1bqR9afG?= =?us-ascii?Q?a0PzVEo3RMTwtlZdqHbqbzOZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0379bb5-7528-4daa-1d76-08d960650a52 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 03:22:12.9448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rVVBCjgT39qkGYYI/UZS/vt0sbKMqr85RVrT20JiKBo6M2SLk2hqhrGU60TahPoAAhArh0ve087DV4SOCkkwQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4806 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH0PR11MB4885E0BFA841514E065D10128CFD9PH0PR11MB4885namp_" --_000_PH0PR11MB4885E0BFA841514E065D10128CFD9PH0PR11MB4885namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable TcgMorLockSmm is only for secure MOR V1. VariableSmm covers secure MOR V1 and V2. I think we can remove TcgMorLockSmm. Thank you Yao Jiewen From: Ni, Ray Sent: Monday, August 16, 2021 11:16 AM To: Zhang, Qi1 Cc: Yao, Jiewen ; devel@edk2.groups.io Subject: Why SetVariableCheckHandlerMor() is implemented in VariableSmm and= TcgMorLockSmm? Qi, I happened to find that there are duplicated implementations in VariableSmm= driver and TcgMorLockSmm driver. Do you know why the check needs to be done in two places? Can we remove the one in VariableSmm driver? Thanks, Ray --_000_PH0PR11MB4885E0BFA841514E065D10128CFD9PH0PR11MB4885namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

TcgMorLockSmm is only for secure MOR V1.<= /p>

 

VariableSmm covers secure MOR V1 and V2.<= /p>

 

I think we can remove TcgMorLockSmm.

 

Thank you

Yao Jiewen

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, August 16, 2021 11:16 AM
To: Zhang, Qi1 <qi1.zhang@intel.com>
Cc: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io Subject: Why SetVariableCheckHandlerMor() is implemented in Variable= Smm and TcgMorLockSmm?

 

Qi,

I happened to find that there are duplicated impleme= ntations in VariableSmm driver and TcgMorLockSmm driver.

Do you know why the check needs to be done in two pl= aces?

 

Can we remove the one in VariableSmm driver?

 

Thanks,

Ray

--_000_PH0PR11MB4885E0BFA841514E065D10128CFD9PH0PR11MB4885namp_--