From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.11342.1629873116422328560 for ; Tue, 24 Aug 2021 23:31:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ldSdyGqd; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="197032316" X-IronPort-AV: E=Sophos;i="5.84,349,1620716400"; d="scan'208";a="197032316" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 23:31:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,349,1620716400"; d="scan'208";a="527098430" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 24 Aug 2021 23:31:55 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 24 Aug 2021 23:31:54 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 24 Aug 2021 23:31:54 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 24 Aug 2021 23:31:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=niCxnXpbgXyiGH/uBHZX7ucrqXjRQtBPu7v6QmxUj8+aglFTELfZT0Yw4Gg3L7hmnJ7F99ALZyULWcNE1K///IxpwY5cqZhh3ldtS4BViOrLb0Gndy1p4EC1ynU8uYIIhfV5RxtBIAXR6FT2uaGzYJrM3heYhVqUxqhuEfo0o/fI93M/0yfrUDjiPexzShID40qAAQrOjcclo4TMa5BGfPmBqwHn/dqaI5LfyY3BqZdnGQQDgbF7ombbE5vBprw85qoqgDLDXX2p1bGZ3AurP8aAjpzlW+3p6vOW/B3sgJhavfPFrx7VyzC4MNdqvOhD1rUpQfKjtLYOUYawF8E4LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GiU6srb4CMAfVuBIkKYuJ9An8wl54gW2w3xLQWmhC3M=; b=AknfgLS/PLNb73sfNegDp6N12XAfhjvdqS3LKjxWhQ2kfnrontzznwF9CxLiyO9HOVk07WiwzHKOAjSTgVejYa5V2eRrhkdoy6ZPSGCKLNfkmUhlZ/kIbSKOrGMpi0oUF8jc0KUedrmovSXUYVChmGuRq7qc7iASo+4LOgKTP6Q3hUD/B9gceqZPbdi9DIchWZ95YroBQXsl9G3ZmJ/fwYkHbCBsN1O2IkbBDMS2gxpvETHicH7rzNk9hvbHGtdJ6L0w2rSWbUGST5myUTdBACvB0kLeyFXUTvhuXggLcIzHoA/bFpP9BIQZOKginfp/piL5YZ3I8rpl0HNfeeyqWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GiU6srb4CMAfVuBIkKYuJ9An8wl54gW2w3xLQWmhC3M=; b=ldSdyGqdLyLaRDn5+aVEAOFwwrWwntA6p4zlRbZsESkq0O/SCUmGBeS3w5xW1lSxGJvTZAhblKXM4Lbj3D23nIu4LlOcGFOavPOODFXrzTZ85wKAsHE4Hkn+1k3hE0kfqc/Ir0ovUxzoO7gaBJCu7FZ9J6BHptFd2+tKXu/CRO4= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Wed, 25 Aug 2021 06:31:51 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::e97b:e466:268f:fb79%6]) with mapi id 15.20.4436.024; Wed, 25 Aug 2021 06:31:51 +0000 From: "Yao, Jiewen" To: Brijesh Singh , "devel@edk2.groups.io" CC: James Bottomley , "Xu, Min M" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , Michael Roth Subject: Re: [PATCH v3 0/3] reuse the SevEsWork area Thread-Topic: [PATCH v3 0/3] reuse the SevEsWork area Thread-Index: AQHXk25ofQHFZD4IIk+WgV9BSaX1oquDzqkA Date: Wed, 25 Aug 2021 06:31:51 +0000 Message-ID: References: <20210817134651.20444-1-brijesh.singh@amd.com> In-Reply-To: <20210817134651.20444-1-brijesh.singh@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa517f73-71c3-4f3b-d02c-08d96792065d x-ms-traffictypediagnostic: PH0PR11MB4790: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5IHhwOT1fzCpZ1vsQOU541qeChw8RwJoNjMCnOLORPGpME83hs0on1BUK+MyUiQSioJl623BGA/bObDNLHnO1INFifqhVOI4DtxhbdGu6YW9LR1uUYDRU6r74kKirmFOQzG9yMJQrwZsIovWdkhwbfNhiBKlKP6u6AUsAnsSNfYPYNIRNr1IdbcchZY48JOa4wY8FkgC8PBa6Dz8S5is9yFpdlTkdHTurtDuPGFRbsUPqKWEXvD6BoxCRFGc6r31sY7MxTKz2JhC0Wh8BD81iSVW0+lbcWtcUOzhHcjWjg3hvsWQqpxatsDtWUp4D8ZrpegAsXA/WF/xsfdCIuh5SrAcFxBmtlZWrQr/MdG+H0ZEjpQ4ahQe+/we/qLn/X1GFdgzcEyA6/22fhWGvl78gP/cmxlaBTXZXE3YM2qVtF27WVP516cTh+9EbVndZ87pZZTxqtt1VYPfLBghq2nySV7/M0436uMjwwaPdbQUpA42TOFqtTw2QAuo+iB8hJuiwiDjCMe6CEW9taqHMKmVmS8hhfsH2W4IVOkvZEB9aCaQ82xzNQ7xRDLooAjMug75AT6H86Hhi0Yh5viFqNPLK0D38NSQTopp/jkSaQ2uKj1Dxng4fFY5cSbtOShwKG2UBv5x4Xdypv+EsyINa3LIHFBOHwt/uKDwhUywS4iF5HG0b8WH3F1RX+NE518EZdouonrxWfadSP1wdwbozDWkFLynDbpGsjfiYHqjR+NJIhT/+D9Wsx6Rhu/X+7acqWkcE77BVEs41T906QFY8Ksp4yTRClCoOOYNfq6HRmM0F9U= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(8676002)(52536014)(2906002)(26005)(186003)(38100700002)(478600001)(122000001)(7696005)(83380400001)(54906003)(110136005)(6506007)(53546011)(5660300002)(8936002)(316002)(966005)(19627235002)(4326008)(33656002)(66476007)(71200400001)(66556008)(38070700005)(66946007)(9686003)(76116006)(86362001)(66446008)(64756008)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lz3D+2kDg9jiM/ItzJAjcVT+gMkRhEB2TGWsYrhV8wl7u43iUczuC7ph0q8k?= =?us-ascii?Q?6VYxNxeNaNNqfDOu+IJwzUQqsgsj43/wrEnwyb5qwa/EGKhU2aQE0ZnSgIrz?= =?us-ascii?Q?cTbE3L/kFe7TNC2giIrB8oR9YOZPU5zEIDdtC6r7EwUrZVPSiyXshSh74dIw?= =?us-ascii?Q?HPoD6hYiygtYmGniKiB0NH1TnkIV5eI7eLpBodFfTm9lConXKo9isDH39a7i?= =?us-ascii?Q?BLIyqV3afXW30LZNf7Huq+mp4QgSyLTGQubl07wsGiVI30LKC6P7s1Y0Pwwj?= =?us-ascii?Q?962faScb/uQ6+DizB67bYE6rlmtoQ9IZHYKo/LWDP76odxr4szAJZ8snFRBI?= =?us-ascii?Q?cw1Z95PWcouz3sDqFOrmIxKOwXW3z0rvj73DNZ9rOw1Fu7h2UTA/uNWDf3oi?= =?us-ascii?Q?NSy3IwXBToJLsvmjf/w5zK2VGABxien5rPvs2bSzmo452r+kIjVTrJqGXEGC?= =?us-ascii?Q?+XEHFQ18yfkicnbOJ43AUlPtwe8NrFBiwquz1RLNW+Zv56qs6mEqNtJ7YBcV?= =?us-ascii?Q?WHJbkcJxDhb9RM73rp9uBsvflkpCJ74tKs8FrgUki2dY9caGqDa1EZ4PplRI?= =?us-ascii?Q?EYc9wA307+h6yUiYLlusABsyjdTH+o1CdSdGyLLtS7+OrVXfZwDkq/LD882O?= =?us-ascii?Q?RD5WA+sUVa1hkFf0awJOLNvjuTtbe2gxatZeWmm6FoaAJ/xC+y5Dq9HuFv1f?= =?us-ascii?Q?YWXpgk40uFs1Brs8RB1HUJi9ZK8rb/rQpymXRNMRXRI3SAi3QQXKl7NJFeO1?= =?us-ascii?Q?jSrWCZHG5jPGXN8qqYQipgkdVVCDdx8DuYbL1bNe6p1snUS3KZ/fcXetltPQ?= =?us-ascii?Q?WvrPfZcln9MXxAyP+S/uGismUCmlq73S2koAY2RHqRwwjD816pJ9CEZajVeB?= =?us-ascii?Q?0IcDxi8A0lPngnAO+Pe81wMLrT0x5YjFu6pIzbN4TQ4499B/3uIxSahXeyVq?= =?us-ascii?Q?lrzTZ9mfkL7SM/oK4TsZH3hTXWWeMDp9sPO2pC7iS2bsAYZDaTIDGvjcLn4f?= =?us-ascii?Q?25k5/yHj3G/w50+polIhFkZukiGZvC5RBaFjYN3uWIkxmg6j9tbdUB7TbWdi?= =?us-ascii?Q?le6U84rnmsw3oU954J2O7j7OdSHOeXxgUcH1iP+cMSdv+I66yF51ZQxgWtBW?= =?us-ascii?Q?cxy1dA/0FZ/bXSDY2pfPOLWhaypYHfwOjgAMbavXwvwR5kCr3QTUO5Gjt10i?= =?us-ascii?Q?A8/fLYlZFheIsY+FAGJdJmniPqF+rmiVJ/+nkbJhXLNtjnJH8l+clnGEitg2?= =?us-ascii?Q?5jdN+KPF4T72idZolQUm+X91LaW7KqBPIjVDiWQQ7DN3LusP14WIFUg88dhL?= =?us-ascii?Q?/6HBFBQTMHGyFgHqDK4ekW56?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa517f73-71c3-4f3b-d02c-08d96792065d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2021 06:31:51.7849 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +y6Hn+lDW4kb2koodZVXhnxtC5J0ulx+J9r02lUFn9ikC3jWf1TxoZIgWYdUEa7Afjp3XtpErVuvJ1l0mz3J/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you Brijesh. Reviewed-by: Jiewen Yao Since we are in code freeze, I will merge after we finalize the stable tag = 202108. Thank you Yao Jiewen > -----Original Message----- > From: Brijesh Singh > Sent: Tuesday, August 17, 2021 9:47 PM > To: devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Yao, Jiewen ; Tom Lendacky > ; Justen, Jordan L ; > Ard Biesheuvel ; Erdem Aktas > ; Michael Roth ; Brijesh > Singh > Subject: [PATCH v3 0/3] reuse the SevEsWork area >=20 > Based on the discussion on the mailing list, we agreed that instead > of wasting extra page in the MEMFD, we can reuse the SevEsWorkArea > buffer for the TDX. To avoid any confusion, lets introduce a OvmfWorkArea > that will contains 32 bytes of header followed by the actual workarea. >=20 > While at it, move the code to clear the GHCB page from PageTable build > to AmdSev.asm. >=20 > I have used the existing TDX BZ for it because the request came > during the TDX patch review. if anyone have concern please let me know > and I will happily create a new BZ. >=20 > Full tree is at: https://github.com/AMDESE/ovmf/tree/sev-new-work-area >=20 > Brijesh Singh (3): > OvmfPkg: introduce a common work area > OvmfPkg/ResetVector: update SEV support to use new work area format > OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm >=20 > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Erdem Aktas >=20 > Changes since v2: > - address Tom's feedback >=20 > Changes since v1: > - address Jiewen's feedback. >=20 > Brijesh Singh (3): > OvmfPkg: introduce a common work area > OvmfPkg/ResetVector: update SEV support to use new work area format > OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm >=20 > OvmfPkg/OvmfPkg.dec | 12 +++ > OvmfPkg/OvmfPkgX64.fdf | 9 +- > OvmfPkg/PlatformPei/PlatformPei.inf | 4 +- > OvmfPkg/ResetVector/ResetVector.inf | 1 + > OvmfPkg/Sec/SecMain.inf | 2 + > OvmfPkg/Include/Library/MemEncryptSevLib.h | 21 +--- > OvmfPkg/Include/WorkArea.h | 67 +++++++++++++ > OvmfPkg/PlatformPei/MemDetect.c | 8 +- > OvmfPkg/Sec/SecMain.c | 36 ++++++- > OvmfPkg/OvmfPkgDefines.fdf.inc | 6 ++ > OvmfPkg/ResetVector/Ia32/AmdSev.asm | 109 +++++++++++++++++---- > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 57 +++-------- > OvmfPkg/ResetVector/ResetVector.nasmb | 1 + > 13 files changed, 238 insertions(+), 95 deletions(-) > create mode 100644 OvmfPkg/Include/WorkArea.h >=20 > -- > 2.17.1