Re: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Tuesday, November 9, 2021 3:00 PM
> To: Xu, Min M <min.m.xu@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Brijesh Singh <brijesh.singh@amd.com>;
> Erdem Aktas <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe
> 
> On Mon, Nov 08, 2021 at 02:07:57PM +0800, Min Xu wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
> >
> > XenTimerDxe is a local Apic timer driver and it has nothing to do
> > with Xen. So rename it to LocalApicTimerDxe.
> >
> > After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.
> > Otherwise 8254 timer is used.
> >
> > Since LocalApicTimerDxe doesn't depend on OvmfPkg, so it is moved to
> > UefiCpuPkg.
> >
> > Patch #1:
> > Rename XenTimerDxe to LocalApicTimerDxe
> >
> > Patch #2:
> > Switch timer in build time for OvmfPkg. If CSM_ENABLE=TRUE, 8254 timer
> > is used, otherwise the timer is LocalApicTimerDxe.
> >
> > Patch #3:
> > Move LocalApicTimerDxe from OvmfPkg to UefiCpuPkg.
> >
> > Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v3
> >
> > v3 changes:
> >  - Move LocalApicTimerDxe to UefiCpuPkg
> >  - Fix the errors in v2 patch-1 that OvmfXen.dsc / .fdf and
> >    MicrovmX64.dsc / .fdf are not updated for new name.
> >  - Add XenTimerDxe reviewers.
> >
> > v2 changes:
> >  - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>