From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.8882.1636441435888384771 for ; Mon, 08 Nov 2021 23:03:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bCAxXoP6; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="318591434" X-IronPort-AV: E=Sophos;i="5.87,219,1631602800"; d="scan'208";a="318591434" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 23:03:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,219,1631602800"; d="scan'208";a="731672501" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga006.fm.intel.com with ESMTP; 08 Nov 2021 23:03:54 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 8 Nov 2021 23:03:54 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 8 Nov 2021 23:03:54 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 8 Nov 2021 23:03:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kfaJwFkeL966ZnePXoxyF+XpTyOKGKQ13DScGRq6IcQoUolPQgpKAdxrEKl96so6kBYK0X0PozuqODs42xR5JgFm7h9WGwxyY6YO+F4zoNQ0O10go1kZiCKi9m77To5x1sd615aZI0xvBBC9UbrS6rQVOqTcP9z1VtGVkYMZXUFlbUVcToigfldy1xD2GFku+70dw9EpRlpa42aNHR60y6ZXgzuQVPBgRhfhH0s6Pw2PZLQcNzn0t2v0D4IT4Ev7XZuNu8kYrM1kU584pgQv/UOdUlKGYoOnKpLVieMU3pcqHCRes0zeqN8LVcUvj6GtpfsmzspiWyyVCqycS+nXHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r+PZ5WrcmVfGW5XYoZoDifmpf50zGaC0qG89kztiEsk=; b=YiVp6vajkGBBKaw0pRHIQ84A01d46G9FaFNxZDGieICu3P2r5Es9iXy6DXdffEV8GLHkXhOBo1cMU6JDMJsGvsuf2NMW8AT4N4nVlRDw555SauABRVX+J+PpGq/c9eon0ycF0oKzhCNyQ1gLzmE6GztVwghz7QGtYZpA1gAJUxvcYH5Mwp3zNpDkiwqrut8hPQPc+K885/8LESusbOc7OUwYwCBL/KKYMIddoJhp8lHx7QGvwIy0oHawcO7EjcwhSJgWGUUZnSUTz76vW+1YnGKujZDbPBWpbMkDhgtn3HbJ3TsNu6lUNifYxUUZyvQLXm3QvQFcRxOq+ujuy+dNQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r+PZ5WrcmVfGW5XYoZoDifmpf50zGaC0qG89kztiEsk=; b=bCAxXoP6uH65LENow4aww12WBaL0NcqRDL13JscWpqhdPD23i8qREIzp4ZiTwXZLXjGIKRgHJ9pqMNMISjQR8EZHB56FO7b7B58PlWWSUbHyQKRvWBrEagb2xQ5snnY7yG7SYjll/xW3gdWM1ayw4megZ4DumdXdkz4OmoQ2/Vg= Received: from PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) by PH0PR11MB4950.namprd11.prod.outlook.com (2603:10b6:510:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Tue, 9 Nov 2021 07:03:20 +0000 Received: from PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80]) by PH0PR11MB4885.namprd11.prod.outlook.com ([fe80::c5cb:e37a:9f3:8f80%6]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021 07:03:20 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "Xu, Min M" CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , Erdem Aktas , James Bottomley , Tom Lendacky , "Dong, Eric" , "Ni, Ray" Subject: Re: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe Thread-Topic: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe Thread-Index: AQHX1GcKFc7kogPvPEKJ0nZ6Sib+NKv6xfQAgAAA8pA= Date: Tue, 9 Nov 2021 07:03:20 +0000 Message-ID: References: <20211109065946.ndeg4sloapkfgvz7@sirius.home.kraxel.org> In-Reply-To: <20211109065946.ndeg4sloapkfgvz7@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 660b0754-df2c-4a09-6275-08d9a34f0399 x-ms-traffictypediagnostic: PH0PR11MB4950: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s4/RhYHJPTocrpLaqB7CQZpopoD87bseMk1Osv570D21u3S9aGCb0PpN1DxR8d+N+w2/ht0PBdHc27WQ3kf0I109hzh6WSVmALNDWCWjK/E7GK0DTV5i5XMd/XA7FOtHoq+ALxsehdX+YUxBjPbNGXq8HOpipUmIAu8RfpF4Iodz+4+IuL/NJt2j6csnFS7wQR0zBh+0b2s/eox93H8Zdj4N2wyexAvYnRBDT4PyHny4lsLl6J0osFwpmtgTrBhRJDmUjUyQGtZeaa46KplNuUVU3WODO0jov/pCDKG2VvQ9AzNCy+MXkt7hzbvnLxuA9EU9e9Mbphlop+1p4hmdhcSk6a6rnGLQTE2B13B5gTIuChhTrImtLzRm7ENWcqjkmvlrSlfHChvn0kBOM+XsG9sIu60eoIf/lC2EsyV58zuze+FUquFEt+EcwreBrCsoXGA/zvcQynLiOZMQgFbQL88bhf98ejHBoJJIFmPV5RNztiw/NPPCOx/CMBitTcl/fJnxE+j20yWK1B7pvJ6dAgAO+1T8hLoIQkE8PyqBIdegQD/BGgowESA1llV78RPyciHk+Nm5ln9G6cLhWJPr9VUIxparRMcmikWvRfF5tYXETWKx2qGsMOlxWjNWRcCQe93Fr0fNvQ2cuhIo0KP63vU1mzmy5OvU6DVka9QjjF79GvRvTfAi2EuF1/9raYtueSmv98CKD6dZq3AAqB08HwbqoWjCGeZXryyeAWg3OD2bMlBtHu0Q0Q+CvgI2j9AkEQG/fqwF1hVhkUVUcXz4deMPvmkNZVMZG3AXdfvyUlExPiHI7cJziOyz42cKnyRSR608Sq6Xy4x0NOc92ySSNQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4885.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(6636002)(8676002)(4326008)(9686003)(64756008)(83380400001)(66476007)(55016002)(110136005)(508600001)(6506007)(33656002)(2906002)(5660300002)(66946007)(8936002)(76116006)(66556008)(7696005)(316002)(186003)(86362001)(38100700002)(122000001)(38070700005)(82960400001)(966005)(71200400001)(107886003)(26005)(52536014)(66446008)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fP9N8TlBzl1vQUDUBjqEK5/VePnpgBpmo+RZul9rwP/6cEX69huKye5wPd3o?= =?us-ascii?Q?yrxXMOJJ4xIf4mbh6w17SBr3svTQ0X5mp9+5z4thpvnMh6Lr2T0xHU/oknAu?= =?us-ascii?Q?UFWrByUeAUh4+7Cz4WIL4trirl6ru0nwa3NQVm7OrTDBMsVEkGddtrCHeHaR?= =?us-ascii?Q?1Mx9WPYXdr65pWQ8b11zjMmd4DP8BFOo0eN4poYB2AfcKNcJ5KITwcnca3CS?= =?us-ascii?Q?uzmctAwxKQtpvJx5p56A+xW+HdZd8SO3dFTokjZUWrW1Q44W+UutkF/KcDYo?= =?us-ascii?Q?KSsFEhPvJCOmAwRcIdUc5U/dmiSXQ5bdPajDYRu0PDUOO/Vs573Fpb4/1NMi?= =?us-ascii?Q?hkjehGEpw5X83Ist5rF4EBJZ/C3ZcCMWZIN+8yASolIrvvIxHmKGpx6ekfoa?= =?us-ascii?Q?5w96wLohfspnVoUM1pDnzXAWL/d71OUy2WOqgUUi/mt6PLtYPxWk8Tx5PXSn?= =?us-ascii?Q?3mBjsgOx0PaRCoRlEGge7oYyDfapX0Ogqeg7NEvUEdHFSnGc5ztVbtqXcmNB?= =?us-ascii?Q?/RREoBfU3Dog0547fxIQ8Fhwmb1XtsRiMwd4S6F1obUU1AS7fC9WK2zv6MnI?= =?us-ascii?Q?jFGiz3DTqHeIHZXLUg0H6UDnowBm+39YKyanA3zPVOBj28c9O2T103Ahc57b?= =?us-ascii?Q?pHJ5rG2wEogfcnAB9JujO23DbtTn6sn0J2tEHy1zlWtG3BCMeAEqCIMQijT/?= =?us-ascii?Q?FmYwHVHRXMuZbSsT6kstkDh+n39nF6pQl6EUyAm9jwVHEu2ztbqUeo7/jdo7?= =?us-ascii?Q?UUJiX+fm6eR0dSSjb+n5ayzzEqzSIp90v1qCAaU/vP+qLTC5ZTPX8wo7DMXn?= =?us-ascii?Q?beTJ3yzyWGsh6bgW6hrfiMY46ihDwrCzPkG22xbrtGdgD4iDpsXL5iqJG8za?= =?us-ascii?Q?eYVn7IL7Hqxi3CP2/oBD5+Vd53L3VY0SUsT/elwUs2ZMNh5y50LRX5mqumvO?= =?us-ascii?Q?VTgO4ifRlP8ZY6zd69694zNFAie4ma5xM2TiGcui2MglcR7nosP1xECuYdC3?= =?us-ascii?Q?GFLsqViCMNKn7sfMwIoFR5BnTc8Zu23j3Aq77L9WVa3CVhsDDTaJAL8qXvJq?= =?us-ascii?Q?nr2wExzyhN2vR51ksjYJy45UHMJUnX+v9Wk8krD3Yekx0aPAwks/YEXxHY4+?= =?us-ascii?Q?mOb+VlvWoYgoBn5NIwrehfSMEoWzT9fzcL2bLad6rjY+OraxAl4uAGfyvk2P?= =?us-ascii?Q?iNElxxotwOhxQq8/ChxeHwhmvkESt6p9lC1kTj/86qNTh4pIWJatB1hGNoM7?= =?us-ascii?Q?ybWxVwzR9cRMbhCY9jvgPJ5cXbq9QRjcTeS35kNrHZ1MoTrAeDc4U3bnHYP0?= =?us-ascii?Q?R3qn8JAi4t98mMFn/Z8x9YN6EorziJr9V97F2y5F545lBLF57GkT5QJUHcWk?= =?us-ascii?Q?KooEa33F57OaKO6FVWn0c4tlsjAkwrYW0iB5ZB1AhgWX16fmB4QBX1XRBDOM?= =?us-ascii?Q?BEsGBadv1WotoJqlJRNd7bTPwH2lhJouAXPVsNgupo97BstMqa22s0iHs9S0?= =?us-ascii?Q?bJPh7PUQLCD2kWiept4HKZ8xx4RyNRpmPxWfzOKLU7LftGG2pOL8PZFsiBBb?= =?us-ascii?Q?S08tAMjPo82Cark+wXHIT7iJ07h2LdRdqNJNt5Wt+Li1LfWGjFlXWKoT03AQ?= =?us-ascii?Q?kcA8MBKh0XygmeU2LcYSxms=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4885.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 660b0754-df2c-4a09-6275-08d9a34f0399 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2021 07:03:20.5881 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4WfQl5J2dqZ93PNyEi0RbCeYcykb7aQOlprdpVIw20kZXe0vkI0jn1wSgmLqcIqVHtwJfFcGbEtuMFA20eMS3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4950 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Gerd Hoffmann > Sent: Tuesday, November 9, 2021 3:00 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Jus= ten, > Jordan L ; Brijesh Singh ; > Erdem Aktas ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Dong, Eric ; Ni, Ray > > Subject: Re: [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe >=20 > On Mon, Nov 08, 2021 at 02:07:57PM +0800, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3711 > > > > XenTimerDxe is a local Apic timer driver and it has nothing to do > > with Xen. So rename it to LocalApicTimerDxe. > > > > After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=3DFA= LSE. > > Otherwise 8254 timer is used. > > > > Since LocalApicTimerDxe doesn't depend on OvmfPkg, so it is moved to > > UefiCpuPkg. > > > > Patch #1: > > Rename XenTimerDxe to LocalApicTimerDxe > > > > Patch #2: > > Switch timer in build time for OvmfPkg. If CSM_ENABLE=3DTRUE, 8254 time= r > > is used, otherwise the timer is LocalApicTimerDxe. > > > > Patch #3: > > Move LocalApicTimerDxe from OvmfPkg to UefiCpuPkg. > > > > Code at: https://github.com/mxu9/edk2/tree/ovmf_lapic_timer.v3 > > > > v3 changes: > > - Move LocalApicTimerDxe to UefiCpuPkg > > - Fix the errors in v2 patch-1 that OvmfXen.dsc / .fdf and > > MicrovmX64.dsc / .fdf are not updated for new name. > > - Add XenTimerDxe reviewers. > > > > v2 changes: > > - Add gEfiMdePkgTokenSpaceGuid.PcdFSBClock in *.dsc > > > > Cc: Ard Biesheuvel > > Cc: Jordan Justen > > Cc: Brijesh Singh > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Gerd Hoffmann > > Cc: Eric Dong > > Cc: Ray Ni > > Signed-off-by: Min Xu >=20 > Reviewed-by: Gerd Hoffmann