From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Chang, Abner" <abner.chang@hpe.com>,
"Schaefer, Daniel" <daniel.schaefer@hpe.com>
Subject: Re: [Patch 3/6] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM and RISCV64
Date: Wed, 3 Nov 2021 05:28:37 +0000 [thread overview]
Message-ID: <PH0PR11MB4885F7D4D120BE44E5E4A6978C8C9@PH0PR11MB4885.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211103030542.1529-4-michael.d.kinney@intel.com>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
Need ARM/RISC-V owner to confirm.
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, November 3, 2021 11:06 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Ard Biesheuvel <ardb+tianocore@kernel.org>; Chang, Abner
> <abner.chang@hpe.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>
> Subject: [Patch 3/6] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM
> and RISCV64
>
> Fix SecurityPkg build breaks for ARM and RISCV64 by adding RngLib
> mapping.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> SecurityPkg/SecurityPkg.dsc | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
> index 37318c64c59f..73a93c2285b1 100644
> --- a/SecurityPkg/SecurityPkg.dsc
> +++ b/SecurityPkg/SecurityPkg.dsc
> @@ -84,6 +84,14 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64]
> # Add support for GCC stack protector
> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>
> + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +
> +[LibraryClasses.ARM]
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
> +[LibraryClasses.RISCV64]
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
> [LibraryClasses.common.PEIM]
> PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
> PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> @@ -381,4 +389,3 @@ [BuildOptions]
> MSFT:*_*_IA32_DLINK_FLAGS = /ALIGN:256
> INTEL:*_*_IA32_DLINK_FLAGS = /ALIGN:256
> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> -
> --
> 2.32.0.windows.1
next prev parent reply other threads:[~2021-11-03 5:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 3:05 [Patch 0/6] Fix package build issues Michael D Kinney
2021-11-03 3:05 ` [Patch 1/6] DynamicTablesPkg: Add missing BaseStackCheckLib instance Michael D Kinney
2021-11-03 12:12 ` Sami Mujawar
2021-11-03 3:05 ` [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64 Michael D Kinney
2021-11-03 5:36 ` Daniel Schaefer
2021-11-03 21:25 ` Maciej Rabeda
2021-11-03 21:36 ` Michael D Kinney
2021-11-03 3:05 ` [Patch 3/6] SecurityPkg/SecurityPkg.dsc: Add missing RngLib " Michael D Kinney
2021-11-03 5:28 ` Yao, Jiewen [this message]
2021-11-03 5:37 ` Daniel Schaefer
2021-11-03 3:05 ` [Patch 4/6] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping Michael D Kinney
2021-11-03 5:37 ` Daniel Schaefer
2021-11-03 3:05 ` [Patch 5/6] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues Michael D Kinney
2021-11-03 14:00 ` [edk2-devel] " Philippe Mathieu-Daudé
2021-11-03 3:05 ` [Patch 6/6] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds Michael D Kinney
2021-11-03 14:01 ` [edk2-devel] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB4885F7D4D120BE44E5E4A6978C8C9@PH0PR11MB4885.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox