From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.2459.1625034998439595300 for ; Tue, 29 Jun 2021 23:36:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lS7+6cDG; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10030"; a="293933783" X-IronPort-AV: E=Sophos;i="5.83,311,1616482800"; d="scan'208";a="293933783" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 23:36:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,311,1616482800"; d="scan'208";a="408693108" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 29 Jun 2021 23:36:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 29 Jun 2021 23:36:36 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 29 Jun 2021 23:36:36 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 29 Jun 2021 23:36:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GV63gaAfLtcuCn0qQkHPR4vX7YkdIGk07XLeOuo6sojwDKbQL6hLVTKSVwqU//pD851SKgIAHNIhpHwqZaJvd/Tmn05n+lG2YHdozzqzN3a/SwHvSMk8DMPNwpppnY1oLbbFk4PPTyF7iR3JSz2pp/AyJDK+PGlBYUtg1dvPpoCD7ehb2LwKx+AHrZQaM+ujPDyfp0X5aOhF941B4oPkyQFXkXh4t7lkflltg3htyd2b7WY3AHBOGhrVphsH3+b47M4bRFfWKL3aGbujpdeSyC8yEzLr+/84PhsmG7fdo5gVy0ameBgw0jEZXe4KSi0cE7n7fjYuqGuRDNfR3Nscqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDDa3WEOYP8eFlQsEmGSu2xR/+PH3YnIJTzeyrbm0wc=; b=gQ90WAJldKqvwvs6HqUNANQhf8O5RghK9ChuJE76QSJDl/gGVKPCxEzct+5yr7cvThVExfdwYfGRHgS58llwTMlJEBKerDFBKl0/eX/VvBaUbo5jndEz2VnCFQkNxG2QyocOPLVFV5vXDFDCIIrS50Id8BKE0pbK5B/lxFAPuDu7dMavZA2LLIFle+l3xzrQ+K683oqg0+MyfQM1nYrELRef+5jbPkRq61gM5ECeAVZ2toBWM8YwJJ7jyQmZ1O7NG6GwfKrJSRQ/K/O60R0c7ljPAZYPVnpXGeJF/ISejhKVO37+DFljT+SFUWXxDoIYVi7yDM8CGrgo2NV8iqFaxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDDa3WEOYP8eFlQsEmGSu2xR/+PH3YnIJTzeyrbm0wc=; b=lS7+6cDGmEzNbxrHMVc9k5vamyGt4oLaF9R5Sq2Pv/V8N0MVfJiUOQPXkaSVKAhFOIacvoRH924TknI1OpvgvW480ZgBvSPXhC9Tpn1C6W7eKKc4kEv5lTyzOfE9GektODHgTsjUMXXSLscS2/FQFd8Ue8VjTtHmEi15ZL3MCHM= Received: from PH0PR11MB4936.namprd11.prod.outlook.com (2603:10b6:510:42::20) by PH0PR11MB4951.namprd11.prod.outlook.com (2603:10b6:510:43::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Wed, 30 Jun 2021 06:36:34 +0000 Received: from PH0PR11MB4936.namprd11.prod.outlook.com ([fe80::d19b:9189:d5f9:94d]) by PH0PR11MB4936.namprd11.prod.outlook.com ([fe80::d19b:9189:d5f9:94d%6]) with mapi id 15.20.4264.026; Wed, 30 Jun 2021 06:36:34 +0000 From: "Ni, Ray" To: Yang Gang , "devel@edk2.groups.io" CC: "Dong, Eric" , Liming Gao Subject: Re: [PATCH] MdeModulePkg PiSmmCore: Change MemoryAttributes message to DEBUG_VERBOSE level Thread-Topic: [PATCH] MdeModulePkg PiSmmCore: Change MemoryAttributes message to DEBUG_VERBOSE level Thread-Index: AQHXbXR53Hkm2+Wa206m8jC8+O9XqqssGY0Q Date: Wed, 30 Jun 2021 06:36:33 +0000 Message-ID: References: <20210630055406.559-1-yanggang@byosoft.com.cn> In-Reply-To: <20210630055406.559-1-yanggang@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2bb610cc-e072-45ae-c1b4-08d93b916768 x-ms-traffictypediagnostic: PH0PR11MB4951: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z7VMC3ZzGxvmJzvtKQjCfQ5u4OWU6WiaQQgyMswI/0mOUytajdslwG57N0lD1T+Qk4dlMSdtVu1tK0U8x7XwEW9Gnro3XiGCHwO39nwc8ytyNmh7CMQeTbP2Pf7dyk8tIz60xRFjqD97Gzwkru+creEBaOrbl1CJZbOWNZoVDAb7qjmp11HfelOgeHc3Kk5Cv53p0iSeYzU+UtxjPp+8219pcYgPAzZftBWcGChRKPMUhHyyNwIKxcj0pPsmdRHnNYPMFOfiVf9gAFNBC0fjE4GpsMte5LIpag5PVW+TkTBYs+1rjGJmca9WTOo2E+022kgbZ0g8byyw5EIbXf6dPZYOUVw6m8vjXyImflE51KT9hRnxhaqv7jdANhRsde7s+tW5QPrmZqTkYLNUPKiBiPgTlq3CNbPHVPczAHeizZFiE732HC59tcYOeSI4aQ9ME7zfpE6bQBe6JUwYSw1/DBonWhlw3XciAUA1KouMHT/43zBRY4cnEioNEsU0eG8kh0ja2ftN+O+QmO7Vk9IlJIjEXslvHnDBtrwINYDUvaUeBTQ6oJiIgwQ6ZWoChnqbl+KNrfCWSUIr+zE79d/HlE5gvSnAZBx84vnorLOyiiUL+XBZXn/HGSOJwlNY0DXbrVraX9bmnRp3ay2TZRrJkw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB4936.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(136003)(366004)(346002)(396003)(376002)(39860400002)(76116006)(55016002)(5660300002)(8936002)(26005)(186003)(33656002)(15650500001)(8676002)(71200400001)(66946007)(316002)(478600001)(54906003)(83380400001)(53546011)(86362001)(66556008)(52536014)(64756008)(7696005)(66446008)(9686003)(4326008)(110136005)(66476007)(122000001)(38100700002)(6506007)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mBRFP7mMtpUuMxfovvSvsE+pkdC4r+rdumR7aq8EzjZTpcT0it5vNp7S18EM?= =?us-ascii?Q?Z27roctTBiuxXywpyWY6Mqk2KCWpG7yUH/zSaWsvIBLaN3N6Qg11dTYPAkZu?= =?us-ascii?Q?iJ2IrqpNE65uMxwMnKbzMLxW1465AW5WBrHao+C9qvqMCMWWqfkQk9mOQkP0?= =?us-ascii?Q?bbiJdazb91QaTE0bofd52S8Kg9iQ9zbv8dMf9PEYrba19dj1uRu7j2rcPM3j?= =?us-ascii?Q?b1Fxw3N1anSfP6hfq2qLX32VYW2UAd4tqpsd0l50tmoH89uCVwnbMe4p8ZVZ?= =?us-ascii?Q?JjLfQGRkO0pKk+ZAiJECS9TP+XGoAo07LFUwxh/OtJvpDMs66cdAVW/uTR9r?= =?us-ascii?Q?7qxLfb6dbiGUUZysNS/F9u9JmtQQMLfW59pSfIKNPP/5BBFYLAN8l+JAdztq?= =?us-ascii?Q?Bdli3VkXvBokoYUoh0LRa1H6mkpiyflWltJse1XHFk1A5zS6oidu12aXtXhk?= =?us-ascii?Q?KBfSYbjLdnxM5rOgymmIyaaJxDKKr+gVIf87qkod+T8p4MMw3Zoyxu8cxc/J?= =?us-ascii?Q?76Gj4b+3dkN21a5gkGdKYg3zdE2j2LlwjDI0E+9TONycHSsnDY+/lms63swr?= =?us-ascii?Q?UushRKG5/TazmQ7lcG/hpePC8qp2/q51Q6s6dCuhy2TIfGIRQuW8UzPELtw4?= =?us-ascii?Q?EjUFILYlZbUIeYiWeXfNl99MaRVows/UZxBu2WePeSvSvfg8N2JEykOxrRCi?= =?us-ascii?Q?gfQ/CxnxpjBts6E07ao1D02XLhC9RuGJtghbJU491UkkU5MV6WyINkS6qM4U?= =?us-ascii?Q?SNEff4wz15AfEg8LNjygn0HUV+1czt//urDtxIw+R1cwRiYRq+SRQ52HE1wx?= =?us-ascii?Q?5CwEJlIr5dK9XKTN1IIIzPgdbTnjAMtcVt3uN9ceA2l8F9tg4rFKCA49mg7T?= =?us-ascii?Q?0ymS+vD3gEbde/h7yNVMfDakh8MC7lWAPS4/4fuor6PNunamtObNrYKhRLo3?= =?us-ascii?Q?t3EgAxlJPVZS6ox7wNLhgGRwZYIRtC4gi9pSe2FpIbKOuNrr1JJM6TB/H2yx?= =?us-ascii?Q?Pnt91W6rLEgSWzWpsdG8DkslGiExtToTMp08YjCJ1CFrQBnjeWRPta9GhBGG?= =?us-ascii?Q?knlHFNujPSmFfof9h92/a+QmgFSe7FdbHx6vZzj6gno1NJS8EvH0yzlg1+IG?= =?us-ascii?Q?LVUMGAhmdKN7+xyvSbcEGgkgpMsZvwSS8YGT+1OYt1xK8O8AM4V3BcIS9tmo?= =?us-ascii?Q?S92hu9/ZyS/ozUti6B4Y3on7zMQirmaNNrMqv55kQxkcoiqcxvvNLw0jiMAS?= =?us-ascii?Q?DRQQviuRinp0GJUjdYIBASj+C5/4sr21owbF0zKpT/VLKaqqDZ84If9zlvKB?= =?us-ascii?Q?6Dco/Kjjqh9tg2d0ThLTTgkd?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4936.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bb610cc-e072-45ae-c1b4-08d93b916768 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2021 06:36:33.9367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g2hs9uEaVHX6zh0OnM49VNme/f1QuLd0/5aELjPr2YmSKd5IRdqQA/X5W8rsM/6+JARNPYkT+zFZhBrEFrxnWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4951 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Can you explain why VERBOSE is chosen instead of INFO? Thanks, Ray -----Original Message----- From: Yang Gang =20 Sent: Wednesday, June 30, 2021 1:54 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Liming Ga= o Subject: [PATCH] MdeModulePkg PiSmmCore: Change MemoryAttributes message to= DEBUG_VERBOSE level Signed-off-by: Yang Gang Cc: Eric Dong Cc: Ray Ni Cc: Liming Gao --- .../Core/PiSmmCore/MemoryAttributesTable.c | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c b/MdeModul= ePkg/Core/PiSmmCore/MemoryAttributesTable.c index de8262ecb9..3e8a80dd7d 100644 --- a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c +++ b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c @@ -1208,10 +1208,10 @@ PublishMemoryAttributesTable ( ASSERT (Status =3D=3D EFI_BUFFER_TOO_SMALL); =20 do { - DEBUG ((DEBUG_INFO, "MemoryMapSize - 0x%x\n", MemoryMapSize)); + DEBUG ((DEBUG_VERBOSE, "MemoryMapSize - 0x%x\n", MemoryMapSize)); MemoryMap =3D AllocatePool (MemoryMapSize); ASSERT (MemoryMap !=3D NULL); - DEBUG ((DEBUG_INFO, "MemoryMap - 0x%x\n", MemoryMap)); + DEBUG ((DEBUG_VERBOSE, "MemoryMap - 0x%x\n", MemoryMap)); =20 Status =3D SmmCoreGetMemoryMapMemoryAttributesTable ( &MemoryMapSize, @@ -1236,19 +1236,19 @@ PublishMemoryAttributesTable ( MemoryAttributesTable->NumberOfEntries =3D (UINT32)RuntimeEntryCount; MemoryAttributesTable->DescriptorSize =3D (UINT32)DescriptorSize; MemoryAttributesTable->Reserved =3D 0; - DEBUG ((DEBUG_INFO, "MemoryAttributesTable:\n")); - DEBUG ((DEBUG_INFO, " Version - 0x%08x\n", MemoryAttribute= sTable->Version)); - DEBUG ((DEBUG_INFO, " NumberOfEntries - 0x%08x\n", MemoryAttribute= sTable->NumberOfEntries)); - DEBUG ((DEBUG_INFO, " DescriptorSize - 0x%08x\n", MemoryAttribute= sTable->DescriptorSize)); + DEBUG ((DEBUG_VERBOSE, "MemoryAttributesTable:\n")); + DEBUG ((DEBUG_VERBOSE, " Version - 0x%08x\n", MemoryAttrib= utesTable->Version)); + DEBUG ((DEBUG_VERBOSE, " NumberOfEntries - 0x%08x\n", MemoryAttrib= utesTable->NumberOfEntries)); + DEBUG ((DEBUG_VERBOSE, " DescriptorSize - 0x%08x\n", MemoryAttrib= utesTable->DescriptorSize)); MemoryAttributesEntry =3D (EFI_MEMORY_DESCRIPTOR *)(MemoryAttributesTabl= e + 1); for (Index =3D 0; Index < MemoryMapSize/DescriptorSize; Index++) { CopyMem (MemoryAttributesEntry, MemoryMap, DescriptorSize); - DEBUG ((DEBUG_INFO, "Entry (0x%x)\n", MemoryAttributesEntry)); - DEBUG ((DEBUG_INFO, " Type - 0x%x\n", MemoryAttributesEn= try->Type)); - DEBUG ((DEBUG_INFO, " PhysicalStart - 0x%016lx\n", MemoryAttribut= esEntry->PhysicalStart)); - DEBUG ((DEBUG_INFO, " VirtualStart - 0x%016lx\n", MemoryAttribut= esEntry->VirtualStart)); - DEBUG ((DEBUG_INFO, " NumberOfPages - 0x%016lx\n", MemoryAttribut= esEntry->NumberOfPages)); - DEBUG ((DEBUG_INFO, " Attribute - 0x%016lx\n", MemoryAttribut= esEntry->Attribute)); + DEBUG ((DEBUG_VERBOSE, "Entry (0x%x)\n", MemoryAttributesEntry)); + DEBUG ((DEBUG_VERBOSE, " Type - 0x%x\n", MemoryAttribute= sEntry->Type)); + DEBUG ((DEBUG_VERBOSE, " PhysicalStart - 0x%016lx\n", MemoryAttri= butesEntry->PhysicalStart)); + DEBUG ((DEBUG_VERBOSE, " VirtualStart - 0x%016lx\n", MemoryAttri= butesEntry->VirtualStart)); + DEBUG ((DEBUG_VERBOSE, " NumberOfPages - 0x%016lx\n", MemoryAttri= butesEntry->NumberOfPages)); + DEBUG ((DEBUG_VERBOSE, " Attribute - 0x%016lx\n", MemoryAttri= butesEntry->Attribute)); MemoryAttributesEntry =3D NEXT_MEMORY_DESCRIPTOR(MemoryAttributesEntry= , DescriptorSize); =20 MemoryMap =3D NEXT_MEMORY_DESCRIPTOR(MemoryMap, DescriptorSize); @@ -1= 331,7 +1331,7 @@ SmmInstallMemoryAttributesTable ( { SmmInstallImageRecord (); =20 - DEBUG ((DEBUG_INFO, "SMM MemoryProtectionAttribute - 0x%016lx\n", mMemor= yProtectionAttribute)); + DEBUG ((DEBUG_VERBOSE, "SMM MemoryProtectionAttribute - 0x%016lx\n",=20 + mMemoryProtectionAttribute)); if ((mMemoryProtectionAttribute & EFI_MEMORY_ATTRIBUTES_RUNTIME_MEMORY_P= ROTECTION_NON_EXECUTABLE_PE_DATA) =3D=3D 0) { return EFI_SUCCESS; } -- 2.23.0.windows.1