Re: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3898 S3 Resume flow may result in executing garbage address.

Re: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3898 S3 Resume flow may result in executing garbage address.

[cbduggap]

HI all,
Please help to review the changes 

Thanks,
Chinni.

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of cbduggap
Sent: Friday, May 20, 2022 3:20 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
Subject: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3898 S3 Resume flow may result in executing garbage address.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>

Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
---
 MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
index 2c19f1a507..16319e2fd3 100644
--- a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
+++ b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
@@ -288,6 +288,7 @@ DxeLoadCore (
         EFI_ERROR_CODE | EFI_ERROR_MAJOR,         (EFI_SOFTWARE_PEI_MODULE | EFI_SW_PEI_EC_S3_RESUME_PPI_NOT_FOUND)         );+      PeiServicesResetSystem2 (EfiResetWarm, EFI_SUCCESS, 0, NULL);     }      ASSERT_EFI_ERROR (Status);-- 
2.36.0.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89914): https://edk2.groups.io/g/devel/message/89914
Mute This Topic: https://groups.io/mt/91227575/5000832
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [chinni.b.duggapu@intel.com] -=-=-=-=-=-=

Re: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3898 S3 Resume flow may result in executing garbage address.

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

I guess this is to follow Liming's recommendation said in the bugzilla.
But I don't understand why reset is better than deadloop().
reset IMO is a silent failure if S3Resume2 PPI doesn't exist.

[-- Attachment #2: Type: text/html, Size: 204 bytes --]