From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A549BAC0CDC for ; Thu, 9 May 2024 08:29:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1XjyF2jbzb/Bc4J1KVCVguZ8X03M43k3X7/4amCMOBM=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715243384; v=1; b=VVcRCmie5RIyJutAZhM8D7y+rsNbcdrmXjNCz20oNwiTKy5xXT0DlAoDVIliUZlz2cG3o3Ad zTZB9rqXUdVi0tJ4osB2VxPQKAr8wzziPyCgJd1vDEgig8wXkLbtF9N8hhXnTFrMiFsub3MCftn 3CKsflOhrI+QuQ//HGZMAIjGik+4N6q46bi+Fmzs5uWELYCPTWP9U95SohuYOwL0fps/8fVZMOD nJx9e+EcIiq3g0Ou9jQR7FjlYtB0ZUD2TQtYy6ZyAV4xynCtWf0IzlmBvR36gWqauKdRDcKDdp6 fbLSeDYiJtEh53dunHU1ReUtVK/Pvk1zvOaGkt3BEOJPQ== X-Received: by 127.0.0.2 with SMTP id AInvYY7687511xFzXBp7BzcW; Thu, 09 May 2024 01:29:44 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mx.groups.io with SMTP id smtpd.web11.5285.1715243383070339453 for ; Thu, 09 May 2024 01:29:43 -0700 X-CSE-ConnectionGUID: 4qD3/sZXReae1y2XbMf4hw== X-CSE-MsgGUID: mzdCzk/7RB25blzegRK7xg== X-IronPort-AV: E=McAfee;i="6600,9927,11067"; a="11087779" X-IronPort-AV: E=Sophos;i="6.08,147,1712646000"; d="scan'208";a="11087779" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 01:29:30 -0700 X-CSE-ConnectionGUID: XYPqNlQqQ/moeSU4C3LLqA== X-CSE-MsgGUID: VhEgF35ZTeWwnMsBAYdk1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,147,1712646000"; d="scan'208";a="33733865" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 May 2024 01:29:30 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 9 May 2024 01:29:30 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 9 May 2024 01:29:30 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 9 May 2024 01:29:29 -0700 X-Received: from PH0PR11MB5046.namprd11.prod.outlook.com (2603:10b6:510:3b::20) by MW6PR11MB8390.namprd11.prod.outlook.com (2603:10b6:303:240::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.45; Thu, 9 May 2024 08:29:27 +0000 X-Received: from PH0PR11MB5046.namprd11.prod.outlook.com ([fe80::ae9e:f9e:2825:244c]) by PH0PR11MB5046.namprd11.prod.outlook.com ([fe80::ae9e:f9e:2825:244c%4]) with mapi id 15.20.7544.047; Thu, 9 May 2024 08:29:27 +0000 From: "Wenxing Hou" To: "Li, Yi1" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , gaoliming Subject: Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls Thread-Topic: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls Thread-Index: AQHaodnrXfmkckXYd0CSXhplPh6bMrGOd5vAgAAaC1A= Date: Thu, 9 May 2024 08:29:27 +0000 Message-ID: References: <20240509062700.2062-1-wenxing.hou@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5046:EE_|MW6PR11MB8390:EE_ x-ms-office365-filtering-correlation-id: 1bb5495a-2e4c-4a4b-bc96-08dc700223c9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?GHxq3HWgb19DOguSncQPiYuFrDGcpaBu2iUVJqnsf7NrmLEFfeE3zs7G8cwi?= =?us-ascii?Q?eWMKmJWMaXYJJ7SrmwT1n8CkLBT4Ax2yKUH8NGStssIATosZ2FqW1oQ6gNht?= =?us-ascii?Q?FTbIayMWmhiMhTwsEbtplubS01/brnvWQ1I2q3ZKzc0hkewv2X3O3f5VNGem?= =?us-ascii?Q?0vFTpNJiQo2wc/sYQ1iAcX0O0G7ZqvXyYBGbfnvu6w7YXC3XTVWQrCykp03f?= =?us-ascii?Q?vZU3BWSOuyBPApn44+NltZusOtix37X7xLWRdyBOHN+AppuuSKW3GZs9YGjY?= =?us-ascii?Q?IshrwjJ4Z+GOauaLl2ypAjF2thoga6YvocAO998anfuM0fftkdi+Dspaqk4w?= =?us-ascii?Q?k5XXNWilp5K/nB4pf8miyYElOFhPwEps1tGlLbWqjdgUpUbZ9HswhCumZveb?= =?us-ascii?Q?h3ntKYOAzK2WBwhFbLONc3C2kVilWOMukRSvHDgYXeeYH9hRlX9Y2jdyx2/U?= =?us-ascii?Q?+aL11B1Gh768TI8u0TM/y6SBdptycnBUlyiqRfoVVr6trquc1flPORHQ3gkc?= =?us-ascii?Q?DU5p9niQgC9kOpxhPNsPHURqKUA8tD0uDqSYyyiHUeRTfqwLbxh2jMfg8OgN?= =?us-ascii?Q?VgZpKqQ+TH12Dv+7+5W2MdHgb2te82A05Zc80Z7R9dXhe1imScQiMfgFRIXw?= =?us-ascii?Q?tQZ0criDak9afXUgD3YN8SNC8It8PMB8izYi7BKdJT0iaxgwDuhtqHwsnJDn?= =?us-ascii?Q?s9jSG/luMbtFyTKYB3i0M4m1CFnyWXzIkFxiSiWt6954w+RAO8Na/Y2WowP4?= =?us-ascii?Q?uGBsMyO03AmkQNjIjkpHl/AduX+uGQcz14ymxHiBLjyVCRaUcmvJjmMpQzG8?= =?us-ascii?Q?yXBfy96q/ZVvqd4sxjfYXphGHrSS5Zp9KRyY0HjKsOZ2p21MH2MegQsgyWYR?= =?us-ascii?Q?a4RfT6mOGy0lznKnS6Y+C30dztc/aTuh20b56O/F8d5lhBck32HfcX4zg9Bn?= =?us-ascii?Q?oC5D8i5I7XQBghIqsMKz/8JbGxfzxEPw4VEMXXJMRwUEEaIelHBRyPJiSsKp?= =?us-ascii?Q?nRDzBXWjjRRKRRlLVCww+RsEs8p9DICIJwGSuVKl42IuzrJF5FixRNA4gdtV?= =?us-ascii?Q?cWwPweCzQcU3EebT2YHEjow4bKe8utM13C+j9CqY/gTQQzUpALhRdy7UQhO9?= =?us-ascii?Q?vjPu1rdKR/BMthtokgRxoKlbdeBLVDKMJI65T4FFd9hwqsFLvFlILSMrB913?= =?us-ascii?Q?/Dp8fp1xeDc02q4otqMJaRINP/vnKOpUGAyXrV+NcUIBQY0+KYMARpR538xu?= =?us-ascii?Q?E6eeoZOP589eek2M0N4l0DlhkLxGn63ytx+mfMWEFCvez+TS3JRXG1MCd5yg?= =?us-ascii?Q?gQc=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4X5MF10iSBlAfFQOckXDwnzLmpIY7kW+gTL3ehuIid0lJLbWyrQQrZ5wxNvQ?= =?us-ascii?Q?IsruMtj+0KFgqWTGMLiSBWVI4E5Vu4TuKyoYvLVkLB75vjn3dYqWJCQDSMLH?= =?us-ascii?Q?j1oCTFTQocpD1L7PqputZ9+Zx3O5IcoimHFcP+wGdzerG6Xi4NoC9VUk1kR+?= =?us-ascii?Q?HP7S4hlA8pQiJ8Ny66KPNWZHfDwnT7MYzjePRXmsPH8X/JdDakNGrutjybOq?= =?us-ascii?Q?NQ0Q3JfK5k05YK5gI4koTv4yYhnQpBvOX5nWyatwf4j0qeKAJKwkrIF61F0Q?= =?us-ascii?Q?Vvr+NqbnJQE8HT7IJEgZ0kKnbQpdRFMMxWcDu0I9xUn55qOc+y1tLuas/t1D?= =?us-ascii?Q?vCzPilmrCUk+hbSc1zWk/aLbQohpMq/CYwXJaPeG8HYtI+s8D3a4jxqKBzI2?= =?us-ascii?Q?+6Dnq5WQ3BTbPiv0V6WvhbyaJq3yrpQSDIz+snE88ud5E5M28lwEhVG8Un9I?= =?us-ascii?Q?E3S36i0+TWDsctGwYjLnTixjyNM0+Po7fNrd/ft771WscJDwmVho9MPn1hF3?= =?us-ascii?Q?yA4lUOeT1gV2UTwZ+YWuAzXgcR7fXypjaCw6k+d6l18JKZ64pPdJB/eLCDrm?= =?us-ascii?Q?9zJkDPAbgYrtSAkb+FTmNU4O5ViSh9TT5WVQGWmXQqOO2CRlXtSpsSqDUl13?= =?us-ascii?Q?pVLilNcIDzuQEpc0gFxfNoH1c+QTrM3KFhc1RYXs4HaHSrmimUcRJu45vg19?= =?us-ascii?Q?evtc1iqFfL4N8vD0Jla5U4nzaQy7LlZ4kSemM0YcrQHAcMNu2i79lrM2dgLD?= =?us-ascii?Q?dOIhFv+Qqta0/Ktz3QZxVN2l5eYa/KiG/LwVpE32zczajOoli3wuEni/HZa/?= =?us-ascii?Q?raAeIzWe6+S+qSuYCgmvn7CXOABQ3AoSgkHVYEn8JImze/5BIDzrQFi6BVtP?= =?us-ascii?Q?fYvFYqVZb/7Y9ayoTFqSJ+FvG33D5YHZ5ZL8xjOca6dvPhYz39WhTkoV4pQ2?= =?us-ascii?Q?8/hoboUkvz/NzNy+LD6rVynTqqE5/whBEj7brVrt76bAN5bS7Dc8akLyPw3n?= =?us-ascii?Q?p3LA0qiEuEXrJYHk0LJEIelPHH3XOp2y2+Vk5lnXt/pLq3qp0uxdDAWG5HbW?= =?us-ascii?Q?HxSYcl6GdDTAnJ+QYONSglP+fRgpPGyysT0rIGQH0vxj/sIUTu3NrYFOaJdg?= =?us-ascii?Q?Uc5A0dhJrdL6RFvaHwn0fZ+JwwDcswStSz/6wv9dKj+Qh/7gjxkmkurQhpkF?= =?us-ascii?Q?nU86OyIPB9GdVCTQJzqmPevhx+JhDw9i8OC2gWOyNG2VFkFb/qfwkf8BGJFY?= =?us-ascii?Q?CafOLvOe71YvBx5ujagzzyrRxwy2EBVVcTR9osZinkw9fAPfaEoEV0CfOadY?= =?us-ascii?Q?+SUzx3kpzUiKvbrK9ZkP+WIJn2iKp6nt06iOJ9CsakvLvfvjbBxUFJGVxK0p?= =?us-ascii?Q?OV0zmb0LgEGxly6vR1YsgAfnLO0yMzADWIqvgINYRzbSaOnM/kFFToUxZknQ?= =?us-ascii?Q?ThM363go3lowOwyrvyfvjZqcQafkYKPR1Y0bcgU1cmDsLCCRqj5rQmdDXUhM?= =?us-ascii?Q?ElvyvrU/eu4xCuT43zHNn4AWjkLKVWQDjRkJ0k+GekuKCzczyBoF8xZ+AS4J?= =?us-ascii?Q?D6QoLTXB7jGbRW5zGZPBCe3nUnnpqf/CsID72ijB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5046.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb5495a-2e4c-4a4b-bc96-08dc700223c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 08:29:27.2311 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tPpRqhBYfqFzW0v9n/8WvcWdMJsB87cAePbKf1a9+rdWNjZkQuVkpssFBlbwOYPJyINTTbI6TSzMVQUM5rf5gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8390 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 09 May 2024 01:29:43 -0700 Resent-From: wenxing.hou@intel.com Reply-To: devel@edk2.groups.io,wenxing.hou@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: S7YJlOYeTx45UIYzT2sFCWXdx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=VVcRCmie; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, Thanks for your feedback. The new PR is: https://github.com/tianocore/edk2/pull/5645 Could Li Yi help me merge the PR? Thanks, Wenxing -----Original Message----- From: Li, Yi1 =20 Sent: Thursday, May 9, 2024 2:54 PM To: Hou, Wenxing ; devel@edk2.groups.io Cc: Yao, Jiewen Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls For this patch set: Looks good to me. Reviewed-by: Yi Li -----Original Message----- From: Hou, Wenxing =20 Sent: Thursday, May 9, 2024 2:27 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 Subject: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4177 Add AeadAesGcm/Pem(only RSA)/X509(only RSA)/More RSA/PKCS5/pKCS7/Authentico= de/Timestamp implementation based on Mbedtls. The patch has passed the EDKII CI check: https://github.com/tianocore/edk2/pull/5552 And the patch has passed unit_test in EDKII and integration test for platfo= rm. And the patch hass passed the fuzz test: https://github.com/tianocore/edk2-staging/commit/4f19398053c92e4f7791d468a1= 84530b6ab89128 v2 changes: - Fix format variable name/hardcode number issue; - Fix Pkcs7 memory leak; v3 changes: - Fix some issues form reviewer; - Add SHA3/SM3 implementation; - Update *.inf files; Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou Wenxing Hou (11): CryptoPkg: Add AeadAesGcm based on Mbedtls CryptoPkg: Add rand function for BaseCryptLibMbedTls CryptoPkg: Add Pem APIs based on Mbedtls CryptoPkg: Add X509 functions based on Mbedtls CryptoPkg: Add Pkcs7 related functions based on Mbedtls CryptoPkg: Add Pkcs5 functions based on Mbedtls CryptoPkg: Add more RSA related functions based on Mbedtls CryptoPkg: Add AuthenticodeVerify based on Mbedtls CryptoPkg: Add ImageTimestampVerify based on Mbedtls CryptoPkg: Update *.inf in BaseCryptLibMbedTls Add SHA3/SM3 functions with openssl for Mbedtls CryptoPkg/Include/Library/BaseCryptLib.h | 4 + .../BaseCryptLibMbedTls/BaseCryptLib.inf | 47 +- .../Cipher/CryptAeadAesGcm.c | 227 ++ .../BaseCryptLibMbedTls/InternalCryptLib.h | 49 + .../BaseCryptLibMbedTls/PeiCryptLib.inf | 27 +- .../BaseCryptLibMbedTls/Pem/CryptPem.c | 138 ++ .../Pk/CryptAuthenticode.c | 214 ++ .../BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep.c | 278 +++ .../BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkdf2.c | 100 + .../Pk/CryptPkcs7Internal.h | 29 +- .../BaseCryptLibMbedTls/Pk/CryptPkcs7Sign.c | 635 ++++++ .../Pk/CryptPkcs7VerifyBase.c | 113 + .../Pk/CryptPkcs7VerifyCommon.c | 1354 ++++++++++++ .../Pk/CryptPkcs7VerifyEku.c | 689 ++++++ .../BaseCryptLibMbedTls/Pk/CryptRsaExt.c | 352 +++ .../BaseCryptLibMbedTls/Pk/CryptRsaPssSign.c | 140 ++ .../Library/BaseC= ryptLibMbedTls/Pk/CryptTs.c | 381 ++++ .../BaseCryptLibMbedTls/Pk/CryptX509.c | 1940 +++++++++++++++++ .../BaseCryptLibMbedTls/Rand/CryptRand.c | 114 + .../BaseCryptLibMbedTls/Rand/CryptRandTsc.c | 114 + .../BaseCryptLibMbedTls/RuntimeCryptLib.inf | 26 +- .../BaseCryptLibMbedTls/SmmCryptLib.inf | 36 +- .../BaseCryptLibMbedTls/TestBaseCryptLib.inf | 39 +- CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf | 6 + .../Library/MbedTlsLib/MbedTlsLibFull.inf | 6 + 25 files changed, 6973 insertions(+), 85 deletions(-) create mode 100644 = CryptoPkg/Library/BaseCryptLibMbedTls/Cipher/CryptAeadAesGcm.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pem/CryptPem.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptAuthentic= ode.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep= .c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkd= f2.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Sign= .c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Veri= fyBase.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Veri= fyCommon.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Veri= fyEku.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaExt.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaPssSig= n.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptTs.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Rand/CryptRand.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Rand/CryptRandTsc= .c -- 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118749): https://edk2.groups.io/g/devel/message/118749 Mute This Topic: https://groups.io/mt/105996826/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-