Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

["Wenxing Hou" <wenxing.hou@intel.com>]

Hi Liming,
Thanks for your suggestion.


Hi all,
The current Patch Set status is:
	This patch set was submitted before soft feature freeze. 
	It passed code review after soft feature freeze starts.
	And the Patch set is: Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
	              		         Reviewed-by: Yi Li <yi1.li@intel.com>

We want to catch this 202405 stable tag.
If anyone have feedback, please let me know.

Thanks,
Wenxing

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Thursday, May 9, 2024 4:59 PM
To: devel@edk2.groups.io; Li, Yi1 <yi1.li@intel.com>; Hou, Wenxing <wenxing.hou@intel.com>
Cc: Yao, Jiewen <jiewen.yao@intel.com>
Subject: 回复: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

Seemly, this change is new feature to add more crypt APIs based on Mbedtls.

This patch set was submitted before soft feature freeze. But, it passed code review after soft feature freeze starts. 

Based on current rule, this patch set is not allowed to be merged for this stable tag 202405. 

If you want to catch this stable tag, please raise this requirement to the mail list and collect the feedback. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Li, Yi
> 发送时间: 2024年5月9日 16:33
> 收件人: Hou, Wenxing <wenxing.hou@intel.com>; gaoliming 
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Yao, Jiewen <jiewen.yao@intel.com>
> 主题: Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on
Mbedtls
> 
> This patch set was submitted before soft freeze and will not affect 
> other
existed
> codes, I am OK to merge it.
> 
> Hi Liming,
> 
> Do you have any comments?  I will merge it if no objections.
> 
> Thanks,
> Yi
> 
> -----Original Message-----
> From: Hou, Wenxing <wenxing.hou@intel.com>
> Sent: Thursday, May 9, 2024 4:29 PM
> To: Li, Yi1 <yi1.li@intel.com>; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; gaoliming 
> <gaoliming@byosoft.com.cn>
> Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> 
> Hi,
> 
> Thanks for your feedback.
> The new PR is: https://github.com/tianocore/edk2/pull/5645
> 
> Could Li Yi help me merge the PR?
> 
> Thanks,
> Wenxing
> 
> -----Original Message-----
> From: Li, Yi1 <yi1.li@intel.com>
> Sent: Thursday, May 9, 2024 2:54 PM
> To: Hou, Wenxing <wenxing.hou@intel.com>; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> 
> For this patch set:
> 
> Looks good to me.
> Reviewed-by: Yi Li <yi1.li@intel.com>
> 
> 
> -----Original Message-----
> From: Hou, Wenxing <wenxing.hou@intel.com>
> Sent: Thursday, May 9, 2024 2:27 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
> 
> Add AeadAesGcm/Pem(only RSA)/X509(only RSA)/More 
> RSA/PKCS5/pKCS7/Authenticode/Timestamp
> implementation based on Mbedtls.
> 
> The patch has passed the EDKII CI check:
> https://github.com/tianocore/edk2/pull/5552
> 
> And the patch has passed unit_test in EDKII and integration test for
platform.
> And the patch hass passed the fuzz test:
> https://github.com/tianocore/edk2-staging/commit/4f19398053c92e4f7791d
> 4
> 68a184530b6ab89128
> 
> v2 changes:
>  - Fix format variable name/hardcode number issue;
>  - Fix Pkcs7 memory leak;
> 
> v3 changes:
>  - Fix some issues form reviewer;
>  - Add SHA3/SM3 implementation;
>  - Update *.inf files;
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
> 
> Wenxing Hou (11):
>   CryptoPkg: Add AeadAesGcm based on Mbedtls
>   CryptoPkg: Add rand function for BaseCryptLibMbedTls
>   CryptoPkg: Add Pem APIs based on Mbedtls
>   CryptoPkg: Add X509 functions based on Mbedtls
>   CryptoPkg: Add Pkcs7 related functions based on Mbedtls
>   CryptoPkg: Add Pkcs5 functions based on Mbedtls
>   CryptoPkg: Add more RSA related functions based on Mbedtls
>   CryptoPkg: Add AuthenticodeVerify based on Mbedtls
>   CryptoPkg: Add ImageTimestampVerify based on Mbedtls
>   CryptoPkg: Update *.inf in BaseCryptLibMbedTls
>   Add SHA3/SM3 functions with openssl for Mbedtls
> 
>  CryptoPkg/Include/Library/BaseCryptLib.h      |    4 +
>  .../BaseCryptLibMbedTls/BaseCryptLib.inf      |   47 +-
>  .../Cipher/CryptAeadAesGcm.c                  |  227 ++
>  .../BaseCryptLibMbedTls/InternalCryptLib.h    |   49 +
>  .../BaseCryptLibMbedTls/PeiCryptLib.inf       |   27 +-
>  .../BaseCryptLibMbedTls/Pem/CryptPem.c        |  138 ++
>  .../Pk/CryptAuthenticode.c                    |  214 ++
>  .../BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep.c   |  278 +++
>  .../BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkdf2.c |  100 +
>  .../Pk/CryptPkcs7Internal.h                   |   29 +-
>  .../BaseCryptLibMbedTls/Pk/CryptPkcs7Sign.c   |  635 ++++++
>  .../Pk/CryptPkcs7VerifyBase.c                 |  113 +
>  .../Pk/CryptPkcs7VerifyCommon.c               | 1354 ++++++++++++
>  .../Pk/CryptPkcs7VerifyEku.c                  |  689 ++++++
>  .../BaseCryptLibMbedTls/Pk/CryptRsaExt.c      |  352 +++
>  .../BaseCryptLibMbedTls/Pk/CryptRsaPssSign.c  |  140
> ++  .../Library/BaseCryptLibMbedTls/Pk/CryptTs.c  |  381 ++++
>  .../BaseCryptLibMbedTls/Pk/CryptX509.c        | 1940
> +++++++++++++++++
>  .../BaseCryptLibMbedTls/Rand/CryptRand.c      |  114 +
>  .../BaseCryptLibMbedTls/Rand/CryptRandTsc.c   |  114 +
>  .../BaseCryptLibMbedTls/RuntimeCryptLib.inf   |   26 +-
>  .../BaseCryptLibMbedTls/SmmCryptLib.inf       |   36 +-
>  .../BaseCryptLibMbedTls/TestBaseCryptLib.inf  |   39 +-
>  CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf   |    6 +
>  .../Library/MbedTlsLib/MbedTlsLibFull.inf     |    6 +
>  25 files changed, 6973 insertions(+), 85 deletions(-)  create mode 
> 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Cipher/CryptAeadAesGcm.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pem/CryptPem.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptAuthenticode.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkdf2.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Sign.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7VerifyBase.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7VerifyCommon.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7VerifyEku.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaExt.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaPssSign.c
>  create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptTs.c
>  create mode 100644 
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Rand/CryptRand.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Rand/CryptRandTsc.c
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 










-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118759): https://edk2.groups.io/g/devel/message/118759
Mute This Topic: https://groups.io/mt/105997960/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-