From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2109DD80287 for ; Sat, 7 Oct 2023 13:39:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WCac6ujQmzKl2QJnEHMwSx7uaXclX/88dovcaJUPjY8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696685945; v=1; b=Q0n4I79daQDbJv51+QRyZzN2C0WBKr4tIcCky75lKt06brnZSLXuG6kBZ+UiowWxjDwiQNPj R/2HUUDg50rKSsMlL0n9PJA5+3nAWUhyY1fwqH2VFZ6RoPHzMRhImb+5feKMSQMOH0IMPXsgJOc 8PulNLNk2XavHQ1sWyIFJ/74= X-Received: by 127.0.0.2 with SMTP id TYo9YY7687511x5qBLeABgIL; Sat, 07 Oct 2023 06:39:05 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.17673.1696685944716256641 for ; Sat, 07 Oct 2023 06:39:05 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10856"; a="374256982" X-IronPort-AV: E=Sophos;i="6.03,206,1694761200"; d="scan'208";a="374256982" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2023 06:39:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10856"; a="926285435" X-IronPort-AV: E=Sophos;i="6.03,206,1694761200"; d="scan'208";a="926285435" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Oct 2023 06:39:04 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sat, 7 Oct 2023 06:39:03 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Sat, 7 Oct 2023 06:39:03 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Sat, 7 Oct 2023 06:39:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=emAotDnoAW/beM+H0YUu8q6ITQp7YxNr99lsWG9qOTzNvn8lu0ZwN+7+lm7Sz0zOOVg7g3pJsYaWPmdlqmLKbZiClRN36WNmTLKj7TKvQFfqTVOSWze5T0TMziq7wd8WwfsB6hXw86oNcIzefCQ4HFcHXzd0XL86UxZPxPKOkjcG/Spv0qbUXl8NjsxUDpJbDa5tg2E/qs3NHmXGFWg/M9ygSL6FdLvz0rN1ke/iH6Lokt2M5fcecLZFtgYpKLe214mHGvdU5fytMN5D7ixnRB1FQjJIWPci9r2s9HwucKP8PgS0OT42wgzBwKyIASy/CQfTSt3KJFzfRq5NvAbIgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e3GxJp8ZDDfYqO/geJ6itJb/vcEKXN0x9orh+eJpf1s=; b=SI5FPGLdyhMTBKbJ8Ry4r/4P8scHqWey6/krGt4y2/SqEBFcJkbwXXvjGEu7OTU7Gb/E4cz604t41skQYRuSpJRAfRHkLgbFtGny5hJiftuWX4e64NMn77efnJQ2QWcWkqN3W7ivH75GZrrso6C+C8YSGjpYNmYe4oQ4sZdymhddOWkej0bb1XlTxy/nn8b9YyR2TJpuBPHuAZbazFFOPKKDD6NkovBdYY0mcGpX7648G/6J96amK/REjySj7aURWfeavTGG3SLN2vc5syQgmCa1dAQ80tVVSnxiKmZZwNCriRlMcu9WcdoazCxqBIuf/Ud6UIw5h+kj527icWAQYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH0PR11MB5046.namprd11.prod.outlook.com (2603:10b6:510:3b::20) by MN0PR11MB6181.namprd11.prod.outlook.com (2603:10b6:208:3c7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.39; Sat, 7 Oct 2023 13:39:00 +0000 X-Received: from PH0PR11MB5046.namprd11.prod.outlook.com ([fe80::3513:5c7e:37e9:5d32]) by PH0PR11MB5046.namprd11.prod.outlook.com ([fe80::3513:5c7e:37e9:5d32%4]) with mapi id 15.20.6838.040; Sat, 7 Oct 2023 13:39:00 +0000 From: "Wenxing Hou" To: "devel@edk2.groups.io" , "sean.brogan@microsoft.com" , "mikuback@linux.microsoft.com" , "Kinney, Michael D" , "Gao, Liming" CC: "Li, Yi1" Subject: Re: [edk2-devel] [PATCH v3 09/11] CryptoPkg: Add Mbedtls submodule in CI Thread-Topic: [edk2-devel] [PATCH v3 09/11] CryptoPkg: Add Mbedtls submodule in CI Thread-Index: AQHZ8iU0pv5a0WcSR0qQl7lZvRdPobA+YDeg Date: Sat, 7 Oct 2023 13:39:00 +0000 Message-ID: References: <20230928153416.537-1-wenxing.hou@intel.com> <178919F6750E1B48.1188@groups.io> In-Reply-To: <178919F6750E1B48.1188@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5046:EE_|MN0PR11MB6181:EE_ x-ms-office365-filtering-correlation-id: e6624cae-0f56-4c1e-6616-08dbc73ac38f x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: QBxQJjBtWoHDRqxZbM6ebUH95B83X6ZUJzlfc2X4GgsT8TuhG8HvRYIxRowuSyEMKZYJ99/xeDmZc1xYCEEYYF7fv1uQy0eo+O9+pYpOXXenA49CvDBm40WPi6Gpydx0Sng25B+lLTDzfhdCLVDMue9Xn337cCj1f3zs+Ihiju3eJ/9UP8T6HAR98O2iEEdmyXSVUDMJJdm9/jlfDDPxsBEjcm8lEqvwifm0ba0p7rLMNSncWh6A6EljDEQ2EWgVkaLd4cTXTZrnVjivpuo/bRV+h73iax8CeitMGoPovGpGa5O9wIW3wYkQ8Zi8sAp2XqsUTgjZwwy/w2wjqdTIIvIelZE4FKc67vSpKnj1/YRN/xJGQxswkPOsWY0KLiR94Nl2JP1AxjB8w4lj4SRVAbXiGyk744fVE3UnfV+o4VVaUqXmM/iFYgFif+3/Ikmf8dcFSRCGNrdUP4SpXXBUw1XHzeywq4h9q4VgQ4Y9u1dMYdtW6ExGx1EHpD/nE9kQFOgWA0A2gNV27uSzGegvCGJVNO2py4QldEqynchfc+ItoF9MUmt/zb3EkPn8CuUxEULpTFKJ2qqZ8uO5beicGiq7O4gUXG4V+E2hkAJFnv6PyOsqNuBYdix8kgJpeF1lkxNGreIYb7PRP0agK4qyOg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+YXvhC58pCHFnTDT5Y5AyZa3pYyAEdcBOvP/diA+FtKm07l7o4X8luWzJ8HQ?= =?us-ascii?Q?x1f1SwejuU/C6Ts8my6hjUyTwNDlTUIJgKMdAFGdtmo3Pp//uY8vkW/3YBwv?= =?us-ascii?Q?0XILcCQNPjicBibdSzqc2WEXC6jVQcDwoTt2R7R3KLd2xMKG1Od9wTCVtiof?= =?us-ascii?Q?L6WPCkNJp3Hj6qczd+eUNAX2yk+qYG4e35TTdl8ZrhOBWnSSMbYmovLvzo7e?= =?us-ascii?Q?qJaoQvIhf8Ze7Ap9CYl0zR7pqlDOdf3lFLfknOhEjKDuP/xyMfIU0z0KlK4C?= =?us-ascii?Q?CodMWuFvA+hNfMzS8HVhfiAGbYRtHPE95Ih1u6hFvUoTDhAMAJ4Ag3pQdUsG?= =?us-ascii?Q?xM+t/dSEI6KgiiLEFP+I4n7XuHJPNhIqegeLEMh7KcsGH0hXYOqiNzRuGKmc?= =?us-ascii?Q?kW+ZFN3fi6OWYg/U7GhgOCJ2JsDeZ/wfw4rHHNXoOy2usQujf+CK6aIIamg5?= =?us-ascii?Q?8g+0nS/7G2m9B2P8Ewg4oG1g+0PJI1GyBr7KKrpOW0Ha/ciR0vt/aK/IQWF+?= =?us-ascii?Q?H0JQn0U4I34be1jH3ng8mdgqyw8xpdWwyS3q6eoS/6/pRx11hHh9imnVE9vv?= =?us-ascii?Q?qjVc2ThF3HzoH8OBoAOx2ybVhI3AvN7DcCvCfeZ/UGJdhf4o94tPe9V8LneQ?= =?us-ascii?Q?z7x13x1vC1WfolHgo4BIL6u0Tz5ZmMlsmiO2KdIflnHmqkF+uQ84r9gdthBc?= =?us-ascii?Q?cqzs7OeJbQaAZ12y0exm25maEP4V3ZYzZlfGFI9vATaAQpU/sOna8lIsKITE?= =?us-ascii?Q?LMgay7757FnTxqI16kl+bLVEqIVORVeoZRyBRaAUyXeBIASVDcYs2xQWhHvo?= =?us-ascii?Q?SGNCWEKWdKjEez0kXFrsnRuPYb8SiXVGXMDKOh+bm4FcSznO1Z7idNAMg+5S?= =?us-ascii?Q?KjxLR61qGz9nhZ8pZ486kxtP4cAgoPXqaMpolCtiu/3jNKA/lVS57b2fw6Qb?= =?us-ascii?Q?EfIWwBwK4CvsW3bhu9KK8379Gd7h2PKjDlifAN8rGcvVbCVAjFOlkSpOsUHj?= =?us-ascii?Q?eFGEfYbTk7uKXP3kkN8KIa238ybWvj4MV4qEc0n3PCRsyb8XVuwDsCvSdEch?= =?us-ascii?Q?QDvHE8euxt+k0TT691Us5QhlFjq5iR2ZOd5+98Ou2gRsLlLe1BwFFLANOG6o?= =?us-ascii?Q?wnQID1BSZdlpo3EeaCPYCgRarBxOFWVl8u38uXY6WUN+Y3M7PH2GDDpQR2ZX?= =?us-ascii?Q?XWa8BrKKXDvpaPf2X+/LBZ1k7RNcSL9XCR2x696af+S9CP/LViUUsQTOc6c1?= =?us-ascii?Q?zbfwX/5LEDC3Mt/L9kJSsatNLGThOPabQfjam/igFOLqX73CsZsQ5BcGKFhp?= =?us-ascii?Q?+nwIPlYA9n0mfmDYQD92dJ3ATon6g4yP7aWRy1um44PysCfon8J2NS1DkzRs?= =?us-ascii?Q?EM9oz8TAlm3u9Oo+vPOZmu7VWjOJ70WB+SkN0y3ME2kyNv0g9qJQHVwdeC3L?= =?us-ascii?Q?aHiwrsjJb/OcWi7ZhcHVyR7mURkuUy0bmiRMR8PMnehmV8osctfpeRhegdAZ?= =?us-ascii?Q?NNE4zkv3QivtcKmPysZK/+7m6RhAmUGNpzjQZZ+2Kgp3mq699sXUq5pyaQP4?= =?us-ascii?Q?rUbKjx3Y3OFpNWDTggca6PadhONaYzmlT8DwrPsp?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5046.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6624cae-0f56-4c1e-6616-08dbc73ac38f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2023 13:39:00.5995 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SEIaccRYZ0YzMAIb8ACwmZXPTEOIm4CO2XlHbTNjIeThMxvC8SqaEsFiAhu1RnoR1KBbQv6ORlfO1fu/TR4e0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6181 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wenxing.hou@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tjCzrwbb7dskC9oXiv9X3Z4jx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Q0n4I79d; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi all, My patch is about enabling Mbedtls. And this patch will change the pytool. Could you review this patch for the pytool change? Thanks Wenxing -----Original Message----- From: devel@edk2.groups.io On Behalf Of Wenxing Hou Sent: Thursday, September 28, 2023 11:34 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 ; Lu, Xia= oyu1 ; Jiang, Guomin Subject: [edk2-devel] [PATCH v3 09/11] CryptoPkg: Add Mbedtls submodule in = CI Change CI for new Mbedtls submodule. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4177 Cc: Jiewen Yao Cc: Yi Li Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Wenxing Hou --- .pytool/CISettings.py | 2 ++ CryptoPkg/CryptoPkg.ci.yaml | 12 +++++++++++- CryptoPkg/CryptoPkg.dec | 3 ++- CryptoPkg/CryptoPkg.dsc | 8 ++++++++ CryptoPkg/Private/Library/MbedTlsLib.h | 12 ++++++++++++ 5 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 Cryp= toPkg/Private/Library/MbedTlsLib.h diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 6fb7342f81= ..c5803a877c 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -199,6 +199,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsMa= nager, SetupSettingsManag "MdePkg/Library/BaseFdtLib/libfdt", False)) rs.append(= RequiredSubmodule( "MdePkg/Library/MipiSysTLib/mipisyst", False= ))+ rs.append(RequiredSubmodule(+ "CryptoPkg/Library/Mbed= TlsLib/mbedtls", False)) return rs def GetName(self):diff --gi= t a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index 59ba56d41e..967612230d 100644 --- a/CryptoPkg/CryptoPkg.ci.yaml +++ b/CryptoPkg/CryptoPkg.ci.yaml @@ -38,10 +38,20 @@ # This has OpenSSL interfaces that aren't UEFI spec compliant = "Library/BaseCryptLib/Hash/CryptParallelHash.h", "L= ibrary/Include/fcntl.h",+ # This has Mbedtls interfaces that are= n't UEFI spec compliant+ "Library/Include/stdint.h",+ = "Library/Include/stubs-32.h", # These directories contain auto= -generated OpenSSL content "Library/OpensslLib", "L= ibrary/IntrinsicLib",- "Library/BaseCryptLib/Pk/CryptPkcs7Verify= Base.c"+ "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c",+ = # mbedtls+ "Library/MbedTlsLib/mbedtls",+ # Th= is has mbedtls interfaces that aren't UEFI spec compliant+ "Libr= ary/MbedTlsLib/EcSm2Null.c",+ "Library/MbedTlsLib/CrtWrapper.c",= + "Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h",+ = "Library/BaseCryptLibMbedTls/SysCall" ] }, "CompilerPl= ugin": {diff --git a/CryptoPkg/CryptoPkg.dec b/CryptoPkg/CryptoPkg.dec index a5fa81a338..e613b6b1ae 100644 --- a/CryptoPkg/CryptoPkg.dec +++ b/CryptoPkg/CryptoPkg.dec @@ -28,9 +28,9 @@ Library/OpensslLib/OpensslGen/include Library/OpensslLib/OpensslGen/pr= oviders/common/include Library/MbedTlsLib/Include- Library/MbedTlsLib/mb= edtls Library/MbedTlsLib/mbedtls/include Library/MbedTlsLib/mbedtls/inc= lude/mbedtls+ Library/MbedTlsLib/mbedtls/library [LibraryClasses] ## @= libraryclass Provides basic library functions for cryptographic primitives= .@@ -49,6 +49,7 @@ ## @libraryclass Provides library functions from the openssl project. = # OpensslLib|Private/Library/OpensslLib.h+ MbedTlsLib|Private/Library/= MbedTlsLib.h ## @libraryclass Provides compiler intrinsic functions re= quired to link openssl project. #diff --git a/CryptoPkg/CryptoPkg.dsc b/C= ryptoPkg/CryptoPkg.dsc index a55dcb9668..6a0104a3bb 100644 --- a/CryptoPkg/CryptoPkg.dsc +++ b/CryptoPkg/CryptoPkg.dsc @@ -364,6 +364,14 @@ CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf CryptoPkg/Library/BaseC= ryptLib/SmmCryptLib.inf CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.in= f+ CryptoPkg/Library/BaseCryptLibMbedTls/BaseCryptLib.inf+ CryptoPkg/Libr= ary/BaseCryptLibMbedTls/SecCryptLib.inf+ CryptoPkg/Library/BaseCryptLibMbe= dTls/PeiCryptLib.inf+ CryptoPkg/Library/BaseCryptLibMbedTls/SmmCryptLib.in= f+ CryptoPkg/Library/BaseCryptLibMbedTls/RuntimeCryptLib.inf+ CryptoPkg/L= ibrary/BaseCryptLibMbedTls/TestBaseCryptLib.inf+ CryptoPkg/Library/MbedTls= Lib/MbedTlsLib.inf+ CryptoPkg/Library/MbedTlsLib/MbedTlsLibFull.inf Cryp= toPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf CryptoPkg/Library/Int= rinsicLib/IntrinsicLib.inf CryptoPkg/Library/TlsLib/TlsLib.infdiff --git = a/CryptoPkg/Private/Library/MbedTlsLib.h b/CryptoPkg/Private/Library/MbedTl= sLib.h new file mode 100644 index 0000000000..30517a76d3 --- /dev/null +++ b/CryptoPkg/Private/Library/MbedTlsLib.h @@ -0,0 +1,12 @@ +/** @file+ MbedTlsLib class with APIs from the mbedtls project++ =20 +Copyright (c) 2023, Intel Corporation. All rights reserved.
+ =20 +SPDX-License-Identifier: BSD-2-Clause-Patent++**/++#ifndef=20 +MBEDTLS_LIB_H_+#define MBEDTLS_LIB_H_++#endif-- 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109161): https://edk2.groups.io/g/devel/message/109161 Mute This Topic: https://groups.io/mt/101639984/6360182 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [wenxing.hou@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109385): https://edk2.groups.io/g/devel/message/109385 Mute This Topic: https://groups.io/mt/101816236/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-