From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 08620D811A7 for ; Mon, 8 Jan 2024 08:22:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=33b4aGAZphfkCe/n6SKOY9n29AImrC720USx+678NIs=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704702169; v=1; b=SAJx3DXr53VnjDmZP7UWMaLewivZl7n8MAFP5RXB60jII4y7GokZH048LSP7qQdhfbcYnXF2 b72nNsrB8WF3LcnIGjxcoschQCAg+sCkfYZ+QCeui3cT9tOVyh6YBv/5M4wasqlPVGruKsal4gf VcdeuB7lKxEbbr8l1nu7tEbo= X-Received: by 127.0.0.2 with SMTP id B7ftYY7687511x1Dkp7UsFkA; Mon, 08 Jan 2024 00:22:49 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.2545.1704702168756324461 for ; Mon, 08 Jan 2024 00:22:48 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="429006002" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="429006002" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 00:22:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="781343467" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="781343467" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Jan 2024 00:22:47 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 00:22:47 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 00:22:46 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Jan 2024 00:22:46 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Jan 2024 00:22:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FV9z/kV4XKZFN9EBfzS9wQgNjWYPmMPdxyHeY8FkKBIAVLwFkze6wzMRN/k+TZGzmLS/PYPj4QFYV1Ozi5pniuL9++kT01efZ1NwU4Zo5RhNWk3uwTp44FFa98HSNpcRQuUPchaTOZyHXLBzY/uy9SgwIHIQmCFMx4QcQvUEVsgmUpuHRbGUyg2jxTI/ydeJ/3ouIcKuP5YJCb1W8bW1XQvwIrm4tZ7vOjIW9jDncR5epltqmuIUOxcF9v3ugV2jeE57kJhp2XkoUdoGFC15iT8Tr3BHRdbylu0602TVdiA8u7a5QUTz3bDFyA8WW+d0rFud+yJuXlVR22A0E/8FdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qLANSXWRzZGP0ygSQD+NRYkOs/tWD80ZxdeBQQI2Uv8=; b=mw9XwD9xUkpDR7954TvfpUU597oezKcabCjG0w9OVOiWJujVEJt07zRxWMoVerkLPtXFzKDQ0MQO6QothG9NYVh3+fx0UXURnLOd10iIJDRHSXnrSrLmxleJtgdXjgpdfoTsh+4Gft+sHGAeQ0W6Sb+SLQKcUudjprtW7b3jzYcmH6tHqwfHES1KsKyS+ee0S1BTaCRPqSDBqdx8ENiX2XGoNYkRZZrxEe0Wq7kYb1QKktko6hr/QDeu2QkLjlcc+UYhrOXjRt4Ek0Q1Ga2Q3F5TdR9sW60yR5NCZS7uCOeIkJlLRTqGHbceUl8BqaDCpzWAK0MaSZhA+vBuzCcPGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH0PR11MB5046.namprd11.prod.outlook.com (2603:10b6:510:3b::20) by PH7PR11MB8550.namprd11.prod.outlook.com (2603:10b6:510:30c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 08:22:44 +0000 X-Received: from PH0PR11MB5046.namprd11.prod.outlook.com ([fe80::8b27:f4b5:6525:590e]) by PH0PR11MB5046.namprd11.prod.outlook.com ([fe80::8b27:f4b5:6525:590e%3]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 08:22:44 +0000 From: "Wenxing Hou" To: "Li, Yi1" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Jiang, Guomin" Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Thread-Topic: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Thread-Index: AQHaPujZAcPn11RAO0q6Oo6Ik8nyLrDJWaCQgAY6yhA= Date: Mon, 8 Jan 2024 08:22:44 +0000 Message-ID: References: <20240104083415.2967-1-wenxing.hou@intel.com> <20240104083415.2967-2-wenxing.hou@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5046:EE_|PH7PR11MB8550:EE_ x-ms-office365-filtering-correlation-id: 402100b1-b879-4daf-61b9-08dc1022fd73 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: GQZjgKK2dE0e8pSKys8hOI07HqdpX0nJq9/axDyRT3b302o4Gq2jOR7+p3iXckQxRmB9CPA+57y9VxNAEPOAtzLi87oVMAkw7Gk6XKKPuWnyo5ESH3gftQygqODlbL0ffKyHa2bEQmvM+2eiUGQd6oSOyg+zUHu6rPMGNPcNWXCrchXAnM51dDtcgI+ZkAowcYmcNjMGKSlkAtyv4ZiFlJQwWy8JnON81SGIebZr61QChP1BtMgzwPDZrWYjrHYkAANGk6pfuspxUpThgJ19/jptghRHhLKp1g/M8HsQcec7dbLHv/6UDXi3Iippl9zkEnwCV0tIDMvK3j0ikrtVje8vUon5h/IYnUO8Bo39Cp7nQY2IUkeCqAU5lHdpQJ30CyU5tLa+2LxVHPrT6taPm6ntbwG+jkoVmm2i7hOl4RfuRSMgoxpW4K8zIaDGQG0b9gwX08MfoMl6BfXRzhlgcKcdsHZLECL2ZZ+EniZPWmyVmfzp9L6d1LvZTymZRZTuQoDpPAChPCvLfRX2FCyk5qBO0NggPXXJrCFtlR96usuB/JYzVM8VyJMGVyMpV6kT3o5A43LxgKNIW7N5mx3oOYu+7Q2J20f7HNG0rCeLxSA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?33PTbGCRdfc/uDMj3hjZ/XGunfor3I8QEz7RL+1Tah9p31luN4q/jxCir1my?= =?us-ascii?Q?kotBnPbBmY7kc4DhvKQrTSS9zzDVS5OCv8Ni5O4QJGWpHQRNlteukkgUdxpH?= =?us-ascii?Q?fWE9InP5Q0Y4D3Ogwv1g0IywoNB7CpAXSgS0r7MGcgLSVvzkiZT3fim7xYDq?= =?us-ascii?Q?elssd5/ugewDRU+2m9JA7uNUOyw+c61IpMtedgXMIdf7qOrV0laoaFx+X98t?= =?us-ascii?Q?2oS4PqbByr+KAq+pjiiepOSXxFbKoVxUE6ZY1q/5j02T+rVoXjBh4JaCQCy5?= =?us-ascii?Q?enAPe8uENcc1IokgC/OEyzfE1MYF1ThCh+wKXH1PbKiXECKmFMf5euXPE1Ip?= =?us-ascii?Q?4HkNInKYxCI3s+gajQSWZW6KRusOoyC6L4TwgML0jCCaVaJ2ESLsu/GuOVlJ?= =?us-ascii?Q?s4klCVTq1gDSocIOrpCYveLDeNECW8LOw1KcSwkQ9Qg9gf2L5Ry9dk+Sw1RM?= =?us-ascii?Q?ADKk66M06VtBMNSBB+bNnioWYWK38jMG6JNlZLV2SwtGXj8sdQLCpBg6kOxM?= =?us-ascii?Q?bYcmC7bL1Rrrq88uolIbhrVaN/uNnRns6L3NBI3JT7EU66t0PBloXFZV5bty?= =?us-ascii?Q?jyL69jBgsMs0dy4EAPwJsRODqRLkdMMK6sVfDQmUQmwisbN1heK2j6b988pw?= =?us-ascii?Q?CFREot9WcNodtUvQqU+xskuYdBuNVIkhdmvPhh1W8SPTzm+zqN1U7tqmpSZ5?= =?us-ascii?Q?P+tgJvq60Um83iQhdBdSw8SzkK5eyZlREdOnHRSDSDrXrX9uJzpJAb25WYEh?= =?us-ascii?Q?8N5/o6CMAvlHKc0xlrBNkiPG2+K2+pfgmN9LshwDf4ZpFiPKtR9luhibP68K?= =?us-ascii?Q?LsMRpnn5kukR4KfYqSxnRMjtfiDjki9nuoj43i+vkyM88dLw4PE1TPAU6uQy?= =?us-ascii?Q?ZyiePEbqY1qaYsoNPz1DdctqHBooxeU6MJSOm6rdH7DSSZrKVoiVj0mbt5f3?= =?us-ascii?Q?ZDRQF5y2dgJaKsPUnLIPOkDqL6dyeazZGAtlGupTHoXERKrzgYJatbpmtP1a?= =?us-ascii?Q?6fV9fEjEXc5W/lnnigA9jS9p83C1dFh3rnbrVkmltMGQ7sADtEGt/XCGq5Ht?= =?us-ascii?Q?bj356CBbtCMT+lwdmXe5VM9WUpkMfmko75XIkBSpa0AC41xGo4sNEDzOjRq5?= =?us-ascii?Q?5o8ndLxaRkBtbcgFFfKrwO/3JPnN4+/Wnrcb5qQwephyCvaIthB+lfGF81n8?= =?us-ascii?Q?QUYc/BQFkAEqDil8mLQX5ElPSGMGR7wmvARFShHTk9KIldOeZbpibx9l0xQE?= =?us-ascii?Q?PO/eIEbdb3RuzkV8NoJr8RBPEK4bxC105Ugfxc/sKUrf+hep4dfB2u+s4Mpl?= =?us-ascii?Q?AZEYLF5L5uS0l0cORMYsEIQi2b2oY/2ehyEHKfWMTPZMBt7X7r0ICNZcDNCP?= =?us-ascii?Q?pTtQt9k7KvKJD+ktnxzG8+iuDZxH5PsjSpjdAcypMFfac9n8eDrx4GDKydEE?= =?us-ascii?Q?vW7Y1PpNhAM6JQhLundwSVty/ll6nkd+6npKF4F9UB7iXm++5AHR7/XtLSrk?= =?us-ascii?Q?0Hy5Z5EtzZIshXhYFVOMKPfxYDUwziEz7toHdDXJCzNsAQ0Xog8zrSxkv299?= =?us-ascii?Q?cRRgKlSFtzzWwXQgM7NIwPac/cgPWWSaZD2ZhzGY?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5046.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 402100b1-b879-4daf-61b9-08dc1022fd73 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 08:22:44.6809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XRYAAUTRwhseufGTRLizRGagNHdMhVSAbbrdyntdum1nk3PiFEcFWlQGqjXFplgaEDMNySUuIu9pYaIaIrj8TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8550 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wenxing.hou@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Kym8XRZjQumW93bgr5U7GiTpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SAJx3DXr; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi, For VS build, the size is same for enable or disable MBEDTLS_NO_UDBL_DIVISI= ON, because the previous code only had GCC build failure. This MACRO doesn't af= fect the VS build. For GCC build, the previous code didn`t have the size because of the build = failure. To compare the size ,I add the dummy API for previous code: tu_int __udivti3 (tu_int a, tu_int b) { return 0;} And the size has very small change(<1kb) for enable or disable MBEDTLS_NO_U= DBL_DIVISION. Thanks Wenxing -----Original Message----- From: Li, Yi1 =20 Sent: Thursday, January 4, 2024 4:59 PM To: Hou, Wenxing ; devel@edk2.groups.io Cc: Yao, Jiewen ; Jiang, Guomin Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Hi, > disabling it can reduce code size in some embedded targets. Could you provide size change after/before this define enabled? Thanks, Yi -----Original Message----- From: Hou, Wenxing =20 Sent: Thursday, January 4, 2024 4:34 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 ; Jiang, = Guomin Subject: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4630 Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure. Cc: Jiewen Yao Cc: Yi Li Cc: Guomin Jiang Signed-off-by: Wenxing Hou --- CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h = b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h index ae9ef3a1b380..3068612c0815 100644 --- a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h +++ b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h @@ -67,7 +67,7 @@ * example, if double-width division is implemented in software, disabling * it can reduce code size in some embedded targets. */ -// #define MBEDTLS_NO_UDBL_DIVISION +#define MBEDTLS_NO_UDBL_DIVISION =20 /** * \def MBEDTLS_NO_64BIT_MULTIPLICATION --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113370): https://edk2.groups.io/g/devel/message/113370 Mute This Topic: https://groups.io/mt/103519146/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-