From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.4310.1678152199181476590 for ; Mon, 06 Mar 2023 17:23:19 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=H7OGahy/; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678152199; x=1709688199; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iL3MnQI356X437jP5Y4qcnwQoG6p9AyI+6szgFrLNRc=; b=H7OGahy/65/07iaRlqNQwXhXk4Mzj3RWCYz/NV7OI393lQw5i7ynAqXq cjs8tIXWuHy8fk7j+do0RvUcoF0x/diNCgZxn//DDIkik50lR2QHE8a7i TVJm5jSYiJk+Qm+BKfzPmVuEGblmoUFUTUzHSErPlJjw85zSpZ6XokPQA jbpiYYfb1JpHX/lK6HKq5Il5WbiYLjCLcL9xbcrojsrPUCtRH737Zf33a GSGxHuGI6Pam6iZNc+GtWj/Pf6FYb6/8OHuWTLmkSFjmDAHt2pSHShVZv KwquBISk4dbNd7WgMro0hRbxMCeJNPYizn0mvJKarcmzhGsZJ0Yql8gVV g==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="333200667" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="333200667" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 17:23:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="765449300" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="765449300" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 06 Mar 2023 17:23:18 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 17:23:17 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 17:23:17 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 6 Mar 2023 17:23:17 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 6 Mar 2023 17:23:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mRRIYfJKj113oEhQQAr1OdOD0B9HHLmqJHplrLW9Gbl/qslD95IrP0btCg4v4J0uYIKs71CTnPzQKPNS5uMARYrKrY2jloXBE7yY7/rl7bniTUFfcXvSwQVfNGBCjTwumga5p1GHsootQhGxmJoPIoPfUDUfFNClfwXPe8BNpR2/uA5UU3u3BU5D1RDwJVismYxYMNj2Um7WjOm5zipR+wVJU2G3nF/XIivBUGXs2UpEbISgm89DHxVIgdxhvBfy5b4qW+0XiDc0GB41+H7h7NCVmz1w9I3Um2OOPjeWzWwtZoeiw1YSed6ozIN2m8TKc3mLQ3+SDOiiztDhLQwDnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BfpVPw+fIxoCXq9SbhB4Jjl7X4Y9VpN8J/9ivEXf/iU=; b=Xv2xez3bQIeiTp8tzBmmsfgYXaS3I6QRKg0IxGJXSkkTLtlDxAvhrAwBLbh1qzcwIca7FvvN9Xm89ptvmgadyIynT1lnDJjAxzoTJpfYBXBUloPQmkwJA9DYE0IEaHI5OGQCisrRrXZqV7kzPHh/N4FyvtvqJt4ce12Pvp96pBnTqDAKGXCfvmtwBSfXgwKSAdMZMoBWfkT/Bp183mdYBB/AOKzPCYiHLsXlXRzD4uXSrnpCP/lDsviFOHuSOIHHOgEk7/PZmvDX/LEF5xHO7o4AfRCM9m2/hEC7s+6c+3mVVSmd6Z+gqTTrtpwaEnIjGZeODPDN0wfarYOUK/MHnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by SJ0PR11MB5663.namprd11.prod.outlook.com (2603:10b6:a03:3bc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Tue, 7 Mar 2023 01:23:15 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::a17b:667e:4d44:747d]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::a17b:667e:4d44:747d%3]) with mapi id 15.20.6156.028; Tue, 7 Mar 2023 01:23:15 +0000 From: "Zhiguang Liu" To: "Zeng, Star" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly Thread-Index: AQHZTKYgIjctqse1M0WmHpUl734Iia7tlTJwgAAAchCAAPd+IA== Date: Tue, 7 Mar 2023 01:23:14 +0000 Message-ID: References: <20230302012649.1512-1-zhiguang.liu@intel.com> <1749CE106AC7BFA5.3736@groups.io> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|SJ0PR11MB5663:EE_ x-ms-office365-filtering-correlation-id: d38358cb-7345-4811-0837-08db1eaa8664 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 00NF7Or7xuiTD78RAx3UGaqxveq6cFkjNurtySvjCaHs2vNtcQf1l0Wa2Pkzc9cfm3AwWMtxaQgaknsuzP3W1RjNEzp2s/9cdr74L3U3Dqtr3gsjuXSjCQdJjvAvJ7u2kKAfeAwSeOntrallVd952vReoT5ELSQeLgzJNQ300xSLkhjus7PEoCyhWJvUrbPv7ARDkkEKTJTvvAi0XKcXPRc/skpzC66BKcN+FcJUzqV5IqQxBW7epEPfmImKe5tYMWgsBzkC3Md+95XQSbhuqRFLmUA6T/0577go3lZ0/+WIwzjL0K6+GSD68JnTvakOH/Spvdkm+aN7EAFYZ5d4P670KYlulC4BvFFkI5AmoJAL830L3ITiu/cOPQ22l9oERtF6Q4EtJNzXWWeg1v67EbbfVtCZOVMmMXZWPXmgpdSlefq0yx43ar1AY+9xW3Gw4ws+5YaRRamU7EnTKWMQC/erMX2vmjCq2ql6Uws3Q13VkA6lB+cDFIcBtGOu6CxojaMdBFSTc7vavRp6lKL14INEdEGt84ovzfSTz/8C9o1PZTtxxshbtrZ/RujS/+aaoSrczKvZSEgxtHfMP1CiGuuo6XwdJJiJ//pH+J46vICfOZ6ttL6t2RcW6mciMO5g3HdToE9zRYpNaRywPeEWH52TlWi+AR3o9ywKHKj9lCW+yk9Uo07LcRBQi2F3iWzl/zdxbUSw4C+V6cPI7LKYCEmkSHKRcnrCp16X5xr+NVU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199018)(6506007)(53546011)(966005)(38070700005)(83380400001)(33656002)(86362001)(82960400001)(122000001)(38100700002)(9686003)(55016003)(186003)(26005)(41300700001)(66556008)(66476007)(66446008)(66946007)(8676002)(64756008)(4326008)(2906002)(76116006)(52536014)(8936002)(5660300002)(478600001)(7696005)(71200400001)(316002)(66899018)(54906003)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LGaebwHwC2BB+O5G9jQQM3gXMiiUp+ymFy0U7vjlsiAGqyQyeYej/o4pvzZS?= =?us-ascii?Q?TbTCMP7BRjAO/VrtkKeYnCCetgKinVh2rgrxZ+1F/26yffxTjMmD0PcZ+gRt?= =?us-ascii?Q?RdWXh7q+tjCgM/J6gfQ6pRfMFmZnXyvRN08vmiVg2pD/sx7Fk0ffKv6+XfKA?= =?us-ascii?Q?8c4X9KM3dUSiief38dH2VmvKFZc4rM8qlWrmAGWmrglblgLixFHr0ra7tRlc?= =?us-ascii?Q?4NBluFHw69igkBZ0NGC8sNLZLQbrfiTkfPpcOQOiLX5jJE8azYtLFxE6X0me?= =?us-ascii?Q?s32U/93JlAnGdyxV7IciGgS/vBPA/zOx1IwqG6Zq9DDfcKYAqHxClCuo8hwk?= =?us-ascii?Q?Ni/NMaEynlr2dpsYOzhbGtBJ9/QQ9BMZszMGWdA5HgIQklGESt+rmgvFTCCy?= =?us-ascii?Q?YiigvA0CWuTrGGgB2jBFkuQYa3tDGAPtksv2y23HJ2kX9IcLSTEm4eY/e6rm?= =?us-ascii?Q?bspAa+YGia5890od8t5VrH4kZdCdBsnMb2jXOXTBa56xwDDy0+mks4Qz26Ow?= =?us-ascii?Q?sEgPqS/rxd0kGSDlr/m5QKAJq5dYc+qpQ4Xh7KfLY2wCfPOPkHDFTPj607RF?= =?us-ascii?Q?jtSVO8gPQcPazzdNdgNT2TybWJinncX+OKNNoRmlALAstt1JO+beBBVC4+6R?= =?us-ascii?Q?p94ygkEKFJkLL/3Jw4fb85ZgIaIjyMOqT53l4x0ivZNgN9c8UD4vUa1B/gG0?= =?us-ascii?Q?yyUozzfW/uxzzKPYer9aZ2QMuC9IpEVfNDJM9uVnWZKFvKdobzWKL7rFnfVl?= =?us-ascii?Q?2YJ/D3DJ1IvnumYRMQKYn+lJXtjpExyeNjz5443FdNSfokiWNBWNgAI457cI?= =?us-ascii?Q?Jhr3IbKnkU95yoRe9Avzthl9OM3YCR0bfJqO9aa5BihSVxME+z/AzqklBreL?= =?us-ascii?Q?QgRVOIy9DbwP8rNs/2ErYGwKbWjdBrTBi2YHQgITiYOjGhrRuiaCFSNjsbkk?= =?us-ascii?Q?yk34nXIqMa+R4dRx+ttTMKITYm8vJv3SGhmZcXfrnl/4+jG3r8N5VR2O1+/K?= =?us-ascii?Q?LdZGvYR2Ah5SPfOUglpqxuqmAYDZUcuK/6nCtZmLalnohZ6YbaYKH8zDun6m?= =?us-ascii?Q?Lav8HDgs70CEN4YMJQbaL5XQF3LTrg8xVhD6Nhspugsy2KoMDRoe4zRlivCH?= =?us-ascii?Q?Q97ty8/9PsdVHc6hJfjYfpN4kBbLOgdTaOyLiJsQsFGZOtijJYNLV2LCFKzm?= =?us-ascii?Q?KPeXAtMg814uZAjgcCIruLqjtPlDXwsBzgHRkLikPQV9hP8tp1qLHgDnzmPl?= =?us-ascii?Q?2mFwK8X8vb67lTcQUJUNPm6yChizQrauGNWA/G9nMkXG4pwKg6zIdHlXqcj5?= =?us-ascii?Q?twy3t02oKGZPG53SwrIE+7nq/Zocd2eJag8LXlUDXU6jAtk7qLSXioPOw0s8?= =?us-ascii?Q?TF4Hw70uGgExl3ugu64rwM+mClY5sd0gUkZVzVacCn06qL/lRy/RhLOloHTS?= =?us-ascii?Q?R0DaMMyIoRcZdszcQYuSEsUrLsSVS2uv/tdhgWU+GU0cP3Z0FAtSiulG2HWH?= =?us-ascii?Q?Jr7lu3hG0vrDsHomD8xUY+ghAL5mMwhUVhkQxyW/yXjyeRdfYARxPaJbwR6j?= =?us-ascii?Q?5ESvlcu2lZBBI6wP4BbyAcaVy7dD7GoL8CHw6JHP?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d38358cb-7345-4811-0837-08db1eaa8664 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2023 01:23:15.0408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jR2NJWaviTK7QEibEq5sws/66WRekVfGvTgymzUBMcUlGxQWH9Ta0PrrJVc6XnaPM6dwtOjzuE6NLm+dZIl81g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5663 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, the bugzilla link should be https://bugzilla.tianocore.org/show_bug.cg= i?id=3D4348 Will correct it when merge the patch. Thanks Star for catching this Thanks Zhiguang > -----Original Message----- > From: Zeng, Star > Sent: Monday, March 6, 2023 6:37 PM > To: devel@edk2.groups.io; Zeng, Star ; Liu, Zhiguang > > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Zeng, Star > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily > correctly >=20 > BTW, look like wrong Bugzilla ID is used in commit message, please correc= t it > when merging the patch. >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zeng, > Star > Sent: Monday, March 6, 2023 6:35 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Zeng, Star > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily > correctly >=20 > Reviewed-by: Star Zeng >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Thursday, March 2, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correct= ly >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4238 >=20 > Per SDM, DisplayFamily =3D Extended_Family_ID + Family_ID. > Correct the related code. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Zhiguang Liu > --- > UefiCpuPkg/Application/Cpuid/Cpuid.c | 4 ++-- > .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c > b/UefiCpuPkg/Application/Cpuid/Cpuid.c > index 372c6ef87d..51c463fb10 100644 > --- a/UefiCpuPkg/Application/Cpuid/Cpuid.c > +++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c > @@ -1,7 +1,7 @@ > /** @file > UEFI Application to display CPUID leaf information. >=20 > - Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2016 - 2023, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -217,7 +217,7 @@ CpuidVersionInfo ( >=20 > DisplayFamily =3D Eax.Bits.FamilyId; > if (Eax.Bits.FamilyId =3D=3D 0x0F) { > - DisplayFamily |=3D (Eax.Bits.ExtendedFamilyId << 4); > + DisplayFamily +=3D Eax.Bits.ExtendedFamilyId; > } >=20 > DisplayModel =3D Eax.Bits.Model; > diff --git > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > index a8e4f920fc..25b8958252 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > @@ -1,7 +1,7 @@ > /** @file > CPU Features Initialize functions. >=20 > - Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
> + Copyright (c) 2017 - 2023, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -67,7 +67,7 @@ FillProcessorInfo ( >=20 > DisplayedFamily =3D Eax.Bits.FamilyId; > if (Eax.Bits.FamilyId =3D=3D 0x0F) { > - DisplayedFamily |=3D (Eax.Bits.ExtendedFamilyId << 4); > + DisplayedFamily +=3D Eax.Bits.ExtendedFamilyId; > } >=20 > DisplayedModel =3D Eax.Bits.Model; > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20