From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.29393.1620637177221306403 for ; Mon, 10 May 2021 01:59:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=SK27cULn; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: /F89JxcjS61hlM6ZLdkqJjJ0YTU1UagDkXY5fYfmkkSkdgwYtaTBvkN27FKUs9bJZ6mPf2wK5q iy/1GeHZ+YYA== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="178735019" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="178735019" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:59:34 -0700 IronPort-SDR: m5w6dHSywmyPohZZWkKVQ2Q2B5TUv5PQ0OF8YKaNChaKTopBHMBxHz1V28DIp7zOZPR1Fb6sTp NYXD+aIw1A3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="433723018" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 10 May 2021 01:59:34 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 10 May 2021 01:59:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 10 May 2021 01:59:34 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 10 May 2021 01:59:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0KaHH7eBFNnPxBsHMXamnGObwKftNXgujVn/O92b6lpneMWkBr7OmRRORs6HIokq3wapIq4S6VTXRww8g7NGKdBqwB4w7pFpPnoMjT5zOehZZpOp6TJpJoj2FZjaj0ei2/bQ2dWYF5FTiKhn6KlTOhsX8RMxULFNJ4zW8xkdHna/rxnrc9KXCTv7bKLLHJNpcQ3uqHxrM0ByKDHERjOy32z+qTa1Pp0KQ6epZrT88bB5PIUdTB6PzMaGzD6c8HkIeE7FM0vrCAYrrCI0ZYWC9lYjsa1Qkdq5qdQ8QcrE4AK8cl6q5SHqLDpouPFBV4LdvtWrYJgBBkFkJ1aG+GwRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WnF0NX9GUQVm4GvsACNCkZWtSUqmg2QnjHc9hLfYqTw=; b=IbG3SaKk19BKzZidL+XTPkzAQSGsEMZ+Y9vaCyod0TqUpPeVjIPOiPHCFMAtoYypqQInZFhsQlecUg9BEQAxpZQbvSzzWGwwBSLaoR4QjIL45nc9h4u1cGaScos7fI2k5QJJYr3LU/SmSZjjDN7GOxTaN/jbmxEY6NCAM8T8Q+0kE9oodPbWzmitZEcbndWKRbFJHCsBgNsVe70ofZRNTOGIncwM36yYUcDFlLpzwKV+EjeSWUkGjyTSY4MOMemR+mDQ8sq4VYSS6STDJyQ/hAmdm6ZFl8XsBTEAzzBt/cyh4k8W0sULyUf3KWneZJzP/WvmX3LWviSBY280jQZbbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WnF0NX9GUQVm4GvsACNCkZWtSUqmg2QnjHc9hLfYqTw=; b=SK27cULnlmry3HzXweF0MlAAmVDWKWFNZ7I4AjfcnZWJp2psXFWHbOfAmhqIFsSUwRk2NJvb20FZhhmCubXAgHO3INimo6OgpnBASP/iUJE88d/wUSafuc9c/zD8ontKLB+M2Os7vCM476orEEa5CZ/Ion6sWBmLfSNgJp0aCg8= Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by PH0PR11MB5190.namprd11.prod.outlook.com (2603:10b6:510:3c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 08:59:30 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::f490:d71f:fbbe:3b7f]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::f490:d71f:fbbe:3b7f%5]) with mapi id 15.20.4065.042; Mon, 10 May 2021 08:59:30 +0000 From: "Zhiguang Liu" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Zhichao" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager menu from any fv Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager menu from any fv Thread-Index: AQHXRXS/kW9BjvMMxEmaXgJ1MrggL6rcZEEAgAADQDA= Date: Mon, 10 May 2021 08:59:30 +0000 Message-ID: References: <20210510081532.1073-1-zhiguang.liu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4d61a1e-952d-4652-2a1b-08d91391ec31 x-ms-traffictypediagnostic: PH0PR11MB5190: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nI0Eqq0jUhodpQcuAVBdPGIHWAWBCzgfILsNlJd+tBJYd0+JcNsBe0axNIN2UDIHvdQYsIzwgGfgxAfFN1v8HVWWG9yw3I0oozfNY2Ph83o23rC+r/ID0ejBVqYtCl+oZnFepjJEBg39S71C19nUA693nEIhFlI/J8TL1NTzgbgvUOcANIKHmRChEH3oADNwpNb0P+dIe6d2TsLjvdNkTAG6OMOL27cRYqHbQ3ucoIwg9GE2ARJbDgY8jlyO9rN4tq/NZaUNtvLmGaLhCLgchc8tD2/28iyPlwl6lOoYBwbLt7u1ZfyQ2A1s1PAOmdiXGMCdNrPJWU+RvuX1o6Q40pbMFqe76rxtl9oiLO3gxcUqpnCIorX4m6mobO4Xaf6U6EjsJvyDSFH2p+vki0A51tiVi88xqvUzkn614+WmplMd7swCfHAjrMSkVW3/0PfuEwbxBZEEfkb8LMHcN2Pjp1LqSVtxvOEzOMZ242mnVtKMpoRlFy0tGGJBAobth7N3qlOjhG9jADmYDXFzVs1i76r5qCtnpejd6/aiC8lyqF1FsAP7GPQZ9uEGfLxyrV3caXG8qqbcT3dRRuavYc4k9a+b29LOQS6yu0QhUH60qCXI0CQ0x9LWdNdAE5PPik2V1GWvkLGZ1pKFYh32UZiWzO5oH0CwlLGEtAKFC1l6NpvO48qpK68DORHG57Ks9e/Z x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(366004)(376002)(39860400002)(346002)(66946007)(110136005)(9686003)(76116006)(316002)(26005)(52536014)(4326008)(55016002)(8676002)(33656002)(54906003)(478600001)(186003)(966005)(66476007)(66556008)(66446008)(83380400001)(8936002)(6506007)(107886003)(53546011)(71200400001)(2906002)(122000001)(5660300002)(38100700002)(86362001)(7696005)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Oe/2FSZ8Wpx4VkXko9DdolUo5XpRpqF7haL3oM63sowwc2SP86X5HCSyME/4?= =?us-ascii?Q?qLRXi/3pDOcC57YHuE+DOcUeJVsoCyOsIEP6aBbx5XWUHPuRIUgfuQsxYokE?= =?us-ascii?Q?5yqYbtnXfTGxpFyLC4ucwlHQiSaQ0DMq1806ZBaIY9Zxc0XIMeIiKV80gPhX?= =?us-ascii?Q?K3wmzVDC/xeG2WgJy2zQE6p4OL8ABeIaNGtNJ83hCVLGXsPdjNK8y+W6aMR8?= =?us-ascii?Q?/e6bplxbngzEk+CukRu9SSBd9JadYXThF2O+IqS6inUxlhnJeeZGNHRQoXLs?= =?us-ascii?Q?9A0Cnm+/qwYORSKchx87RaQZaKJpos39BSvGLVVEb4PYzHSppMjoIpmAl4LQ?= =?us-ascii?Q?7HI8O5oONpd/ThPtOWW3aZKBw0kIQRlbMf/WsB+dcYLB82mL13ba3kh5vFCX?= =?us-ascii?Q?5FHHMicy2l7/xW4kLhrE1FUIRc/Ic4v6QCjI1kilEonEgkKQDabepNwQNMwy?= =?us-ascii?Q?CFGVIRg9CiAokbdCp302m4VKtwD12ghrVtiQaVRBHubsIEeKsSE4y2HtCihf?= =?us-ascii?Q?dB+k2Pd4I6ZeKXdofa9OwgmW3pJJxx2C9FPaAOc/NXajyBMrvg4u3zUZ0hq5?= =?us-ascii?Q?NvAfELcF4kpdv+NxAoREgtJafdoGPGmFoq4xV7gBMko/Wl8BU9meSw9g1ab+?= =?us-ascii?Q?SQ5i5yl6ZwTZHPSCfp9jxKuLkSs/8KoPseXqh2zUYD6A9QjM1d7KGPEAm0xU?= =?us-ascii?Q?bN/0SJDIS1P7zKMbNjyMf5JKdI6b6QyR/t6TxOb+80yyAsLgWz0o7pfdQG+J?= =?us-ascii?Q?FORM6AI4BTRPUFnBJpzsv58uco1gHP1xh2sz+FXZ7RXZRlX9s/kS6ltjBiWb?= =?us-ascii?Q?Xfunv3DtO/uW+uoy0IHdDbe0jn9wWP5O54jx7BenvkGoih4GmIbJF2+imMXt?= =?us-ascii?Q?j0E7eNicVCvntx0pNui3H9s24iXpEbYCqRGsjegNemP6UNQWXpuncBnMfdG2?= =?us-ascii?Q?JhymOjr+TOAso/CxcUss6iofgxbQ6I0m76sx86RJtI/SkJx98izlfYb9AVdt?= =?us-ascii?Q?NwVppuRSOZUISmj1tFUxowaRebvIOtvYykCiKmNLjtfCV1BMHXE+ZQH1URSA?= =?us-ascii?Q?jIr6CF+eeF8Xh6O1OiVQHMBhrPaVZt+N+1QAB+VX7vVf9zcyuOSdiKDyRiUX?= =?us-ascii?Q?yyftzgQm9i2W/8sARdU0UQI2ADA8hCM/ulqjBfziGH5fWrRNVXp+NGEzKdvU?= =?us-ascii?Q?2n9lHYrGNpM/Rb25SbG7q8XaKOxhpFvKYgGutnrEEnnyUh85R/Ev1H9TZ1oV?= =?us-ascii?Q?2tIyf01/f0V7ypOIC4sSN3XX2piisIatAMxyUtP7S5caEZHWy9ln0kqjtZZp?= =?us-ascii?Q?GsFlOi6dCE9Zy5XuLxkAdNNb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4d61a1e-952d-4652-2a1b-08d91391ec31 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 08:59:30.1465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +7tQCcgjjGQtBAD8LWMKvMF5WCoyX9dho9c7H5v+RflSC4Y+BZtt0Cuxq6DcNwSbUwBFmy5GnmextG/dZckITA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5190 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Hao, I don't have the data about the boot performance. However, I think it has little impact for the originally working platforms. In function GetSectionFromAnyFv, It will first search section in current FV= .=20 If it finds the section, it will return succuss.=20 Only if it can't find the section, it will take extra time to search in oth= er FV. This case won't happen in originally working platforms Thanks Zhiguang > -----Original Message----- > From: Wu, Hao A > Sent: Monday, May 10, 2021 4:42 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Cc: Wang, Jian J ; Gao, Zhichao > ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager > menu from any fv >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Zhiguang Liu > > Sent: Monday, May 10, 2021 4:16 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Gao, Zhichao ; Ni, Ray > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Retrive boot manager > menu > > from any fv > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3384 > > > > Currently, UefiBootManagerLib has the below assumption: > > Assume the BootManagerMenuFile is in the same FV as the module links > > to this library. > > It has some limitation now, so remove the assumption. >=20 >=20 > Hello Zhiguang, >=20 > Sorry for a question. Do you know what is the boot performance impact if > 'GetSectionFromAnyFv()' is being used? > Any data on the impact for originally working platforms? >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Zhichao Gao > > Cc: Ray Ni > > Signed-off-by: Zhiguang Liu > > --- > > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > index 6cc34d29c0..b8df4d590f 100644 > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > @@ -2,7 +2,7 @@ > > Library functions which relates with booting. Copyright (c) 2019, > > NVIDIA CORPORATION. All rights reserved.-Copyright (c) 2011 - 2020, > > Intel Corporation. All rights reserved.
+Copyright (c) 2011 - 2021, > > Intel Corporation. All rights reserved.
(C) Copyright 2015-2021 > > Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: > > BSD-2- Clause-Patent @@ -2385,7 +2385,6 @@ > > EfiBootManagerRefreshAllBootOption ( > > This function is called to get or create the boot option for the Boo= t > Manager > > Menu. The Boot Manager Menu is shown after successfully booting a > boot > > option.- Assume the BootManagerMenuFile is in the same FV as the > module > > links to this library. @param BootOption Return the boot option = of the > > Boot Manager Menu @@ -2437,7 +2436,7 @@ > BmRegisterBootManagerMenu ( > > if (DevicePath =3D=3D NULL) { Data =3D NULL;- Status =3D Get= SectionFromFv (+ > > Status =3D GetSectionFromAnyFv ( PcdGetPtr > > (PcdBootManagerMenuFile), EFI_SECTION_PE32, = 0,@@ - > > 2455,7 +2454,7 @@ BmRegisterBootManagerMenu ( > > // // Get BootManagerMenu application's description from EFI U= ser > > Interface Section. //- Status =3D GetSectionFromFv (+ Status = =3D > > GetSectionFromAnyFv ( PcdGetPtr (PcdBootManagerMenuFile)= , > > EFI_SECTION_USER_INTERFACE, 0,-- > > 2.30.0.windows.2 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#74859): > > https://edk2.groups.io/g/devel/message/74859 > > Mute This Topic: https://groups.io/mt/82714887/1768737 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > > - =3D-=3D-=3D-=3D-=3D-=3D > >