From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation
Date: Mon, 12 Dec 2022 07:34:04 +0000 [thread overview]
Message-ID: <PH0PR11MB504822754A4D9804B4A5011D90E29@PH0PR11MB5048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <172E5F0FD36A90C2.5063@groups.io>
Hi Liming and Mike,
Could you help review this patch?
Thanks
Zhiguang
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Wednesday, December 7, 2022 9:37 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove
> HOST_APPLICATION limitation
>
> Remove HOST_APPLICATION limitation for UnitTestHostBaseLib, so that this
> library can be used as BaseLib by Emulator.
> Also, add some missing files
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> index 09a610c31c..12a5cdcc0a 100644
> --- a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> +++ b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> @@ -1,7 +1,8 @@
> ## @file
> -# Base Library implementation for use with host based unit tests.
> +# Base Library implementation for use with host based unit tests, and
> +# can also be used by emulation platforms such as EmulatorPkg.
> #
> -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2022, Intel Corporation. All rights
> +reserved.<BR>
> # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> #
> Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.<BR> #
> Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR> @@ -18,7 +19,7 @@
> FILE_GUID = 9555A0D3-09BA-46C4-A51A-45198E3C765E
> MODULE_TYPE = BASE
> VERSION_STRING = 1.1
> - LIBRARY_CLASS = BaseLib|HOST_APPLICATION
> + LIBRARY_CLASS = BaseLib
> LIBRARY_CLASS = UnitTestHostBaseLib|HOST_APPLICATION
>
> #
> @@ -128,6 +129,7 @@
> X86RdRand.c
> X86SpeculationBarrier.c
> X86UnitTestHost.c
> + IntelTdxNull.c
>
> [Sources.X64]
> X64/LongJump.nasm
> @@ -168,6 +170,7 @@
> X64/RdRand.nasm
> ChkStkGcc.c | GCC
> X86UnitTestHost.c
> + IntelTdxNull.c
>
> [Sources.EBC]
> Ebc/CpuBreakpoint.c
> --
> 2.31.1.windows.1
>
>
>
>
>
next parent reply other threads:[~2022-12-12 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172E5F0FD36A90C2.5063@groups.io>
2022-12-12 7:34 ` Zhiguang Liu [this message]
2022-12-13 23:54 ` [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB504822754A4D9804B4A5011D90E29@PH0PR11MB5048.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox