* Re: [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation
2022-12-12 7:34 ` [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation Zhiguang Liu
@ 2022-12-13 23:54 ` Michael D Kinney
0 siblings, 0 replies; 2+ messages in thread
From: Michael D Kinney @ 2022-12-13 23:54 UTC (permalink / raw)
To: Liu, Zhiguang, devel@edk2.groups.io, Gao, Liming,
Kinney, Michael D; +Cc: Ni, Ray
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Sunday, December 11, 2022 11:34 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation
>
> Hi Liming and Mike,
> Could you help review this patch?
>
> Thanks
> Zhiguang
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Zhiguang Liu
> > Sent: Wednesday, December 7, 2022 9:37 AM
> > To: devel@edk2.groups.io
> > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> > Ni, Ray <ray.ni@intel.com>
> > Subject: [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove
> > HOST_APPLICATION limitation
> >
> > Remove HOST_APPLICATION limitation for UnitTestHostBaseLib, so that this
> > library can be used as BaseLib by Emulator.
> > Also, add some missing files
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> > MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > index 09a610c31c..12a5cdcc0a 100644
> > --- a/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > +++ b/MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
> > @@ -1,7 +1,8 @@
> > ## @file
> > -# Base Library implementation for use with host based unit tests.
> > +# Base Library implementation for use with host based unit tests, and
> > +# can also be used by emulation platforms such as EmulatorPkg.
> > #
> > -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2007 - 2022, Intel Corporation. All rights
> > +reserved.<BR>
> > # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> #
> > Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.<BR> #
> > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> > reserved.<BR> @@ -18,7 +19,7 @@
> > FILE_GUID = 9555A0D3-09BA-46C4-A51A-45198E3C765E
> > MODULE_TYPE = BASE
> > VERSION_STRING = 1.1
> > - LIBRARY_CLASS = BaseLib|HOST_APPLICATION
> > + LIBRARY_CLASS = BaseLib
> > LIBRARY_CLASS = UnitTestHostBaseLib|HOST_APPLICATION
> >
> > #
> > @@ -128,6 +129,7 @@
> > X86RdRand.c
> > X86SpeculationBarrier.c
> > X86UnitTestHost.c
> > + IntelTdxNull.c
> >
> > [Sources.X64]
> > X64/LongJump.nasm
> > @@ -168,6 +170,7 @@
> > X64/RdRand.nasm
> > ChkStkGcc.c | GCC
> > X86UnitTestHost.c
> > + IntelTdxNull.c
> >
> > [Sources.EBC]
> > Ebc/CpuBreakpoint.c
> > --
> > 2.31.1.windows.1
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 2+ messages in thread