From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.16981.1675229310100389606 for ; Tue, 31 Jan 2023 21:28:30 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DYWQLB4L; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675229310; x=1706765310; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wc+7Q5pyQbc3mFzTTMWJWQkSDot/SQkLIwWiuA6e+aQ=; b=DYWQLB4LWCdPNGArIgal/ce0EhqcRVaUYjCCzvS0rBanyjVhBcmWcM0u d9/o+McxRf1NWq1cZ6Teoriin+9LHH8KeNlbCdy7nuD276Oon73ag7/9a w5AE9GcWQh94r85HNK4WQfVG2RkBwz46RN5t/KHGANyQwhhZV8keOtxxL u5/jDea6AGnguWXvvQR/KfcffRApw7WEPhEYCvmNM3ySZ/XxIOfLhZ+ec yqG9u1G2At3oY9Uo9VPGqKaCCheMXgBdhXMYnT7BktPiFLNgj9QN6/DXx O9NGVVy8sU4FVb9Dy9UpQHXOoSX1jA+wxg/twCnkHfUWGvotpBLOMtm7q Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="308391465" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="308391465" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 21:28:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="773293351" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="773293351" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 31 Jan 2023 21:28:29 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:28:29 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 31 Jan 2023 21:28:29 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 31 Jan 2023 21:28:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DOjrMFO0t9iiSSiyioozEtTfn2KhkrVr7yzxDIfBee6OxrUeFxSQe+a2HktGW7WPqcP+l6Mk8Nu7hs+1L7KIwYVewrqVl4tXnUePBl2wAwh0Rkq5vLmV2XL+RucKND7VcXeX8e06SBynFAnGEPzx/FQSzRRsf1kn6MZHrKMUW8B1/zz92Q0W17V8Q6kNaNgC68U+jLMb9v4hHoLaY3G6TaP0neEbaRVUf7lYRMCV/LV4tic92bKesudFKEAtV723m9tURtlrgfj5hgp8GjTOXGSsPOcljLYfUmKx/tdky0XK0cFO0l32kFbuUwbxCV9GiX1QQdNmTTdyZ47qofFg3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uexgTMtrKX4c0fdC0PnbJwTbxNW8YqSslM+ksZFukm8=; b=bB3umYSoXwg1+vtxASozBBrZvoiHsKg+yQWpocbMUeJ9vNiYJehp8jqQoqhJbPYV4xQfxyD3LQPdMWNWlk0IrSsJ6cdfZCIuSJzHuh0cuBSt4ckQGj9AxeXz/KrJrUmJGkFUhe3jUWBp0HasyvKolDW6N2/heLE8QqcWSVJIaN7rWkIg7RAkQ+xxYXtTUMRELdJhFVRSc0nUczJK6CM3VgWPxLbYTS3W9bsmuHUEDadxVraj+v1B5+SirStG7r1zBi2v6++9BB7csWNQeYuZmi+AaJiy+TO+4vwtHwJlwN+bHBXhAamvZcelyb3K1YP9W0HP73302euiHBizWVVWMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by BN9PR11MB5308.namprd11.prod.outlook.com (2603:10b6:408:119::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 1 Feb 2023 05:28:21 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::f382:d721:8364:480d]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::f382:d721:8364:480d%7]) with mapi id 15.20.6064.024; Wed, 1 Feb 2023 05:28:20 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "Liu, Zhiguang" , "Gao, Liming" , "Wang, Jian J" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning of PcdDxeIplSwitchToLongMode Thread-Index: AQHZI9tdJfVU3rRu1EOIj0WEoujb+q65s/VQ Date: Wed, 1 Feb 2023 05:28:20 +0000 Message-ID: References: <1738869DA53A568A.3916@groups.io> In-Reply-To: <1738869DA53A568A.3916@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|BN9PR11MB5308:EE_ x-ms-office365-filtering-correlation-id: b30564dd-0a9c-43e5-627b-08db041521a0 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NDjPDXIM5HsXgG/3B+NGpzj7sgE4R7A2YlEyCNpoe1sH5b6KO1AXBAN6Wtsec1yzT+czizj4f4y6+PL+cByDpy+bXmbA524sGDJ29cZxZAI9hLbQcekVjKoA0CgrBNVZ5BE3vfGx0axZE7BaBs5y2WdO9me8TezyvXDORR5Ti/wlE3xuGfWpEx7Lc41wvV2LrAJ3MpcuB73oEIjza/8nyF9S1ISyocn+b7X35USbUnrLfv0lvSce+XPd8I51b+77hcSHNPwSVzcI8ayGv+No0sKd3M0wXaNJIt4ZyHqvYs6miuNhUUN/PXpHw8ZsIXObCXSFIwgjP763/DlmwTUZQwmra5BCrgFTpIBMFkPHAGn56GwMGuVoETji0RToD/7mNentBLGHsCrI4sYrwLI4GSpaWuBUZB5i0ABBF6zNYv70k+yWsleJ8g8OJMnmKQcOUFaBZIWXgz5C1SKp0tk/omYksRvGx07xDWiMq9AbqccTpqim2103EJ2cq+TFzTFYZhKjucFYFDyyuBwYghnCPXtY7QzgHqJ9wd3m7iYDGF7WjXlzIoLT4BISNXHSOXsF2HQDcFmZwD2QSgXnHae8FUFNBxTYc20ILBeY7ZGCXlKnp9NYMoStpxxp/P83QGnkiIYfK8ze+MHmnv1dKsw08wD3UrEBsswSIy06aXFJGswgZxMCwMo6cK3Mr3oMCR8RudVDo0uxwfIWeTRyqc4jkKE6b5kmxU+Iy5dh0V9f9aKOflgX6pfDgeZmuofR5rTOL+r+mbHO8zUYTeLIfARfjw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(346002)(396003)(366004)(376002)(39860400002)(136003)(451199018)(8936002)(41300700001)(8676002)(66946007)(66556008)(478600001)(71200400001)(86362001)(66446008)(66899018)(64756008)(66476007)(76116006)(4326008)(7696005)(52536014)(316002)(55016003)(33656002)(110136005)(6636002)(6506007)(53546011)(966005)(5660300002)(107886003)(2906002)(186003)(38070700005)(26005)(9686003)(122000001)(38100700002)(82960400001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BOFGlXJVptoMxXT6Q7DpZV+c368WEyt8vWGtAZspeKMugXqtWV0CXDK+fp5r?= =?us-ascii?Q?3iVZReWpDMGpbCIL95Kvhio0x+kRDummbRN3yu1HEWBIGWXAvea0dkyw68nr?= =?us-ascii?Q?2qf1s8iGjnvlVWgwAbdGjv6DbH2oZpVdvH69D4U1AvhsE1NF4zTTUL/tPBlb?= =?us-ascii?Q?Uipvk2UAp1L2zHeu6qgX0IMIgNaRBKrfwsZvUN9UAWNeUG6r1pcSKA9JrEGq?= =?us-ascii?Q?Ud50OJpJlDA6qErBX9wuwCmlS9vWlefoM1kFqECcmFZqaGX1Q4sfmDMx23Vz?= =?us-ascii?Q?1GzITJDkjDZCoh/ZoUqfIbdxGBpxj3d3+nFJxBRRnuWNIORjBRTyjLrvnWYu?= =?us-ascii?Q?FB+/o+pAmWjBKYpY1URs8BCRXs15H1kQLzjvu0bjjocV7tt0AzNbkV7cS3Xa?= =?us-ascii?Q?hhm4GbvIe4KZMc0Bo55wECAiRCDKGc2PbOL3pL6uGQUdrX9u8IU7gapCH/x+?= =?us-ascii?Q?HVp6/MptxIxNl6SsV/XlwtXpBSWkseIJ2D1lvykBw+EWTOzAcg+53HCaakwC?= =?us-ascii?Q?Gc7cN7u2yBXFzminB84u4oUVJEVS/ehHLjE96y9nlamyRKN3Zh6et1vkyGkC?= =?us-ascii?Q?rMo53+GV3Sum6Qf8ULgeRAGp2weUGdiLWEMpaWfA1HzyrxKiEZMKndTRHSRv?= =?us-ascii?Q?cuMXr5pUpkdNyco1OTJ/uHfyhdfa5LU1EPELLkMBw9pZKzln7liqrDYa95Zi?= =?us-ascii?Q?GyPHnYVj4r0u0p6PiJZuJQo8UemugfvSretzK8TxsxevbXetLF+Pv3JGZAQP?= =?us-ascii?Q?r7dnlY/nL4m/J5bAg7AfcrZKr5TAzNzg0c5OXjpWTwzZ0+Hl7lCLlpmjRmIs?= =?us-ascii?Q?OcI1tpWQuTiCKt75PHVgs8AfjiinoKQWAlsIVikGtq0S9p8TQ/rRVsJSv807?= =?us-ascii?Q?FZk+O3+VZ7usZPYJYcv06m8Wwwg5AgBfMi5tVkxO3qLlMLbWVz8AHTVbRRMd?= =?us-ascii?Q?/Yv/mEzyiqvitnQkO3MU1+PkH6XXjar7nVowO9O6wgcC0xf3rkbI4ORHId68?= =?us-ascii?Q?J6qXS5WBjPVEUklJglP5Gwt/sGyILKkqdzQ2MSV3PoyLf5Bs5pKZOZd63VNY?= =?us-ascii?Q?RnmjL+Bim1ATw6VHE8DdrFhU7PuGgoYbW7dOkwxaSMF9SZkoIO8pF8shcu/V?= =?us-ascii?Q?VBqvrAkEWFPLvoqT3gSZnOSKkmZB10/P4pkUaPp9DSRCZRZvqZDLKk4GWk62?= =?us-ascii?Q?cY4KZ9+omtQHhFwW0btweGJvWFrFsDOWZzncjFWXra2AktrtKd/B3FQi6qa3?= =?us-ascii?Q?sSVmyNRMt2OpY4xDXRU2tUEqaydbTXbhx7KgNglmLRGRrk0y4ZsaAjrPAnmy?= =?us-ascii?Q?oOA0Rcm0zaNE0DbWPqS5xGToUXv2UaiXoezcj2Gm3G6r2Z5gTzDPhzSRJ03I?= =?us-ascii?Q?r/MOBOcu+tbUmyXIs1uVFeiaYU5qZSbXC5xigfqNRviQGBaxW371P1c6PxlT?= =?us-ascii?Q?d2Spk7pXmVOx3mkG3mnQ4+UZrsKr+ff6KxqfGzAgcFE9YYz37O8ml/ZFFZZe?= =?us-ascii?Q?liwGr31XxkDGBRoW9nXFxE1aKK9l5ICOJrm75UcXSvTsdxvt/Np0eJvT5qlF?= =?us-ascii?Q?zTJ0MwXCjM2rXIJFr/MrBcXy9L37RYniBVk0Hjf2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b30564dd-0a9c-43e5-627b-08db041521a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 05:28:20.6790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ac/yTklMkEJxe4dlcmtXGjQX7WNQUKGFp48HcMyf6a/j1ENpKlCeJo+OkGpFIs/eInjThLlsCbwq/BCZ7LlQ7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5308 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming and Jian, What do you think about this patch? Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Monday, January 9, 2023 11:34 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Wang, Jian J > ; Gao, Liming ; Ni, Ray > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning > of PcdDxeIplSwitchToLongMode >=20 > Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, indicating > whether need switch to long mode when loading DxeCore. > However, the comments in dec are confusing for the case where PEI core > and DXE core are both in 64-bit. This patch makes it clear. > PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and switc= h > to long mode to load 64-bit DXE core. In other cases, this PCD is false. > This also aligns with current usage in OvmfPkg. >=20 > Cc: Jian J Wang > Cc: Liming Gao > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/MdeModulePkg.dec | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -922,10 +922,8 @@ >=20 > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > ## Indicates if DxeIpl should switch to long mode to enter DXE phase. > - # It is assumed that 64-bit DxeCore is built in firmware if it is tru= e; > otherwise 32-bit DxeCore > - # is built in firmware.

> # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long mode = to hand > over to DxeCore.
> - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack switch= to > hand over to DxeCore.
> + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform st= ack > switch to hand over to DxeCore.
> # @Prompt DxeIpl switch to long mode. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|B > OOLEAN|0x0001003b >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20