From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.4721.1678153479824825190 for ; Mon, 06 Mar 2023 17:44:40 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CkdcBUMD; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678153479; x=1709689479; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7mJVINjS5c0SoSIHIt9KNmj1tCz7Nbl6c+BKF3/dFXI=; b=CkdcBUMDyjbziQgkMeWeorh2sy3JMnmyyDFp5QreQRjrEOZFr/WHzPZ1 5/8KS+ZF9YkDUccEwenREPt3BOoH07or8KrWsjAOYkLov197E+n+DuD+x /zS9hbvH6lNm8/wWdBRVAccfMmaicVax2TaOeXPHWnyRAhrjLecd02AEd KyReFRU3iTBmsU1yXuNqGC+qhn22dZw0vLeJR/KjVYoRNm9kP+p7OhJwV rIlfm8aw3Tx/IJTkok7MjYp9puzBwZ9I5eVhiPhBdm09XTblN/0tX/MnS 8KUBAq0fMYckUig1J3MXVpj1OjYWfqaORU7wZQPCq+k3wAUeYGEQGVhnD Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="400556656" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="400556656" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2023 17:44:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10641"; a="669679133" X-IronPort-AV: E=Sophos;i="5.98,238,1673942400"; d="scan'208";a="669679133" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 06 Mar 2023 17:44:30 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 17:44:30 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 17:44:29 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 6 Mar 2023 17:44:29 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 6 Mar 2023 17:44:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bdWp+yh1uGhjVkrZKgG6znShW2z3M1uTiE7bvwSUnIY/iYErOJlJdRwm+4dp2CJTy9vgBwOARC6eEtrQjCzIHYrUoZ3KsZR7FevblgJRez2oOJTnk7l6blQuSLlRx7ci/LQ1t3Zm0dZljFt8Izyw+SEJiJHOlPtf21UKzUxJdrVG/LO+HZoVNWmFbOl92Y2GX7bRlZ0NQgiEY5pAe2vh2hQNIypoSPNlJu5hDgiRv5DYMCUfyOhWS59Fdx1YbcOBaPcz5Yxfv0M0McsbBLVyfjA27iWW1H9+/j+/REYjGkTF+jUgwdComtljgJR1yHZX7vZsOGe3+zWK09SjtBfLDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iGbeF0TcvfDoMvEO5U2LvpKyuIRPsUOAZCoi4IENgzU=; b=b2ARSFfFIMrKOLcSqXS/XjGHdpKIs8knyug+omFZPKWeLpAgb2u8sE8HexSzZXQCyYbZTipG8Y1k1+xL36ML8Du7bEMFIjVmxAG+dDl1Iy9jlK602GSYVf+hXzdibAGzAJDRi7fzAfkhoq+oq5dmsSPW3+izRTJCtTMGDf3173ouHxvmGesm9IQfeXeFVrkJZzvmtnBo5M4b3Xb5uCygwscrH8JG40RRj5Qhp5J0XB9/+8O7q9bVx0+boktXlfQRS2h85+iMB/XMxmxjuXPmASnQBDYytgkXfI2128aHEBmvXLxLlRYAZ9hcHaNeMDBPsQVmSko3vp+hAri+r9UfSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by DS0PR11MB6421.namprd11.prod.outlook.com (2603:10b6:8:c7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.22; Tue, 7 Mar 2023 01:44:27 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::a17b:667e:4d44:747d]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::a17b:667e:4d44:747d%3]) with mapi id 15.20.6156.028; Tue, 7 Mar 2023 01:44:27 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "Liu, Zhiguang" , Gerd Hoffmann CC: Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib Thread-Topic: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib Thread-Index: AQHZSn3m8Yb7jtZ5skie5pIi7qYyKq7ihJ4AgAEPwXCACwLdcA== Date: Tue, 7 Mar 2023 01:44:27 +0000 Message-ID: References: <20230227072357.397-1-zhiguang.liu@intel.com> <20230227092058.bfsueq3bhqhjwfwg@sirius.home.kraxel.org> <1747D9F1C3716F33.5262@groups.io> In-Reply-To: <1747D9F1C3716F33.5262@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|DS0PR11MB6421:EE_ x-ms-office365-filtering-correlation-id: 92503ac5-30af-4c9e-70bc-08db1ead7cc0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cQY0p7tZmbRMh24qMipPiDGcW8a5tnOEe+4m6wirjJ9cgTE81bHQUKsnIzowtH7HMI9+0VO31+x7UxDh5oB5v9gLbxXnPuMVauKcwXHgUigGIZdUJY3+qvherYiRRsUFCrx196KvVjhh+DVZWUZzeHztfRgOEFj/kIKE92H3yCuV9F8ve/fIYKVEjF/1TXvCjwjyG8ukbc2R/gPbQhhj5qPN58GvYSagFzD021xSoNwGIsTgJiVEiORcnUdKaPfme0JVsHFMhc0zKv7aw6rpfth6bpcDE+hZKxV8rb/KIgNRd8imTsUVoZNlXC7m0Fr8FH0dLflijAD+pIdAJjMNssDo5HOJTKhHEbYEompoxVx6BUXcPWNPE+Z4n0ezaQZ/46P8nfOi5JHL83DFfPG7PXUkOOWjmQExixGol0vwR3M3KS64KJsQJQfq+WweOpJLm4yB6TYeOvWVHBVusd/uYbrdqxQSx7b5/0uRs57VyWYBDMv+b/C2jj2toQWwSYlW4rnTcZnL3mYxbMAmLZWsap1g/i0JS9XjWkpTpXmrvHPj8ywsLrytgwQZn5ixPO0xdnqJVdTv58Wfr76MB+r1E3gMxf+5QhPXVwM4/3vCfhHRXBqFCmF7Q1+LyTTlHrYUBBYNttlkr3eAP3NMKiuEpGQljh3VNjN6Ghj1urdyD46XNJMH9BaUQp4fy8+dH2Iy3DHejh+W7fEW+JO1L4+SmtWzE8d1gHko6dJYF829mwY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(346002)(376002)(366004)(136003)(451199018)(82960400001)(53546011)(66556008)(55016003)(66446008)(64756008)(66476007)(186003)(76116006)(66946007)(122000001)(66899018)(26005)(6506007)(9686003)(8676002)(4326008)(38100700002)(2906002)(107886003)(966005)(38070700005)(83380400001)(54906003)(110136005)(5660300002)(7696005)(478600001)(41300700001)(52536014)(33656002)(8936002)(71200400001)(86362001)(316002)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?k9bXIq7soKMFKMc+sSfrHxoSTqC5lPBdSUqc8c+8UWL261JnU+Ecen/HFXOf?= =?us-ascii?Q?lPhag0Yxe1JANKW39ifpfYAy9T8bRx7eMPgonm7UhLM2QHu8X1N1G/wePQ+d?= =?us-ascii?Q?xwxPZ8L8SdXZIVLkz4/cOdWj7D3J9R3CGT4vAQQ2rjDwChyuiH9sNghBZ3f0?= =?us-ascii?Q?wCekU5uDYuk4JMhAFIISmbNLL/AvJkXX1/PEk9/jQffb9jECjVh/Ir4JDzj5?= =?us-ascii?Q?42ZOvl+h5KodQZPmtxPtzNqMhtA/kt8Ma+aHw5V3+kbCxM4Fp4e8clTbMFQN?= =?us-ascii?Q?8FRLUJaZJy9ORcYgCOy6Hg2JlBp6Td25Yh5oV6esCag2fGMmwqasCfgx0zS5?= =?us-ascii?Q?LNcCbJHovEjt2+un9uEw/U+hrjpxQV4ZDctWxSor5vLFax/ik7oI3d3t3T3m?= =?us-ascii?Q?+C1VUqX9gaTkKBq3PN5AGM56VnhWYMC3Ntc+gtg28rcWrpQoES3Q4CrZdzxg?= =?us-ascii?Q?yvtz4IfYgEWcKd9I7sx+9jtxzle5YcuknIY8FvkBOIWmT8gsEQgALko+G9QW?= =?us-ascii?Q?1L+zUEfqQq24B0YJ7cwKb6v7pgFndcsjhIAX7vqB7cDZBK7rFeapAXLBrv2Q?= =?us-ascii?Q?TyncjKfI2KmfpMNMbb6c7KjXBs5Fn2rD+01P1XxKBgKLG3zx7+3DtWClqkGV?= =?us-ascii?Q?JR+8MNgbjrt05AnCFn6B0xLrPH8tYILIYZ56xIy1voDLHoDs6fGVqA+14Fj2?= =?us-ascii?Q?J9EpkhF6RviQOYwpSPmxcYOYcyxysvB3Lm3VHMeri/xE115q5z9TfM1YhJg4?= =?us-ascii?Q?CggWsfVzSB/gCRN5JLSwG6Bd0ozPM1TZPQPnI216ulL8zf6ZVteou/Z845Tv?= =?us-ascii?Q?LhHTK4jpsKpuqad+U4d1/qcVudsCzm6jaFHFbR0boIXsCU5QmnDNCl05z6vC?= =?us-ascii?Q?v/YmqZTl+DECxyerdXJfz1WZ3K+wmecJNIKMtXRVVF3f6BJSmv2b92DGZDpe?= =?us-ascii?Q?z4u1IQBFREAQMBKMj1+KhdoNyjVsAR2HAeiMemEgOd86WRCtcxB7Xvz1xdId?= =?us-ascii?Q?pbC1X2pXbe3H3K8R0vKD4Sl+FmsZ70T68d+Z1yXIDugfAlktULSLAnMr/4hn?= =?us-ascii?Q?kfvQkjBx6vlxGvQS1jNmWzxtnXM0K4XQdHNwWVjxRmMkKgqV0ecM+5HNfZew?= =?us-ascii?Q?YWTwhiizN5arcEjTJKyTzg8BX6BvX4T9B9Dr+w7SClQeTJ52vyt6rx3KmpKa?= =?us-ascii?Q?9OGWZqgbqnNW7yI4xWk+/rcCjJhgcqmbHVDD+Ux2v1boEFxxtFb28iM27w2+?= =?us-ascii?Q?dqN0CODn1y2TQB32oUkhrhLYzMiYRneiewBEK4haq0hwq6tJDhqRvkSk01OO?= =?us-ascii?Q?3y/qVRN6qkUovsEr/4p3R/oHcV6MTXC0XWbfCKsrnhnZPmKTpPIUvZo7KYql?= =?us-ascii?Q?7GK0ueyKHBYsyQnUDIq9LZUcBdudqdjVuUJGR7De5fF8tjepGhqVdKtxnfmf?= =?us-ascii?Q?Vn7UFrC38fen/zp6phgC/8j0XpzvNRyWYNWDl/SspLgZLf97nIUVW7owbUA0?= =?us-ascii?Q?bEraOuDM/mEyRiRuQuYCvV//4Vsgntlzdfw9oY39BHCPis9UDXkCoK9jZRFP?= =?us-ascii?Q?4PJ9TBqr/vPq4kQdv24GD9Bc57GgHGIdLIJKn6mL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92503ac5-30af-4c9e-70bc-08db1ead7cc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2023 01:44:27.3750 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qSfw1XbKjXV+HpIQ9QFjFKF25DEK7i7mdsKr75Z9hFQONIuMFu2uAkd2KF8nmlCHoAYxtnzPgy4k+4Y0aywOBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6421 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gerd, Could you help review this patch set? Thanks Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Tuesday, February 28, 2023 9:50 AM > To: Gerd Hoffmann ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to > MdePkg/CpuLib >=20 > Hi Gerd, >=20 > Yes, just like you said, no code logic modified, just relocation. >=20 > And thanks for your suggestion, but since it is a simple code change, but > contains too many patches, if it is ok for you, I don't plan to send the = whole > patch series this time. >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: Gerd Hoffmann > > Sent: Monday, February 27, 2023 5:21 PM > > To: devel@edk2.groups.io; Liu, Zhiguang > > Cc: Ard Biesheuvel ; Yao, Jiewen > > ; Justen, Jordan L > > Subject: Re: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib > > to MdePkg/CpuLib > > > > On Mon, Feb 27, 2023 at 03:23:57PM +0800, Zhiguang Liu wrote: > > > V4: > > > This patch set has already gotten reviewed-by except OvmfPkg. Also > > > V4 > > has a little code change for OvmfPkg. > > > So I only sent pathces about OvmfPkg (patch NO.1 and NO.4) to avoid > > disturbing other Package Maintainers. > > > Other patches can check the V3 version or check the PR link > > > https://github.com/tianocore/edk2/pull/4066 > > > > It is perfectly fine to repost the whole series, especially when v3 > > was posted months ago. It's good to add any review tags to the > > patches though to make clear which are reviewed already and which are > not. > > > > > UefiCpuPkg which does not meet the design spec. So merge UefiCpuLib > > > to CpuLib is a good way to sovle these problems. To minimize the > > > impact,this change is carried out in four steps. > > > > > rename {UefiCpuPkg/Library/BaseUefiCpuLib =3D> > > > MdePkg/Library/BaseCpuLib}/Ia32/InitializeFpu.nasm (100%) rename > > > {UefiCpuPkg/Library/BaseUefiCpuLib =3D> > > > MdePkg/Library/BaseCpuLib}/X64/InitializeFpu.nasm (100%) rename > > > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c =3D> > > > MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c (93%) > > > > So in essence this series moves the code unmodified (other than some > > reaming due to the new location) and updates all references? > > > > take care, > > Gerd >=20 >=20 >=20 >=20 >=20