From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 32187D8042C for ; Mon, 24 Jul 2023 02:47:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mVTqGAjh4AWJfJv4YtwgH+vIA7xGkflTpjp56Xm5z/c=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenan tHeadersStamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690166836; v=1; b=iDo2XTCyzqyoXpkH9WjfMB/4sw8F0uHJXkLoJ0yQE3C+RSbHCFC1lyJld8+r9aSiEb1+Un49 OZkRwXirSKgIyCiqhuhK1xmJCqXv5SlFHdedkqOwqqWm71eTt4EjnxQsLVzTdyPgeeMX377EUua F8U5AVZledbEqiVAeMypT0nw= X-Received: by 127.0.0.2 with SMTP id Hc3BYY7687511xwZIHQgkGFN; Sun, 23 Jul 2023 19:47:16 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.39564.1690166835760503007 for ; Sun, 23 Jul 2023 19:47:15 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="431129972" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="431129972" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2023 19:47:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="795617200" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="795617200" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 23 Jul 2023 19:47:14 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 23 Jul 2023 19:47:14 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 23 Jul 2023 19:47:14 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 23 Jul 2023 19:47:14 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 23 Jul 2023 19:47:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKPBcndp0CJxwdgYTg+ml3+Nejk3ZBa5znxITDgtV+JjmgY7JjrYrgwVz0VPw4NwS5krNtMwt1uXPJ3RSjvalYS2c0jRQJuJw9H25RdGlO5U3C2uwcyOCh5qR05EkExFfzTJcn+4/zEsf+md7Hjw6YmqGVkZqjhLUG7cqLcjqXCgt+ptLRd/nBdNtO9xgoHTbjtfuccn9cMNrG0Uop71pgamS6YhQWIrAzyxi+sApl2vF4CtFMYuj+PJ+hFKYSTh4QbY4Tko15FsakKNwF3DuRuSoey8VokVmzMVWEvBD/kohgGgOBgR4Afxo21hcnlO/4DXsWjYu3povO0Be+9tsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sQTJ1/MlgEvScGpOYhBZtAwcjBFVJEBjNXo8pXEOkY4=; b=j6BLUeK4Dn0/L6TQFyS6s7U93lSgvRZQFiI92L3yffUmI+5XPLdjoLpuXxYkUz5r8HQNprYEsjd7VwThsEDgfaLRDggX/p8dhQDhtFNp4/6LTZISZAIkDoBAeOLLs2nqnsbin6rNh/D5CAkrrkfJA3yVhYYSzXmcs3KcQU4lJs9EevifMOcxsv5/Q3x88lsBOb/mqAr4K4l128YEm1LDJuFB1YlL2ci2Z60vxR4WkbyfrCDsCAxBluSK9/WskRLNK/YrM2B8ofeRd/BOSssDCADQXcp/rGJWNsv5vJvMYe9Dei7nEw9Vn0iKDyuhlzgU6iVvTGct9cIeLEWRwo37vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by BL1PR11MB5954.namprd11.prod.outlook.com (2603:10b6:208:385::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Mon, 24 Jul 2023 02:47:11 +0000 X-Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::7748:2c9d:c575:c42f]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::7748:2c9d:c575:c42f%4]) with mapi id 15.20.6609.032; Mon, 24 Jul 2023 02:47:11 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "Liu, Zhiguang" , Gerd Hoffmann , Julien Grall , Anthony Perard , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 3/4] OvmfPkg: Remove applicationProcessorEntryPoint Thread-Topic: [edk2-devel] [PATCH 3/4] OvmfPkg: Remove applicationProcessorEntryPoint Thread-Index: AQHZst0XZ1sCvHBqdU+4JaU8+zO2PK/ITCtA Date: Mon, 24 Jul 2023 02:47:10 +0000 Message-ID: References: <20230710031706.1329-1-zhiguang.liu@intel.com> <1770634CE62FBB6D.7145@groups.io> In-Reply-To: <1770634CE62FBB6D.7145@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|BL1PR11MB5954:EE_ x-ms-office365-filtering-correlation-id: 862e6e5c-5bf9-47c4-4a55-08db8bf04734 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7FCe0HhGuUFNyGRgpoFy3UiZybSHolRD+43Di+S8rGg76h6k2vB3Erut2WGYd6yZkPETL1PgOhvQGzfe0k5cexyhi4OSgDv4mbd0fxJra8cvA/u5ShygDBT8nYdhxBf/224DBIFeIhmZ/Svq2edShRBSOEl7Sk8Xti78fI1XhXyAUnwiL0l2iD15Z3kc2BWbHp2SfVnmg8ZPu8OvGGir/REJm0PNEFfUOE8HhIeYoaE7DuK+y2EmH1q0IU7POLRa9Bnc3WYqjpnQUfFPluy99w4tDmEA8D3Bd5RlUgrdcFnKPR59cop8X1Mscqt1JFfHclhnZQmpiOGXgypBim6TvN9sTb/RDm4gCzSOxAcMrNf8dpJIp4/RJ79qVff1e+dvAFTcXx9L3lOOiwfWdCFZTcy63jWV/3QdzX+pScqDKAH8W2uhPdFVaag0J80y+yx3QMyKiSx9/KC/lJOQX7ByzYiV0WwWySqn7QTPgfnl70QL794ziIoFVj7E/0GGQbx5zt3xPTkzDAvLq4PHP3zYFQu9K6/NVqVpZHH0mV7PNkw0AqB9HJGpgVh/EUpskdDaaOpQYZNK1iHx5lwlud8OzNNfl6Sn0yhOvEoFlA77p7dDEtylUE+qAsEBOnD5q3Qn+MxPkQ1lfQD70V+371OZXd5IVX8kgClXjeA3h/QDh30xoTbh6PltbLbrw97Jg0SPpP6uZ3qlLo6ApzUs1cn3+Q== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RYzo2CeGJB7qKINGnm4y1wVYbH5/wy+Ow7OdDMVGuapZZjqdxQcEWru27MYz?= =?us-ascii?Q?6lGKwlkMpQKRhEEdW9f1G+hTbJxMfRcWMFVGhjrC0eR8nmFKy0L+eMTz52+F?= =?us-ascii?Q?GZHJchJU7cfs1v5L6HgAyQjk25bnMoAqEoNobkI1Mm/hf+2lEL50SFsuf1Oi?= =?us-ascii?Q?SAwOPsE8Oq6FT900YSUXgeyNqFIN9OcH9bVGmc3kn9uxLY6rC+S4az3Whvzr?= =?us-ascii?Q?rsWVPQjzqKXxeRzh1F4cpD+YC8FQP+2t/DwvG3IuHpCDavuCc/4iYvdSIp03?= =?us-ascii?Q?fWfwc8vra6wgXmIOoiD3zkhOEbOs3OJ7WkMPTqx52I5YcWUKZqKHyskfaDYz?= =?us-ascii?Q?eei5JdY4nvEKgVCFnlaHdXBCwETIBEmy7fkRQ4tVNReeXvnDo7t2MaCRNZpD?= =?us-ascii?Q?jqJjaee+H7wfN7NJ8qirmjXUpEziMctxevzOO/TRfvl76ZjsCS/JC4FibBF6?= =?us-ascii?Q?GkiQuTBby0OEEFpCls0CTXwQEMQ1gE9gibpPauz2Hlr1xBK8M8xSdUt2tcKg?= =?us-ascii?Q?ISuszy0ToETD09f4L5qPnYPUUcZZRGi1ppzKImMGeuPq0idNie+JcavewW1e?= =?us-ascii?Q?yx4MnJWGnOGaXwj8Gg36Fgh7VlvIm1PdJF2Xt3ALVuuyf1ZhTEGwiEU3zHcE?= =?us-ascii?Q?tTglIDtDkkOuQUwOImPRQLn/AIzWypNiUfna0rHQObYZiWMnLZy3GiNOI/ql?= =?us-ascii?Q?+SLEvnVLIT6IfTCP6k8z5+IxxF9WyAPrAuu85aOj1IlyJIOZldkY1i0vV+bz?= =?us-ascii?Q?liNciOLEzIucyaXTpypttyz/zo6KEnxXlB3/mwLAsvOz/BHuLYLUCyLOflQ/?= =?us-ascii?Q?dGDI9KTGBd/qL/m5iuKY+NwDh0x0jI/hQ7KlpCvXTtSQKIREf1vVYrOSMLt4?= =?us-ascii?Q?goRrQFj78l0aEAt9gPHUOk/xWDYqOd2Sma0v+PDvwdNpGhKceDT4MDKuuhVX?= =?us-ascii?Q?YaKulEblu3milo2Sod8NN4pFO+kAXfLncrqU9frAQZYwpxd5HCXu0UZ1F62J?= =?us-ascii?Q?weVcSv5B/zaa5GfoVnjOCVBPiYoHgrAe9Cy5KRhLMQD9ab2iKb2k3aui6rLe?= =?us-ascii?Q?9d/d2F8tz6y10ikynno7gYXABVCMsvdZkLmMd76Fxsn2nOkSkRxsfFxFyRpb?= =?us-ascii?Q?vVtWStp6mgRofUIDl9Vq9yZNp4jC9y/YTzdyhKBxvUht5V1NdL17X7r/5glg?= =?us-ascii?Q?bspEZEHe7Unx6yA2GWH9tcjsMCRNWkuD1yygQyz+eLsFTkjvO9aLl7d/N7NR?= =?us-ascii?Q?tJnfgmOnwvVmNIaGd3fip7/KwutshZmgaDCYtclNQzqo+EgRYBvMocpBFAZI?= =?us-ascii?Q?+8ZhaYFDh5dzat9Xgjrwp9Qfgv4W37WdqVwkNVDcRe/sl7tzCG9uq0JKLEg9?= =?us-ascii?Q?TWySntuRtL8Y+RTdaly628pbGVgNoQGAQmeEIYwIscyVxoI6Q+keS/NBWa1b?= =?us-ascii?Q?u0GH3GBcCQ1IkVZddQ4vYtVpZEEJgwJ4YRX/hAbHRTWIdzMAIT2kjWK3Y+A4?= =?us-ascii?Q?oU4WPxsdaHT1eKAlqzs84fE+dtruRegkGXq7uaQStlVt2okrYdM1thmL2LWK?= =?us-ascii?Q?Tl8PQg0pSZF2+Rcs3yY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 862e6e5c-5bf9-47c4-4a55-08db8bf04734 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2023 02:47:10.5799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gr2QjrUEiKsZ5/hVYndNU3oKX9fQFB+htFjpFrh/5oln8zt59YhB40W7uIafLFFKYlARINvu1b/AQk8uuPeSdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5954 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZXQKr22OJv41WEvG5d8ClzYVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iDo2XTCy; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi OvmfPkg maintainer & reviewer, Please help review this patch. Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Monday, July 10, 2023 11:17 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Ard Biesheuvel > ; Yao, Jiewen ; Justen, > Jordan L ; Gerd Hoffmann > ; Anthony Perard ; Julien > Grall > Subject: [edk2-devel] [PATCH 3/4] OvmfPkg: Remove > applicationProcessorEntryPoint >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4494 >=20 > Current reset vector uses 0xffffffe0 as AP waking vector, and expects Gen= Fv > generates code aligned on a 4k boundary which will jump to this location. > However, some issues are listed below 1. GenFV doesn't generate code as > the comment expects, because GenFv assumes no modifications are > required to the VTF-0 'Volume Top File'. > 2. Even if removing VFT0 signature and let GenFv to modify, Genfv is hard= - > code using another flash address 0xffffffd0. > 3. In the same patch series, AP waking vector code is removed from GenFv, > because no such usage anymore. The existing of first two issues also appr= ove > the usage is not available for a long time. >=20 > Therefore, remove AP waking vector related code. >=20 > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Zhiguang Liu > --- > OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm | 15 +++------------ > OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm | 16 +++------------- > 2 files changed, 6 insertions(+), 25 deletions(-) >=20 > diff --git a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > b/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > index 12f2cedd67..8f94da89f7 100644 > --- a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > +++ b/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > @@ -160,22 +160,13 @@ guidedStructureEnd: >=20 > ALIGN 16 >=20 > -applicationProcessorEntryPoint: > ; > -; Application Processors entry point > +; 0xffffffe0 > ; > -; GenFv generates code aligned on a 4k boundary which will jump to this = -; > location. (0xffffffe0) This allows the Local APIC Startup IPI to be -; = used to > wake up the application processors. > -; > - jmp EarlyApInitReal16 > - > -ALIGN 8 > - > - DD 0 > + DD 0, 0, 0 >=20 > ; > -; The VTF signature > +; The VTF signature (0xffffffec) > ; > ; VTF-0 means that the VTF (Volume Top File) code does not require ; an= y > fixups. > diff --git a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > index 56749bdbc9..67156d8252 100644 > --- a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > +++ b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > @@ -39,23 +39,13 @@ xenPVHEntryPoint: >=20 > BITS 16 > ALIGN 16 > - > -applicationProcessorEntryPoint: > -; > -; Application Processors entry point > ; > -; GenFv generates code aligned on a 4k boundary which will jump to this = -; > location. (0xffffffe0) This allows the Local APIC Startup IPI to be -; = used to > wake up the application processors. > +; 0xffffffe0 > ; > - jmp EarlyApInitReal16 > - > -ALIGN 8 > - > - DD 0 > + DD 0, 0, 0 >=20 > ; > -; The VTF signature > +; The VTF signature (0xffffffec) > ; > ; VTF-0 means that the VTF (Volume Top File) code does not require ; an= y > fixups. > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107155): https://edk2.groups.io/g/devel/message/107155 Mute This Topic: https://groups.io/mt/100322593/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-