* [PATCH] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf
@ 2023-04-12 6:39 Zhiguang Liu
2023-04-12 8:03 ` Ni, Ray
0 siblings, 1 reply; 3+ messages in thread
From: Zhiguang Liu @ 2023-04-12 6:39 UTC (permalink / raw)
To: devel; +Cc: Zhiguang Liu, Nate DeSimone, Ray Ni
Remove SmmLockBox.inf to fix a build issue, because it is already
been included from MinPlatform dsc/fdf file
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
index 1719513d3a..221706ae03 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
@@ -202,7 +202,6 @@ INF UefiCpuPkg/CpuDxe/CpuDxe.inf
INF MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
INF MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.inf
INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
-INF MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
--
2.31.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf
2023-04-12 6:39 [PATCH] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf Zhiguang Liu
@ 2023-04-12 8:03 ` Ni, Ray
2023-04-12 8:24 ` Zhiguang Liu
0 siblings, 1 reply; 3+ messages in thread
From: Ni, Ray @ 2023-04-12 8:03 UTC (permalink / raw)
To: Liu, Zhiguang, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L
Zhiguang,
Can you please remove it from Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc?
Thanks,
Ray
> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Wednesday, April 12, 2023 2:40 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf
>
> Remove SmmLockBox.inf to fix a build issue, because it is already
> been included from MinPlatform dsc/fdf file
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> index 1719513d3a..221706ae03 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> +++
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> @@ -202,7 +202,6 @@ INF UefiCpuPkg/CpuDxe/CpuDxe.inf
> INF MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> INF
> MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutor
> Dxe.inf
> INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
> -INF MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
> INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
> INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
> --
> 2.31.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf
2023-04-12 8:03 ` Ni, Ray
@ 2023-04-12 8:24 ` Zhiguang Liu
0 siblings, 0 replies; 3+ messages in thread
From: Zhiguang Liu @ 2023-04-12 8:24 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L
Yes, nice comment
Thanks
Zhiguang
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Wednesday, April 12, 2023 4:04 PM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: RE: [PATCH] SimicsOpenBoardPkg: Remove duplicated
> SmmLockBox.inf
>
> Zhiguang,
> Can you please remove it from
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc?
>
> Thanks,
> Ray
>
> > -----Original Message-----
> > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > Sent: Wednesday, April 12, 2023 2:40 PM
> > To: devel@edk2.groups.io
> > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [PATCH] SimicsOpenBoardPkg: Remove duplicated
> SmmLockBox.inf
> >
> > Remove SmmLockBox.inf to fix a build issue, because it is already been
> > included from MinPlatform dsc/fdf file
> >
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf |
> 1
> > -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git
> > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> > index 1719513d3a..221706ae03 100644
> > ---
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> > +++
> > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> > @@ -202,7 +202,6 @@ INF UefiCpuPkg/CpuDxe/CpuDxe.inf INF
> > MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> > INF
> >
> MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutor
> > Dxe.inf
> > INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
> > -INF MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
> > INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
> > INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> > INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
> > --
> > 2.31.1.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 8:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-12 6:39 [PATCH] SimicsOpenBoardPkg: Remove duplicated SmmLockBox.inf Zhiguang Liu
2023-04-12 8:03 ` Ni, Ray
2023-04-12 8:24 ` Zhiguang Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox