Re: [PATCH 1/3] UefiPayloadPkg: Simplify code logic

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Hi Ray,
The function DetectAndPreparePlatformPciDevicePath is the second parameter of VisitAllInstancesOfProtocol.
It follows the below type:
typedef
EFI_STATUS
(EFIAPI *PROTOCOL_INSTANCE_CALLBACK)(
  IN EFI_HANDLE            Handle,
  IN VOID                 *Instance,
  IN VOID                 *Context
  );

The same function pointer type is also defined in OvmfPkg.
I didn't change the function pointer type to avoid same type having different definition in edk2 repo.
Do I need to consider that? What's your suggestion?

Thanks
Zhiguang


-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Tuesday, May 10, 2022 3:39 PM
To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Maurice Ma <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: RE: [PATCH 1/3] UefiPayloadPkg: Simplify code logic

> 
> +DetectAndPreparePlatformPciDevicePath (
> 
>    IN EFI_HANDLE  Handle,
> 
>    IN VOID        *Instance,
> 
>    IN VOID        *Context

Is "Context" needed? Can you please remove it?