Re: [edk2-devel] 回复: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Hi Liming,

Thanks for the comments. This patch is merged before this comment, but I can still send another patch to modify if needed.

However, I think the implement in this patch is more simple.
The implement in QuarkPlatformPkg need changes in inf, dec and dsc files, and is not as intuitive as just getting and setting a variable.
It may be simpler if the implements can reuse a same DynamicHiiPcd, do you think it is possible?
If I misunderstand anything, please correct me.

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Monday, March 15, 2021 9:36 AM
> To: Ni, Ray <ray.ni@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] 回复: [Patch edk2-platforms V2]
> Intel/BoardModulePkg: sort load option in the first boot
> 
> Zhiguang:
>   I see QuarkPlatformPkg uses PCD
> gQuarkPlatformTokenSpaceGuid.PcdBootState
> to decide whether current boot is the first boot or not.
>   This PCD is configured as DynamicHiiPcd, and be set in
> Platform\Intel\QuarkPlatformPkg\Library\PlatformBootManagerLib\Platfor
> mBootM
> anager.c
> 
>   Can you use the same solution in Intel BoardModulePkg?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Ni, Ray <ray.ni@intel.com>
> > 发送时间: 2021年3月10日 17:56
> > 收件人: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> > 抄送: Dong, Eric <eric.dong@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Agyeman, Prince
> > <prince.agyeman@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> > 主题: RE: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load
> > option in the first boot
> >
> > 1. DataSIze should be set to sizeof (BOOLEAN) before calling
> > GetVariable()
> >
> > > +      Status = gRT->GetVariable (
> > > +                      L"IsFirstBoot",
> >
> > 2. Can you please define a macro in this C file for IsFirstBoot string?
> > e.g.: #define IS_FIRST_BOOT_VAR_NAME L"IsFirstBoot"
> >
> > > +      if (IsFirstBoot == TRUE) {
> >
> > 3. Please remove "== TRUE". Just use "If (IsFirstBoot)".
> >
> > > +                        L"IsFirstBoot",
> > 4. Please use the macro defined as above.
> >
> > >
> > > +                        &gEfiCallerIdGuid,
> > >
> > > +                        EFI_VARIABLE_NON_VOLATILE |
> > > EFI_VARIABLE_RUNTIME_ACCESS |
> EFI_VARIABLE_BOOTSERVICE_ACCESS,
> >
> > 5. Please remove "EFI_VARIABLE_RUNTIME_ACCESS".
> >
> > > +                        1,
> > 6. Please use sizeof (BOOLEAN) instead of "1".
> 
> 
> 
> 
> 
> 
>