From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.22235.1628513246281603155 for ; Mon, 09 Aug 2021 05:47:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=V7XekYV1; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: zhiguang.liu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="214412735" X-IronPort-AV: E=Sophos;i="5.84,307,1620716400"; d="scan'208";a="214412735" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 05:47:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,307,1620716400"; d="scan'208";a="525240579" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 09 Aug 2021 05:47:25 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 05:47:25 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 05:47:25 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 05:47:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FFzmO21s/l/IxK4fpE/2xYHK3WzJLu2qxqb2wPx3j00Xlyx8UFhOiM7qTwj/2+AO14JxPOsZm3yPXL+CzAZbBMTwTd1gZDQbgQEf0MfoRw2Qafb8yQbHhau6WfWg61TTm6bMihXLHYD61u+2l0Sk5MpVRre8DTOiNTPSUPEuDTHhdRo8PBNaNI8LVdpDkXySnSCxx/akpjWMxV0qXCMUu1NcPnQL/bgVBLNqmC5IOjzB7H3v/8Sbe/orWEBgr+Do29Hoj7ltf5wA0Rrv7wCEFDwjeObwKP6YkErDEd6oqUwbe4i7/wOTWiDKyE35ukZklslRtW2IwTpJ3ONZXadCmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WpqIP/MDznTN/ka27JdlI8wKFl0DNc0iT89wkMtk1qU=; b=Q6bbeMRXN8gzjmseGA8aZFWCQCsdIZP7g41osF//gea7DtvB1qQd8rt1lCa7aFxUHlZIs9EGP/Q4G5/GNIJ3D5IKSVS/ezlvNpE0gYI0Py/Ci1evsMV2QTAT5bNF/NXF9d1wR5e/lzNAC1by92fh8dyA/VCZ5/dpWMp4urVMhs/ietar2AO6U8R6+tCewLXl23i8wl56qtJ6SBnoiA+JXuDiSN/0bqhkSvb0+K+s+Ap4VkIuT8WDgKm67MWe4bcFMEKaAVzfCxLAQWliZhD8xd+qQDf1dwIp2t6YX3tl2BgxK3ePMHuFtQr+jaSWVIZ/OgW1mHMhdPkTgoUQAdVDrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WpqIP/MDznTN/ka27JdlI8wKFl0DNc0iT89wkMtk1qU=; b=V7XekYV1rfzaTRFtem9S7rLgCOUXupDKsBzaVD4l2GwXEGOVQgu/skTaBrWR+LdT/N3pt+dphK9KB87h2hOdtvyR25nKMtAIF6lZ0WKCrk2vHhCKxiI29Yh/SYv4/xHWUOaIcRb3dno9HHDed9FR+8xZPCm5e3iFS1ll4qYYSow= Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by PH0PR11MB5112.namprd11.prod.outlook.com (2603:10b6:510:3b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.26; Mon, 9 Aug 2021 12:47:23 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::c836:8db1:b5f5:4062]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::c836:8db1:b5f5:4062%9]) with mapi id 15.20.4394.023; Mon, 9 Aug 2021 12:47:23 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "Tan, Dun" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib Thread-Topic: [edk2-devel] [PATCH] MinPlatformPkg: Fix the incompatible change about SecureBootVariableLib Thread-Index: AQHXjP6hucNSqAq40E2j0zT4/BKMqKtrHvDA Date: Mon, 9 Aug 2021 12:47:23 +0000 Message-ID: References: <20210809091128.1029-1-dun.tan@intel.com> In-Reply-To: <20210809091128.1029-1-dun.tan@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ce544fe-eaaa-42cf-ddc7-08d95b33d5be x-ms-traffictypediagnostic: PH0PR11MB5112: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5tOk7SZOlWBrQ8PU3jYojoKB5C+1l/zT6zM4VeAi0Sxo/bLVUOU7A/BuPkkdXsLkAfZO4eooLA8w7RsIuaFfQf4OS4W29A8B3qsmR5f9QcKO4KEKqR42DSQ5I6X7Dadtbw0mEq2if/nlfOD+edvZTMc14VTWAiCcaquTEse29vWyyGSe7NUry2qKPq9qm+vApVikFnV48VigbpKlVTaGc9Wx2mQic6jPcwmnpsCAFcWPmYloRuULvOQGThHPBUQjZRMZv0QolDC4aVNkb5mI/FZqILRm5VYPQDzF1PPTZVi3s0A7lk4JBZX3AN4BhCzv6zavpiCe5bSYfo+Jq9Dpo03VvD7ggAN3ld5r/GksSgzgCe5CGkd2/nEWrd9+BdW2t28Lmq/s22ghDvMYMVLh8ZGi9KY66WXKDTe9Z/w5KfhCd+YUTlsez1UGF2tFigrGxi5fyhKmfrK/6kpNIrqxgBQuC2QDDA731gKMsyY5tboBfCIBWFMsHj08fyRdd9DRDEvJgc4dqIhIJuQN7RSzfJbs5M/zfB5vdcQ4HgV8ZOtfxHISP8imEcNq+zPBWnoQf+VGKS3qa9XH/RMtpc58Wrsz0oBoypwFqe+sN+QxhjP4KyF1KFTn9OU7BafCd4P4ygJ6Q5ncenDtBxM1qISsMyoifU0IAGdGqp6kyfbGd0vd31ALaunrRfPsmLwhiXEY1P48b8RpAq8055HgsWFPCAOZM9qLjnKFKxoWEf4lJynEQMG2vUrGU4c60XYAE2uXWg0E2Z/ECmoBLbMuXAE338KYTWtp9gHJD9EqAX/HjQX2F7NZgc4LjYyv2HhUoB7i8hKyH38cA5jbqmDxriliYA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(66556008)(38070700005)(26005)(66946007)(2906002)(55016002)(66446008)(316002)(966005)(8936002)(6506007)(83380400001)(110136005)(122000001)(4326008)(107886003)(186003)(38100700002)(8676002)(66476007)(54906003)(64756008)(76116006)(86362001)(33656002)(52536014)(6636002)(53546011)(7696005)(478600001)(71200400001)(5660300002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IoY7m/mIJvhLWrL6dP2aUZKGUlE0QqlTkTxJqB0yREJXLsAnba/yG5KHhcDt?= =?us-ascii?Q?tBn3MnHtof/2Q40PXH1bzZzTnCsqNoHGTlzJszX1sxKh5K6E3NevYYh03u7z?= =?us-ascii?Q?RNV/eIvDSgBGW8LGFRtu2JcGhULeDdD3Loxfee5+5uwoHFp8BuIOrZc2Y2rn?= =?us-ascii?Q?Bxj0O23pM/S7zDbirT0Vd+bXSETDGYF9LxwIXX0O1JiutiMiv2UYuMz0xKhd?= =?us-ascii?Q?gPJ5u9Rt6dcJVwhK1hXPvD5chT5vkgngl4Ke1xJcDvTXf/BzC7mLCvDsKdRV?= =?us-ascii?Q?SjmMBquWFjJs76Dor8zOLrUqp9kXsxrILVuJfPOEskSDH5PoAfbl1YzRCPe3?= =?us-ascii?Q?mVJGPhxHnVa0UAGVxVP3/CR3jzSICa6OS3jAt+nckw7LJR1jC+mbQ6wcl4uB?= =?us-ascii?Q?Ss5yDu5x0Mf6Nf8BQSEi+4rRpBlpz753onu1JCDjxqn43XpnRqfVUxXP5Swl?= =?us-ascii?Q?ENlpcZW9k1Bi4vj/uIwmN96yHMX2YsM1TG9/1qlkd/5YeutAaxt4DllXV71v?= =?us-ascii?Q?XPYA0Dat0DZRl9Dzn+KylAvvN8yyF50dhpiryvEtZz9apDZQm22BBdwZmaqV?= =?us-ascii?Q?hJ0JBBVoYiFS0Bb1hCNhXcIRSLmQeCUnMOb/mOKE4rK1BMbyxETUtThA0qji?= =?us-ascii?Q?UCywD8qPJCqKbNhFTTrtlrebT+H1vpAfEMjcm3YAuBirmcYX9euMRX0o5HAy?= =?us-ascii?Q?A5uWr4GYJSN1QCmUdhZ2H8Y4lnaCHt0WMxnA2wkvTo2Mk7sH8xUtjhFtYxvw?= =?us-ascii?Q?rmHbjC2lnS0ta20JnQEZpaU/0Jb40F9KbBiAiv0UQxm9TXikDpuHiAPQPjs3?= =?us-ascii?Q?EeH0AszWg2wTPb+JQfXMCRAKzy58tGcO58zaniw432DBcG1fdvy4UDy1556l?= =?us-ascii?Q?3iMj5YGgjDyXy7UAILl5WsyGudfOWe8ImGSG1Vtvzyjr4Yar1FPHar+imqux?= =?us-ascii?Q?CHaV4YPx77Nn4Z21QFEJS0Mk78YOMdQLoO1DljkzFOFnjPyV1IxlDB+LxwX2?= =?us-ascii?Q?CHmynI9gJKJx699fFXy63Ga5QIPEhOgXvtVbZYWfruz5T5SsGoW6cZUUbbyX?= =?us-ascii?Q?+m+1Utuv1lzHraJDDAHz1UMQVQgyfB9Gfg1aEUEUipR8NXhuFOEj2/dD7PA+?= =?us-ascii?Q?1961Dhke+zV3YvzkvFebTGw5tgACz5XQ/YVJxwg+oP4b9yKn7KPqQMVbaeC0?= =?us-ascii?Q?jvnW2Lza0ZpMOSCe977vW6JEiJcQh0Ywk+eQfd7GfrqV8+X8kv7XoV0UTmll?= =?us-ascii?Q?SdsowZknlNe/Fl1INA8BriW62rytnCRxbdmDjSQvzpmMLKMLyVZZJjTST8tF?= =?us-ascii?Q?qx4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ce544fe-eaaa-42cf-ddc7-08d95b33d5be X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 12:47:23.6265 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qAWPaQ5T/iMoV5Xr68Q3VzzLMeXHM+AvwSuX8Gfne9IsT5TLUbJTtfDuWl+mzgjYZC3GGCqwyRvWfgfjq6gv/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Dun, SecureBootConfigDxe.inf will also consume SecureBootVariableProvisionLib li= brary. Can you also add the library in this patch? Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Monday, August 9, 2021 5:11 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric ; Tan, Dun > Subject: [edk2-devel] [PATCH] MinPlatformPkg: Fix the incompatible change > about SecureBootVariableLib >=20 > The newly created lib will be consumed by SecureBootConfigDxe.inf in > CoreDxeInclude.dsc >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: DunTan > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > index b154f9615d..5157c87a9a 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > @@ -139,6 +139,7 @@ >=20 > !if gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable =3D=3D TRUE > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.in= f > + > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBoo= t > VariableLib.inf > !endif >=20 > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20