public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "Tan, Dun" <dun.tan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version
Date: Thu, 9 Mar 2023 02:23:31 +0000	[thread overview]
Message-ID: <PH0PR11MB50484F881482F3430E127CA690B59@PH0PR11MB5048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230303072629.1781-3-dun.tan@intel.com>

Hi Dun,
Do you mean the mailbox version?
Here is from spec
	MailBox Version | Version of the mailbox. 0 for this version of the spec.
If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR _WAKEUP_MAILBOX _STRUCTURE_VERSION 

Thanks
Zhiguang

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, March 3, 2023 3:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup
> Structure Version
> 
> Add define for Multiprocessor Wakeup Structure Version. The version for
> MpWakeupStructure in Spec6.4 is 0.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 16c2faaaf2..4920939bdc 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -601,6 +601,11 @@ typedef struct {
>    UINT64    MailBoxAddress;
>  } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
> 
> +///
> +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4
> +spec.) /// #define
> +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION  0x0
> +
>  ///
>  /// Multiprocessor Wakeup Mailbox Structure  ///
> --
> 2.31.1.windows.1


  reply	other threads:[~2023-03-09  2:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03  7:26 [PATCH 0/2] Modify defination for MpWakeupStructure duntan
2023-03-03  7:26 ` [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan
2023-03-09  2:06   ` [edk2-devel] " Zhiguang Liu
2023-03-03  7:26 ` [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version duntan
2023-03-09  2:23   ` Zhiguang Liu [this message]
2023-03-09  2:39     ` duntan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB50484F881482F3430E127CA690B59@PH0PR11MB5048.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox