public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v3 1/9] OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib.
Date: Fri, 4 Nov 2022 06:44:24 +0000	[thread overview]
Message-ID: <PH0PR11MB50486C3197CC5E7083F30A7B903B9@PH0PR11MB5048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221101075842.1218-2-zhiguang.liu@intel.com>

Hi OvmfPkg Maintainers,
Could you help review this patch, and also the patch "[PATCH v3 4/9] OvmfPkg: Remove UefiCpuLib from module INFs." ?

Thanks
Zhiguang

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Tuesday, November 1, 2022 3:59 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH v3 1/9] OvmfPkg: Add CpuLib to module INFs that depend
> on UefiCpuLib.
> 
> There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
> UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
> failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  OvmfPkg/IntelTdx/Sec/SecMain.c             | 1 +
>  OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/OvmfPkg/IntelTdx/Sec/SecMain.c
> b/OvmfPkg/IntelTdx/Sec/SecMain.c index ab01ec9ab1..eef47f17e4 100644
> --- a/OvmfPkg/IntelTdx/Sec/SecMain.c
> +++ b/OvmfPkg/IntelTdx/Sec/SecMain.c
> @@ -17,6 +17,7 @@
>  #include <Library/BaseMemoryLib.h>
>  #include <Library/PcdLib.h>
>  #include <Library/UefiCpuLib.h>
> +#include <Library/CpuLib.h>
>  #include <Library/DebugAgentLib.h>
>  #include <Library/IoLib.h>
>  #include <Library/PeCoffLib.h>
> diff --git a/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c
> b/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c
> index 74cb55611f..0e2515ca38 100644
> --- a/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c
> +++ b/OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c
> @@ -11,6 +11,7 @@
>  #include <Library/BaseMemoryLib.h>
>  #include <Library/PcdLib.h>
>  #include <Library/UefiCpuLib.h>
> +#include <Library/CpuLib.h>
>  #include <Library/SynchronizationLib.h>  #include <Uefi/UefiBaseType.h>
> #include <Library/TdxLib.h>
> --
> 2.31.1.windows.1


  parent reply	other threads:[~2022-11-04  6:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  7:58 [PATCH v3 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib Zhiguang Liu
2022-11-01  7:58 ` [PATCH v3 1/9] OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib Zhiguang Liu
2022-11-04  6:43   ` [edk2-devel] " Ni, Ray
2022-11-04  6:44   ` Zhiguang Liu [this message]
2022-11-01  7:58 ` [PATCH v3 2/9] MdePkg: Move API and implementation from UefiCpuLib to CpuLib Zhiguang Liu
2022-11-01  7:58 ` [PATCH v3 3/9] IntelFsp2Pkg: Remove UefiCpuLib from module INFs Zhiguang Liu
2022-11-01 16:11   ` Chiu, Chasel
2022-11-01  7:58 ` [PATCH v3 4/9] OvmfPkg: " Zhiguang Liu
2022-11-04  6:43   ` [edk2-devel] " Ni, Ray
2022-11-01  7:58 ` [PATCH v3 5/9] PcAtChipsetPkg: " Zhiguang Liu
2022-11-01  7:58 ` [PATCH v3 6/9] SourceLevelDebugPkg: " Zhiguang Liu
2022-11-02  1:04   ` Wu, Hao A
2022-11-01  7:58 ` [PATCH v3 7/9] UefiCpuPkg: " Zhiguang Liu
2022-11-01  7:58 ` [PATCH v3 8/9] UefiPayloadPkg: " Zhiguang Liu
2022-11-02  5:22   ` [edk2-devel] " Lu, James
2022-11-02  5:30     ` Guo, Gua
2022-11-03 14:11   ` Guo Dong
2022-11-01  7:58 ` [PATCH v3 9/9] UefiCpuLib: Remove UefiCpuLib Zhiguang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB50486C3197CC5E7083F30A7B903B9@PH0PR11MB5048.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox