* [PATCH 0/2] Fix the length and PldHeader for UniversalPayload ExtraData @ 2021-07-02 7:35 duntan 2021-07-02 7:35 ` [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h duntan 2021-07-02 7:35 ` [PATCH 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData duntan 0 siblings, 2 replies; 5+ messages in thread From: duntan @ 2021-07-02 7:35 UTC (permalink / raw) To: devel Change PldHeader to Header in ExtraData.h Assign the length and revision of UniversalPayload ExtraData duntan (2): MdeModulePkg: Change the PldHeader to Header in ExtraData.h UefiPayloadPkg: Assign the length of UniversalPayload ExtraData MdeModulePkg/Include/UniversalPayload/ExtraData.h | 4 +++- UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) -- 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h 2021-07-02 7:35 [PATCH 0/2] Fix the length and PldHeader for UniversalPayload ExtraData duntan @ 2021-07-02 7:35 ` duntan 2021-07-05 1:06 ` Zhiguang Liu 2021-07-02 7:35 ` [PATCH 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData duntan 1 sibling, 1 reply; 5+ messages in thread From: duntan @ 2021-07-02 7:35 UTC (permalink / raw) To: devel; +Cc: Zhiguang Liu, Ray Ni, DunTan Change the PldHeader to Header in UNIVERSAL_PAYLOAD_EXTRA_DATA The meaning of Pld is too general Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: DunTan <dun.tan@intel.com> --- MdeModulePkg/Include/UniversalPayload/ExtraData.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Include/UniversalPayload/ExtraData.h b/MdeModulePkg/Include/UniversalPayload/ExtraData.h index 146ec845f6..1128f5f47b 100644 --- a/MdeModulePkg/Include/UniversalPayload/ExtraData.h +++ b/MdeModulePkg/Include/UniversalPayload/ExtraData.h @@ -18,11 +18,13 @@ typedef struct { } UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY; typedef struct { - UNIVERSAL_PAYLOAD_GENERIC_HEADER PldHeader; + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; UINT32 Count; UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY Entry[0]; } UNIVERSAL_PAYLOAD_EXTRA_DATA; #pragma pack() +#define UNIVERSAL_PAYLOAD_EXTRA_DATA_REVISION 1 + #endif -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h 2021-07-02 7:35 ` [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h duntan @ 2021-07-05 1:06 ` Zhiguang Liu 2021-07-05 1:08 ` Wu, Hao A 0 siblings, 1 reply; 5+ messages in thread From: Zhiguang Liu @ 2021-07-05 1:06 UTC (permalink / raw) To: Tan, Dun, devel@edk2.groups.io, Wu, Hao A, Wang, Jian J; +Cc: Ni, Ray [-- Attachment #1: Type: text/plain, Size: 1464 bytes --] Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> Add MdeModulePkg's maintainers. ________________________________ From: Tan, Dun <dun.tan@intel.com> Sent: Friday, July 2, 2021 15:35 To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Tan, Dun <dun.tan@intel.com> Subject: [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h Change the PldHeader to Header in UNIVERSAL_PAYLOAD_EXTRA_DATA The meaning of Pld is too general Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: DunTan <dun.tan@intel.com> --- MdeModulePkg/Include/UniversalPayload/ExtraData.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Include/UniversalPayload/ExtraData.h b/MdeModulePkg/Include/UniversalPayload/ExtraData.h index 146ec845f6..1128f5f47b 100644 --- a/MdeModulePkg/Include/UniversalPayload/ExtraData.h +++ b/MdeModulePkg/Include/UniversalPayload/ExtraData.h @@ -18,11 +18,13 @@ typedef struct { } UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY; typedef struct { - UNIVERSAL_PAYLOAD_GENERIC_HEADER PldHeader; + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; UINT32 Count; UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY Entry[0]; } UNIVERSAL_PAYLOAD_EXTRA_DATA; #pragma pack() +#define UNIVERSAL_PAYLOAD_EXTRA_DATA_REVISION 1 + #endif -- 2.31.1.windows.1 [-- Attachment #2: Type: text/html, Size: 2950 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h 2021-07-05 1:06 ` Zhiguang Liu @ 2021-07-05 1:08 ` Wu, Hao A 0 siblings, 0 replies; 5+ messages in thread From: Wu, Hao A @ 2021-07-05 1:08 UTC (permalink / raw) To: Liu, Zhiguang, Tan, Dun, devel@edk2.groups.io, Wang, Jian J; +Cc: Ni, Ray [-- Attachment #1: Type: text/plain, Size: 2137 bytes --] Acked-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu From: Liu, Zhiguang <zhiguang.liu@intel.com> Sent: Monday, July 5, 2021 9:07 AM To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com> Cc: Ni, Ray <ray.ni@intel.com> Subject: Re: [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Add MdeModulePkg's maintainers. ________________________________ From: Tan, Dun <dun.tan@intel.com<mailto:dun.tan@intel.com>> Sent: Friday, July 2, 2021 15:35 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Tan, Dun <dun.tan@intel.com<mailto:dun.tan@intel.com>> Subject: [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h Change the PldHeader to Header in UNIVERSAL_PAYLOAD_EXTRA_DATA The meaning of Pld is too general Cc: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Signed-off-by: DunTan <dun.tan@intel.com<mailto:dun.tan@intel.com>> --- MdeModulePkg/Include/UniversalPayload/ExtraData.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Include/UniversalPayload/ExtraData.h b/MdeModulePkg/Include/UniversalPayload/ExtraData.h index 146ec845f6..1128f5f47b 100644 --- a/MdeModulePkg/Include/UniversalPayload/ExtraData.h +++ b/MdeModulePkg/Include/UniversalPayload/ExtraData.h @@ -18,11 +18,13 @@ typedef struct { } UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY; typedef struct { - UNIVERSAL_PAYLOAD_GENERIC_HEADER PldHeader; + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; UINT32 Count; UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY Entry[0]; } UNIVERSAL_PAYLOAD_EXTRA_DATA; #pragma pack() +#define UNIVERSAL_PAYLOAD_EXTRA_DATA_REVISION 1 + #endif -- 2.31.1.windows.1 [-- Attachment #2: Type: text/html, Size: 5811 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData 2021-07-02 7:35 [PATCH 0/2] Fix the length and PldHeader for UniversalPayload ExtraData duntan 2021-07-02 7:35 ` [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h duntan @ 2021-07-02 7:35 ` duntan 1 sibling, 0 replies; 5+ messages in thread From: duntan @ 2021-07-02 7:35 UTC (permalink / raw) To: devel; +Cc: Guo Dong, Ray Ni, Maurice Ma, Benjamin You, DunTan Assign the length and revision of UniversalPayload ExtraData Cc: Guo Dong <guo.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Signed-off-by: DunTan <dun.tan@intel.com> --- UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c index c619470dbb..3de601025e 100644 --- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c +++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.c @@ -110,6 +110,8 @@ PeiLoadFileLoadPayload ( sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA) + ExtraDataCount * sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY) ); ExtraData->Count = ExtraDataCount; + ExtraData->Header.Revision = UNIVERSAL_PAYLOAD_EXTRA_DATA_REVISION; + ExtraData->Header.Length = sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA) + ExtraDataCount * sizeof (UNIVERSAL_PAYLOAD_EXTRA_DATA_ENTRY); if (ExtraDataCount != 0) { for (ExtraDataIndex = 0, Index = 0; Index < Context.ShNum; Index++) { Status = GetElfSectionName (&Context, Index, &SectionName); -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-05 1:09 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-07-02 7:35 [PATCH 0/2] Fix the length and PldHeader for UniversalPayload ExtraData duntan 2021-07-02 7:35 ` [PATCH 1/2] MdeModulePkg: Change the PldHeader to Header in ExtraData.h duntan 2021-07-05 1:06 ` Zhiguang Liu 2021-07-05 1:08 ` Wu, Hao A 2021-07-02 7:35 ` [PATCH 2/2] UefiPayloadPkg: Assign the length of UniversalPayload ExtraData duntan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox