From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>,
"Rhodes, Sean" <sean@starlabs.systems>
Subject: Re: [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't relocate in some case
Date: Thu, 7 Apr 2022 00:57:10 +0000 [thread overview]
Message-ID: <PH0PR11MB50486F830E6F2DF009452DF490E69@PH0PR11MB5048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB16319A516B4E3D1538038CC48CE69@MWHPR11MB1631.namprd11.prod.outlook.com>
Sorry, it is a typo. the example should be
The first segment is located at 0x1000, and the desired address is 0x2000.
The second segment is located at 0x2000, and the desired address is 0x1000.
The current ELF loader may copy first segment to 0x2000, which will erase the second segment.
Thanks
Zhiguang
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Thursday, April 7, 2022 8:06 AM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Ma, Maurice <maurice.ma@intel.com>;
> You, Benjamin <benjamin.you@intel.com>; Rhodes, Sean
> <sean@starlabs.systems>
> Subject: RE: [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't relocate in
> some case
>
>
>
> > -----Original Message-----
> > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > Sent: Wednesday, April 6, 2022 9:52 PM
> > To: devel@edk2.groups.io
> > Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma,
> > Maurice <maurice.ma@intel.com>; You, Benjamin
> > <benjamin.you@intel.com>; Rhodes, Sean <sean@starlabs.systems>
> > Subject: [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't
> > relocate in some case
> >
> > Current implementation of the Elf loader reuses the same memory range
> > if the desired memory range is covered by [file base, file base + file size].
> > However, there is a potentil bug, for example:
> > If the first segment is located at 0x1000, and the desired address is
> > 0x2000. While the second segment is located at 0x2000, and the desired
> > address is 0x2000. When we parse and try to load the elf file, current
>
> Why the desired address for both segments is 0x2000?
next prev parent reply other threads:[~2022-04-07 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 13:51 [PATCH] UefiPayloadPkg: Fix bug that Elf loader doesn't relocate in some case Zhiguang Liu
2022-04-07 0:06 ` Ni, Ray
2022-04-07 0:57 ` Zhiguang Liu [this message]
2022-04-11 2:05 ` Ni, Ray
2022-04-10 21:01 ` Guo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB50486F830E6F2DF009452DF490E69@PH0PR11MB5048.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox