From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 14FE8D802DF for ; Fri, 1 Dec 2023 01:56:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=03nPvmkSyokbPbu90SfVXpLDypNmNlxBlqvEoyNN954=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701395785; v=1; b=hwAmlNah57GJg830Bfm9uBCdXHw0x7bSJCKrLlrQ2agWOBbi/aVVmOaJ4Yl3qqAQmjH/ekOs LScA+9Wf5DtAg94l8FDtEZykA05EPcoF2EShk92jDfmlwvP9ITPkcULxhgR//2FvaPbjHg8I6ct elkCmA93wQmzQVL9Np1zU2YU= X-Received: by 127.0.0.2 with SMTP id DWPNYY7687511x3o5uYQMip1; Thu, 30 Nov 2023 17:56:25 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mx.groups.io with SMTP id smtpd.web11.13218.1701395784919931714 for ; Thu, 30 Nov 2023 17:56:25 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="271972" X-IronPort-AV: E=Sophos;i="6.04,240,1695711600"; d="scan'208";a="271972" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 17:56:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="798525386" X-IronPort-AV: E=Sophos;i="6.04,240,1695711600"; d="scan'208";a="798525386" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Nov 2023 17:56:23 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 17:56:23 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 30 Nov 2023 17:56:22 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 30 Nov 2023 17:56:22 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 30 Nov 2023 17:56:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMuYXAGKm2i1YENC/S4rHUJi2IHUEZN9tfFdNeHq4wlb6VaUTmiaT3mlgOcQXo+5XzWR4geWTThV9+xotyXP2a1OZu7Se5B+FDBgDabpJ+ggPiC/3lRqmdIfKyvTuo9r/UXL6/BbQc18KMnxdGksOAsGmoEfLvj57hJz0ydjqYTBllqbzxHm3GbQOw38L1DjDwgOHqaZKz2vaK7aPDl3AFQjD2wIu8TG6ef/E5xoTV/ooe87PDplRWqWoqGTsjxdLsqA3qWOJqSvNdnWOb2F9G3mzboKbad8OoX1+Y4X+FnH6Sejru11UVjAxphlIu/oq2Bs+VsZUOHr4OtU2rDiEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bCZd0S3aI6aLwUSQ4thEkkxwTM5BgEH3/n3/pkk7GHk=; b=WBjsReg8Ejpg2MZbu1NCv7MqYGh38wHxaTGYpP2p/dDT6OkooMFzOmw0g8svt2WVyaiznHWkNku2aRwVdk17T1vRfcgbOB/JvZhaSEQDjBWMDBT0cwTRPV6OHilJanahB72Fzrq9D395OJoqK/6/U7AYHooNvczjBoN2kIGDlNjmxKUDe7hpFjTPAMerdRYIeJHC8kkdmK4oD2jHLqJuWHdUXWRPgpTky+Sm0M28TiMLQ+rnHmklQ+fp8gbyBHuyX0WNUT8mADt79lVrWGUXAgW47WNU3GCRtPpBgrRCuowd0iQPEsyQLzBvN/1dT/5YIxeTqF8J9R+QQnytmRjWoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by DM4PR11MB7181.namprd11.prod.outlook.com (2603:10b6:8:113::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Fri, 1 Dec 2023 01:56:21 +0000 X-Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::14f8:6a86:25c7:e96b]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::14f8:6a86:25c7:e96b%4]) with mapi id 15.20.7046.027; Fri, 1 Dec 2023 01:56:20 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "S, Ashraf Ali" CC: "Kumar, Rahul R" , "Ni, Ray" , "West, Catharine" , "V, Sangeetha" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase Thread-Index: AQHaI7OnWnQs7IrgtEaBB4/o/ImdM7CTp6vg Date: Fri, 1 Dec 2023 01:56:20 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|DM4PR11MB7181:EE_ x-ms-office365-filtering-correlation-id: 348474a6-07ee-4f3b-a9fb-08dbf210b6ff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: nYGBn4X15tqVbLqxViuMw9nmv7tcPqnoRlF45u4PuOiyn0xNfzylwGYOkOeXTsK0QRdDl5r3yFXLw3YjEz+wuuZqO9fCJZbYtYdnWq00auUYwkvl61MVCZJlAjJ6MdWTxnp1BHQGPrhfXDQ8wLrls046KS4Bu+afLDpMfa36sIlNHURQ5TjJD8IoJdAEO7R6mRFi0lquFQ4RNLqG4TWFN0PyUEjABUDjrYgeMANdGTYEzfVgUCooFR1HHtjxG33aD8cWWtHfj2+crsiSVngcY/vEIf0jSsdn1CXZL/Nx438Yyw/VKcgERPZS+1FsZCVQmAXnGlspe3thp+8Lpb4+FrdEoJrPl2GkQt3a1H607Rt9Ti2UTZKTgS0+m5l6sjuOx/UYj4OdZQH7Am16c8EoqW1fanV4E6FfiWjgd5M/KFYJMfox+DIqa1spcnQU2tlgClNN3ZdSp/YkZCxTXz6qBs33oIkYAsoWbf9y+Vzak+o6/n5kXHzpbfRXBVSIm0X8GthAzLNRRDxkabYfONZ2ZRnr1DUN0dS8IISHestqFBE/fmCxrxloglY7h7qs5KkptElI3JV68R4zJXBMegJvtNJ5nhrYHcpA48W3M5ljTCahrESG5qqRp0rvV5O0NUMlT2SYXQh4QFUhdGODDf1uQoFD3Tud7tzWIxWwETF5zf2yUzct9ftTjhlP0dj+17E9 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iq305DXQ52fHRdgAKW01cneinxyRV8xLVMANXZ6gNqCsOcC23/ZksZKRiUz4?= =?us-ascii?Q?E+3PJKiKeHj2XsCJtfWuqVXHmUB76C1uLN4VvJIky5ytGLFCCc5Znb+Wbyob?= =?us-ascii?Q?elLq29IC7hxeUCwaH9iGTy/iWwiRJ3AQDzHxKzu8pKsXR0GiKGGwr9lRhDjF?= =?us-ascii?Q?xEw9t+w7s/ddHleUgTlFa0OWiAj5nZ6eu35mu6ressYzJT4EeMBCm0fxkDcC?= =?us-ascii?Q?hUzmSz5uQAFPgYvemXfHgZXTAVr5JJmPV9tFX4lzs1VUUns46bphP8SCwOvH?= =?us-ascii?Q?4Ot8WsfsGeuzTKDKtMUXCT8vh8xKSQ3lXcwk5duyOva/xLlI1V1SnDcVKolP?= =?us-ascii?Q?/5BufSKPIk/fda9DDjWQE+RrwvB0LseS/lF2Xs4roWFVbuc3ku2fUZvPj+ge?= =?us-ascii?Q?vmAJpziNeW+Tk0DWqmJgJ8cZYqNFl+nAdMqwjIbdv4mQr7qcmSc6iqiMXsru?= =?us-ascii?Q?ErlxNK019gMNWQQYGm6vFYPagymmvJ32jTfXUS5B7a+PquTPmgczhp++H6NY?= =?us-ascii?Q?zqc54AvCicIK0MwLPx49BBVx6UlJUFLhJWbCFyGWQn+MbnGnEnYhrTTRYAjj?= =?us-ascii?Q?TGW30qLGPNnfhxJg47TF52mJKYy6jsPaJ/R5fiJBeeaVe9/O+g8z3JlDaKkB?= =?us-ascii?Q?lk9D3hrI6g5I7TYmsBYQ62j7+nI5MDFZE3+772NeNnHdc5RkWKCoPzjUsLm2?= =?us-ascii?Q?C9HuiJxQ+VG6VCG0+dU4kovgiPn6s3QkCk9jmbmUYqQwom0zJhZtIej9nidr?= =?us-ascii?Q?sajL1ZmMk327QQDOxIfILQETyxeTg/eY0WMdosXzHi6oqbyhuO5Le0msiNT/?= =?us-ascii?Q?z5ViRmAxmAy3He0GYXc7Ni2SYFbgk26FhnNJrpQJhlsII8EVxfyeUt9OUm1i?= =?us-ascii?Q?XNS/iQuVjLqxnDQLFFHsID/nXFjnsYJS46rQu/e0K4YdOzNl+GidItLSgu1x?= =?us-ascii?Q?majXIxc9ij6J7rykQk692wgY2qAtQg/4ApmjJk2/nvRUAb3pXRuCMww5b+8A?= =?us-ascii?Q?pEo/WJa6Cuyr3BnsdMQrl0vU6hMSllaksZn74SkKDPAeoNEYrdMraygOvvNr?= =?us-ascii?Q?vSJkc7hLjW1OXhmWyqyuuI0fV5JP2a7qBgIE4bBtheas/7M1NDJRrXPfFrVW?= =?us-ascii?Q?1sHq3TidfGYln8ViUWzIiiRUXHVLrnslRrNBIZ/h6gsdTCg+CFnXn6wHxl8A?= =?us-ascii?Q?FVs+tU310ySEu1iPJrWJL9SRg3gNned2g0t8rdZGOSt5KqEaKV8VWzGUelHb?= =?us-ascii?Q?/R49P6oqp2WHqutvj68rJRCR38E7S4x9t25whtHlGi0yqnaLFmDu5WRnjU7k?= =?us-ascii?Q?3LSKEz4LM55SATME4c/MsUOWU21EGdVZbFhLgNEDUmn4e+2qFp7WrLrlXF15?= =?us-ascii?Q?EhbT8NiMMP0upOx9Pkx26vLmFHKKpXNalAiwBvn9mJzbSoepTk23Yt/5Hx8X?= =?us-ascii?Q?1o+Pdh6RTcHmSx51KS1LakEmeT8dHb4FP9+rnWEWyPBSUrkRCf28AjT+Yqjc?= =?us-ascii?Q?xR9oRFBlldRvYRR3GyOFDYFh+EnW7o8th4vNHjVc9BOMK48iJT5yXHeUxJVh?= =?us-ascii?Q?E69lVzXtVpzGxkOuRuMgYn8hWQg61V4vkzH6IaOG?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 348474a6-07ee-4f3b-a9fb-08dbf210b6ff X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2023 01:56:20.6294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uFPDbNBVEVQaBTe+45Vg6jczsDV/29AUCvt3b6W2Y13I8stjxhxzXmEpMdO2S6ZvZFXFzEeefF3joJsYVdu6YA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7181 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: l0OG4xXiIwlJYOj56n9Cd3hLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hwAmlNah; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Ashraf For 1G page table, page table topology is like below Each Pml4 contains at most 512 Pdp. Each Pdp contains at most 512 Pdp entries. Now, we only have one Pml4, one Pdp and 512 Pdp entries. If increasing Ppd entries to more than 512, we need additional pdq, also ne= ed to change Pml4 to include the new added pdq. Also, we need to make sure all tables are 4K aligned. Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ashraf Ali > S > Sent: Friday, December 1, 2023 1:35 AM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Kumar, Rahul R > ; Ni, Ray ; West, Catharine > ; V, Sangeetha > Subject: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page > Table Size increase >=20 > Currently 1G Page table is restricted 512GB. this patch can help to incre= ase the > page table size based on the input. default will be 512GB build option > PAGE_TABLE_1G_SIZE is used to increase the page table size >=20 > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Catharine West > Cc: V Sangeetha > Signed-off-by: Ashraf Ali S > --- > UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt | 4 ++-- > UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf | 2 ++ > UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm | 13 +++++++++++-- > 3 files changed, 15 insertions(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > b/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > index 4fcb15c3b1..4d153fc1a7 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > +++ b/UefiCpuPkg/ResetVector/Vtf0/ReadMe.txt > @@ -1,10 +1,10 @@ >=20 > =3D=3D=3D HOW TO USE VTF0 =3D=3D=3D > Add this line to your DSC [Components.IA32] or [Components.X64] section: > - UefiCpuPkg/ResetVector/Vtf0/ResetVector.inf > + UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf >=20 > Add this line to your FDF FV section: > - INF RuleOverride=3DRESET_VECTOR > UefiCpuPkg/ResetVector/Vtf0/ResetVector.inf > + INF RuleOverride=3DRESET_VECTOR UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf >=20 > In your FDF FFS file rules sections add: > [Rule.Common.SEC.RESET_VECTOR] > diff --git a/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > b/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > index 6b406163db..96106a4b11 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > +++ b/UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf > @@ -53,5 +53,7 @@ > # -DARCH_X64, -DARCH_IA32 > # * for using 1G page table: > # -DPAGE_TABLE_1G > +# * for incresing the 1G page table size (Size in GBs): > +# -DPAGE_TABLE_1G_SIZE=3D1024 > # * for different debug channels: > # -DDEBUG_SERIAL, -DDEBUG_PORT80, or not specify any debug channel > diff --git a/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > b/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > index 7960b141be..b080dc5296 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > +++ b/UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > @@ -1,7 +1,7 @@ > ;-----------------------------------------------------------------------= ------- > ; @file > ; Emits Page Tables for 1:1 mapping. > -; If using 1G page table, map addresses 0 - 0x8000000000 (512GB), > +; If using 1G page table, map addresses 0 - 0x8000000000 (512GB, Size > +can be increse via PAGE_TABLE_1G_SIZE), > ; else, map addresses 0 - 0x100000000 (4GB) ; ; Copyright (c) 2021 - 2= 023, > Intel Corporation. All rights reserved.
> @@ -39,6 +39,15 @@ BITS 64 > %define PAGE_PDPTE_1GB(x) ((x << 30) + PAGE_BLE_ATTR) %define > PAGE_PDE_2MB(x) ((x << 21) + PAGE_BLE_ATTR) >=20 > +%ifdef PAGE_TABLE_1G_SIZE > + %define PAGE_PDPTE_1GB_SIZE PAGE_TABLE_1G_SIZE %else > + ; > + ; Default 512GB of 1G Page Table > + ; > + %define PAGE_PDPTE_1GB_SIZE 512 > +%endif > + > ALIGN 16 >=20 > %ifdef PAGE_TABLE_1G > @@ -47,7 +56,7 @@ Pdp: > ; Page-directory pointer table (512 * 1GB entries =3D> 512GB) > ; > %assign i 0 > - %rep 512 > + %rep PAGE_PDPTE_1GB_SIZE > DQ PAGE_PDPTE_1GB(i) > %assign i i+1 > %endrep > -- > 2.39.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111959): https://edk2.groups.io/g/devel/message/111959 Mute This Topic: https://groups.io/mt/102898657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-