From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.5684.1623299607327049312 for ; Wed, 09 Jun 2021 21:33:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=fV0SzJac; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: QQRbCAoUFzXiJlfwBm89hJ+K839b2/sSktEVwBwln7yU4gyQKrpipzYE0/WlVtW8gkwdvC2kIU h7pwwC5aG8Sw== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="192539069" X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="192539069" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 21:33:26 -0700 IronPort-SDR: NxdgrK1Ys5C1saCf7RLau2glUvYNuIYEf/ajXCgU/G1Q1dUsRmr7fRRZ/r5cZdALMYjUCUWAmT iI1p39E5Wjjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="486004461" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 09 Jun 2021 21:33:25 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 9 Jun 2021 21:33:25 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 9 Jun 2021 21:33:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 9 Jun 2021 21:33:24 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Wed, 9 Jun 2021 21:33:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEP9nNcKOqW98GOF8+RRxlwS4Y7KsYHemaAVEZDmf58cQXn4OaZvyDplNMbVgWZ18v0D2Y+I7BxdTEJAnq98c2FmbJ6uRVxyuGhpRLPKZoBkXns81GIZ6362jKSSF6SFbzCV0G//4Vd0SzxOybOMaGk+TzARpoln38/H1JxInYSO0F87srYDlCTOFxdarWyJMs5KZSz4htxU3qSdIqEHO6zzIEmoGc1XLqHxyX96HKGUTB65xFaVB62okzmzkRR+wt1XquNnEee1/+tAHNpZBg1328K+12pX5FTbrZ9N3G3rR0qko3d774imCeNMViI/q3PGzNOAllXaUpEQx5FbOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDrxoSdMM1e0TtjO22uY01ZytQxx7huVVvMtvZQe50s=; b=RbU8JFgdDAoVg57CDXuV5TP9RJBUhOwVKsQ+mrvEnMXKWHIVeSKIVmek2qcVFacBRlKEi+KlJtQKFtewsovM8s4gSccDlxJy3CWOH8ixancrcBXluG+wU8+WSsRIYZu5VQXnCADeOYaJuLKuoB4T4OzyD9mUZqgdntfu3zz19ahSGNZBoxv0f0EhdqdpeH50mjSouKlZPErSu9GqNvPr+dIMtmRB4YRRGYo7vmnWcY4Vdf7IKiYwXTn5Ez40pkB5rtwPNhLe4KjOmtOI42zEUcns9VgsO8JS9LXnyoeD6kCkDvkRGfgGgpzdkAJd3Gwh6A/1QCXjQiICaJvXS7cRVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDrxoSdMM1e0TtjO22uY01ZytQxx7huVVvMtvZQe50s=; b=fV0SzJacxy2OEHygfuDU9tkWiL7MQIlw/C+oIDzQp9IOSPTng4HIDZiYc2EGmw6H5TwjZ883LMdl4kvyS03nY4IhdaxTT+3phZKevdfumxtEFiH30DSVI8GXwZre/JfsEVe0Vmsm8X+px1eB8gF+jhqUTy/XEAev5MKYrQrg0zc= Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by PH0PR11MB4965.namprd11.prod.outlook.com (2603:10b6:510:34::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Thu, 10 Jun 2021 04:33:22 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::8c52:953e:b2c2:d4e1]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::8c52:953e:b2c2:d4e1%2]) with mapi id 15.20.4195.030; Thu, 10 Jun 2021 04:33:22 +0000 From: "Zhiguang Liu" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [Patch V3] UefiPayloadPkg: Use DynamicEx instead of Dynamic to pass PCD across binary Thread-Topic: [Patch V3] UefiPayloadPkg: Use DynamicEx instead of Dynamic to pass PCD across binary Thread-Index: AQHXXZlbK646q3fqJkC0mgNPz4k0hasMjmQwgAAYsTA= Date: Thu, 10 Jun 2021 04:33:22 +0000 Message-ID: References: <20210610013826.1986-1-zhiguang.liu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9e571b83-79ee-4443-0817-08d92bc8e1ab x-ms-traffictypediagnostic: PH0PR11MB4965: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GhWDcabDVU8p1XkPFfIa52EY7L2gcDgtq6y/66SeXrIhQ2fYkDDA1LY/92YFW5bIjA3L8lewWjr6bS1W++tAeEYd+WeKsRV/PvfS77+/71iJkekHp0FVdCnanfjlUiaESrSHRtWGJ1e5OlzFRiB6IqPn2jUTB5AA8EW6GCuyNo4OQvg0wHS39dFrQhTgz+vtdkufWRD2LAeJ/TFwTVPEk+gAN64lJIKp3TpL0tDwGetp+kjkaAE8LgkLU5SjEKNQu8IBXHjmBZFj7BRkTJN5DiP+eIeafQRVmLfjeH5r/ys82oUtoSxOy+b8k3YapIWLWDgkqHO/JgRQje4CmeKFHiq4/YkNHeFQjCk9DJthc7Y5STcx3RFGnUZp3S/sQPm5fHwUdai+yxG9slKbCZ+FXCi12lfI0jwPRLwYFQLvx11eSECTwvbwyQG6pBouGejHQvmwmfGYAeyTM3QcserXyUSSY0+NFmaorGy21HREiYRWn2RjFE0ZxWO7u2PpSI4VzvFYx9ZLHnIhLKeON4T5uGMXwmzNssxzHYJOwemfHtbR9Nza+OopCW4vdBM+ZdBheI91DwB+zP2pFuX/o2VytMoV27FEqWYnJRfbtLg/AHw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(376002)(346002)(136003)(4326008)(52536014)(8676002)(86362001)(54906003)(8936002)(9686003)(478600001)(5660300002)(38100700002)(122000001)(110136005)(55016002)(71200400001)(53546011)(6506007)(316002)(186003)(7696005)(83380400001)(2906002)(66556008)(66946007)(33656002)(64756008)(26005)(66476007)(66446008)(76116006)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YaJAGbhZv6zF7bRXRZLb5Vac+s3GY3IMJwBCi+X6NE4AbDyIi1LNPdXnOcfl?= =?us-ascii?Q?yIZV/vH2HbWjgbzlViOdSoy4pS7hCHmsWn44YuAQ9ZT9NtD2MmfQb2MV1bQs?= =?us-ascii?Q?MudQLqaVdaIFZAc8ZozNcxROc1Kn9t56oM5uNJfmyYMw2LUeLw6ijTf9+a00?= =?us-ascii?Q?St1qLxULFk7QmagClvGb+y+hXl4HMeQMy3TmSK1JeJAHw8oT+oFYad+F501Y?= =?us-ascii?Q?HRhAd4VoYxeXnLE4t14GIF1C939AdvhoFEpZwQYGJ/EOhJNOaBkzddUWMo15?= =?us-ascii?Q?lNffXbj2cRq1Dv1+91raYJczvIxeZBGeYWpJc52mRT9r8r3aqgzztCTPSCjp?= =?us-ascii?Q?lxeF7YwzIhCY+GeZF7TTuly85V2OqLCqr1m8y2YJxpP+8XgvQFx+SMRFmFl1?= =?us-ascii?Q?gnoQRpDZJps5Qj3pPH/8jh1bqzsPPZIrdE1syXFj0p5TSoftQ+dHxRKrNssq?= =?us-ascii?Q?uKjyhUbuPMUNxCW7375PRi+7mSUBpxGiSjUfhaBI7m2jqcTicFEGsC9UqVg5?= =?us-ascii?Q?Q7VGXcJZ+xs0d0OXaQEAdx+NjfIAvSfSB2D24DOrvZAHbH8jeqWHWltRj//X?= =?us-ascii?Q?HRaQG8h5G7gfF1JaF2K+t4MUdwPVETGdVMTw1+btHjTfh3mXJTwUpQc0MxWe?= =?us-ascii?Q?MrAHgOoupFt9K1p5r9EE2mHoJqyCtoaRR20Amn9VFeEyT2RtBV/lhBIK7CWZ?= =?us-ascii?Q?q32Wv/MZEk53wBlvwzanmt0xLg+Ae0nBX98zYe/HVNUg8i7n64o+2xIDNrAm?= =?us-ascii?Q?5SH/Fo6qV4AV3vDEYzwXodfMOL9Rg0C3DWNHfyE/487Dm/pu57tAVH3dbLCE?= =?us-ascii?Q?Uvpjp4tn3FwH4xi/U7G6EiGiS0yaVdExxLaz8OvQi/L8/uHVGmaUu0Unaqh+?= =?us-ascii?Q?Zhq58MsYUzhXUMhFlomWm+SxOaKlGsWzoN9n6Rb63Kwf3+rmkeL4++ZatyNJ?= =?us-ascii?Q?5pZVffPQODQyxk0hKsn1hGNjsW/6tzp2rL40lLWx4U2pfYfCazXow0Mf5o3Y?= =?us-ascii?Q?8a58IWktxin6MLw31AGyXurRwMDZwIL8A4vTJ/PPazYfIq1/FyzmOGiiAz3/?= =?us-ascii?Q?djLKUUZLS7dEd59Q1qeLavI2Rf3dp7T3u8x2u/TVR6nX9+u5DoEVi6LK7JSm?= =?us-ascii?Q?SLkl4E4KrEq9P6MYzSZVeMmGt/A89WDxzbT3U6wve2cftW9vyvU3yx0Z25Xp?= =?us-ascii?Q?scDEIBiM9NNuEG+rkK3u0Z7Isxe5EbSFOU4SVMH/10tYG3oalsM4/aPj+h9W?= =?us-ascii?Q?IRLnyL2IGMLu/4o32KokPp3OODi3UBLjh21x0l/cqC5l6GgaAz0Ud6CbHX2R?= =?us-ascii?Q?1rY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e571b83-79ee-4443-0817-08d92bc8e1ab X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2021 04:33:22.7628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qXXv5+rdfGxWqpNeMY5r8ToFLzfzHVYFVBreIzK4FkFPUXXvVRsMfpWRWC0phF6kmMcDr+I/AgwJlvDZ8WS4LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4965 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Guo, Thanks for the comments. I described the reason in the V2 commint message: Explicitly define some PCDs as DynamicEx, or their default type will be = Dynamic Thanks Zhiguang > -----Original Message----- > From: Dong, Guo > Sent: Thursday, June 10, 2021 11:04 AM > To: Liu, Zhiguang ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: RE: [Patch V3] UefiPayloadPkg: Use DynamicEx instead of Dynamic > to pass PCD across binary >=20 >=20 > This patch 1) changed PCD type from Dynamic to DynamicEX 2) added 3 PCDs. > It would be great if you could describe why 3 PCDs are added in the commi= t > message. >=20 > With that: > Reviewed-by: Guo Dong >=20 > Thanks, > Guo >=20 > > -----Original Message----- > > From: Liu, Zhiguang > > Sent: Wednesday, June 9, 2021 6:38 PM > > To: devel@edk2.groups.io > > Cc: Ma, Maurice ; Dong, Guo > > ; You, Benjamin > > Subject: [Patch V3] UefiPayloadPkg: Use DynamicEx instead of Dynamic > > to pass PCD across binary > > > > V1: > > When passing PCD database from Edk2 boot loader to Universal Payload, > > the local token number in boot loader PCD database can be different > > with that in Payload PCD database. > > Dynamic PCD directly use local token number, while DynamicEx will > > search token number by Guid and ExTokenNumber, which are unique pair > > and can make sure finding the correct token number in boot loader's > > PCD database > > V2: > > Remove PCD PcdFlashNvStorageFtwWorkingBase and > > PcdFlashNvStorageFtwSpareBase, because they are not consumed by any > > modules. > > Explicitly define some PCDs as DynamicEx, or their default type will > > be Dynamic > > > > V3: > > Not remove some PCDs for they will be consumed soon > > > > Cc: Maurice Ma > > Cc: Guo Dong > > Cc: Benjamin You > > > > Signed-off-by: Zhiguang Liu > > --- > > UefiPayloadPkg/UefiPayloadPkg.dsc | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > > b/UefiPayloadPkg/UefiPayloadPkg.dsc > > index 37ad5a0ae7..4b0ec3a059 100644 > > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > > @@ -336,11 +336,11 @@ > > > > > > > > > ########################################################## > > ###################### > > > > # > > > > -# Pcd Dynamic Section - list of all EDK II PCD Entries defined by > > this Platform > > > > +# Pcd DynamicEx Section - list of all EDK II PCD Entries defined by > > +this > > Platform > > > > # > > > > > > > ########################################################## > > ###################### > > > > > > > > -[PcdsDynamicDefault] > > > > +[PcdsDynamicExDefault] > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0 > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0 > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0 > > > > @@ -363,6 +363,9 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100 > > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0 > > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0 > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0 > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE > > > > + gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|0 > > > > > > > > > > > ########################################################## > > ###################### > > > > # > > > > -- > > 2.30.0.windows.2