From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.10575.1670402055729515934 for ; Wed, 07 Dec 2022 00:34:15 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DqZ27Yp2; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670402055; x=1701938055; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yViq/buVTfXTdX6ZHHMst5Hv7FQ7RmbeljelxUVDb8Q=; b=DqZ27Yp2Y7/Gu7wrINej1Rk7gyXrfspINw10k6zjpy4epN+HYVGEy/l6 iIyADZVUQbNrVMnH/OSo9hu5nmmPSkZ5EQjW4DukC4LhnJ6TsZ0iZdxSC WVDIxKEF2gseASJnlkwEf5fmhuiT8KNnC+bU+4/fJOuKfukHmSiYK2MZm vPukH5VgUEKHqe7j9gXtpbSlqHSz3H7KEecLX2hgC+H0hmBZQeSs/tA7j kWXLSvNORf6jsMTygAniSz3nZmAQL/QqMFsy3iXuyb8ZLVxN7HgyZb9Oy JyHOp1WsJh1wN2I06q66ur+AukUyS9YOJEh1IeQYe51ahHvZe+ORwTFX/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="297193991" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="297193991" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2022 00:34:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="679056583" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="679056583" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 07 Dec 2022 00:34:10 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 7 Dec 2022 00:34:10 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 7 Dec 2022 00:34:09 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 7 Dec 2022 00:34:09 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 7 Dec 2022 00:34:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etVlgYl67QuB85B2dyCF6S8RpcitKyAmGHU5PFKzOnE+IBDvUkLTYI+pxAtaQ7dj24UwzcNXZtqLxmKwtFRFU9cCEZaABbkeokJreYC6/i6zbGWGZ+6t4ZLr97e+Jz3L7M8yDCPJwKER6Uc3DeHBCbJizrx0YxmjL5iOtJZswDWp8r7jyf/xiMwUUS5rXMUstbUIhmK7Qvc0dys1ZYOHjsE/ctTGdpdN8dC2wr88DDpOTz6RpR09SKRapdEyJhtOKots3rHqh4xQSOIU8IhHZT5f1s0WDTuOZ3ZueIlW9EXNwTBE4PrDgJJTAFKpZterN8onnPjoZLwZ+rZmCWZ+FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3r5i7EwqUltqqjnxVsNI9ywQdB8A70+qxLwjO23S+i0=; b=WsXYJAkSsH2LWC9DH4Xur5MS5S8zF9qrpsP2CFho6fIT+ljKvT7YNmdBgQ2bWYr3concwn8PlBuKOAR+QOhgBnMCELGh8fgWfhabnDRO5aqxkwvTvpD4ALxOsV/kCF/Yr53/aRnr097CHCRHOK1u200Qq7R0DDDJVBprSY7+qpJNAhEldoWR6HlZn3bBww8vfdPbCjaJ5GECMUFJpIkkCjDocwzCPldjIo9i08ptAMMx/0j1Oot4d98KZk037rGJcp/WVsREh/WO+AtOpW9MwcRSyIEFm4aq2ePt7l2HUicVCcC2K/ILPcrdwrcMhqQ5zT3FFkd1iPRDqQB+/aZy6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by SJ2PR11MB7473.namprd11.prod.outlook.com (2603:10b6:a03:4d2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 08:34:07 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::bf9a:7d68:2ee8:dfd9]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::bf9a:7d68:2ee8:dfd9%6]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 08:34:07 +0000 From: "Zhiguang Liu" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Andrew Fish Subject: Re: [edk2-devel] [PATCH] EmulatorPkg/Win: Unload DLLs before reset Thread-Topic: [edk2-devel] [PATCH] EmulatorPkg/Win: Unload DLLs before reset Thread-Index: AQHZCHcBqSLDz+s1BUWHvgwBH1TrZq5iFOqwgAAGYCA= Date: Wed, 7 Dec 2022 08:34:07 +0000 Message-ID: References: <172DD36D81169CD7.13790@groups.io> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|SJ2PR11MB7473:EE_ x-ms-office365-filtering-correlation-id: 175d6320-962e-4135-0cf8-08dad82dce73 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qJHH7SkSTM78orW/4ny1UsjwL+mREbAxr3ip87/UBjy+lzUGpw6IWl+09geFObLPJPEwhbu/ZMGjZ/RubCWfHnUEE8+YGQTA9O1yNyoWiFoXWESSvx/8ATzGhcWVWQ7CzU7qCFGU1dODE5uXL+WlfcO8C+pT+FqA5uZx26bHLN76CdH4IGfZHySAKaX3GXGn3frp4XsMLV9fbcIYzeYr2lihUpe6y4ucc5uJAo/3bxwSpb/ONkBXm9sCvvnCByGhvv1liMDHyx7N5PbMRrZVKMnP00+PT8VjcQbAAlVeu0BFw+2KZ5QU0EFm46KzdUKo33LmFoX5t/LBPjWnv7NJfrN8lAr7WGyl5vnKlxkZY+ALt8mRYMVUw3JRXwLo6pLXDq3Ao8PRVgdKfEsm8t8iHrRoKjba/Yi21NkDSeryEhA/tYrVjS8XkP/tGVm+D+L1XQvyRQhAX4N4OfI2CvQAV8gLrxREHjra+1Ea70rLCDQoS35nNhzl23/Q+Q+zfGpMq1fPIp44Kt2DQJYbYHMP/jM1Y1Bds13NB7N79V1AfYsGqT6/xBCH2npBAip5ZDNpBB4KfjrS8JPl9uWeymqjTfTAzAmlArl4GAW6CY5GzFPK1+4rEumrGujFbddnFOpD+ZBsI07LT5HJcq4Fh2ZsFy7dGso7/ME7zbbgea/SQTvpfzbsivWXbGk9y+g17+CTMGyqotS0VnUoFMT3d+1doTdjUU6c79uQSI2YckZhIOIEoNxZO+3NDGLGuPBnBpzkZJ+bxDx2bgb/jDE3eJ+O5A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(136003)(376002)(366004)(396003)(451199015)(38070700005)(55016003)(110136005)(71200400001)(316002)(53546011)(9686003)(6506007)(7696005)(26005)(186003)(5660300002)(2906002)(4326008)(8676002)(66556008)(66446008)(82960400001)(33656002)(38100700002)(41300700001)(66946007)(76116006)(66476007)(64756008)(66899015)(966005)(122000001)(8936002)(86362001)(83380400001)(478600001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qwGkE1ZcKXOMJPhCz97OaQuqtGU80v1/Y9KzsMxPBsPRKbnDU9s54RAiX7FG?= =?us-ascii?Q?sptX+GFqu706AYchOCaMLB3Fu5cd0UDFwCgHPyGt7pNe+hDXPGaoY6q+aK9y?= =?us-ascii?Q?myZO0xbSQQcRefwFlEqLYKFnIrlBVsL0hksiRrO3/0jxRWR9lXty4s2dOMDl?= =?us-ascii?Q?mGFkQ/p1iCAqXjTXctpiDEkf2Xu2p7uO6AswuC2HdGcSb3cUV6jx7/yy01HN?= =?us-ascii?Q?4aKMSi7VA3RVxdKdraT3EP7XE3Fu0tD2POmI8GeVzrcSUpSG/Rspu4erOk0c?= =?us-ascii?Q?ORr6oWBvWXIc2cmKK5g7THSnKY4tmdnOyiBuUuBTXpxDjPAVWjXmFSL94tXV?= =?us-ascii?Q?YGdxHFP4LnpSDQOhhe/4Y+VFHW2V2z2YaiUt5bFIk+rUQzErfAblfkR5xbtz?= =?us-ascii?Q?w0rHos7h/ibwzWWtrYNrIiFeIJcREbuE1SUnNdGAUCCN5LB8tIXaODFx9KPj?= =?us-ascii?Q?TQ4mLiIIZHg96s9vgUR48UDZh6HySUfDI7yt/IjiFhSqLzH0NpbpLIdnO00O?= =?us-ascii?Q?bKXiUqFcXmrMskHrJmLF7p5AUkoLluSADyvJWBEiwfT6WMSqGb/g9T5xPR+v?= =?us-ascii?Q?xSdndZjAuKU/g0AL6R4lAmomb0MAiQLL+t8XF6r7dITvdoyWrPT33Pxj+e2+?= =?us-ascii?Q?Pnv07DF1xQfnOl6J80apwQDZQsGHcmp4RnWHhuzq/9PotgEkU22PASn2DQtj?= =?us-ascii?Q?d5eDy56iMeLSll6jsOQB/6sp/nzOXMrjdUHsxBBVlE2CB93M+e+1uvrRxZ+f?= =?us-ascii?Q?FWxxpH5aIhsLi9Lqp1SRTSRJT2g0GMUUtnyKhhEtN2WINkZOkwWzDBHvsELc?= =?us-ascii?Q?vyvn3Exuv9toR/qKgV0jSspiwc/WNQ4YZLTz3s3UmMQsRgzAt4ktmG0yYVM9?= =?us-ascii?Q?INORcHI1uoUGkDg8HHd+M/xzEGD00NY12HqCvQ0Z5l+qJMy4cjUVLQQTB2yj?= =?us-ascii?Q?MBq7YA/yPV2H5V5KmrsNtBs2eubNO6VyYi1xHjINw9Xpy+DlhBjkthIXBHZ/?= =?us-ascii?Q?4v+QCFrw6IyjyggaQCJfK7uqgvUKeR0Xt927sLciHcPw8WEPhIi1jxFuakrT?= =?us-ascii?Q?4ChJ3/K8SpGo++rO+FvkkAkDVv7Axuv8coheyqaLgjxXajF0b0BnCaMwBSoy?= =?us-ascii?Q?exuQYXxgg366yQWYH3rN4MlR/GQOqkysQTBgL8EumBsSlqYtuyZs2++YSlrQ?= =?us-ascii?Q?by+xKf7WbiomsByMqkDGWz46QG3/uxFuxGzErNVR6K4nmc9uRW0hBDXh1p1R?= =?us-ascii?Q?vZLXMo5+Ax4Fn/YLp7DdNOuXaFtOMOjCYmZ8ZzYTeWuROYLllar4vbNRETxR?= =?us-ascii?Q?DCmgF55YPBGLcbQp2bIhIgdg64WO9FcQP7RoBITLkc7kayyM8mYjdCsJliZO?= =?us-ascii?Q?x3R1p8J2BScgDI789vwCW6jEQCtLqTkJhzylJzUhAZzHjMNJzIVxD1yiJzq4?= =?us-ascii?Q?lTYL2CZFiMSSYM3kFqaPCq2Ry6OKfdVSnCekqZQSQ6WeC6B2FCPz6FQUKFNR?= =?us-ascii?Q?4+WGEWFL7gIWONqRy23523ywfq33lQBXpWa9RpihRIQQpagzNxh1epbT+XHL?= =?us-ascii?Q?Ka4PKUx6TEedicqSimq29i7s2H+DPrdYIuIG6ngh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 175d6320-962e-4135-0cf8-08dad82dce73 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 08:34:07.4516 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rc38qErkqqf+9v8mNaCW5/2QVxbfevf+mFN/iwQPhTAK6ta3DWW2Dxhn5kJILnEdc4cROAFkcUXFvtGyzE8X3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7473 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, the patch looks fine. Reviewed-by: Zhiguang Liu > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, December 7, 2022 4:08 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Liu, Zhiguang ; Andrew Fish > Subject: RE: [edk2-devel] [PATCH] EmulatorPkg/Win: Unload DLLs before > reset >=20 > Zhiguang, can you please help to review this patch? I guess Andrew is bus= y > on something. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ni, > Ray > > Sent: Monday, December 5, 2022 2:59 PM > > To: devel@edk2.groups.io > > Cc: Liu, Zhiguang ; Andrew Fish > > > > Subject: [edk2-devel] [PATCH] EmulatorPkg/Win: Unload DLLs before > > reset > > > > EmulatorPkg/Win calls LoadLibraryEx() when the corresponding DLL file > > is found for each PEIM or DXE driver. The module entry point is > > changed to point to the entry point from the DLL. This helps to notify > > Visual Studio that a new windows module is loaded and corresponding > > symbol parsing is performed for source level debugging. > > > > But entry point from the DLL is only executed when the module is not > > loaded by AddModHandle(). > > When reset happens, we need to clear the DLL loading so that in next > > boot the module can be loaded again by AddModHandle(). > > > > Without this patch, source level debugging doesn't work after reset. > > > > Signed-off-by: Ray Ni > > Cc: Zhiguang Liu > > Cc: Andrew Fish > > --- > > EmulatorPkg/Win/Host/WinHost.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/EmulatorPkg/Win/Host/WinHost.c > > b/EmulatorPkg/Win/Host/WinHost.c index 096292f95a..084cd4cbd7 100644 > > --- a/EmulatorPkg/Win/Host/WinHost.c > > +++ b/EmulatorPkg/Win/Host/WinHost.c > > @@ -226,12 +226,26 @@ WinReset ( > > IN VOID *ResetData OPTIONAL > > > > ) > > > > { > > > > + UINTN Index; > > > > + > > > > ASSERT (ResetType <=3D EfiResetPlatformSpecific); > > > > SecPrint (" Emu ResetSystem is called: ResetType =3D %s\n", > > mResetTypeStr[ResetType]); > > > > > > > > if (ResetType =3D=3D EfiResetShutdown) { > > > > exit (0); > > > > } else { > > > > + // > > > > + // Unload all DLLs > > > > + // > > > > + for (Index =3D 0; Index < mPdbNameModHandleArraySize; Index++) { > > > > + if (mPdbNameModHandleArray[Index].PdbPointer !=3D NULL) { > > > > + SecPrint (" Emu Unload DLL: %s\n", > > + mPdbNameModHandleArray[Index].PdbPointer); > > > > + FreeLibrary (mPdbNameModHandleArray[Index].ModHandle); > > > > + HeapFree (GetProcessHeap (), 0, > > + mPdbNameModHandleArray[Index].PdbPointer); > > > > + mPdbNameModHandleArray[Index].PdbPointer =3D NULL; > > > > + } > > > > + } > > > > + > > > > // > > > > // Jump back to SetJump with jump code =3D ResetType + 1 > > > > // > > > > -- > > 2.37.2.windows.2 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#96943): > > https://edk2.groups.io/g/devel/message/96943 > > Mute This Topic: https://groups.io/mt/95464183/1712937 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > >