From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Tan, Dun" <dun.tan@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure
Date: Thu, 9 Mar 2023 02:06:33 +0000 [thread overview]
Message-ID: <PH0PR11MB50489E8141424E59BAC7E8E890B59@PH0PR11MB5048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230303072629.1781-2-dun.tan@intel.com>
Thanks for the fix.
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of duntan
> Sent: Friday, March 3, 2023 3:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to
> 'ApicId' in MpWakeupStructure
>
> modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination in
> Acpi64.h.
>
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
> MdePkg/Include/IndustryStandard/Acpi64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 575ca0430c..16c2faaaf2 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -607,7 +607,7 @@ typedef struct {
> typedef struct {
> UINT16 Command;
> UINT16 Reserved;
> - UINT32 AcpiId;
> + UINT32 ApicId;
> UINT64 WakeupVector;
> UINT8 ReservedForOs[2032];
> UINT8 ReservedForFirmware[2048];
> --
> 2.31.1.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2023-03-09 2:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 7:26 [PATCH 0/2] Modify defination for MpWakeupStructure duntan
2023-03-03 7:26 ` [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan
2023-03-09 2:06 ` Zhiguang Liu [this message]
2023-03-03 7:26 ` [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version duntan
2023-03-09 2:23 ` Zhiguang Liu
2023-03-09 2:39 ` duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB50489E8141424E59BAC7E8E890B59@PH0PR11MB5048.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox