From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.3661.1678872373765887081 for ; Wed, 15 Mar 2023 02:26:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AV5g1Dvs; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678872373; x=1710408373; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iBWg2qhosI8q9jXxzWw7b1AML+NJfVATRIX5qKpxsv8=; b=AV5g1Dvs6buPx4Hmegz0DfLkomLQM4sPD+grRiKa4M4Za3wb4N7DX0OR QX6Ee3eXfbhE1+Uw4BLzitYiQpXmSVh1KUOQHTq3oxhdYb4cjNKo7krOA +3EZFx8gJl+TlQOydnZrCVfDJ6ln5Q7CXs8CPooTQj74EV8FoMsWXw80m 5ZWkreyP40fnfWETK0tBAIt08iZkQZfGi4ua9IHzhRGitISN4nnyk+uLk YfzVLL7mfPoye8bZajcr4ARaMj2NN7ZtdyY0s4IwTPgI0zI4YHkFcOrpD ac2hebBM3ehR3jcgpQefH05ECtN4la+Nt7MVywRKM4kabrnjzPRTbD+kr Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="336343352" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="336343352" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 02:26:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="748348917" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="748348917" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 15 Mar 2023 02:26:13 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:26:13 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 15 Mar 2023 02:26:13 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 15 Mar 2023 02:26:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cx4lFcqOSd/f1TzXVAs8YzBRtJ6YgDJa4s5ZFIBqyw8ab3pMJ2QAmIHpjRaSmW5MW2YIzPCNJq10od68gi1n22rDLIkdCTdrqG2L1rsPLZd3MfpLf9rX0VUSV+VoPaAewmeLsAq5gxHPmDNorggP4s3Rdc/pse6vuLJc40PEgl1yvZmIbC+fcoB5w/sxXNFfUXKfXFpl9djFCL0ByJP9ysGuews14M6aS1EJjVz7PMqnwfoMtvPCP3mzMRTWDTKq4BoXd7WAEWEDfydVgcuUWalc+grvCpotiQP6W6IypLfxAxUrxzRP+9FAPjqky9Qy2aI+3VQUS+J5n7ZSHZ5XqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B7A2q4dF0xf7dhEnS2QTfXO4Z104hdSMYVDlVDfRmOY=; b=HuC/qCm+yGOwZnTalVFZEwfM5ZyZJPeF4XLwjbupK6g768Jh9jKGh0t71JBQyTetLr0/EHZnCFlLKjRw7YTtpqQ3mz6pLbxoQDP+ddjF9e52dicPrJ6u2Ti+PSNLjfZaIch74ClhCtT7gq5sIpErQGHYuJcjh5uLBlRnYSVsUUDCiC3ENi3/Bnif8O/tq8G2CqEmsKmlfp0hQJbR9SwYyh4VcvGOxCGh25k1SAicTf87V++gKS1E7IJ7guurjCrsRKaZWvsBa5ZkXayqH7lecvBvw3lE5IbiNDoQX9zcmlnc4/NhjtJfsrVcIX+VaesQKRydiRzMnoP9Om5JWOjkbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by SJ0PR11MB4960.namprd11.prod.outlook.com (2603:10b6:a03:2ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 09:26:10 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::a17b:667e:4d44:747d]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::a17b:667e:4d44:747d%3]) with mapi id 15.20.6178.026; Wed, 15 Mar 2023 09:26:10 +0000 From: "Zhiguang Liu" To: "Ni, Ray" , "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested API is changed Thread-Topic: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested API is changed Thread-Index: AQHZUaYYgpt8f1N9Dku6J+wLORj3Xa77b1cAgAArUQA= Date: Wed, 15 Mar 2023 09:26:10 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-15-dun.tan@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5048:EE_|SJ0PR11MB4960:EE_ x-ms-office365-filtering-correlation-id: b2b46460-9e25-4bc7-6566-08db2537508f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BBZHQR9E+uU1IMJCSZGXOlQtKxYk15EP2cmupVkCIQ4YbTc42/DVAFWDHlHLWEGS0uwzeKOS75g9Wrk+A1+GTOInwFys0aplSsFvXpzrwFikKz3bBIUTZ3HcORKmSAGZo9XPa1k6+eT6Rq6mJgr7o0JY1bXf/bu1QU2SwK62qOJp6E2txXACq7nEqXKPV83iYxgrY4cZhee7xty9Ju8oIgw9nJOx4JNoH877wErr8LS+ZXPVEqaEtwAxkXEVnnnJ1KnV9ebWoUcMyQZKT7sn9P9dAR0xRBlRnsltYY7bUyV1RdAH3gEwUc1g9CB89MvMHI5YlwedycjpbdXO7IKm7OXQbJEeNO7D4YVFS3VwlzTPHI3ePFXvpkqL5tFWbijb/qwvIkjpHaFUwG9zgEn7G5hJ4rLyJ0WRi8FQOog+/quYHPaHJwu3Gh73f4/PjyZgBPrYCOBcjBDL6B6VvVVRWLe9HutfTDEsDW4l+Ht7jKcHTY/ZTMQMNC1jhVzNLD73NYdtT6UN8aHFZscUqk0KOAU+6P4USkiXTksWVShOJSv8l4Z5709YHGkcfaZxETALSOcNOCFqMFgIMvXHNF9OhSnjsK/60VrLrtjSeDrSseBTpn/nr4G9zQ3DtO3lJb+faCB9EdqJxPspcfbnaAv8+upfq0ESB4kZ9aQmXCuGi5cI+yzZr+eNr7zEihsXqT+PP7Q3KUAM+q6YVgpzxBHNZw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(396003)(366004)(136003)(346002)(451199018)(5660300002)(83380400001)(478600001)(7696005)(107886003)(53546011)(9686003)(6506007)(71200400001)(26005)(186003)(38070700005)(76116006)(66476007)(66556008)(66446008)(52536014)(66946007)(8676002)(41300700001)(64756008)(55016003)(4326008)(8936002)(33656002)(86362001)(54906003)(316002)(110136005)(38100700002)(19627235002)(82960400001)(122000001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lY8IoPvS/w03XfSL+bZWKbQDP3PnJnyBek5LWxxWnxlAGhkcUwOfhCigzL3N?= =?us-ascii?Q?YX8YfuXSYrPzfdQQNz3h7gnWPbIWTS+10ZKct+AK5RwYZEswSs8n8TWU3z0Y?= =?us-ascii?Q?3j7B88JYpGUPCEwjOW8xwRqpTG3c4kXeq5qrQRUffyCDXZ24SiCZmUkZYgIC?= =?us-ascii?Q?nQlqwBphFJ3BgvHL3uvE9wDXyLx59t4i4ybFfI7SjKYoMh346Ylj/qXU09Py?= =?us-ascii?Q?7aMGBZeuXOy/FT/R6M4ESPS+98ehpmKBR0wgOQuoR4RwQMLdFY2LHCzlFV7V?= =?us-ascii?Q?DGtNJgUVut+7q2qyP9OBrstEtG/2pk8vm2jA6qXhmNbGDijl7+rgcnj81WPU?= =?us-ascii?Q?423QcwQ8/dDtndjZzcax+PyBQ9wPPZaY5fg8p8dL4MfNpFYuTeGpjxQ59NcV?= =?us-ascii?Q?St10BzdmB70fdTDVjuU+bIyJ15alSqG/l9RfJSw8WPCP7YDqqsMu4LxClFyV?= =?us-ascii?Q?bjUYRF9b3nwWP6tjAcZACL9RXeg07YM1e7WoPIRNZH0ZTzd1+txQI6OIsekj?= =?us-ascii?Q?dNeMmCPeoTq8IJpFzbTkLi8fMBguhlUzjl1qIR14OGNQGuotGXyvxUZQ6iVn?= =?us-ascii?Q?We//mjxpw518uxcxH19fqQxKeHYXcllcRWQjZW3s/ksb+0JPvTmf2XFIxWUR?= =?us-ascii?Q?55tq1UaZjf6j5LIHYpgs93GkQ/Kywjsaoeo1G8iv66Htcz4vTnGzXOTXuQuI?= =?us-ascii?Q?o56o+UEtQ5qRFzTxwI36gA0GKgNUpjvuPXmMqXFpdrBawr6i6MSVFgYmuMnD?= =?us-ascii?Q?RwuXSx1ivglboXF6UmQirMB2BmrX6q+C2QjrLC5bcKO9RucnLDZfbBa4Rzgq?= =?us-ascii?Q?d+8xjhuLb40+FSvMgt4XUFiQIYk2gauG493kp95fT8gQSlFxwob1wLFsmlJG?= =?us-ascii?Q?l7OuIL46+1I3bhqfJRwkzUIBshBNAJHlcDmMWbEfn28HUyjCFcAGrLJshAmG?= =?us-ascii?Q?1LG8CJGRvKRRXkjKWcfdYpfz/RZT9X/XiK3excpSJ2SrE1UxAOxfWHRXRnGx?= =?us-ascii?Q?HDKCR8Chx9goqdr8pv465epgTuVMIzncmR1IIv0lmFO88xqNM0b1uC6stOQK?= =?us-ascii?Q?8bl1BOpNbIYvPsQdOmmRMSxag+r1YXQDyPBkNgZ3VQPn5/i2YoYo90ge+gaD?= =?us-ascii?Q?/ralR5JHPFfTQywnuNQAp6rC3W78QopZZa/+oXmD45YiQ0pfu8nlfEgOp7oX?= =?us-ascii?Q?fWRt5TO4Ujc+A+mZrHM8r7+FP9Ojn38n/do8aFicgoY5IYp8/hnkc3kbkk5K?= =?us-ascii?Q?216GFcYmwaILDjR7kcHlB4AEIQ1EZnK2wyv5zftOcxmcIgCL1MBPB+B2crK+?= =?us-ascii?Q?pBNdAuaBcLUkfMgKP0qpKRV5vMG/jIUIkVaOZ0XFRIPH2Lg9Vr9y8NsRsPFa?= =?us-ascii?Q?sYNF/3YLia36SMYY/8z8BYawqAe0DWEo9P7TaEyPhev4ommizt05ORpVwE0Z?= =?us-ascii?Q?aL2pPN5w3UzMSPaP3EqANZuF4H3/KPzNsMQG7JvKpvtXIS24smRzcdFh+M6e?= =?us-ascii?Q?bqhsU23L8s/7riB6RwsnkisT11tsRsXXnlUi2y+AZFZ8nNBTSuzEz65h7NVh?= =?us-ascii?Q?kMLHofry+k4yCIEEuUnR/ARE6J5KmvCIhwlrmavG?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2b46460-9e25-4bc7-6566-08db2537508f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 09:26:10.7904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ONRUsPpFraaOlUTZrhbVhvXCkaMjzQFmZonf+amy1+YJgo2mRc9OHtwbJ2iS4n5j5vOQ+2m3xaz6lyXMKAbdRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4960 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, The Address could be not 4k align, "& IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_AD= DRESS_MASK" is to clear the low 12 bit to avoid impact the attribute. I think it is needed Thanks Zhiguang > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, March 15, 2023 2:43 PM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Kumar, Rahul R > Subject: RE: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since test= ed > API is changed >=20 > > @@ -413,8 +422,9 @@ CompareEntrysforOnePoint ( > > // > > for (Index =3D 0; Index < MapCount; Index++) { > > if ((Address >=3D Map[Index].LinearAddress) && (Address < > > (Map[Index].LinearAddress + Map[Index].Length))) { > > - AttributeInMap.Uint64 =3D (Map[Index].Attribu= te.Uint64 & > > mSupportedBit.Uint64); > > - AttributeInMap.Bits.PageTableBaseAddress =3D ((Address - > > Map[Index].LinearAddress) >> 12) + > > Map[Index].Attribute.Bits.PageTableBaseAddress; > > + AttributeInMap.Uint64 =3D (Map[Index].Attribute.Uint64 & > > mSupportedBit.Uint64); > > + AttributeInMap.Uint64 &=3D > > (~IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK); > > + AttributeInMap.Uint64 |=3D (Address - Map[Index].LinearAddress + > > IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS > > (&Map[Index].Attribute)) & > > IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK; >=20 > 1. "& IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK" is not > needed.